Re: Document Intel Silvermont support in invoke.texi

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 09:39:24AM +0400, Igor Zamyatin wrote: Please see updated patch. Is it ok to install? Ok, thanks. 2013-06-11 Igor Zamyatin igor.zamya...@intel.com * doc/invoke.texi (core-avx2): Document. (slm): Likewise. (atom): Updated with MOVBE.

Re: [PATCH] DATA_ALIGNMENT vs. DATA_ABI_ALIGNMENT (PR target/56564)

2013-06-11 Thread Jakub Jelinek
On Mon, Jun 10, 2013 at 08:44:05PM -0400, DJ Delorie wrote: @@ -986,12 +1053,10 @@ align_variable (tree decl, bool dont_out if (! DECL_THREAD_LOCAL_P (decl) || const_align = BITS_PER_WORD) align = const_align; } -#endif } +#endif I think this change in

Ping: Re: [DWARF] Fix multiple register spanning location.

2013-06-11 Thread Christian Bruel
Hello, May I have a review from the DWARF, the ARM and RS6000 maintainers for comments/approval ? http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01613.html Needed to fix the powerpc-spe bootstrap referenced in bugzilla #57389 Many Thanks Christian Christian Bruel christian.br...@st.com wrote:

Re: [announce] New scalar-storage-order branch in GCC repository

2013-06-11 Thread Eric Botcazou
I experimented with something like this a while ago. The goal was to have a -f{big,little}-endian switch that changes the default byteorder, and also to add endianness attributes. It didn't go very far, but I could compile some simple testcases and it seemed to behave as expected for those.

SPE detection broken on Linux (bits/predefs.h: No such file or directory)

2013-06-11 Thread Roland Stigge
[Forwarding from http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57578 , as suggested] Hi! The build of powerpc spe on Linux aborts like this: [...] /«PKGBUILDDIR»/build/./gcc/xgcc -B/«PKGBUILDDIR»/build/./gcc/ -B/usr/lib/gcc-snapshot/powerpc-linux-gnuspe/bin/

Re: [patch] [python libstdc++ printers] Fix gdb/15195

2013-06-11 Thread Phil Muldoon
On 21/03/13 14:20, Tom Tromey wrote: Phil == Phil Muldoon pmuld...@redhat.com writes: Phil 2013-03-21 Phil Muldoon pmuld...@redhat.com Phil PR gdb/15195 I think this should use a full URL. Phil def to_string (self): Why doesn't the 'children' method also need a fix?

Re: [GOOGLE] Avoid emitting duplicated weakref

2013-06-11 Thread Bernhard Reutner-Fischer
On 9 June 2013 05:31, Xinliang David Li davi...@google.com wrote: Guard also with L_IPO_COMP_MODE as this is lipo specific. Sounds like this is the LIPO incarnation of http://gcc.gnu.org/PR31537 See the patch at http://gcc.gnu.org/PR31537#c9 for not adding the alias in the first place (back

Re: [PATCH] PR32219, weak hidden reference segfault

2013-06-11 Thread Bernhard Reutner-Fischer
ping, CCing middle-end maintainers for review. On 31 May 2013 10:13, Chung-Lin Tang clt...@codesourcery.com wrote: On 13/5/15 8:12 PM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com writes: On 13/5/10 6:37 PM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com

Re: [GOOGLE] Avoid emitting duplicated weakref

2013-06-11 Thread Jan Hubicka
On 9 June 2013 05:31, Xinliang David Li davi...@google.com wrote: Guard also with L_IPO_COMP_MODE as this is lipo specific. Sounds like this is the LIPO incarnation of http://gcc.gnu.org/PR31537 See the patch at http://gcc.gnu.org/PR31537#c9 for not adding the alias in the first place

Re: Document Intel Silvermont support in invoke.texi

2013-06-11 Thread Kirill Yukhin
Ok, thanks. Checked into MT: http://gcc.gnu.org/ml/gcc-cvs/2013-06/msg00376.html I think we also should port core-avx2 into 4.8.x Thanks, K

[v3] Fix libstdc++/56019

2013-06-11 Thread Paolo Carlini
Hi, tested x86_64-linux, committed to mainline. Thanks, Paolo. 2013-06-11 Paolo Carlini paolo.carl...@oracle.com PR libstdc++/56019 * include/c_global/cstddef (max_align_t): Add to namespace std. * include/c_std/cstddef: Likewise. *

Re: [Patch, Fortran] PR57508 - Fix ICE/Reject-valid issue with get_temp_from_expr (intrinsic assignment with defined assignment)

2013-06-11 Thread Tobias Burnus
Hello Mikael, Mikael Morin wrote: Le 03/06/2013 16:06, Tobias Burnus a écrit : diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c index b2e8fdc..655d3c1 100644 --- a/gcc/fortran/resolve.c +++ b/gcc/fortran/resolve.c @@ -9293,8 +9293,12 @@ get_temp_from_expr (gfc_expr *e, gfc_namespace

Re: Document Intel Silvermont support in invoke.texi

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 01:42:47PM +0400, Kirill Yukhin wrote: Ok, thanks. Checked into MT: http://gcc.gnu.org/ml/gcc-cvs/2013-06/msg00376.html I think we also should port core-avx2 into 4.8.x If you mean the documentation of it plus atom MOVBE listing, yes. Patch preapproved.

Re: [Patch, Fortran] PR57508 - Fix ICE/Reject-valid issue with get_temp_from_expr (intrinsic assignment with defined assignment)

2013-06-11 Thread Mikael Morin
Le 11/06/2013 12:00, Tobias Burnus a écrit : Hello Mikael, Mikael Morin wrote: Le 03/06/2013 16:06, Tobias Burnus a écrit : diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c index b2e8fdc..655d3c1 100644 --- a/gcc/fortran/resolve.c +++ b/gcc/fortran/resolve.c @@ -9293,8 +9293,12

[PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Jakub Jelinek
Hi! As discussed on IRC, decl_binds_to_current_def_p doesn't handle some cases properly, e.g. if a DECL_COMMON decl has hidden visibility, then it returns true even without consulting linker plugin resolution, even when the common might bind to a real definition of the var in some other TU of the

[PATCH] dg-extract-results.sh tolerate spaces in variant names.

2013-06-11 Thread Marcus Shawcroft
Hi, The dg-extract-result.sh script is not tolerant of spaces in test variants. Consider the following site.exp fragment: set target_list [ list arm-eabi-aem{-marm -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp} \ arm-eabi-aem{-marm -march=armv8-a -mfpu=crypto-neon-fp-armv8

Re: [PATCH] dg-extract-results.sh tolerate spaces in variant names.

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 01:12:50PM +0100, Marcus Shawcroft wrote: Hi, The dg-extract-result.sh script is not tolerant of spaces in test variants. Consider the following site.exp fragment: set target_list [ list arm-eabi-aem{-marm -march=armv7-a -mfpu=vfpv3-d16

Re: [PATCH] dg-extract-results.sh tolerate spaces in variant names.

2013-06-11 Thread Marcus Shawcroft
On 11/06/13 13:55, Jakub Jelinek wrote: On Tue, Jun 11, 2013 at 01:12:50PM +0100, Marcus Shawcroft wrote: Hi, The dg-extract-result.sh script is not tolerant of spaces in test variants. Consider the following site.exp fragment: set target_list [ list arm-eabi-aem{-marm -march=armv7-a

Re: [PATCH] dg-extract-results.sh tolerate spaces in variant names.

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 02:07:50PM +0100, Marcus Shawcroft wrote: On 11/06/13 13:55, Jakub Jelinek wrote: On Tue, Jun 11, 2013 at 01:12:50PM +0100, Marcus Shawcroft wrote: Hi, The dg-extract-result.sh script is not tolerant of spaces in test variants. Consider the following site.exp

Re: [PATCH] dg-extract-results.sh tolerate spaces in variant names.

2013-06-11 Thread Marcus Shawcroft
On 11/06/13 14:12, Jakub Jelinek wrote: On Tue, Jun 11, 2013 at 02:07:50PM +0100, Marcus Shawcroft wrote: On 11/06/13 13:55, Jakub Jelinek wrote: On Tue, Jun 11, 2013 at 01:12:50PM +0100, Marcus Shawcroft wrote: Hi, The dg-extract-result.sh script is not tolerant of spaces in test variants.

Re: [c++-concepts] code review

2013-06-11 Thread Andrew Sutton
I think I previously put constraint_info in lang_decl_min, right next to template_info no less. It was easy to manage there, and initialized as part of build_template_decl. But this obviously doesn't work for partial specializations unless they get template_decls. Right. And we would want

[AArch64] Split simd combine

2013-06-11 Thread Sofiane Naci
Hi, This patch split the simd aarch64_combine pattern. This passes the full regression test suite in aarch64-elf. OK for trunk? - Thanks Sofiane aarch64-split-simd-combine.diff Description: Binary data

[AArch64] Fix move_lo_quad_mode move

2013-06-11 Thread Sofiane Naci
Hi, This patch fixes a bug in the move_lo_quad_mode pattern. The pattern, shown below, issues a scalar MOV instruction for vector modes: (define_insn move_lo_quad_mode [(set (match_operand:VQ 0 register_operand =w,w,w) (vec_concat:VQ (match_operand:VHALF 1 register_operand

RE: new mul* patterns U constraint in rl78

2013-06-11 Thread Kaushik Phatak
Hi DJ, umul is used when the insn takes two operands in A and X, and computes a value into AX. macax is used when the insn pattern itself reads from two virtual registers and writes to a virtual register (i.e. V = V op V), but clobbers AX anx BC in the process. Thanks for the

Re: [c++-concepts] code review

2013-06-11 Thread Jason Merrill
On 06/11/2013 09:45 AM, Andrew Sutton wrote: After investigating, neither call_expr nor resolve_nondeduced_context do what I need. I need a resolution of a call expression that does not return overload sets, especially in the case where the initial call expression is already dependent. Does

Re: [Patch, Fortran] PR57535 - Fix class-array handling for function result variables

2013-06-11 Thread Mikael Morin
Le 06/06/2013 17:10, Tobias Burnus a écrit : The attached test case failed with an ICE for function result variables as in that case the function decl was used. Build and regtested on x86-64-gnu-linux. OK for the trunk? Yes, thanks Mikael

Re: [PATCH] ARMv6-M MI thunk fix

2013-06-11 Thread Julian Brown
On Mon, 10 Jun 2013 09:02:24 -0700 Cesar Philippidis ce...@codesourcery.com wrote: On 6/10/13 8:32 AM, Richard Earnshaw wrote: On 07/06/13 17:50, Cesar Philippidis wrote: On 6/6/13 9:00 AM, Richard Earnshaw wrote: The pipeline offset is 4 for Thumb2 as well. So at the very least you

Re: [c++-concepts] code review

2013-06-11 Thread Andrew Sutton
After investigating, neither call_expr nor resolve_nondeduced_context do what I need. I need a resolution of a call expression that does not return overload sets, especially in the case where the initial call expression is already dependent. Does this have to do with restrictions on

Re: SPE detection broken on Linux (bits/predefs.h: No such file or directory)

2013-06-11 Thread David Edelsohn
On Tue, Jun 11, 2013 at 4:36 AM, Roland Stigge sti...@antcom.de wrote: [Forwarding from http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57578 , as suggested] Hi! The build of powerpc spe on Linux aborts like this: [...] /«PKGBUILDDIR»/build/./gcc/xgcc -B/«PKGBUILDDIR»/build/./gcc/

[PATCH] final.c: make debug_prefix_maps static

2013-06-11 Thread David Malcolm
Usage of debug_prefix_maps is hidden behind an API, with the only direct uses of the ptr being within final.c. Indeed the declaration of its type is local to that file. Hence it can be made static. Successfully bootstrapped on x86_64-unknown-linux-gnu OK for trunk? 2013-06-11 David Malcolm

Re: [c++-concepts] code review

2013-06-11 Thread Jason Merrill
On 06/11/2013 10:49 AM, Andrew Sutton wrote: After investigating, neither call_expr nor resolve_nondeduced_context do what I need. I need a resolution of a call expression that does not return overload sets, especially in the case where the initial call expression is already dependent. Does

Re: [PATCH] ARMv6-M MI thunk fix

2013-06-11 Thread Julian Brown
On Tue, 11 Jun 2013 15:42:24 +0100 Julian Brown jul...@codesourcery.com wrote: Ahh -- so actually, maybe the right thing to do is use this last style of thunk for v6-m, the same as v7-m -- is there any reason that wouldn't work? (I wrote this patch to start with, but I don't remember if I

Re: [c++-concepts] code review

2013-06-11 Thread Andrew Sutton
And you need to do this even when the call is type-dependent? Yes. Especially when the call is type-dependent. That's how I generate the constraint sets, which are used to determine the most constrained template during overload resolution.

Re: [AArch64] Split simd combine

2013-06-11 Thread Marcus Shawcroft
On 11/06/13 14:44, Sofiane Naci wrote: Hi, This patch split the simd aarch64_combine pattern. This passes the full regression test suite in aarch64-elf. OK for trunk? - Thanks Sofiane OK /Marcus

[PATCH] function.c: Remove stray copy of initial_trampoline

2013-06-11 Thread David Malcolm
Both function.c and varasm.c contain their own copies of this declaration: static GTY(()) rtx initial_trampoline; Only the one in varasm.c is used; the one in function.c appears to be a missing removal from this move: 2004-05-13 Diego Novillo dnovi...@redhat.com Merge from

Re: [PATCH] DATA_ALIGNMENT vs. DATA_ABI_ALIGNMENT (PR target/56564)

2013-06-11 Thread DJ Delorie
Thanks!

Re: new mul* patterns U constraint in rl78

2013-06-11 Thread DJ Delorie
; end of mulqi macro +;; [(set_attr valloc umul)] I think this one needs to be macax also, since the constraints have v in them but the opcodes use ax. Other than that, it's OK.

Re: [PATCH] function.c: Remove stray copy of initial_trampoline

2013-06-11 Thread Jeff Law
On 06/11/13 09:16, David Malcolm wrote: 2013-06-11 David Malcolm dmalc...@redhat.com * function.c (initial_trampoline): Remove stray copy; see varasm.c for the real copy. This is fine. However, I'd just make the ChangeLog * function.c (initial_trampoline): Remove

Re: PING - Sort SH / H8300 ISR tests

2013-06-11 Thread Jeff Law
On 06/10/13 15:36, Oleg Endo wrote: Hello, Any comments on that one? Original message containing the attachment is here: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01086.html On Mon, 2013-05-20 at 18:06 +0200, Oleg Endo wrote: Hi, I've noticed that testsuite/gcc.dg has some ISR related

Re: [PATCH] tree-into-ssa.c: make interesting_blocks static

2013-06-11 Thread Jeff Law
On 06/07/13 11:36, David Malcolm wrote: interesting_blocks is only used inside tree-into-ssa.c, so it can be made static. Successfully bootstrapped on x86_64-unknown-linux-gnu (using gcc-4.7.2-2.fc17.x86_64). OK for trunk? 2013-06-07 David Malcolm dmalc...@redhat.com *

Re: [PATCH] tree-object-size.c: mark unknown as const

2013-06-11 Thread Jeff Law
On 06/07/13 11:40, David Malcolm wrote: The array unknown within tree-object-size.c is only ever read from, not written to, so it can be marked as const. Successfully bootstrapped on x86_64-unknown-linux-gnu (using gcc-4.7.2-2.fc17.x86_64). OK for trunk? 2013-06-07 David Malcolm

C++: fix ICE with CONST_DECLs

2013-06-11 Thread Mike Stump
Here is a simple one. When processing CONST_DECLs after an error, we can ICE. This avoid the ICE. Ok? 2013-06-11 Mike Stump mikest...@comcast.net * init.c (constant_value_1): Protect CONST_DECLs better in the face of errors. diff --git a/gcc/cp/init.c b/gcc/cp/init.c

RE: [patch, mips] Micromips delay slot fix

2013-06-11 Thread Moore, Catherine
-Original Message- From: Maciej W. Rozycki [mailto:ma...@codesourcery.com] Sent: Monday, June 10, 2013 8:50 PM To: Steve Ellcey; Moore, Catherine Cc: Richard Sandiford; gcc-patches@gcc.gnu.org Subject: Re: [patch, mips] Micromips delay slot fix On Tue, 11 Jun 2013, Steve Ellcey

Re: [PATCH] final.c: make debug_prefix_maps static

2013-06-11 Thread Richard Henderson
On 06/11/2013 07:57 AM, David Malcolm wrote: Usage of debug_prefix_maps is hidden behind an API, with the only direct uses of the ptr being within final.c. Indeed the declaration of its type is local to that file. Hence it can be made static. Successfully bootstrapped on

Re: C++: fix ICE with CONST_DECLs

2013-06-11 Thread Paolo Carlini
On 06/11/2013 06:27 PM, Mike Stump wrote: Here is a simple one. When processing CONST_DECLs after an error, we can ICE. This avoid the ICE. No testcase? Paolo.

Re: [gomp4] Some progress on #pragma omp simd

2013-06-11 Thread Jakub Jelinek
On Sat, Apr 27, 2013 at 08:17:35PM +0200, Jakub Jelinek wrote: One way we could implement the SIMD private/lastprivate/reduction vars and for Cilk+ also firstprivate ones might be: - query the target what the maximum possible vectorization factor for the loop is (and min that with simdlen if

Re: [PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Richard Henderson
On 06/11/2013 04:31 AM, Jakub Jelinek wrote: +bool +default_binds_to_current_def_p_1 (const_tree exp, int shlib) +{ ... +} I'm having trouble picking out what's supposed to be different between this function and default_binds_local_p_1. It appears to be the same set of tests, just rearranged

Re: [PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 09:56:28AM -0700, Richard Henderson wrote: On 06/11/2013 04:31 AM, Jakub Jelinek wrote: +bool +default_binds_to_current_def_p_1 (const_tree exp, int shlib) +{ ... +} I'm having trouble picking out what's supposed to be different between this function and

Re: [PATCH] function.c: Remove stray copy of initial_trampoline

2013-06-11 Thread David Malcolm
On Tue, 2013-06-11 at 09:56 -0600, Jeff Law wrote: On 06/11/13 09:16, David Malcolm wrote: 2013-06-11 David Malcolm dmalc...@redhat.com * function.c (initial_trampoline): Remove stray copy; see varasm.c for the real copy. This is fine. However, I'd just make the ChangeLog

Re: [PATCH] final.c: make debug_prefix_maps static

2013-06-11 Thread David Malcolm
On Tue, 2013-06-11 at 09:34 -0700, Richard Henderson wrote: On 06/11/2013 07:57 AM, David Malcolm wrote: Usage of debug_prefix_maps is hidden behind an API, with the only direct uses of the ptr being within final.c. Indeed the declaration of its type is local to that file. Hence it

Re: [PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Richard Henderson
On 06/11/2013 10:03 AM, Jakub Jelinek wrote: On Tue, Jun 11, 2013 at 09:56:28AM -0700, Richard Henderson wrote: I'm having trouble picking out what's supposed to be different between this function and default_binds_local_p_1. It appears to be the same set of tests, just rearranged into a

Re: [patch, mips] Micromips delay slot fix

2013-06-11 Thread Richard Sandiford
Moore, Catherine catherine_mo...@mentor.com writes: I'm testing a slightly different patch from the one that Steve posted: Index: mips.md === --- mips.md (revision 199648) +++ mips.md (working copy) @@ -703,8 +703,13 @@

Re: [c++-concepts] code review

2013-06-11 Thread Jason Merrill
On 06/11/2013 11:09 AM, Andrew Sutton wrote: And you need to do this even when the call is type-dependent? Yes. Especially when the call is type-dependent. That's how I generate the constraint sets, which are used to determine the most constrained template during overload resolution. Ah,

Re: C++: fix ICE with CONST_DECLs

2013-06-11 Thread Jason Merrill
On 06/11/2013 12:39 PM, Paolo Carlini wrote: On 06/11/2013 06:27 PM, Mike Stump wrote: Here is a simple one. When processing CONST_DECLs after an error, we can ICE. This avoid the ICE. No testcase? Yep; the patch is fine, but needs a testcase. Jason

Re: [PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 10:18:17AM -0700, Richard Henderson wrote: 2) DECL_COMMON with non-default visibility - the old version would return true, now it returns false unless linker plugin tells us the current common was used Or do you think we should just do what we did before

Re: [PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Richard Henderson
On 06/11/2013 11:20 AM, Jakub Jelinek wrote: 2013-06-11 Jakub Jelinek ja...@redhat.com PR target/56564 * varasm.c (decl_binds_to_current_def_p): Call binds_local_p target hook even for !TREE_PUBLIC decls. If no resolution info is available, return false for common

Re: Remove self-assignments

2013-06-11 Thread Jeff Law
On 06/09/13 10:25, Marc Glisse wrote: Hello, this patch removes some self-assignments. I don't know if this is the best way, but it passes a bootstrap and the testsuite on x86_64-linux-gnu. 2013-06-10 Marc Glisse marc.gli...@inria.fr PR tree-optimization/57361 gcc/ *

Re: [PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Jan Hubicka
2013-06-11 Jakub Jelinek ja...@redhat.com PR target/56564 * varasm.c (decl_binds_to_current_def_p): Call binds_local_p target hook even for !TREE_PUBLIC decls. If no resolution info is available, return false for common and external decls. --- gcc/varasm.c.jj

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Marek Polacek
On Sat, Jun 08, 2013 at 08:22:33PM +0200, Jakub Jelinek wrote: + tt = fold_build2 (EQ_EXPR, boolean_type_node, op1, + integer_minus_one_node); Don't we usually try to have both operands of a comparison of the same type? Not just usually, it really has to be

Re: [PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 08:39:07PM +0200, Jan Hubicka wrote: @@ -6802,10 +6802,20 @@ decl_binds_to_current_def_p (tree decl) return resolution_to_local_definition_p (node-symbol.resolution); } /* Otherwise we have to assume the worst for DECL_WEAK (hidden weaks - binds

[rl78] define TARGET_UNWIND_WORD_MODE

2013-06-11 Thread DJ Delorie
Fixes a libstdc++v3 build failure. Committed. * config/rl78/rl78.c (TARGET_UNWIND_WORD_MODE): Define. (rl78_unwind_word_mode): New. Index: config/rl78/rl78.c === --- config/rl78/rl78.c (revision 199963) +++

Re: More forwprop for vectors

2013-06-11 Thread Jeff Law
On 06/09/13 13:43, Marc Glisse wrote: Hello, just adapting yet another function so it also works with vectors. It seemed convenient to add a new macro. The name sucks (it doesn't match the semantics of INTEGRAL_TYPE_P), but I didn't want to name it INTEGER_SCALAR_OR_VECTOR_CONSTANT_P and

Re: [PATCH] Fix up decl_binds_to_current_def_p (PR target/56564)

2013-06-11 Thread Jan Hubicka
On Tue, Jun 11, 2013 at 08:39:07PM +0200, Jan Hubicka wrote: @@ -6802,10 +6802,20 @@ decl_binds_to_current_def_p (tree decl) return resolution_to_local_definition_p (node-symbol.resolution); } /* Otherwise we have to assume the worst for DECL_WEAK (hidden weaks -

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Marc Glisse
Hello, couple comments (not a true review) On Tue, 11 Jun 2013, Marek Polacek wrote: +tree +ubsan_instrument_division (location_t loc, tree op0, tree op1) +{ + tree t, tt; + tree type0 = TREE_TYPE (op0); + tree type1 = TREE_TYPE (op1); Can the 2 types be different? I thought divisions

Re: Remove self-assignments

2013-06-11 Thread Marc Glisse
On Tue, 11 Jun 2013, Jeff Law wrote: On 06/09/13 10:25, Marc Glisse wrote: Hello, this patch removes some self-assignments. I don't know if this is the best way, but it passes a bootstrap and the testsuite on x86_64-linux-gnu. 2013-06-10 Marc Glisse marc.gli...@inria.fr PR

Re: More forwprop for vectors

2013-06-11 Thread Marc Glisse
On Tue, 11 Jun 2013, Jeff Law wrote: On 06/09/13 13:43, Marc Glisse wrote: Hello, just adapting yet another function so it also works with vectors. It seemed convenient to add a new macro. The name sucks (it doesn't match the semantics of INTEGRAL_TYPE_P), but I didn't want to name it

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Marek Polacek
Hi! On Tue, Jun 11, 2013 at 09:14:36PM +0200, Marc Glisse wrote: Hello, couple comments (not a true review) Thanks anyway ;). On Tue, 11 Jun 2013, Marek Polacek wrote: +tree +ubsan_instrument_division (location_t loc, tree op0, tree op1) +{ + tree t, tt; + tree type0 = TREE_TYPE

Re: Remove self-assignments

2013-06-11 Thread Marek Polacek
On Tue, Jun 11, 2013 at 09:30:29PM +0200, Marc Glisse wrote: I'd be curious how often this triggers in GCC itself as well. Do you know a convenient way to test that? Perhaps you could put in the if (gimple_assign_rhs_code (stmt) == TREE_CODE (gimple_assign_lhs (stmt)) operand_equal_p

[C++ Patch] PR 42021

2013-06-11 Thread Paolo Carlini
Hi, this issue, which originally was about spelling out in the error message the ambiguous candidates, is by and large fixed. Only, we produce the whole diagnostic twice for the testcase at issue: first in cp_parser_lookup_name and then again in cp_parser_nested_name_specifier_opt. The below

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 09:44:40PM +0200, Marek Polacek wrote: + tree type0 = TREE_TYPE (op0); + tree type1 = TREE_TYPE (op1); Can the 2 types be different? I thought divisions had homogeneous arguments, and the instrumentation was done late enough to avoid any potential issue, but

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Marek Polacek
On Tue, Jun 11, 2013 at 10:09:00PM +0200, Jakub Jelinek wrote: On Tue, Jun 11, 2013 at 09:44:40PM +0200, Marek Polacek wrote: + tree type0 = TREE_TYPE (op0); + tree type1 = TREE_TYPE (op1); Can the 2 types be different? I thought divisions had homogeneous arguments, and the

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 10:20:24PM +0200, Marek Polacek wrote: On Tue, Jun 11, 2013 at 10:09:00PM +0200, Jakub Jelinek wrote: On Tue, Jun 11, 2013 at 09:44:40PM +0200, Marek Polacek wrote: + tree type0 = TREE_TYPE (op0); + tree type1 = TREE_TYPE (op1); Can the 2 types be

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Marek Polacek
On Tue, Jun 11, 2013 at 10:33:25PM +0200, Jakub Jelinek wrote: That means you probably should move the function call down in cp_build_binary_op (resp. C counterpart), after the arguments are converted to result_type? Ok, certainly. Seems the arguments are converted here: if (! converted)

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 10:40:12PM +0200, Marek Polacek wrote: On Tue, Jun 11, 2013 at 10:33:25PM +0200, Jakub Jelinek wrote: That means you probably should move the function call down in cp_build_binary_op (resp. C counterpart), after the arguments are converted to result_type? Ok,

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-11 Thread Marek Polacek
On Tue, Jun 11, 2013 at 10:44:12PM +0200, Jakub Jelinek wrote: There is another thing to solve BTW, op0 and/or op1 might have side-effects, if you are going to evaluate them more than once, they need to be surrounded into cp_save_expr resp. c_save_expr. I see. Thanks for the notice.

[google/gcc-4_8] Backport upstream patch to fix non-deterministic order of DWARF output

2013-06-11 Thread Cary Coutant
This patch fixes a testsuite failure when -fdebug-types-section is turned on, where the order of type stub DIEs is dependent on hash table traversal order. Backported from trunk at r199927. Bootstrapped, tested, and committed. -cary 2013-06-10 Cary Coutant ccout...@google.com gcc/ *

Symtab cleanups 5/17

2013-06-11 Thread Jan Hubicka
Hi, weakref is a static variable that is an alias of external symbol. Either by GCC or by GAS it is translated to references to the target and depending on whether target is used or not it is declared as weak or non-weak symbol. Now the implementation in c-common.c sets DECL_EXTERNAL flag when

Aw: Re: [PATCH] Basic support for MIPS r5900

2013-06-11 Thread Jürgen Urban
Hello Richard, How much other changes will be currently accepted here? There is other stuff which I want to prepare and submit here, e.g.: 1. disable use of dmult and ddiv (ABI n32). 2. use trunc.w.s instead of cvt.w.s (to get single float working for normal range calculations; i.e.

[PATCH, committed] PR 57589: Fix logic error in driver-rs6000.c

2013-06-11 Thread Michael Meissner
I committed the following patch as obvious, after making sure it builds and has no regressions. I was looking at driver-rs6000.c today, and I noticed that it was returning an address to an auto buffer for processing -mcpu=native. 2013-06-11 Michael Meissner meiss...@linux.vnet.ibm.com

Re: [PATCH, committed] PR 57589: Fix logic error in driver-rs6000.c

2013-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2013 at 07:25:36PM -0400, Michael Meissner wrote: I committed the following patch as obvious, after making sure it builds and has no regressions. I was looking at driver-rs6000.c today, and I noticed that it was returning an address to an auto buffer for processing

Re: [PATCH, committed] PR 57589: Fix logic error in driver-rs6000.c

2013-06-11 Thread Michael Meissner
On Wed, Jun 12, 2013 at 01:34:59AM +0200, Jakub Jelinek wrote: On Tue, Jun 11, 2013 at 07:25:36PM -0400, Michael Meissner wrote: I committed the following patch as obvious, after making sure it builds and has no regressions. I was looking at driver-rs6000.c today, and I noticed that it

Re: [PATCH, rs6000] power8 patches, patch #7, quad/byte/half-word atomic instructions

2013-06-11 Thread Michael Meissner
I needed to rework the sync.md so that it would work correctly with no optimization (using SUBREG's at -O0 did not give us the even registers for holding PTImode values, so I created a PTImode temporary in load_lockedti and store_conditionalti, which is normally optimized out. [gcc] 2013-06-11

expand_expr tweaks to fix PR57134

2013-06-11 Thread Alan Modra
The following patch fixes PR57134 by a) excluding bitfield expansion when EXPAND_MEMORY, and b) passing down the EXPAND_MEMORY modifier in a couple of places where this does not currently happen on recursive calls to expand_expr(). (a) has precedent elsewhere in expr.c, eg. see expand_expr_real_1

RE: new mul* patterns U constraint in rl78

2013-06-11 Thread Kaushik Phatak
+;; [(set_attr valloc umul)] I think this one needs to be macax also, since the constraints have v in them but the opcodes use ax. Other than that, it's OK. Committed with above change. Thanks for the quick review. Regards, Kaushik

Re: Improve uncprop and coalescing

2013-06-11 Thread Jeff Law
On 06/07/13 03:14, Richard Biener wrote: +/* Given SSA_NAMEs NAME1 and NAME2, return true if they are candidates for + coalescing together, false otherwise. + + This must stay consistent with the code in tree-ssa-live.c which + sets up base values in the var map. */ + +bool