Re: [PATCH] Fix raw-string handling (PR preprocessor/57620)

2013-06-27 Thread Jakub Jelinek
On Mon, Jun 17, 2013 at 06:28:46PM +0200, Jakub Jelinek wrote: lex_raw_string right now only undoes phase {1,2} transformations in between Rdelim( and )delim, while it should undo them everywhere between R and the final . The following patch implements that, and adds testsuite coverage for

[PATCH] Fix pr57637

2013-06-27 Thread Zhenqiang Chen
Hi, Shrink-wrap optimization sinks some instructions for more opportunities. It uses DF_LR_BB_INFO (bb)-def to check whether BB clobbers SRC. But for ARM, gcc might generate cond_exec insns before shrink-wrapping. And DF_LR_BB_INFO (bb)-def does not include def info from cond_exec insns. So the

[PING] [C++ Patch] Remove finish_stmt

2013-06-27 Thread Paolo Carlini
Hi, On 06/16/2013 07:21 PM, Paolo Carlini wrote: Hi, lately doesn't appear to accomplish much. Tested x86_64-linux. pinging this clean-up (before I forget ;) Thanks! Paolo. / 2013-06-17 Paolo Carlini paolo.carl...@oracle.com * cp-tree.h (finish_stmt): Do not

Re: C++ 2014 status page for libstdc++

2013-06-27 Thread Jonathan Wakely
On 26 June 2013 02:28, Ed Smith-Rowland wrote: On 06/25/2013 11:59 AM, Jonathan Wakely wrote: On 25 June 2013 16:45, 3dw...@verizon.net wrote: Here is a C++2014 status page for fun and profit. Excellent, thanks! Tested with xmllint. Are there any other tests I should do? The makefile

Re: [PATCH] Basic support for MIPS r5900

2013-06-27 Thread Jürgen Urban
Hello Richard, Am 25.06.2013 um 23:24 schrieb Richard Sandiford rdsandif...@googlemail.com: Jürgen Urban juergenur...@gmx.de writes: Am 23.06.2013 um 22:21 schrieb Richard Sandiford rdsandif...@googlemail.com: In the native PS2SDK (i.e. no Linux) I detected that there are undefined

Re: [PATCH, AArch64] Minor refactoring of aarch64_add_offset

2013-06-27 Thread Marcus Shawcroft
On 25/06/13 17:04, Yufeng Zhang wrote: This patch carries out minor refactoring on aarch64_add_offset; it replaces 'DImode' and 'Pmode' with 'mode'. OK for the trunk? OK /Marcus

Re: [PATCH, AArch64] Minor refactoring of aarch64_force_temporary

2013-06-27 Thread Marcus Shawcroft
On 25/06/13 17:06, Yufeng Zhang wrote: This patch adds a new parameter 'mode' of type 'enum machine_mode mode' to aarch64_force_temporary, and updates the calls to it. OK for the trunk? OK /Marcus

Re: [C++] Fix __builtin_shuffle

2013-06-27 Thread Marc Glisse
On Wed, 26 Jun 2013, Jason Merrill wrote: On 06/09/2013 07:09 AM, Marc Glisse wrote: + arg0 = build_non_dependent_expr (arg0); + arg1 = build_non_dependent_expr (arg1); + arg2 = build_non_dependent_expr (arg2); +} + return c_build_vec_perm_expr (loc, arg0, arg1, arg2,

[v3] Reorganized a bit the basic_string testsuite

2013-06-27 Thread Paolo Carlini
Hi, now we have /modifiers/ and /operations/ consistently populated. Thanks, Paolo. /// 2013-06-27 Paolo Carlini paolo.carl...@oracle.com * testsuite/21_strings/basic_string/append/*: Move inside testsuite/21_strings/basic_string/modifiers/. *

Re: [C++] Fix __builtin_shuffle

2013-06-27 Thread Jason Merrill
On 06/27/2013 07:59 AM, Marc Glisse wrote: I assume I can't call directly c_build_vec_perm_expr on the original arguments without build_non_dependent_expr? It looks like c_build_vec_perm_expr is safe to take the original arguments, since it doesn't look deep into the expression. So either

Re: [PATCH] Fix pr57637

2013-06-27 Thread Richard Earnshaw
On 27/06/13 10:02, Zhenqiang Chen wrote: Hi, Shrink-wrap optimization sinks some instructions for more opportunities. It uses DF_LR_BB_INFO (bb)-def to check whether BB clobbers SRC. But for ARM, gcc might generate cond_exec insns before shrink-wrapping. And DF_LR_BB_INFO (bb)-def does not

[Patch] microMIPS cleanups

2013-06-27 Thread Moore, Catherine
Hi Richard, This patch adds the m14ke processors to the cpu definition file, adds the m14kc to invoke.texi and updates BASE_DRIVER_SELF_SPECS for the m14ke* Okay to commit? Thanks, Catherine m14ke.cl Description: m14ke.cl m14ke.patch Description: m14ke.patch

Re: [Patch ARM] Add Cortex A15 neon scheduler

2013-06-27 Thread Ramana Radhakrishnan
On 06/26/13 09:37, Tom de Vries wrote: On 18/10/12 18:48, Ramana Radhakrishnan wrote: +(define_insn_reservation cortex_a15_vfp_adds_subs 6 + (and (eq_attr tune cortexa15) + (eq_attr type fadds)) + ca15_issue1,ca15_cx_vfp) Ramana, I noticed you use here the fadds value for the type

Re: [c++-concepts]: constraint association

2013-06-27 Thread Jason Merrill
Just a couple of typos: On 06/24/2013 11:56 AM, Andrew Sutton wrote: +// Returns true if NEWDECL and OLDDEC are member functions with with OLDDECL +// different constraints. If NEWDECL and OLDDECL are non-template members +// or specializations of non-template members, they overloads are

Re: [c++-concepts]: Diagnostics

2013-06-27 Thread Jason Merrill
On 06/21/2013 10:59 AM, Andrew Sutton wrote: + sorry (cannot diagnose disjunctions just yet); Use diagnose_other for the time being? + /* Langhook for print_error_function. */ void cxx_print_error_function (diagnostic_context *context, const char *file, @@ -3326,7 +3331,7 @@

[PATCH] Improve __popcount?i2 (PR middle-end/36041)

2013-06-27 Thread Jakub Jelinek
Hi! This patch speeds up the libgcc __popcount{si,di,ti}2 implementations more than 2 times by avoiding table lookup. I've kept using the table lookup for small word size targets (unfortunately avr/rl78 cheap and thus e.g. MIN_UNITS_PER_WORD isn't reliable for those purposes). Maybe it would be

Re: [c++-concepts]: Requires expression

2013-06-27 Thread Jason Merrill
On 06/21/2013 03:38 PM, Andrew Sutton wrote: I haven't pushed this into a git branch since its a completely separate change from the previous patch. Should I create a new branch for separate work? Sure. Jason

Re: [c++-concepts]: Requires expression

2013-06-27 Thread Jason Merrill
On 06/21/2013 03:38 PM, Andrew Sutton wrote: + tree parms = cp_parser_parameter_declaration_clause (parser); Calling this will push the parameter declarations into the current binding level; you will want to add the begin_scope/leave_scope and pop_binding that cp_parser_direct_declarator

[PATCH] Fix up bzhi (PR target/57623)

2013-06-27 Thread Jakub Jelinek
Hi! Another broken define_insn, bzhi has the middle operand r/m, others are r. But, combine would usually not match memory loads, because the pattern had non-canonical order of AND operands, thus it would never match there, and only could result in broken code if the RA decided to use memory

Re: [C++] Fix __builtin_shuffle

2013-06-27 Thread Marc Glisse
On Thu, 27 Jun 2013, Jason Merrill wrote: On 06/27/2013 07:59 AM, Marc Glisse wrote: I assume I can't call directly c_build_vec_perm_expr on the original arguments without build_non_dependent_expr? It looks like c_build_vec_perm_expr is safe to take the original arguments, since it doesn't

Re: [C++] Fix __builtin_shuffle

2013-06-27 Thread Jakub Jelinek
On Thu, Jun 27, 2013 at 05:24:45PM +0200, Marc Glisse wrote: On Thu, 27 Jun 2013, Jason Merrill wrote: On 06/27/2013 07:59 AM, Marc Glisse wrote: I assume I can't call directly c_build_vec_perm_expr on the original arguments without build_non_dependent_expr? It looks like

Re: [PATCH] Fix vectorizable_store

2013-06-27 Thread Richard Biener
Jakub Jelinek ja...@redhat.com wrote: Hi! On the gomp4 branch I've noticed a miscompilation of the simd-3.C testcase I'm adding there, but even say int a[1024] __attribute__((aligned (32))) = { 1 }; int b[1024] __attribute__((aligned (32))) = { 1 }; unsigned short c[1024] __attribute__((aligned

Re: [C++] Fix __builtin_shuffle

2013-06-27 Thread Marc Glisse
On Thu, 27 Jun 2013, Jakub Jelinek wrote: On Thu, Jun 27, 2013 at 05:24:45PM +0200, Marc Glisse wrote: On Thu, 27 Jun 2013, Jason Merrill wrote: On 06/27/2013 07:59 AM, Marc Glisse wrote: I assume I can't call directly c_build_vec_perm_expr on the original arguments without

patch to build GCC for arm with LRA

2013-06-27 Thread Vladimir Makarov
The following patch is for building arm GCC with LRA. I found that ASHIFTRT and LSHIFTRT are used in address calculation for arm, e.g. (insn 78 76 79 8 (set (reg/v:SI 153 [ offset ]) (mem:SI (plus:SI (ashiftrt:SI (reg:SI 151 [ D.6620 ]) (const_int 8 [0x8]))

[Patch, AArch64, ILP32] Pad pointer-typed stack argument downward in ILP32

2013-06-27 Thread Yufeng Zhang
This patch fixes the bug that pointer-typed argument passed on stack is not padded properly in ILP32. OK for the trunk? Thanks, Yufeng gcc/ * config/aarch64/aarch64.c (aarch64_pad_arg_upward): In big-endian, pad pointer-typed argument downward. gcc/testsuite/ *

Re: [C++] Fix __builtin_shuffle

2013-06-27 Thread Jakub Jelinek
On Thu, Jun 27, 2013 at 05:54:10PM +0200, Marc Glisse wrote: I don't really see why, as I am still calling c_build_vec_perm_expr in the same cases, just possibly not exactly with the same arguments (they don't go through build_non_dependent_expr, but Jason seemed to imply that it did not

Re: patch to build GCC for arm with LRA

2013-06-27 Thread Richard Sandiford
Vladimir Makarov vmaka...@redhat.com writes: Richard, is it ok to commit to the trunk? Looks good to me, but I gave up the right to approve it. I think you need ROTATERT too though (see arm_legitimate_index_p). Also, sorry for the nitpick, but once the full condition overflows one line, I

patch to fix a bug in LRA hard reg splitting

2013-06-27 Thread Vladimir Makarov
The following patch fixes a LRA bug for some experimental target. Sorry, there is no a test case and the bug can not be reproduced by other people until the target is made public. The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev. 200475. 2013-06-27 Vladimir

Re: [C++] Fix __builtin_shuffle

2013-06-27 Thread Marc Glisse
On Thu, 27 Jun 2013, Jakub Jelinek wrote: On Thu, Jun 27, 2013 at 05:54:10PM +0200, Marc Glisse wrote: I don't really see why, as I am still calling c_build_vec_perm_expr in the same cases, just possibly not exactly with the same arguments (they don't go through build_non_dependent_expr, but

Re: [PATCH, i386, PR57623] Introduce _bextr (single underscore) intrinsucs

2013-06-27 Thread Richard Henderson
On 06/24/2013 01:55 AM, Kirill Yukhin wrote: extern __inline unsigned long long __attribute__((__gnu_inline__, __always_inline__, __artificial__)) +_bextr_u64 (unsigned long long __X, unsigned long long __Y, unsigned long long __Z) +{ + return __builtin_ia32_bextr_u64 (__X, ((__Y 0xff)

RFA: patch to build GCC for arm with LRA

2013-06-27 Thread Vladimir Makarov
On 06/27/2013 12:15 PM, Richard Sandiford wrote: Vladimir Makarov vmaka...@redhat.com writes: Richard, is it ok to commit to the trunk? Looks good to me, but I gave up the right to approve it. I think you need ROTATERT too though (see arm_legitimate_index_p). Also, sorry for the nitpick,

Re: [PATCH] Fix up bzhi (PR target/57623)

2013-06-27 Thread Richard Henderson
On 06/27/2013 07:40 AM, Jakub Jelinek wrote: 2013-06-27 Jakub Jelinek ja...@redhat.com PR target/57623 * config/i386/i386.md (bmi2_bzhi_mode3): Swap AND arguments to match RTL canonicalization. Swap predicates and constraints of operand 1 and 2. *

Re: RFA: patch to build GCC for arm with LRA

2013-06-27 Thread Richard Earnshaw
On 27/06/13 17:32, Vladimir Makarov wrote: On 06/27/2013 12:15 PM, Richard Sandiford wrote: Vladimir Makarov vmaka...@redhat.com writes: Richard, is it ok to commit to the trunk? Looks good to me, but I gave up the right to approve it. I think you need ROTATERT too though (see

Re: RFA: patch to build GCC for arm with LRA

2013-06-27 Thread Vladimir Makarov
On 06/27/2013 12:50 PM, Richard Earnshaw wrote: On 27/06/13 17:32, Vladimir Makarov wrote: On 06/27/2013 12:15 PM, Richard Sandiford wrote: Vladimir Makarov vmaka...@redhat.com writes: Richard, is it ok to commit to the trunk? Looks good to me, but I gave up the right to approve it. I think

Re: RFA: patch to build GCC for arm with LRA

2013-06-27 Thread Richard Earnshaw
On 27/06/13 17:59, Vladimir Makarov wrote: On 06/27/2013 12:50 PM, Richard Earnshaw wrote: On 27/06/13 17:32, Vladimir Makarov wrote: On 06/27/2013 12:15 PM, Richard Sandiford wrote: Vladimir Makarov vmaka...@redhat.com writes: Richard, is it ok to commit to the trunk? Looks good to me, but

Fix PR middle-end/57370

2013-06-27 Thread Easwaran Raman
A newly generated statement in build_and_add_sum function of tree-ssa-reassoc.c has to be assigned the UID of its adjacent statement. In one instance, it was assigned the wrong uid (of an earlier phi statement) which messed up the IR and caused the test program to hang. Bootstraps and no test

Re: RFA: patch to build GCC for arm with LRA

2013-06-27 Thread Vladimir Makarov
On 06/27/2013 01:10 PM, Richard Earnshaw wrote: On 27/06/13 17:59, Vladimir Makarov wrote: On 06/27/2013 12:50 PM, Richard Earnshaw wrote: On 27/06/13 17:32, Vladimir Makarov wrote: On 06/27/2013 12:15 PM, Richard Sandiford wrote: Vladimir Makarov vmaka...@redhat.com writes: Richard, is it

Re: [c++-concepts] requires expression semantics

2013-06-27 Thread Jason Merrill
On 06/25/2013 09:27 AM, Andrew Sutton wrote: +/* The REQ expressions are unary expressions that specific inididual specify? +/* A unary expression representing a requirement for an expression that + may be evaluated at compile time. */ The word may is ambiguous and should be avoided in

Re: [Patch] microMIPS cleanups

2013-06-27 Thread Richard Sandiford
Moore, Catherine catherine_mo...@mentor.com writes: 2013-06-27 Catherine Moore c...@codesourcery.com * config/mips/mips-tables.opt: Regenerate. * config/mips/mips-cpus.def: Add m14ke and m14kec. * config/mips/mips.h (BASE_DRIVER_SELF_SPECS): m14ke* implies -mdspr2.

SSA identifiers

2013-06-27 Thread Andrew MacLeod
I'm doing some trial file conversions to my proposed wrapper classes, I'm seeing a couple of places which aren't mapping properly (they triggered compile errors), and I think its because there is a couple of bugs regarding the use of IDENTIFIERS in ssanames.. (I wasn't even aware you

Re: SSA identifiers

2013-06-27 Thread Jakub Jelinek
On Thu, Jun 27, 2013 at 02:25:21PM -0400, Andrew MacLeod wrote: I'm doing some trial file conversions to my proposed wrapper classes, I'm seeing a couple of places which aren't mapping properly (they triggered compile errors), and I think its because there is a couple of bugs regarding the

Re: [Patch, AArch64, ILP32] 5/5 Define _ILP32 and __ILP32__

2013-06-27 Thread Yufeng Zhang
On 06/27/13 01:56, Joseph S. Myers wrote: On Wed, 26 Jun 2013, Yufeng Zhang wrote: This patch defines _ILP32 and __ILP32__ for the AArch64 port when the ILP32 ABI is in use. This helps libraries, e.g. libgloss and glibc, recognize which model is being compiled. GCC already defines _LP64 and

Re: SSA identifiers

2013-06-27 Thread Andrew MacLeod
On 06/27/2013 02:39 PM, Jakub Jelinek wrote: in tree-ssanames.c:release_ssa_names() : if (! SSA_NAME_IN_FREE_LIST (var)) { tree saved_ssa_name_var = SSA_NAME_VAR (var); int saved_ssa_name_version = SSA_NAME_VERSION (var); use_operand_p imm = (SSA_NAME_IMM_USE_NODE

[patch, fortran] PR 50554 - redefinition of index variable with inquire(iolength=...)

2013-06-27 Thread Thomas Koenig
Hello world, the attached patch raises an error if an index variable is redefined with inquire(iolength=...). OK for trunk? Thomas 2013-06-27 Thomas Koenig tkoe...@gcc.gnu.org PR fortran/50554 * frontend-passes.c (doloop_code): Check do loop variables for

Re: [PATCH][ARM][testsuite] Add 'dg-require-effective-target sync_*' to some atomic tests

2013-06-27 Thread Mike Stump
On Jun 12, 2013, at 9:46 AM, Meador Inge mead...@codesourcery.com wrote: This patch adds the needed 'dg-require-effective-target sync_*' lines to some of the atomic tests so that they will not be run if the appropriate atomic support is not available. OK for trunk? Ok. 2013-06-12 Meador

Go patch committed: Improve error message

2013-06-27 Thread Ian Lance Taylor
This patch from Rémy Oudompheng improves an error message for an invalid use of [...] in a variable declaration. The error message said it was in a type conversion, but it was not. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.8 branch. Ian diff -r

Re: [Patch, AArch64, ILP32] 5/5 Define _ILP32 and __ILP32__

2013-06-27 Thread Joseph S. Myers
On Thu, 27 Jun 2013, Yufeng Zhang wrote: We need a reliable way to tell we are compiling for ILP32. On one hand LLP64 support may be added in the future; on the other hand, not all AArch64 If thinking of adding a third ABI, that suggests you should be using something along the lines of

Re: [PATCH] Improve __popcount?i2 (PR middle-end/36041)

2013-06-27 Thread Richard Henderson
On 06/27/2013 07:48 AM, Jakub Jelinek wrote: Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2013-06-27 Jakub Jelinek ja...@redhat.com PR middle-end/36041 * libgcc2.c (POPCOUNTCST2, POPCOUNTCST4, POPCOUNTCST8, POPCOUNTCST): Define.

Re: [x86] Remove 2 builtins

2013-06-27 Thread Richard Henderson
On 06/26/2013 07:22 AM, Marc Glisse wrote: Ping http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00478.html On Sun, 9 Jun 2013, Marc Glisse wrote: Hello, this patch removes 2 builtins that are undocumented, unused, and have confusing semantics. Bootstrap+testsuite on x86_64-linux-gnu.

Go patch committed: Fix method sets with embedded pointer types

2013-06-27 Thread Ian Lance Taylor
This patch from Rémy Oudompheng fixes the handling of method sets for structs with embedded pointer fields. Any such methods can be value methods of the struct, not just pointer methods. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.8 branch. Ian

Re: [c++-concepts] requires expression semantics

2013-06-27 Thread Andrew Sutton
Judging from the implementation, it seems that this relies on the notion of potentially-constant expression which is no longer part of the standard; that notion should only be used for diagnostics that are not required, not for things that participate in the type system. I think it would be

Re: [PATCH] Basic support for MIPS r5900

2013-06-27 Thread Richard Sandiford
Jürgen Urban juergenur...@gmx.de writes: Am 25.06.2013 um 23:24 schrieb Richard Sandiford rdsandif...@googlemail.com: Jürgen Urban juergenur...@gmx.de writes: Am 23.06.2013 um 22:21 schrieb Richard Sandiford Do you want to stick with 128-bit long doubles for PS2, or would you prefer to do

Re: [patch, fortran] PR 50554 - redefinition of index variable with inquire(iolength=...)

2013-06-27 Thread Tobias Burnus
Thomas Koenig wrote: the attached patch raises an error if an index variable is redefined with inquire(iolength=...). * frontend-passes.c (doloop_code): Check do loop variables for EXEC_IOLENGTH. What's the advantage to place it into doloop_code rather than using - as Steve's

Re: [C++] Fix __builtin_shuffle

2013-06-27 Thread Marc Glisse
On Thu, 27 Jun 2013, Marc Glisse wrote: On Thu, 27 Jun 2013, Jakub Jelinek wrote: On Thu, Jun 27, 2013 at 05:54:10PM +0200, Marc Glisse wrote: I don't really see why, as I am still calling c_build_vec_perm_expr in the same cases, just possibly not exactly with the same arguments (they don't

Re: [PATCH] Cilk Plus Array Notation for C++

2013-06-27 Thread Jason Merrill
On 06/27/2013 02:36 PM, Iyer, Balaji V wrote: I looked through the patch again. I was able to get rid of the first if-statement in cp_parser_postfix_open_square_expression function. I think now it looks exactly as you requested. Much better, thanks. + /* Sometimes, it

[C++ Patch] PR 57645 (Core/1123 fallout) 2nd Try

2013-06-27 Thread Paolo Carlini
Hi, this is a better fix for this regression, IMHO. Certainly it's simple and passes the extended testcase, thus tests for defaulted destructors too, etc, with no regressions. The idea, which I got studying in detail check_bases_and_members and its comments, is setting temporarily

Re: [c++-concepts] requires expression semantics

2013-06-27 Thread Jason Merrill
On 06/27/2013 04:56 PM, Andrew Sutton wrote: I was not aware of that. That's probably the right, but I remember having some troubles getting that to work the way I wanted in the previous implementation. It seemed like I actually had to evaluate the expression to determine if it was actually

Re: [C++ Patch] PR 57645

2013-06-27 Thread Jason Merrill
On 06/19/2013 08:22 PM, Paolo Carlini wrote: If, in check_bases_and_members, I simply move deduce_noexcept_on_destructors after check_methods and nothing else, all the new testcases are fine + the tests added for Core/1123, but there are regressions, for example for testcases involving virtual

Re: [C++ Patch] PR 57682

2013-06-27 Thread Jason Merrill
OK, but also remove the check for try after a mem-initializer; it has to come before the mem-initializers. Jason

Re: C++ 2014 status page for libstdc++

2013-06-27 Thread Ed Smith-Rowland
On 06/27/2013 07:01 AM, Jonathan Wakely wrote: On 26 June 2013 02:28, Ed Smith-Rowland wrote: On 06/25/2013 11:59 AM, Jonathan Wakely wrote: On 25 June 2013 16:45, 3dw...@verizon.net wrote: Here is a C++2014 status page for fun and profit. Excellent, thanks! Tested with xmllint. Are

[patch] regex_traits implementation

2013-06-27 Thread Tim Shen
Here is an all-in-one patch of implementing std::regex_traits in libstdc++-v3, including testsuites. This patch also includes changes in http://gcc.gnu.org/ml/libstdc++/2013-04/msg00115.html, so just forget that one. Thank you! -- Tim Shen regex_traits.patch Description: Binary data