Re: [PATCH, SH] Add support for inlined builtin-strcmp (1/2)

On 10/18/2013 12:53 AM, Oleg Endo wrote: > Hi, > > On Thu, 2013-10-17 at 16:13 +0200, Christian Bruel wrote: >> Hello, >> >> This patch just reorganizes the SH code used for memory builtins into >> its own file, in preparation of the RTL strcmp hoisting in the next part. >> > Since GCC is now bein

Re: [PATCH, SH] Add support for inlined builtin-strcmp (2/2)

On 10/18/2013 01:05 AM, Oleg Endo wrote: > I was wondering, in file sh-mem.c, the new function > 'sh4_expand_cmpstr' ... why is it SH4-something? It's a bit confusing, > since cmp/str has been around since ever (i.e. since SH1). Maybe just > rename it to 'sh_expand_cmpstr' instead? Just historica

Re: patch to canonize unsigned tree-csts

Richard Biener writes: > On Wed, 16 Oct 2013, Kenneth Zadeck wrote: > >> On 10/15/2013 02:30 PM, Richard Sandiford wrote: >> > Richard Sandiford writes: >> > >if (small_prec) >> > > ; >> > >else if (precision == xprecision) >> > > while (len >= 0 && val[len - 1]

Re: [PATCH, SH] Add support for inlined builtin-strcmp (1/2)

Christian Bruel wrote: > This patch just reorganizes the SH code used for memory builtins into > its own file, in preparation of the RTL strcmp hoisting in the next part. > > OK for trunk ? A minor nit: > * gcc/config/sh/sh-mem (expand_block_move): Moved here. lost .c? Ok with that chan

[PATCH][buildrobot] frv: Fix get_tree_code_name() conversion fallout

Hi! When building for frv-linux, I see some fallout (cf. http://toolchain.lug-owl.de/buildbot/deliver_artifact.php?mode=view&id=91345): g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qu

Re: [wide-int] int_traits

On Thu, 17 Oct 2013, Mike Stump wrote: > On Oct 17, 2013, at 1:46 AM, Richard Biener wrote: > > [This function shows another optimization issue: > > > >case BOOLEAN_TYPE: > > /* Cache false or true. */ > > limit = 2; > > if (wi::leu_p (cst, 1)) > >ix = cst.to_uhwi ();

Re: [wide-int] int_traits

On Thu, 17 Oct 2013, Kenneth Zadeck wrote: > On 10/17/2013 10:05 AM, Richard Sandiford wrote: > > Richard Biener writes: > > > > > What's the reason again to not use my original proposed encoding > > > > > of the MSB being the sign bit? RTL constants simply are all signed > > > > > then. Just y

Re: [wide-int] int_traits

On Thu, 17 Oct 2013, Kenneth Zadeck wrote: > On 10/17/2013 09:48 AM, Richard Biener wrote: > > On Thu, 17 Oct 2013, Richard Sandiford wrote: > > > > > Richard Biener writes: > > > > On Thu, 17 Oct 2013, Richard Sandiford wrote: > > > > > > > > > Richard Biener writes: > > > > > > > The new tre

Re: [patch] Rename tree-flow.h to tree-cfg.h.

On Fri, Oct 18, 2013 at 2:48 AM, Andrew MacLeod wrote: > This patch finally renames tree-flow.h to tree-cfg.h. It now contains just > the prototypes for tree-cfg.h. Yay! > I've also removed all the #include's from tree-cfg.h, and relocated them > (temporarily) to tree-ssa.h which is acting as t

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On 18 October 2013 00:58, Jeff Law wrote: > On 10/17/13 05:03, Richard Biener wrote: Is it OK for trunk? >>> >>> >>> I had a much simpler change which did basically the same from 4.7 (I >>> can update it if people think this is a better approach). >> >> >> I like that more (note you can

Re: [Patch] Fix wide char locale support(like CJK charset) in regex

Hi, >Oops that's only perfect Chinese version of "hello, world" under UTF-8 >charset. Now it's hex format. > >I also make the char handling simpler. Great, thanks! Paolo

Re: [PATCH][buildrobot] frv: Fix get_tree_code_name() conversion fallout

On Fri, Oct 18, 2013 at 10:23 AM, Jan-Benedict Glaw wrote: > Hi! > > When building for frv-linux, I see some fallout (cf. > http://toolchain.lug-owl.de/buildbot/deliver_artifact.php?mode=view&id=91345): > > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions > -fno-rtti -fasync

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On Fri, Oct 18, 2013 at 11:21 AM, Zhenqiang Chen wrote: > On 18 October 2013 00:58, Jeff Law wrote: >> On 10/17/13 05:03, Richard Biener wrote: > > Is it OK for trunk? I had a much simpler change which did basically the same from 4.7 (I can update it if people think th

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

On Thu, 17 Oct 2013, Cong Hou wrote: > I tested this case with -fno-tree-loop-im and -fno-tree-pre, and it > seems that GCC could hoist j+1 outside of the i loop: > > t3.c:5:5: note: hoisting out of the vectorized loop: _10 = (sizetype) j_25; > t3.c:5:5: note: hoisting out of the vectorized loop:

Re: PR C++/58708 - string literal operator templates broken

On 10/18/2013 04:42 AM, Ed Smith-Rowland wrote: Here is a patch to correct the char type and the type, number of nontype parameter pack for user defined strng literal operator templates. Let's make sure Jason is in CC. Thanks! Paolo.

Re: [PATCH][i386]Fix PR 57756

Sriraman, The tests gcc.target/i386/funcspec-5.c and gcc.target/i386/pr57756.c fail on targets for which -msse is the default (see http://gcc.gnu.org/ml/gcc-testresults/2013-10/msg01365.html or http://gcc.gnu.org/ml/gcc-testresults/2013-10/msg01345.html ). This is fixed with the following patch:

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On 18 October 2013 17:53, Richard Biener wrote: > On Fri, Oct 18, 2013 at 11:21 AM, Zhenqiang Chen > wrote: >> On 18 October 2013 00:58, Jeff Law wrote: >>> On 10/17/13 05:03, Richard Biener wrote: >> >> Is it OK for trunk? > > > I had a much simpler change which did basicall

Re: RFC: Add of type-demotion pass

On Thu, Oct 17, 2013 at 9:32 PM, Jeff Law wrote: > On 10/17/13 04:41, Richard Biener wrote: >>> >>> I don't see this as the major benefit of type demotion. Yes, there is >>> some >>> value in shrinking constants and the like, but in my experience the >>> benefits >>> are relatively small and ofte

[Ping] Re: [C++ Patch] Tidy a bit cp_parser_lookup_name

Hi On 10/13/2013 08:26 PM, Paolo Carlini wrote: Hi, today I noticed that in cp_parser_lookup_name the code in the object_type != NULL_TREE else can be tidied a bit and a lookup_name_real often avoided. Tested x86_64-linux. Can I apply this clean-up? It seems pretty straightforward to me, ess

Re: [PATCH] Fix part of PR58712

On 2013.10.15 at 12:49 +0200, Richard Biener wrote: > On Tue, Oct 15, 2013 at 12:31 PM, Markus Trippelsdorf > wrote: > > Valgrind complains: > > ==27870== Conditional jump or move depends on uninitialised value(s) > > ==27870==at 0x557CDC: cgraph_create_edge_1(cgraph_node*, cgraph_node*, > >

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

On Wed, Oct 9, 2013 at 3:09 AM, Bernd Edlinger wrote: > Hi, > > On Mon, 30 Sep 2013 16:18:30, DJ Delorie wrote: >> >> As per my previous comments on this patch, I will not approve the >> changes to the m32c backend, as they will cause real bugs in real >> hardware, and violate the hardware's ABI.

RE: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

Hi, On Thu, 17 Oct 2013 16:41:13, DJ Delorie wrote: > I'm starting from an MCU that doesn't work right if GCC doesn't do > what the user tells GCC to do. I added -fstrict-volatile-bitfields to > tell gcc that it needs to be more strict than the standard allows for > bitfield access, because withou

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On Fri, Oct 18, 2013 at 12:06 PM, Zhenqiang Chen wrote: > On 18 October 2013 17:53, Richard Biener wrote: >> On Fri, Oct 18, 2013 at 11:21 AM, Zhenqiang Chen >> wrote: >>> On 18 October 2013 00:58, Jeff Law wrote: On 10/17/13 05:03, Richard Biener wrote: >>> >>> Is it OK for trunk?

Re: [PATCH] Fix part of PR58712

On Fri, Oct 18, 2013 at 12:10 PM, Markus Trippelsdorf wrote: > On 2013.10.15 at 12:49 +0200, Richard Biener wrote: >> On Tue, Oct 15, 2013 at 12:31 PM, Markus Trippelsdorf >> wrote: >> > Valgrind complains: >> > ==27870== Conditional jump or move depends on uninitialised value(s) >> > ==27870==

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On 18 October 2013 18:15, Richard Biener wrote: > On Fri, Oct 18, 2013 at 12:06 PM, Zhenqiang Chen > wrote: >> On 18 October 2013 17:53, Richard Biener wrote: >>> On Fri, Oct 18, 2013 at 11:21 AM, Zhenqiang Chen >>> wrote: On 18 October 2013 00:58, Jeff Law wrote: > On 10/17/13 05:03,

[PATCH] Fix PR58775

Hi, The patch fixes PR58775. Bootstrap and no make check regression on X86-64? Is it OK? Thanks! -Zhenqiang ChangeLog: 2013-10-18 Zhenqiang Chen PR tree-optimization/58775 * tree-ssa-reassoc.c (next_stmt_of): New function. (not_dominated_by): Check next_stmt_of for

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On 18 October 2013 10:13, Andrew Pinski wrote: > On Thu, Oct 17, 2013 at 6:39 PM, Andrew Pinski wrote: >> On Thu, Oct 17, 2013 at 4:03 AM, Richard Biener >> wrote: >>> On Thu, Oct 17, 2013 at 4:14 AM, Andrew Pinski wrote: On Wed, Oct 16, 2013 at 2:12 AM, Zhenqiang Chen wrote: > H

Re: [PATCH] Portable Volatility Warning

On Wed, Oct 16, 2013 at 2:48 PM, Bernd Edlinger wrote: > Hi Richard, > > well I think I have now a solution for both of your comments on the > initial version of the portable volatility warning patch. > Furthermore I have integrated Sandra's comments. > > Therefore I think it might be worth anothe

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

On Sat, Sep 28, 2013 at 4:19 AM, Sandra Loosemore wrote: > This patch fixes various -fstrict-volatile-bitfields wrong-code bugs, > including instances where bitfield values were being quietly truncated as > well as bugs relating to using the wrong width. The code changes are > identical to those

Re: [Patch tree-ssa] RFC: Enable path threading for control variables (PR tree-optimization/54742).

On Fri, Jun 21, 2013 at 11:21 PM, Steve Ellcey wrote: > On Fri, 2013-06-21 at 17:43 +0100, James Greenhalgh wrote: > >> So to my mind, this is all far too tied up in pass ordering details to >> resolve. Given that all the threading opportunities for my patch are found >> in dom1 and how fragile th

Re: [Patch tree-ssa] RFC: Enable path threading for control variables (PR tree-optimization/54742).

On Fri, Oct 18, 2013 at 11:55:08AM +0100, Richard Biener wrote: > I suppose with Jeffs recent work on jump-threading through paths > this case in handled and the patch in this thread is obsolete or can > be reworked? Yes, this patch is now obsolete, Jeff's solution is much more elegant :-) Thanks

Re: [PATCH] Fix PR58775

On Fri, Oct 18, 2013 at 06:36:44PM +0800, Zhenqiang Chen wrote: --- a/gcc/tree-ssa-reassoc.c +++ b/gcc/tree-ssa-reassoc.c @@ -2861,6 +2861,19 @@ swap_ops_for_binary_stmt (vec ops, } } +/* Determine if stmt A is in th next list of stmt B. */ +static inline bool +next_stmt_of (gimple a, gimp

Re: [PATCH]Fix computation of offset in ivopt

On Thu, Oct 17, 2013 at 7:52 AM, bin.cheng wrote: > Hi, > As noted in previous messages, GCC forces offset to unsigned in middle end. > It also gets offset value and stores it in HOST_WIDE_INT then uses it in > various computation. In this scenario, It should use int_cst_value to do > additional

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

On Tue, Sep 17, 2013 at 7:37 PM, Richard Sandiford wrote: > Mike Stump writes: >> +/* Partial integer modes are specified by relation to a full integer >> + mode. */ >> +#define PARTIAL_INT_MODE(M,PREC) \ >> + make_partial_integer_mode (#M, "P" #PREC #M, PR

Re: Ping Re: [gomp4] Dumping gimple for offload.

On Thu, Oct 3, 2013 at 6:05 PM, Ilya Tocar wrote: > On 26 Sep 21:21, Ilya Tocar wrote: >> On 25 Sep 15:48, Richard Biener wrote: >> > On Wed, Sep 25, 2013 at 3:29 PM, Ilya Tocar >> > wrote: >> > > On 24 Sep 11:02, Richard Biener wrote: >> > >> On Mon, Sep 23, 2013 at 3:29 PM, Ilya Tocar >> > >

RE: [PATCH] Fix PR58682

> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On > Behalf Of Paulo Matos > Sent: 16 October 2013 09:42 > To: Mike Stump; Kyrill Tkachov > Cc: gcc-patches@gcc.gnu.org > Subject: RE: [PATCH] Fix PR58682 > > > -Original Message- >

Fix asymmetric volatile handling in optimize_bit_field_compare

Hello Richard, I see it the same way. The existing code in optimize_bit_field_compare looks wrong. It is very asymmetric, and handles lvolatilep and rvolatilep differently. And the original handling of flag_strict_volatile_bitfields also was asymmetric. However this optimize-bit-field-compare c

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On Fri, Oct 18, 2013 at 12:34 PM, Zhenqiang Chen wrote: > On 18 October 2013 18:15, Richard Biener wrote: >> On Fri, Oct 18, 2013 at 12:06 PM, Zhenqiang Chen >> wrote: >>> On 18 October 2013 17:53, Richard Biener wrote: On Fri, Oct 18, 2013 at 11:21 AM, Zhenqiang Chen wrote: > On

Re: [PATCH]Fix computation of offset in ivopt

On 10/18/2013 01:18 PM, Richard Biener wrote: > Index: gcc/fold-const.c > === > --- gcc/fold-const.c (revision 203267) > +++ gcc/fold-const.c (working copy) > @@ -7270,8 +7270,8 @@ fold_plusminus_mult_expr (location_t loc, enum tre >

Re: Fix asymmetric volatile handling in optimize_bit_field_compare

On Fri, Oct 18, 2013 at 1:56 PM, Bernd Edlinger wrote: > Hello Richard, > > I see it the same way. > > The existing code in optimize_bit_field_compare looks wrong. It is very > asymmetric, > and handles lvolatilep and rvolatilep differently. And the original handling > of > flag_strict_volatile_

Re: [PATCH]Fix computation of offset in ivopt

On Fri, Oct 18, 2013 at 2:02 PM, Bernd Schmidt wrote: > On 10/18/2013 01:18 PM, Richard Biener wrote: > >> Index: gcc/fold-const.c >> === >> --- gcc/fold-const.c (revision 203267) >> +++ gcc/fold-const.c (working copy) >> @@ -7270,8 +

Re: [PATCH] Fix PR58682

On Fri, Oct 18, 2013 at 1:40 PM, Paulo Matos wrote: > > >> -Original Message- >> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On >> Behalf Of Paulo Matos >> Sent: 16 October 2013 09:42 >> To: Mike Stump; Kyrill Tkachov >> Cc: gcc-patches@gcc.gnu.org >> Subject

Re: [PING^2][PATCH][2 of 2] RTL expansion for zero sign extension elimination with VRP

On Wed, 16 Oct 2013, Kugan wrote: > Thanks Richard for the review. > > On 15/10/13 23:55, Richard Biener wrote: > > On Tue, 15 Oct 2013, Kugan wrote: > > > >> Hi Eric, > >> > >> Can you please help to review this patch? > >> http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00452.html > > > > I thin

Re: [c++-concepts] Shorthand notation

A small follow up change. This removes the "sorry" from concept name resolution. Committed in r203815. 2013-10-16 Andrew Sutton * gcc/cp/constraint.cc (finish_concept_name): Allow functions with the same name as concepts to resolve as call expressions in the usual way.

Re: [PATCH]Fix computation of offset in ivopt

On 10/18/2013 02:10 PM, Richard Biener wrote: > On Fri, Oct 18, 2013 at 2:02 PM, Bernd Schmidt > wrote: >> On 10/18/2013 01:18 PM, Richard Biener wrote: >> >>> Index: gcc/fold-const.c >>> === >>> --- gcc/fold-const.c (revision 203267

Re: [PATCH]Fix computation of offset in ivopt

On Fri, Oct 18, 2013 at 2:26 PM, Bernd Schmidt wrote: > On 10/18/2013 02:10 PM, Richard Biener wrote: >> On Fri, Oct 18, 2013 at 2:02 PM, Bernd Schmidt >> wrote: >>> On 10/18/2013 01:18 PM, Richard Biener wrote: >>> Index: gcc/fold-const.c ==

Re: libgo patch committed: Add system calls

Hello! > This patch to libgo adds some system calls to the syscall package. > Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. > Committed to mainline and 4.8 branch, since these calls were in Go > 1.1.2. Uros. Index: runtime/go-nosys.c =

Re: [PATCH] Reducing number of alias checks in vectorization.

On Wed, Oct 2, 2013 at 8:26 PM, Jakub Jelinek wrote: > On Wed, Oct 02, 2013 at 10:50:21AM -0700, Cong Hou wrote: >> >> + if (int_cst_value (p11.offset) != int_cst_value (p21.offset)) >> >> +return int_cst_value (p11.offset) < int_cst_value (p21.offset); >> > >> > This is going to ICE whenever

Re: [PATCH] [ARM] Fix PR57909 : ICE with internal memcpy and -mno-unaligned-access

Ping^2 I forgot this one was still pending. On 13 August 2013 14:21, Yvan Roux wrote: > Ping. > > On 23 July 2013 16:18, Yvan Roux wrote: >> Hi, >> >> I forgot to add the test case with the PR fix, the attached patch add it. >> >> Thanks, >> Yvan >> >> ChangeLog >> >> gcc/testsuite >> >> 2013-0

Re: [c++-concepts] Shorthand notation

Hi, On 10/18/2013 02:23 PM, Andrew Sutton wrote: A small follow up change. This removes the "sorry" from concept name resolution. Committed in r203815. 2013-10-16 Andrew Sutton * gcc/cp/constraint.cc (finish_concept_name): Allow functions with the same name as concepts to r

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

On 10/14/2013 05:34 PM, Joseph S. Myers wrote: > On Mon, 14 Oct 2013, Dodji Seketeli wrote: > >>> This patch has passes the existing -Wconversion testcases. It >>> modifies Wconversion-real.c, Wconversion-real-integer.c and >>> pr35635.c to be more specific >> >> If the patch passes existing tes

Re: [c++-concepts] Shorthand notation

I know. When I started working on the project, Gaby asked that I keep all concept-related changes in the top-level Changelog.concepts with full paths for the file names. Andrew Sutton On Fri, Oct 18, 2013 at 8:53 AM, Paolo Carlini wrote: > Hi, > > > On 10/18/2013 02:23 PM, Andrew Sutton wrote:

Re: [PATCH] Reducing number of alias checks in vectorization.

On Tue, Oct 15, 2013 at 12:43 AM, Cong Hou wrote: > Sorry for forgetting using plain-text mode. Resend it. > > > -- Forwarded message -- > From: Cong Hou > Date: Mon, Oct 14, 2013 at 3:29 PM > Subject: Re: [PATCH] Reducing number of alias checks in vectorization. > To: Richard Bie

Re: [wide-int] int_traits

On 10/18/2013 04:45 AM, Richard Biener wrote: On Thu, 17 Oct 2013, Mike Stump wrote: On Oct 17, 2013, at 1:46 AM, Richard Biener wrote: [This function shows another optimization issue: case BOOLEAN_TYPE: /* Cache false or true. */ limit = 2; if (wi::leu_p (cst, 1))

Re: [wide-int] int_traits

Richi, Do you want me to back out the patch that changes the rep for unsigned tree-csts? kenny

Re: [PATCH] Fix part of PR58712

> On Fri, Oct 18, 2013 at 12:10 PM, Markus Trippelsdorf > wrote: > > On 2013.10.15 at 12:49 +0200, Richard Biener wrote: > >> On Tue, Oct 15, 2013 at 12:31 PM, Markus Trippelsdorf > >> wrote: > >> > Valgrind complains: > >> > ==27870== Conditional jump or move depends on uninitialised value(s) >

Re: [wide-int] int_traits

On Fri, Oct 18, 2013 at 3:13 PM, Kenneth Zadeck wrote: > Richi, > > Do you want me to back out the patch that changes the rep for unsigned > tree-csts? Not yet please. Thanks, Richard. > kenny

Re: libgo patch committed: Add system calls

On Fri, Oct 18, 2013 at 5:40 AM, Uros Bizjak wrote: > Hello! > >> This patch to libgo adds some system calls to the syscall package. >> Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. >> Committed to mainline and 4.8 branch, since these calls were in Go >> 1.1.2. > > Uros. > > Index

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

On Wed, 2013-10-16 at 11:32 -0700, Mike Stump wrote: > On Oct 16, 2013, at 9:26 AM, Tom Tromey wrote: > > Andreas> You could put it in .dir-locals.el, or put a hook on > > Andreas> find-file-hook that looks at buffer-file-name. > > > We checked in a .dir-locals.el for gdb. I recommend it for GCC

[patch 1/8] Remove gimple-low.h from the tree-ssa.h include list.

gimple_check_call_matching_types() was being called from 3 or 4 different files,and seemed more appropriate as a cgraph routine (which called it 3 times). So I moved that and its helper to cgraph.c. After that, I only needed to update 4 .c files to directly include gimple-low.h bootstraps

[patch 2/8] Remove tree-ssa-address.h from the tree-ssa.h include list.

This patch just does the direct thing.. included the file where it was needed (7 .c files) I was tempted to move copy_ref_info() to a different file... its actually the only routine in this file which is SSA based... and rename the file tree-address.[ch]. Not sure where I'd copy it to, maybe

[patch 3/8] Remove tree-ssa-threadedge.h from the tree-ssa.h include list.

Straightforward. Just include tree-ssa-threadedge in the 4 .c files that need it. bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? Andrew * tree-ssa.h: Don't include tree-ssa-threadedge.h. * tree-ssa-dom.c: Include tree-ssa-threadedge.h. * tree-ssa-loop-ch.c: Likewise.

Re: libbacktrace patch committed (Was: Re: [jit] Update TODO.rst)

On Thu, 2013-10-17 at 21:28 -0700, Ian Lance Taylor wrote: > On Thu, Oct 17, 2013 at 8:54 PM, David Malcolm wrote: > > > > +* segfault seen in libbacktrace, when an ICE occurs > > That reminded me to commit this libbacktrace patch I worked up a > couple of weeks ago. Previously if some debug sec

[patch 4/8] Remove tree-ssa-dom.h from the tree-ssa.h include list.

degenerate_phi_result was defined in tree-ssa-dom.c, I moved it to tree-phinodes since all it does is determine whether the arguements of the phi which are not the same as the result are all the same. This reduced by half the number fo files which required tree-ssa-dom.h. bootstraps on x86_64-

[patch 5/8] Remove tree-cfgcleanup.h from the tree-ssa.h include list.

This was slightly more interesting. I moved the cleanup_cfg_post_optimizing pass from tree-optimize.c to tree-cfgcleanup.c. And that left tree-optimize.c empty... so I deleted that file as well. Other than that, just include it in the other 7 files that require it bootstraps on x86_64-unkno

[patch 6/8] Remove sbitmap.h from the tree-ssa.h include list.

Also straightforward. includes sbitmap in the 5 files that need it. I also happened to notice that tree-switch-conversion.c was including tree-ssa-operands.h directly, and doesnt need it, so removed it too bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? Andrew * tree-swi

[patch 7/8] Remove basic-block.h from cgraph.h

I also happened to notice that basic-block.h was being included directly by cgraph.h. The only thing cgraph.h and most of what use it need are the typedefs for gcov_type: typedef HOST_WIDEST_INT gcov_type; typedef unsigned HOST_WIDEST_INT gcov_type_unsigned; This patch moves gcov_type and gco

Re: [RFC] By default if-convert only basic blocks that will be vectorized (take 2)

failed on 403 of '06: regclass.c: In function 'init_reg_sets': regclass.c:277:1: internal compiler error: tree check: expected ssa_name, have var_decl in copy_ssa_name_fn, at tree-ssanames.c:393 init_reg_sets () ^ 0xb74124 tree_check_failed(tree_node const*, char const*, int, char const*, ...)

[patch 8/8] cfgloop.h includes basic-block.h

Another basoc-block inclusion. cfgloop.h was including basic-block.h, which meant lots of other things were getting it from here too. The only routine in cfgloop.h which uses anything from basic-block.h was bb_loop_depth(). By moving that to cfgloop.c, its no longer required by the .h file.

Re: [RFC] By default if-convert only basic blocks that will be vectorized (take 2)

On Fri, Oct 18, 2013 at 05:45:15PM +0400, Sergey Ostanevich wrote: > failed on 403 of '06: > regclass.c: In function 'init_reg_sets': > regclass.c:277:1: internal compiler error: tree check: expected > ssa_name, have var_decl in copy_ssa_name_fn, at tree-ssanames.c:393 > init_reg_sets () > ^ Yea

Re: [PATCH, rs6000] Don't convert a vector constant load into a splat illegally

Just a quick note that overnight testing of the posted patch was clean. Recap: There are three options on the table: - the posted patch - that patch with the (1 - start) change - replace nunits - 1 with nunits as the loop upper bound I'm happy to implement any of them, as you prefer. I lean t

Re: [Ping] Re: [C++ Patch] Tidy a bit cp_parser_lookup_name

OK. I thought I had already approved this, but apparently not. Jason

Re: [PATCH] Fix profile count updates during tail merging

On Tue, Oct 15, 2013 at 2:05 PM, Jan Hubicka wrote: >> This patch fixes a profile count insanity introduced by ssa tail >> merging. When replacing bb1 with bb2, which has the same successors, >> the bb counts were being merged, but the successor edge weights >> were not. >> >> Bootstrapped and tes

Re: [PATCH] Fix profile count updates during tail merging

> On Tue, Oct 15, 2013 at 2:05 PM, Jan Hubicka wrote: > >> This patch fixes a profile count insanity introduced by ssa tail > >> merging. When replacing bb1 with bb2, which has the same successors, > >> the bb counts were being merged, but the successor edge weights > >> were not. > >> > >> Bootst

Re: [Patch] Handle profile counts truncated to 0 in coldness test

> > As noted above, the change to avoid the RDIV by runs decreases the > effect of the min_run_ratio (now unlikely_count_fraction) in half. So > we really need to increase this parameter to 32 to compare to what the > old version of the code was doing. > > Indeed, using 32 does fix the same set o

Re: [Ping] Re: [C++ Patch] Tidy a bit cp_parser_lookup_name

On 10/18/2013 03:57 PM, Jason Merrill wrote: OK. I thought I had already approved this, but apparently not. Thanks, applied. Can I also ask you to follow up to this exchange which remained hanging? http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00827.html Thanks in advance! Paolo.

Re: [patch] Rename tree-flow.h to tree-cfg.h.

On 10/17/2013 08:48 PM, Andrew MacLeod wrote: rs6000 and alpha were including tree-flow.h in their config/target.c file. I built stage 1 for each target as a cross compiler to confirm builds dont break due to something unresolved. rs6000.c no longer needed it, alpha needs num_ssa_names, so i

Re: [Patch tree-ssa] RFC: Enable path threading for control variables (PR tree-optimization/54742).

On 10/18/13 04:55, Richard Biener wrote: On Fri, Jun 21, 2013 at 11:21 PM, Steve Ellcey wrote: On Fri, 2013-06-21 at 17:43 +0100, James Greenhalgh wrote: So to my mind, this is all far too tied up in pass ordering details to resolve. Given that all the threading opportunities for my patch are

Re: patch to enable LRA for ppc

On Thu, Oct 3, 2013 at 5:02 PM, Vladimir Makarov wrote: > The following patch permits today trunk to use LRA for ppc by default. > To switch it off -mno-lra can be used. > > The patch was bootstrapped on ppc64. GCC testsuite does not have > regressions too (in comparison with reload). The change

Re: [Patch tree-ssa] RFC: Enable path threading for control variables (PR tree-optimization/54742).

On 10/18/13 05:05, James Greenhalgh wrote: On Fri, Oct 18, 2013 at 11:55:08AM +0100, Richard Biener wrote: I suppose with Jeffs recent work on jump-threading through paths this case in handled and the patch in this thread is obsolete or can be reworked? Yes, this patch is now obsolete, Jeff's

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

On Fri, 18 Oct 2013, Joshua J Cogliati wrote: > This patch does not change any of the non-commented c and c++ code. > It changes the dg comments. > Example: > - fsi (3.1f); /* { dg-warning "conversion" } */ > + fsi (3.1f); /* { dg-warning "float-conversion" } */ > > If you want I can change it

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On 10/18/13 03:53, Richard Biener wrote: I think we want a "proper" predicate in tree-cfg.c for this, like maybe a subset of tree_forwarder_block_p or whatever it will end up looking like (we need "effectively empty BB" elsewhere, for example in vectorization, add a flag to allow a condition end

Re: [GOOGLE] Add flag to enalbe AutoFDO accurate mode

ok. David On Tue, Oct 15, 2013 at 10:58 AM, Dehao Chen wrote: > This patch add a new flag to let user to tell compiler that the > AutoFDO profile is accurate. So the compiler will assume function > without any sample is UNLIKELY_EXECUTED. This could save 10%~20% text > section size. > > Bootstra

Re: [PATCH] PR58669: does not detect all cpu cores/threads

On 18 October 2013 03:27, Tom Tromey wrote: >> "Andrew" == Andrew writes: > > Andrew> +#ifdef HAVE_UNISTD_H > Andrew> + procs = sysconf(_SC_NPROCESSORS_ONLN); > Andrew> +#endif > > Space before the "(". > > Technically you should probably check for sysconf in configure.ac. > I'm not sure wh

Re: Add predefined macros for library use in defining __STDC_IEC_559*

Note that the associated glibc patch is now approved, pending the GCC one. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH]Fix computation of offset in ivopt

Hi Richard, Is the first patch OK? Since there is a patch depending on it. http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01931.html Thanks. bin On Fri, Oct 18, 2013 at 7:18 PM, Richard Biener wrote: > On Thu, Oct 17, 2013 at 7:52 AM, bin.cheng wrote: >> Hi, >> As noted in previous messages, GCC

[PATCH] Add debug counter to jump threading code

I was debugging a failure yesterday in the jump threading code that was best narrowed down with a debug counter. No sense in keeping that in my local tree. While adding the new #include, I saw a couple #includes that clearly didn't belong, so I zapped them. Bootstrapped and regression tes

Re: [patch 3/8] Remove tree-ssa-threadedge.h from the tree-ssa.h include list.

On 10/18/13 07:38, Andrew MacLeod wrote: Straightforward. Just include tree-ssa-threadedge in the 4 .c files that need it. bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? OK. Jeff

Re: [patch 4/8] Remove tree-ssa-dom.h from the tree-ssa.h include list.

On 10/18/13 07:39, Andrew MacLeod wrote: degenerate_phi_result was defined in tree-ssa-dom.c, I moved it to tree-phinodes since all it does is determine whether the arguements of the phi which are not the same as the result are all the same. This reduced by half the number fo files which required

Re: [PATCH] Add debug counter to jump threading code

On 10/18/13 09:50, Jeff Law wrote: I was debugging a failure yesterday in the jump threading code that was best narrowed down with a debug counter. No sense in keeping that in my local tree. While adding the new #include, I saw a couple #includes that clearly didn't belong, so I zapped them.

Re: [patch 2/8] Remove tree-ssa-address.h from the tree-ssa.h include list.

On 10/18/13 07:38, Andrew MacLeod wrote: This patch just does the direct thing.. included the file where it was needed (7 .c files) I was tempted to move copy_ref_info() to a different file... its actually the only routine in this file which is SSA based... and rename the file tree-address.[ch]

Re: [patch 5/8] Remove tree-cfgcleanup.h from the tree-ssa.h include list.

On 10/18/13 07:40, Andrew MacLeod wrote: This was slightly more interesting. I moved the cleanup_cfg_post_optimizing pass from tree-optimize.c to tree-cfgcleanup.c. And that left tree-optimize.c empty... so I deleted that file as well. Other than that, just include it in the other 7 files that

[jit] Improvements to error-handling

Committed to dmalcolm/jit: Add defensive checks at the API boundary to gracefully reject various kinds of error. gcc/jit/ * internal-api.c (gcc::jit::context::get_type): Improve error message, and report the bogus value. (gcc::jit::context::new_binary_op): Likewise.

Re: [patch 7/8] Remove basic-block.h from cgraph.h

On 10/18/13 07:43, Andrew MacLeod wrote: I also happened to notice that basic-block.h was being included directly by cgraph.h. The only thing cgraph.h and most of what use it need are the typedefs for gcov_type: typedef HOST_WIDEST_INT gcov_type; typedef unsigned HOST_WIDEST_INT gcov_type_unsig

Re: [PATCH][ARM] New rtx costs table for Cortex A9

On 17/10/13 18:00, Kyrill Tkachov wrote: > Hi all, > > This patch adds the rtx costs table for the Cortex-A9 core. > An arm-none-eabi regression run tuned for A9 succeeded. > This costs tabled showed a slight improvement on some popular benchmarks and > no > performance regressions on others aga

Re: [patch 8/8] cfgloop.h includes basic-block.h

On 10/18/13 07:45, Andrew MacLeod wrote: Another basoc-block inclusion. cfgloop.h was including basic-block.h, which meant lots of other things were getting it from here too. The only routine in cfgloop.h which uses anything from basic-block.h was bb_loop_depth(). By moving that to cfgloop.c,

Re: [patch 1/8] Remove gimple-low.h from the tree-ssa.h include list.

On 10/18/13 07:37, Andrew MacLeod wrote: gimple_check_call_matching_types() was being called from 3 or 4 different files,and seemed more appropriate as a cgraph routine (which called it 3 times). So I moved that and its helper to cgraph.c. After that, I only needed to update 4 .c files to direc

[c++-concepts] Bugfix

Fixing 2 issues. A test for __is_convertible_to was missing in diagnose_trait, and *somehow* the logic for determining constraint ordering w.r.t. requires expressions was missing. Committed in 203826. 2013-10-16 Andrew Sutton * gcc/cp/logic.cc (left_requires), (decompose_left): Add

Re: [Patch] Fix wide char locale support(like CJK charset) in regex

On Fri, Oct 18, 2013 at 5:39 AM, Paolo Carlini wrote: >>Oops that's only perfect Chinese version of "hello, world" under UTF-8 >>charset. Now it's hex format. >> >>I also make the char handling simpler. > > Great, thanks! -m32 and -m64 tested and committed. By the way, UTF-8 *encoding* is a more

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

On 10/18/2013 04:50 AM, Richard Biener wrote: On Sat, Sep 28, 2013 at 4:19 AM, Sandra Loosemore wrote: This patch fixes various -fstrict-volatile-bitfields wrong-code bugs, including instances where bitfield values were being quietly truncated as well as bugs relating to using the wrong width.

  1   2   >