Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Uros Bizjak
Hello! index 000..5375b61 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr53623.c @@ -0,0 +1,25 @@ +/* { dg-do compile { target { x86_64-*-* } } } */ +/* { dg-options -O2 -fdump-rtl-ree } */ Please use: /* { dg-do compile { target { ! ia32 } } } */ Uros.

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jakub Jelinek
On Thu, Dec 19, 2013 at 09:57:36PM -0700, Jeff Law wrote: * ree.c (combine_set_extension): Handle case where source and destination registers in an extension insn are different. (combine_reaching_defs): Allow source and destination registers in extension to be different

Re: [PATCH] Ubsan load of bool/enum sanitization

2013-12-20 Thread Jakub Jelinek
On Thu, Dec 19, 2013 at 10:22:38PM -0700, Jeff Law wrote: + *gsi = create_cond_insert_point (gsi, /*before_p=*/true, + /*then_more_likely_p=*/false, + /*create_then_fallthru_edge=*/true, + then_bb,

[PING] RE: [PATCH] Vectorization for store with negative step

2013-12-20 Thread Bingfeng Mei
OK to commit? Thanks, Bingfeng -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Bingfeng Mei Sent: 18 December 2013 16:25 To: Jakub Jelinek Cc: Richard Biener; gcc-patches@gcc.gnu.org Subject: RE: [PATCH] Vectorization for store

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-12-20 Thread Bernd Schmidt
On 11/26/2013 07:45 AM, Chung-Lin Tang wrote: +(define_insn movhi_internal + [(set (match_operand:HI 0 nonimmediate_operand =m, r,r, r,r) +(match_operand:HI 1 general_operand rM,m,rM,I,J))] Didn't you say you'd removed the J alternative? +error (only register based stack

Re: [PATCH] Time profiler - phase 2

2013-12-20 Thread Dominique Dhumieres
Hello, there's updated version of the patch. Tested on x86_64 with enable bootstrap. Martin This caused pr59541. TIA Dominique

Re: [RFC/CFT] auto-wipe dump files [was: Re: [committed] Fix up bb-slp-31.c testcase]

2013-12-20 Thread Bernhard Reutner-Fischer
On Thu, Oct 31, 2013 at 09:39:11AM +0100, Jakub Jelinek wrote: On Thu, Oct 31, 2013 at 09:34:41AM +0100, Bernhard Reutner-Fischer wrote: The cleanup routine would currently run 7 regexes on the incoming compiler-flags which is supposedly pretty fast. But yes, we could as well key off

RE: Two build != host fixes

2013-12-20 Thread Bernd Edlinger
Date: Fri, 20 Dec 2013 07:57:02 +1030 From: amo...@gmail.com To: bernd.edlin...@hotmail.de CC: gcc-patches@gcc.gnu.org; ja...@redhat.com; d...@redhat.com; ebotca...@adacore.com Subject: Re: Two build != host fixes On Thu, Dec 19, 2013 at 11:50:02AM

Re: Improving mklog [was: Re: RFC Asan instrumentation control]

2013-12-20 Thread Yury Gribov
Ultimately, mklog ought to write the ChangeLog itself. We get rid of that headache, at least. How about this then? Updated mklog now adds 'New file'/'New test'/'Remove' when necessary. I did some tests with unified/context-diffed SVN and git and it worked as expected. I can do more testing

Re: [PATCH] fixincludes: use $(FI) instead of fixincl@EXEEXT@

2013-12-20 Thread Bernhard Reutner-Fischer
On 8 November 2013 17:28, Bruce Korb bk...@gnu.org wrote: Sure. Looks good to me. Thanks pushed as r206146 thanks, On Fri, Nov 8, 2013 at 2:57 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 4 April 2013 22:20, Bruce Korb bk...@gnu.org wrote: Except as noted below, fine by

Re: [PATCH 2/3] libstdc++-v3: ::tmpnam depends on uClibc SUSV4_LEGACY

2013-12-20 Thread Bernhard Reutner-Fischer
On 13 November 2013 18:56, Jonathan Wakely jwakely@gmail.com wrote: On 13 November 2013 09:22, Bernhard Reutner-Fischer wrote: On 11 November 2013 12:30, Jonathan Wakely jwakely@gmail.com wrote: How does __UCLIBC_SUSV4_LEGACY__ get defined? We'd have a problem if users defined that at

Re: [PATCH] Time profiler - phase 2

2013-12-20 Thread Iain Sandoe
Hi Martin, Thanks for working on this! --- However you have introduced some problems including a bootstrap fail on darwin. On 16 Dec 2013, at 10:13, Jan Hubicka wrote: Hello, there's updated version of the patch. Tested on x86_64 with enable bootstrap. Martin On 16 December 2013

[PATCH, libiberty] Remove malloc/realloc from demangler (was: Add a couple of missing casts)

2013-12-20 Thread Gary Benson
Ian Lance Taylor wrote: On Wed, Nov 13, 2013 at 7:30 AM, Gary Benson gben...@redhat.com wrote: Richard Biener wrote: On Tue, Nov 12, 2013 at 8:55 PM, Ian Lance Taylor i...@google.com wrote: On Tue, Nov 12, 2013 at 11:24 AM, Uros Bizjak ubiz...@gmail.com wrote: This was

[committed] Add testcase for PR59413

2013-12-20 Thread Jakub Jelinek
Hi! The bug in this PR has been introduced by my r204516 change and fixed by r205884 (PR59417) fix. I've committed the testcase as obvious so that we can close the PR. 2013-12-20 Jakub Jelinek ja...@redhat.com PR tree-optimization/59413 * gcc.c-torture/execute/pr59413.c: New

Re: [PATCH] merge auto_vec and stack_vec

2013-12-20 Thread Richard Biener
On Fri, Dec 20, 2013 at 12:18 AM, Trevor Saunders trev.saund...@gmail.com wrote: As discussed in http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02808.html bootstrap + same regression tests as previous rev, ok? Ok. Thanks, Richard. 2013-12-19 Trevor saunders tsaund...@mozilla.com gcc/

[PATCH, nds32] Committed: Fix inaccurate alignment checking when passing BLKmode argument.

2013-12-20 Thread Chung-Ju Wu
Hi, all, There is a problem in nds32.h to determine available register number for passing BLKmode argument. The original checking only refers to NDS32_NEED_N_REGS_FOR_ARG macro but that is not sufficient to make decision of using odd or even register number. It is supposed to further check the

Re: [PING] RE: [PATCH] Vectorization for store with negative step

2013-12-20 Thread Richard Biener
On Fri, Dec 20, 2013 at 11:09 AM, Bingfeng Mei b...@broadcom.com wrote: OK to commit? Ok. Thanks, Richard. Thanks, Bingfeng -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Bingfeng Mei Sent: 18 December 2013 16:25 To:

Re: [PATCH, ARM, v2] Fix PR target/59142: internal compiler error while compiling OpenCV 2.4.7

2013-12-20 Thread Richard Earnshaw
On 19/12/13 17:40, Charles Baylis wrote: On 19 December 2013 16:13, Richard Earnshaw rearn...@arm.com wrote: OK with that change. Thanks. The bugzilla entry is targeted at 4.8, but it is a latent problem which affects 4.7 too. Is it ok for 4.8, and should it be considered for 4.7?

Re: [PATCH][ARM] Implement CRC32 intrinsics for AArch32 in ARMv8-A

2013-12-20 Thread Kyrill Tkachov
On 19/12/13 17:58, Kyrill Tkachov wrote: On 18/12/13 15:32, Ramana Radhakrishnan wrote: On Tue, Dec 3, 2013 at 1:46 PM, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: Ping? http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02351.html Thanks, Kyrill Ok if no objections in 24 hours. Thanks Ramana,

[Patch] libgcov.c re-factoring

2013-12-20 Thread Teresa Johnson
On Tue, Dec 17, 2013 at 7:48 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, Dec 16, 2013 at 2:48 PM, Xinliang David Li davi...@google.com wrote: Ok -- gcov_write_counter and gcov_write_tag_length are qualified as low level primitives for basic gcov format and probably should be kept in

[C++ PATCH] Don't ICE on TYPE_BINFO (PR c++/59111)

2013-12-20 Thread Marek Polacek
We ICEd on invalid testcases with auto, because lookup_conversions got template_type_parm as a parameter and the TYPE_BINFO didn't like it. Fixed by checking for RECORD_OR_UNION_TYPE_P first. Regtested/bootstrapped on x86_64-linux, ok for trunk? 2013-12-20 Marek Polacek pola...@redhat.com

Re: [PATCH, libiberty] Remove malloc/realloc from demangler (was: Add a couple of missing casts)

2013-12-20 Thread Ian Lance Taylor
On Fri, Dec 20, 2013 at 5:00 AM, Gary Benson gben...@redhat.com wrote: --- a/libiberty/ChangeLog +++ b/libiberty/ChangeLog @@ -1,3 +1,20 @@ +2013-12-20 Gary Benson gben...@redhat.com + + * cp-demangle.c (struct d_print_info): New fields + next_saved_scope, copy_templates,

Re: [RFC][gomp4] Offloading patches (3/3): Add invocation of target compiler

2013-12-20 Thread Bernd Schmidt
On 12/17/2013 12:42 PM, Michael V. Zolotukhin wrote: Hi everybody, Here is a patch 3/3: Add invocation of target compiler. + /* Run objcopy on TARGET_IMAGE_FILE_NAME. */ + buf1 = (char*) xmalloc (strlen (.data=.) + + strlen (OFFLOAD_IMAGE_SECTION_NAME) + 1); + if

Re: Improving mklog [was: Re: RFC Asan instrumentation control]

2013-12-20 Thread Diego Novillo
On 20/12/2013, 07:08 , Yury Gribov wrote: Ultimately, mklog ought to write the ChangeLog itself. We get rid of that headache, at least. How about this then? Updated mklog now adds 'New file'/'New test'/'Remove' when necessary. I did some tests with unified/context-diffed SVN and git and it

[PATCH] Improve i?86/x86_64 prologue_and_epilogue for leaf functions (PR target/59501)

2013-12-20 Thread Jakub Jelinek
Hi! Honza recently changed the i?86 backend, so that it often doesn't do -maccumulate-outgoing-args by default on x86_64. Unfortunately, on some of the here included testcases this regressed quite a bit the generated code. As AVX vectors are used, the dynamic realignment code needs to assume

Re: [PATCH] Improve i?86/x86_64 prologue_and_epilogue for leaf functions (PR target/59501)

2013-12-20 Thread H.J. Lu
On Fri, Dec 20, 2013 at 8:06 AM, Jakub Jelinek ja...@redhat.com wrote: Hi! Honza recently changed the i?86 backend, so that it often doesn't do -maccumulate-outgoing-args by default on x86_64. Unfortunately, on some of the here included testcases this regressed quite a bit the generated

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jeff Law
On 12/20/13 01:17, Uros Bizjak wrote: Hello! index 000..5375b61 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr53623.c @@ -0,0 +1,25 @@ +/* { dg-do compile { target { x86_64-*-* } } } */ +/* { dg-options -O2 -fdump-rtl-ree } */ Please use: /* { dg-do compile { target { ! ia32 } } }

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jeff Law
On 12/20/13 01:24, Jakub Jelinek wrote: Thanks for working on this, the only thing I'd worry about are HARD_REGNO_NREGS 1 registers if the two hard regs might overlap. The reg_set_between_p and reg_used_between_p calls when you dig down into them eventually use reg_overlap_mentioned_p which

[4.8, committed] Backport value-prof.c fix (PR c++/59255)

2013-12-20 Thread Jakub Jelinek
Hi! I've backported this fix from the trunk to 4.8 branch and for the trunk committed the new testcase. 2013-12-20 Jakub Jelinek ja...@redhat.com PR c++/59255 Backported from mainline 2013-08-19 Dehao Chen de...@google.com * value-prof.c (gimple_ic): Fix the

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jakub Jelinek
On Fri, Dec 20, 2013 at 09:26:10AM -0700, Jeff Law wrote: Thanks for working on this, the only thing I'd worry about are HARD_REGNO_NREGS 1 registers if the two hard regs might overlap. The reg_set_between_p and reg_used_between_p calls when you dig down into them eventually use

Re: [RFC][gomp4] Offloading patches (3/3): Add invocation of target compiler

2013-12-20 Thread Michael V. Zolotukhin
This patch seems to make rather too many assumptions about host and target compilers. Certainly code like this can't go into target-independent code like lto-wrapper. That's true. The point of this patch was to show what is needed to support x86-MIC OpenMP offloading, as we currently see it.

[PATCH][x86] march aliases

2013-12-20 Thread Ilya Tocar
Perhaps we should add sandybridge, ivybridge and haswell aliases for corei7-avx, core-avx-i, core-avx2? I mean, it is a nightmare to remember which one has the i7 in and which doesn't even for me. Yes please, I think this is a good idea. I've added aliases for haswell, sandybridge,

Re: [PATCH][x86] march aliases

2013-12-20 Thread H.J. Lu
On Fri, Dec 20, 2013 at 8:47 AM, Ilya Tocar tocarip.in...@gmail.com wrote: Perhaps we should add sandybridge, ivybridge and haswell aliases for corei7-avx, core-avx-i, core-avx2? I mean, it is a nightmare to remember which one has the i7 in and which doesn't even for me. Yes please, I

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jeff Law
On 12/20/13 09:45, Jakub Jelinek wrote: On Fri, Dec 20, 2013 at 09:26:10AM -0700, Jeff Law wrote: Thanks for working on this, the only thing I'd worry about are HARD_REGNO_NREGS 1 registers if the two hard regs might overlap. The reg_set_between_p and reg_used_between_p calls when you dig

[RFC][gomp4] Offloading: Add device initialization and host-target function mapping

2013-12-20 Thread Ilya Verbin
Hi Jakub, Could you please take a look at this patch for libgomp? It adds new function GOMP_register_lib, that should be called from every exec/lib with target regions (that was done in patch [1]). This function maintains the array of pointers to the target shared library descriptors. Also

Re: RFA (cgraph): C++ 'structor decloning patch, Mark III

2013-12-20 Thread Jason Merrill
On 12/13/2013 10:32 AM, Jan Hubicka wrote: On 12/13/2013 05:58 AM, Jan Hubicka wrote: Moreover when we turn comdat_local to false, we need to recompute also function it is inlined into. I don't see why. If function A calls function B, which calls comdat-local function C, A can be inlined, so

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jakub Jelinek
On Fri, Dec 20, 2013 at 10:17:10AM -0700, Jeff Law wrote: ISTM if we're presented with something like that (and I don't think there's anything in RA which explicitly disallows such code), then what we have to evaluate is whether or not the transformation preserves the semantics. So,

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jeff Law
On 12/20/13 10:25, Jakub Jelinek wrote: So it probably should be checked in combine_reaching_defs instead where you have already both the registers in the right modes available and can call reg_overlap_mentioned_p on them directly. One argument would be SET_DEST (def_insn) and one SET_DEST

[RFA][PATCH][PR middle-end/59285] BARRIERS and merged blocks

2013-12-20 Thread Jeff Law
So here's an alternate approach to fixing 59285. I still think attacking this in rtl_merge_blocks is better, but with nobody else chiming in to break the deadlock Steven and myself are in, I'll go with Steven's preferred solution (fix the callers in ifcvt.c). If we were to return to a fix

[ARM] add armv7ve support

2013-12-20 Thread Renlin Li
Hi all, This patch will add armv7ve support to gcc. Armv7ve is basically a armv7-a architecture profile with Virtualization Extensions. Additional test cases are also added. With this patch and to keep backward compatibility with old assembler, the following asm header will be generated

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jeff Law
On 12/20/13 10:25, Jakub Jelinek wrote: Yes. So my suggestion actually was not correct for that: !reg_overlap_mentioned_p (dest, XEXP (src, 0)) because the first extension above has r1:SI and r2:DI which don't overlap, only r1:DI and r2:DI overlap. So it probably should be checked in

Re: [RFA][PATCH][middle-end/53623] Improve extension elimination

2013-12-20 Thread Jakub Jelinek
On Fri, Dec 20, 2013 at 01:44:06PM -0700, Jeff Law wrote: @@ -342,7 +354,8 @@ combine_set_extension (ext_cand *cand, rtx curr_insn, rtx *orig_set) if (dump_file) { fprintf (dump_file, -Tentatively merged extension with definition:\n); +

[linaro/gcc-4_8-branch] Backports from trunk and merge from gcc-4_8-branch

2013-12-20 Thread Christophe Lyon
We have committed several backports from trunk to linaro/gcc-4_8-branch: r203799 as r205740 (fix testcases for ARM hardfloat targets) r203327 as r205742 (Enhance phiopt to handle BIT_AND_EXPR) r204737 as r205743 (Make AArch64 frame grow downwards) r202872 as r205744 ([ARM][testsuite] Add

[patch] powerpc64 FreeBSD support for boehm-gc

2013-12-20 Thread Andreas Tobler
Hi, the below patch adds support for powerpc64 FreeBSD for the boehm-gc. The diff is already available in boehm-gc trunk. Ok for gcc trunk? Thanks, Andreas 2013-12-20 Andreas Tobler andre...@gcc.gnu.ch * include/private/gcconfig.h: Add FreeBSD powerpc64 defines. Index:

Re: [PATCH] Conditional count update for fast coverage test in multi-threaded programs

2013-12-20 Thread Rong Xu
Here are the results using our internal benchmarks which are a mixed a multi-threaded and single-threaded programs. This was collected about a month ago but I did not got time to send due to an unexpected trip. cmpxchg gives the worst performance due to the memory barriers it incurs. I'll send a

Re: [PATCH][x86] march aliases

2013-12-20 Thread H.J. Lu
On Fri, Dec 20, 2013 at 8:55 AM, H.J. Lu hjl.to...@gmail.com wrote: On Fri, Dec 20, 2013 at 8:47 AM, Ilya Tocar tocarip.in...@gmail.com wrote: Perhaps we should add sandybridge, ivybridge and haswell aliases for corei7-avx, core-avx-i, core-avx2? I mean, it is a nightmare to remember which

Re: [PING] RE: [PATCH] Vectorization for store with negative step

2013-12-20 Thread H.J. Lu
On Fri, Dec 20, 2013 at 2:09 AM, Bingfeng Mei b...@broadcom.com wrote: OK to commit? Thanks, Bingfeng -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Bingfeng Mei Sent: 18 December 2013 16:25 To: Jakub Jelinek Cc:

Re: [C++ PATCH] Don't ICE on TYPE_BINFO (PR c++/59111)

2013-12-20 Thread Jason Merrill
On 12/20/2013 09:29 AM, Marek Polacek wrote: We ICEd on invalid testcases with auto, because lookup_conversions got template_type_parm as a parameter and the TYPE_BINFO didn't like it. Fixed by checking for RECORD_OR_UNION_TYPE_P first. Use CLASS_TYPE_P instead. OK with that change. Jason

Re: [PATCH] Convert more passes to new dump framework

2013-12-20 Thread Sharad Singhai
Committed documentation as r206161. Sorry about the delay. Thanks, Sharad On Thu, Nov 28, 2013 at 10:03 AM, Martin Jambor mjam...@suse.cz wrote: Hi, On Tue, Aug 06, 2013 at 10:18:05AM -0700, Sharad Singhai wrote: On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor mjam...@suse.cz wrote: On Tue,