Re: [google gcc-4_8] Don't use gcov counter related ssa name as induction variables

2014-02-10 Thread Wei Mi
Here is the updated patch, which follow UD chain to determine whether iv.base is defined by __gcovx.xxx[] var. It is a lot simpler than adding a tree bit. regression test and previously failed benchmark in piii mode is ok. Other test is going on. 2014-02-10 Wei Mi * tree-ssa-loop-ivop

Re: [RS6000] power8 internal compiler errors

2014-02-10 Thread David Edelsohn
On Mon, Feb 10, 2014 at 8:33 PM, Alan Modra wrote: > On Mon, Feb 10, 2014 at 07:01:03PM -0500, David Edelsohn wrote: >> On Mon, Feb 10, 2014 at 5:18 PM, Alan Modra wrote: >> >> Shouldn't addr_op2 also be set from find_replacement? > > Sorry, I thought after I sent the email that I should have add

[google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-10 Thread Sriraman Tallam
Hi Teresa, I have attached a patch to recognize and reorder split functions in the function reordering plugin. Please review. Thanks Sri This enhances the linker plugin to reorder functions that are split when using -freorder-blocks-and-partition. Index: function_reordering_plugin/callgraph.h

Re: [Patch, microblaze]: Extended mcpu version format

2014-02-10 Thread Michael Eager
On 11/25/13 23:53, David Holsgrove wrote: MicroBlaze currently only supports mcpu version of format vX.YY.Z This patch extends the mcpu version format to include; vX.YY.Z vXX.YY.Z vXX.YY vX.YY.Z Changelog 2013-11-26 Nagaraju Mekala * gcc/config/microblaze/microblaze.c: Extend mcp

Re: [RS6000] power8 internal compiler errors

2014-02-10 Thread Alan Modra
On Mon, Feb 10, 2014 at 07:01:03PM -0500, David Edelsohn wrote: > On Mon, Feb 10, 2014 at 5:18 PM, Alan Modra wrote: > > Shouldn't addr_op2 also be set from find_replacement? Sorry, I thought after I sent the email that I should have added some explanation of why certain parts need find_replacem

Re: [Patch, microblaze]: Add SIZE_TYPE and PTRDIFF_TYPE to microblaze.h

2014-02-10 Thread Michael Eager
On 11/25/13 23:52, David Holsgrove wrote: Hi Michael, I've attached patch based on latest gcc master. Please let me know if you need anything further. thanks, David On 15 July 2013 14:42, David Holsgrove wrote: Hi Michael, On 18 March 2013 22:50, David Holsgrove wrote: Changelog 2013-0

[PATCH] Fix PR target/60137, no splitters for vectors that get GPR registers

2014-02-10 Thread Michael Meissner
This patch fixes PR target/60137 that shows up when some vector types get allocated to GPR registers, and there wasn't a splitter for the type. It shows up when targetting ISA 2.07 (power8) when VSX is disabled but Altivec (VMX) is enabled, though I suspect there are other failure cases. I bootst

Re: [C PATCH] Improve column info of initializers (PR c/60114)

2014-02-10 Thread Joseph S. Myers
On Mon, 10 Feb 2014, Marek Polacek wrote: > This patch improves location information in a bunch of various > initializers; see the testcase. Main issue was that digest_init > was getting only input_location. > > Regtested/bootstrapped on x86_64-linux, ok for trunk at this stage > or should I que

Re: print quotes around )

2014-02-10 Thread Joseph S. Myers
On Sun, 9 Feb 2014, Prathamesh Kulkarni wrote: > On Sun, Feb 9, 2014 at 8:31 PM, Prathamesh Kulkarni > wrote: > > A trivial fix to print quotes around ) in libcpp/macro.c > > OK for trunk ? > Will not work for if pfile->cb.error callback does not recognize %< and %> > (maybe clients other than c,

Re: [RS6000] power8 internal compiler errors

2014-02-10 Thread David Edelsohn
On Mon, Feb 10, 2014 at 5:18 PM, Alan Modra wrote: Shouldn't addr_op2 also be set from find_replacement? - David > @@ -16201,7 +16200,7 @@ > || !rs6000_legitimate_offset_address_p (PTImode, addr, > false, true))) > { >

Re: [google gcc-4_8] Don't use gcov counter related ssa name as induction variables

2014-02-10 Thread Xinliang David Li
I don't think you should add a new tree bit just for this. A simple UD check can determine prephitmp_23, etc are abnormal ssa names: # prephitmp_23 = PHI PROF_edge_counter_10 = prephitmp_23 + 1; __gcov0.foo[0] = PROF_edge_counter_10; Note you may need to 'hack' a little to check if a stati

[google gcc-4_8] Don't use gcov counter related ssa name as induction variables

2014-02-10 Thread Wei Mi
Hi, I saw a bug happened in fdo-gen phase when a gcov counter related ssa name was used as induction variable and used to calculate loop boundary after loop cond was replaced by an expr with the ssa name. We knew that there was data race in gcov counter in multithread program, so the values in gco

Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-10 Thread Tobias Burnus
Hi! Thomas Schwinge wrote: Please see [...] $ git diff --stat 765faa80eda3bb75aa044ad015e2e5214bf02c6d origin/gomp-4_0-branch | grep -v ChangeLog I am now browsing through the changes. Remarks: 1) I think you also want to set in gcc/fortran/options.c gfc_option.flag_recursive = -1

Re: PATCH: PR target/59605: Create jump_around_label only if it doesn't exist

2014-02-10 Thread Andrew Pinski
On Thu, Dec 26, 2013 at 6:31 PM, H.J. Lu wrote: > Hi Honza, > > r203937 may create jump_around_label earlier. But later code doesn't > check if jump_around_label exists. This patch fixes it. Tested > on Linux/x86-64. OK to install? This test times out when running on a simulator. Is there a w

[RFA] [PATCH] [rtl-optimization/60131] Fix rtl-checking failure in REE

2014-02-10 Thread Jeff Law
As mentioned in the BZ, we have the following insns: (insn 24 23 25 6 (set (reg:DI 0 ax [orig:100 D.2269 ] [100]) (zero_extend:DI (reg/v:SI 0 ax [orig:91 v ] [91]))) j.c:22 133 {*zero_extendsidi2} (nil)) $13 = void (gdb) p debug_rtx (curr_insn) (insn 33 32 35 7 (set (reg/v:SI 0 a

[jit] Add the ability to get int types by size/signedness.

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: Provide a way to get a N-byte int with a given signedness. Also, use template tricks in the C++ wrapper API so that one can map types by writing e.g. gccjit::type index_t_gcc = ctxt.get_int_type (); and having the compiler figure out the details of the type a

[RS6000] power8 internal compiler errors

2014-02-10 Thread Alan Modra
Since reload may make multiple passes through insns, rtl seen during reload can look a little messy. On the second and subsequent passes you get to see any transformations made on previous passes. The rtl sanity checks in rs6000_secondary_reload_inner didn't take this fact into account, leading t

[PATCH] Handle more COMDAT profiling issues

2014-02-10 Thread Teresa Johnson
This patch attempts to address the lost profile issue for COMDATs in more circumstances, exposed by function splitting. My earlier patch handled the case where the comdat had 0 counts since the linker kept the copy in a different module. In that case we prevent the guessed frequencies on 0-count f

Re: [google gcc-4_8][patch] Thunk section names

2014-02-10 Thread Teresa Johnson
Looks good. Thanks, Teresa On Thu, Feb 6, 2014 at 2:19 PM, Sriraman Tallam wrote: > Patch attached. > > > > > > On Thu, Feb 6, 2014 at 2:18 PM, Sriraman Tallam wrote: >> I sent the following patch for review for trunk commit here. Details here: >> http://gcc.gnu.org/ml/gcc-patches/2014-02/msg003

Re: [google gcc-4_8] unify int and fp scaling in gcov-tool

2014-02-10 Thread Rong Xu
Yes. They were the bug I mentioned. This patch fixed that. -Rong On Mon, Feb 10, 2014 at 10:40 AM, Teresa Johnson wrote: > Looks good to me. > > A couple questions: > >> static void >> -__gcov_scale_icall_topn (gcov_type *counters, unsigned n_counters, double f) >> +__gcov_icall_topn_op (gcov_t

RFA: XFAIL gcc.dg/vect/pr56787.c if vect_no_align

2014-02-10 Thread Richard Sandiford
Not 100% sure whether this is the preferred fix, but gcc.dg/vect/pr56787.c has lots of float * parameters that point who-knows-where and so is only vectorised if the target supports misaligned vector accesses: void foo (unsigned long n, const float *__restrict u0, const float *__restrict u1,

[committed] Add some missing vect_ints

2014-02-10 Thread Richard Sandiford
Add /* { dg-require-effective-target vect_int } */ to some tests that require integer vectorisation. pr57741-3.c is mostly a float test but also has a char array (r) that needs to be vectorised. The others are pure integer tests. Tested on mipsisa64-sde-elf and applied as obvious. Thanks, Richa

Re: Ping: PR target/59605: Create jump_around_label only if it doesn't exist

2014-02-10 Thread H.J. Lu
On Mon, Feb 10, 2014 at 11:54 AM, Richard Sandiford wrote: > "H.J. Lu" writes: >> On Sat, Feb 1, 2014 at 2:28 AM, Richard Sandiford >> wrote: >>> "H.J. Lu" writes: On Thu, Jan 30, 2014 at 10:43 AM, Richard Sandiford wrote: > Hi H.J., > > "H.J. Lu" writes: >> diff --g

[jit] Add gcc_jit_function_get_param

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * libgccjit.h (gcc_jit_function_get_param): New. * libgccjit.map (gcc_jit_function_get_param): New. * libgccjit.c (gcc_jit_function_get_param): New. * libgccjit++.h (gccjit::function::get_param): New. --- gcc/jit/ChangeLog

Ping: PR target/59605: Create jump_around_label only if it doesn't exist

2014-02-10 Thread Richard Sandiford
"H.J. Lu" writes: > On Sat, Feb 1, 2014 at 2:28 AM, Richard Sandiford > wrote: >> "H.J. Lu" writes: >>> On Thu, Jan 30, 2014 at 10:43 AM, Richard Sandiford >>> wrote: Hi H.J., "H.J. Lu" writes: > diff --git a/gcc/testsuite/gcc.dg/pr59605.c > b/gcc/testsuite/gcc.dg/pr5960

[jit] Mark "get_inner_" methods as const within C++ wrapper API.

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * libgccjit++.h (gccjit::object::get_inner_object): Make const. (gccjit::location::get_inner_location): Likewise. (gccjit::field::get_inner_field): Likewise. (gccjit::type::get_inner_type): Likewise. (gccjit::functi

[jit] Add operator overloading to the C++ API.

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * libgccjit++.h (gccjit::object::get_context): New method. (gccjit::function): Add overloaded operator () for various numbers of arguments as a very terse way of creating function calls. (gccjit::rvalue::get_type): New meth

[VxWorks] Allow --enable-threads=posix

2014-02-10 Thread rbmj
Some builds of VxWorks have a pthread compatibility layer. This patch allows one to compile GCC to use the pthread compatibility layer instead of the native vxworks threads. I wrote this patch to get the c++11 threads to work - the vxworks native support don't implement all the necessary feat

Re: [google gcc-4_8] unify int and fp scaling in gcov-tool

2014-02-10 Thread Teresa Johnson
Looks good to me. A couple questions: > static void > -__gcov_scale_icall_topn (gcov_type *counters, unsigned n_counters, double f) > +__gcov_icall_topn_op (gcov_type *counters, unsigned n_counters, > + counter_op_fn fn, void *data1, void *data2) > { >unsigned i; > > @@

[jit] Provide a more terse C++ wrapper API.

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: Add some more methods to the C++ wrapper API to reduce the amount of typing needed when performing specific operations, albeit it without going all the way to using operator overloading, since the latter is often too "magical" for some people's taste, and may make

Re: [C PATCH] Improve column info of initializers (PR c/60114)

2014-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2014 at 10:45:24AM -0700, Jeff Law wrote: > >2014-02-10 Marek Polacek > > > > PR c/60114 > >c/ > > * c-parser.c (c_parser_initelt): Pass input_location to > > process_init_element. > > (c_parser_initval): Pass loc to process_init_element. > > * c-tree.h (proce

Re: [PING] [PATCH] _Cilk_for for C and C++

2014-02-10 Thread Jakub Jelinek
On Fri, Feb 07, 2014 at 10:14:21PM +, Iyer, Balaji V wrote: > Attached, please find a fixed patch. Along with it, I have also > added 2 changelog files for C and C++ respectively. Have you even looked at the second testcase I've posted? gimplification ICEs on it with your latest patch, b

Re: CALL_INSN_FUNCTION_USAGE fix, PR52773

2014-02-10 Thread Andreas Schwab
Bernd Schmidt writes: > This is bug that triggers on m68k. The loop unroller creates a MULT > expression and tries to force it into a register, which causes a libcall > to be generated. Since args are pushed we create a > (use (mem (plus virtual_outgoing_args scratch))) > in CALL_INSN_FUNCTION_

Re: [C PATCH] Improve column info of initializers (PR c/60114)

2014-02-10 Thread Jeff Law
On 02/10/14 06:44, Marek Polacek wrote: This patch improves location information in a bunch of various initializers; see the testcase. Main issue was that digest_init was getting only input_location. Regtested/bootstrapped on x86_64-linux, ok for trunk at this stage or should I queue it for 5.0

Re: {GRAPHITE] Replacement of isl_int by isl_val

2014-02-10 Thread Albert Cohen
Le 10/02/2014 16:48, Albert Cohen a écrit : > Le 10/02/2014 10:12, Richard Biener a écrit : >> Btw, Mircea - do you have a copyright assignment on file with the FSF >> covering work on GCC? > > Yes, Mircea is covered by an INRIA-wide copyright assignment, signed on > May 15, 2007 by T. Brown. Aft

Re: [PATCH] fix for PR 59691

2014-02-10 Thread Jeff Law
On 02/06/14 15:21, Iyer, Balaji V wrote: Hello Everyone, Attached, please find a patch that will fix the issue in PR 59691. The main issue was that the Cilk library (libcilkrts) was not checking if the target has SSE support before emitting SSE instruction. This patch should fix that.

Re: [PATCH] Fix for PR60080

2014-02-10 Thread Jeff Law
On 02/07/14 04:00, Bernd Edlinger wrote: Hi, there has been a ICE on solaris 9 and 10 when dumping ASM_INPUT objects without valid source loation at print-rtl.c. print_rtx did not check for this, and tried to print NULL with printf format %s. This happens to be handled by glibc's printf to prin

Re: Unreviewed testsuite patch

2014-02-10 Thread Jeff Law
On 02/10/14 09:28, Rainer Orth wrote: The following patch has remained unreviewed for a week: [testsuite] Don't xfail gcc.dg/binop-xor1.c http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00147.html OK. Jeff

Re: [RFA] [middle-end/54041] Convert modes as needed from expand_expr

2014-02-10 Thread Jeff Law
On 02/07/14 02:17, Richard Biener wrote: +2014-02-05 Jeff Law + + PR middle-end/54041 + * expr.c (expand_expr_addr_1): Handle expand_expr returning an + object with an undesirable mode. + 2014-02-05 Bill Schmidt * config/rs6000/rs6000.c (altivec_expand_vec_perm

Re: [PATCH] Set correct probability for ORDER/UNORDER jumps

2014-02-10 Thread Dehao Chen
ping... Dehao On Fri, Jan 24, 2014 at 1:54 PM, Dehao Chen wrote: > Thanks, test updated: > > Index: gcc/testsuite/gcc.dg/predict-8.c > === > --- gcc/testsuite/gcc.dg/predict-8.c (revision 0) > +++ gcc/testsuite/gcc.dg/predict-8.c (r

Unreviewed testsuite patch

2014-02-10 Thread Rainer Orth
The following patch has remained unreviewed for a week: [testsuite] Don't xfail gcc.dg/binop-xor1.c http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00147.html Rainer -- - Rainer Orth, Center for Bio

Re: [PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-10 Thread Steve Kargl
On Mon, Feb 10, 2014 at 05:23:39PM +0200, Janne Blomqvist wrote: > On Sun, Feb 9, 2014 at 2:40 AM, Steve Kargl > wrote: > > All, > > > > Here is a potentially contentious patch for PR fortran/52879. > > > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52879 > > > > As demonstrated in that PR, it is

[jit] Pass std::vector by reference within the C++ wrapper API

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * libgccjit++.h (gccjit::context::new_struct_type): Pass std::vector "fields" argument by reference rather than by value. (gccjit::context::new_function): Likewise, for "params" arg. (gccjit::context::new_call): Likewise, f

Re: [testsuite, i386] Compile g++.dg/ext/vector26.C with -mmmx

2014-02-10 Thread Uros Bizjak
On Mon, Feb 10, 2014 at 5:14 PM, Rainer Orth wrote: > On both Solaris 9/x86 and 32-bit Linux/x86, g++.dg/ext/vector26.C FAILs > like this: > > FAIL: g++.dg/ext/vector26.C -std=c++11 (test for excess errors) > Excess errors: > /vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/ext/vector26.C:6:13: >

[testsuite, i386] Compile g++.dg/ext/vector26.C with -mmmx

2014-02-10 Thread Rainer Orth
On both Solaris 9/x86 and 32-bit Linux/x86, g++.dg/ext/vector26.C FAILs like this: FAIL: g++.dg/ext/vector26.C -std=c++11 (test for excess errors) Excess errors: /vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/ext/vector26.C:6:13: warning: M MX vector argument without MMX enabled changes the ABI

Re: [v3] Don't xfail 22_locale/num_put/put/char/14220.cc etc. on Solaris 9/x86

2014-02-10 Thread Paolo Carlini
Hi, On 02/10/2014 04:59 PM, Rainer Orth wrote: Two libstdc++ testcases have been XPASSing on Solaris 9/x86 since ca. 20130522: XPASS: 22_locale/num_put/put/char/14220.cc execution test XPASS: 22_locale/num_put/put/wchar_t/14220.cc execution test Therefore I'd like to remove the xfails since th

[jit] Use std::string rather than const char * in C++ wrapper API.

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * libgccjit++.h (gccjit::context::new_location): Update filename arg from a const char * to a const std::string &. (gccjit::context::new_field): Likewise for "name" arg. (gccjit::context::new_struct_type): Likewise.

[v3] Don't xfail 22_locale/num_put/put/char/14220.cc etc. on Solaris 9/x86

2014-02-10 Thread Rainer Orth
Two libstdc++ testcases have been XPASSing on Solaris 9/x86 since ca. 20130522: XPASS: 22_locale/num_put/put/char/14220.cc execution test XPASS: 22_locale/num_put/put/wchar_t/14220.cc execution test Therefore I'd like to remove the xfails since the issue documented there doesn't seem to trigger a

Re: {GRAPHITE] Replacement of isl_int by isl_val

2014-02-10 Thread Albert Cohen
Le 10/02/2014 10:12, Richard Biener a écrit : > Btw, Mircea - do you have a copyright assignment on file with the FSF > covering work on GCC? Yes, Mircea is covered by an INRIA-wide copyright assignment, signed on May 15, 2007 by T. Brown. Thanks, Albert

[jit] Use default arguments to eliminate half of the methods in the C++ wrapper API.

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: Consolidate the with/without source location pairs of methods in the C++ wrapper API into individual methods. This should all compile down to just the equivalent of supplying a NULL (gcc_jit_location *) where the client code doesn't provide a gccjit::location. g

Re: [PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-10 Thread Janne Blomqvist
On Sun, Feb 9, 2014 at 2:40 AM, Steve Kargl wrote: > All, > > Here is a potentially contentious patch for PR fortran/52879. > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52879 > > As demonstrated in that PR, it is possible to provide RANDOM_SEED > with sets of seeds that result in a very poor se

[jit] Update TODO.rst

2014-02-10 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * TODO.rst: Update. --- gcc/jit/ChangeLog.jit | 4 +++ gcc/jit/TODO.rst | 69 +-- 2 files changed, 55 insertions(+), 18 deletions(-) diff --git a/gcc/jit/ChangeLog.jit b/gcc/jit/ChangeLog.jit

Re: [RFA][middle-end/52306] Fix reload from creating invalid RTL

2014-02-10 Thread Ulrich Weigand
Jeff Law wrote: > Anyway, we're processing the input reload for insn 73. We see that insn > 71's SET_DEST is the same as the input reload. The input reload's > reloadreg is a0. Replacing (reg:SI 48) with a0 in insn 71 produces an > insn which is recognized and which satisfies its constraints

Re: RFA: patch for PR59535

2014-02-10 Thread Richard Earnshaw
On 07/02/14 22:06, Jeff Law wrote: > On 02/07/14 11:20, Vladimir Makarov wrote: >>The following patch improves code size for ARM. Before the patch >> CSiBE size generated by GCC configured --with-arch=armv7-a >> --with-fpu=vfpv3-d16 --with-float=hard (with -mthumb) was >> >> 2414926 >> >> Afte

[PING]Re: [PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression

2014-02-10 Thread Renlin Li
On 03/02/14 10:02, Renlin Li wrote: On 02/02/14 19:02, Renlin Li wrote: Hi all, This is a simple patch which resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression. Basically, no special operations are needed for vector type i32in128 or f32in64 in big-endian mode any more due

[PING]Re: [PATCH][ARM]fix potential testsuite/gcc.target/arm/fixed_float_conversion.c regression

2014-02-10 Thread Renlin Li
On 03/02/14 15:56, Renlin Li wrote: Hi all, This patch will ensure testsuite/gcc.target/arm/fixed_float_conversion.c is checked only when "-mfpu=vfp3 -mfloat-abi=softfp" is applicable for the target. Accordingly, two procs (check_effective_target_arm_vfp3_ok and add_options_for_arm_vfp3) ar

[C PATCH] Improve column info of initializers (PR c/60114)

2014-02-10 Thread Marek Polacek
This patch improves location information in a bunch of various initializers; see the testcase. Main issue was that digest_init was getting only input_location. Regtested/bootstrapped on x86_64-linux, ok for trunk at this stage or should I queue it for 5.0? 2014-02-10 Marek Polacek PR

Re: {GRAPHITE] Replacement of isl_int by isl_val

2014-02-10 Thread Tobias Grosser
On 02/10/2014 04:12 AM, Richard Biener wrote: On Sun, Feb 9, 2014 at 9:19 PM, Tobias Grosser wrote: On 02/09/2014 04:47 PM, Mircea Namolaru wrote: Patch for replacement of the isl_int (obsolete) by isl_val. No regressions for c/c++/fortran on x86-64 Linux. Hi Mircae, thanks a lot

Re: [PATCH] Fix PR60115

2014-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2014 at 02:22:44PM +0100, Richard Biener wrote: > > This fixes PR60115 where the issue is that tree_could_trap_p does > not evaluate MEM_REFs for possibly out-of-bound accesses (in case > the access is lowered from an ARRAY_REF where the code does that). > > I've unified TARGET_ME

[PATCH] Fix PR60115

2014-02-10 Thread Richard Biener
This fixes PR60115 where the issue is that tree_could_trap_p does not evaluate MEM_REFs for possibly out-of-bound accesses (in case the access is lowered from an ARRAY_REF where the code does that). I've unified TARGET_MEM_REF and MEM_REF handling and made the order of checking for trapping base

[PATCH][AArch64][committed] Fix typo in aarch64.c

2014-02-10 Thread Kyrill Tkachov
Hi all, I've committed the attached typo fix as obvious as r207654. Cheers, Kyrill 2014-02-10 Kyrylo Tkachov * config/aarch64/aarch64.c (aarch64_override_options): Fix typo from coretex to cortex.diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 16c51a8.

Minor fixes in ipa-devirt.c

2014-02-10 Thread Eric Botcazou
get_polymorphic_call_info_from_invariant is declared as returning bool but actually returns NULL_TREE in several places, and there are several lines in possible_polymorphic_call_targets with dozens(!) of trailing spaces. Tested on x86-64/Linux, applied on the mainline as obvious. 2014-02-10 E

Re: [testsuite, committed] Fix effective target for ivdep tests

2014-02-10 Thread Eric Botcazou
> The ivdep tests use int arrays but required vect_float rather than vect_int. > > Tested on mipsisa64-sde-elf, where it fixes some spurious failures for > -mips32r2/-mfp64, and on mips64-linux-gnu. Applied as obvious. The 3rd and 4th tests also require vect_int_mult. Tested on x86-64/Linux and

[PATCH][ARM] Add -mcpu=native detection for Cortex-A53, A57

2014-02-10 Thread Kyrill Tkachov
Hi all, This patchlet adds the part numbers for the Cortex-A53 and A57 cores so that they can be detected when parsing /proc/cpuinfo on AArch32 Linux systems. This will allow the -mcpu=native machinery to detect those cores. Tested arm-none-eabi on a model. This is a fairly innocuous change,

Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-10 Thread Thomas Schwinge
Hi! On Mon, 10 Feb 2014 13:44:51 +0400, Ilmir Usmanov wrote: > > As -fopenmp seemingly can be mixed with -fopenacc, I think it would be > > nice to have some test cases where !$omp and !$acc are both placed - > > in either order - before the same Fortran statement. > > > I'm going to test this,

Re: [PATCH][ARM] Adjust thumb2_movhi_insn patter

2014-02-10 Thread Ramana Radhakrishnan
On Mon, Feb 3, 2014 at 11:39 AM, Kyrill Tkachov wrote: > Hi all, > > This patch updates the thumb2_movhi_insn pattern for the -mrestrict-it > rules. I had somehow missed it when doing the -mrestrict-it work last year, > and it is possible to generate a deprecated IT block form in ARMv8 Thumb2 > co

Re: [committed] Fix #pragma omp simd with local address taken variables (PR c/59984)

2014-02-10 Thread Jakub Jelinek
On Sun, Feb 09, 2014 at 01:09:28PM +0100, Dominique Dhumieres wrote: > The test gcc.dg/vect/pr59984.c fails on targets using an as that does > not support avx instructions (e.g., darwin). I've committed this to hopefully fix that. 2014-02-10 Jakub Jelinek * gcc.dg/vect/pr59984.c: Requ

Re: [PATCH][AArch64] Wire up Cortex-A57 rtx costs

2014-02-10 Thread Marcus Shawcroft
On 30 January 2014 13:48, Kyrill Tkachov wrote: > Hi all, > > This patch wires up the aarch64 backend to use the Cortex-A57 rtx costs > table that is proposed at > http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01954.html OK if release manager agrees. /Marcus

Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-10 Thread Ilmir Usmanov
Hi Tobias! Thanks a lot for your review! I'm going to test you notes in "reference implementation" (PGI compiler), and then share the results. On 10.02.2014 03:42, Tobias Burnus wrote: Is there a reason that you don't automatically add that flag via goacc.exp? Ditto. Also spaces before/afte

Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-10 Thread Ilmir Usmanov
Hi Thomas! On 10.02.2014 12:52, Thomas Schwinge wrote: --- /dev/null +++ b/gcc/testsuite/gfortran.dg/goacc/goacc.exp @@ -0,0 +1,36 @@ +# Load support procs. +load_lib gfortran-dg.exp + +if ![check_effective_target_fopenmp] { + return +} I assume that this should be indeed "fopenmp" here and no

Re: {GRAPHITE] Replacement of isl_int by isl_val

2014-02-10 Thread Richard Biener
On Sun, Feb 9, 2014 at 9:19 PM, Tobias Grosser wrote: > On 02/09/2014 04:47 PM, Mircea Namolaru wrote: >> >>Patch for replacement of the isl_int (obsolete) by isl_val. >> >>No regressions for c/c++/fortran on x86-64 Linux. > > > Hi Mircae, > > thanks a lot for looking into this. > > Just f

Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-10 Thread Thomas Schwinge
Hi! On Mon, 10 Feb 2014 00:10:26 +0100, Tobias Burnus wrote: > Ilmir Usmanov wrote: > > OpenACC 1.0 fortran FE support -- matching and resolving. > > +static void > > +resolve_oacc_cache (gfc_code *) > > +{ > > + //TODO: resolve subarrays > > +} > > ;-) Just to clarify: I'm fine with inc

Re: Use "[warning enabled by default]" for default warnings

2014-02-10 Thread Richard Biener
On Sun, Feb 9, 2014 at 9:30 PM, Robert Dewar wrote: > On 2/9/2014 3:23 PM, Richard Sandiford wrote: > >>> can't we just reword the one warning where there is an ambiguity to >>> avoid the confusion, rather than creating such an earthquake, which >>> as Arno says, really has zero advantages to Ada

Re: Avoid unnnecesary copying of ipa-prop's expressions

2014-02-10 Thread Richard Biener
On Fri, 7 Feb 2014, Jan Hubicka wrote: > > On Thu, 6 Feb 2014, Jan Hubicka wrote: > > > > > Hi, > > > at WPA we currently read trees accessed by jump functions and then copy > > > them > > > to remove location that is already known to be UNKNOWN and then keep > > > copying > > > them for every

Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-10 Thread Thomas Schwinge
Hi! On Mon, 10 Feb 2014 00:42:54 +0100, Tobias Burnus wrote: > Some general questions to the patch set: Thanks for helping review! > * I miss "-fopenacc". Is the support already in the branch? I assume > that part is then in c-family/c.opt fortran/lang.opt? > > * Documentation: Do you also n

Re: [PATCH] New optimize(0) versioning fix (PR target/60026, take 2)

2014-02-10 Thread Richard Biener
On Fri, 7 Feb 2014, Jan Hubicka wrote: > > On Fri, Feb 07, 2014 at 12:50:22AM +0100, Jan Hubicka wrote: > > > Don't we want to check opt_for_fn (node->decl, cp) instead and arrange > > > -fipa-cp > > > to be false when !optimize? > > > > I can easily imagine using > > !opt_for_fn (node->decl,

Re: [PATCH] Fix Cilk+ catch_exc.cc

2014-02-10 Thread Richard Biener
On Sat, 8 Feb 2014, Jakub Jelinek wrote: > Hi! > > install_builtin calls build_fn_decl, which sets TREE_NOTHROW by default. > In most cases I think that is desirable, but __cilkrts_rethrow apparently > conditionally throws an exception, thus marking it TREE_NOTHROW is very much > undesirable and

Re: [patch] Fix array overflow in gcc.dg/vect/no-vfa-vect-depend-2.c

2014-02-10 Thread Jakub Jelinek
On Tue, Feb 04, 2014 at 04:59:14PM -0800, Paul Pluzhnikov wrote: > gcc/testsuite/ChangeLog: > > 2014-02-04 Paul Pluzhnikov > > * gcc.dg/vect/no-vfa-vect-depend-2.c (main1): Fix buffer > overflow. Ok, thanks. > --- gcc/testsuite/gcc.dg/vect/no-vfa-vect-depend-2.c (revision 20