Re: [PATCH] New check and updates in check_GNU_style script

2014-07-21 Thread Yury Gribov
On 07/22/2014 02:24 AM, Sebastian Pop wrote: What about getting clang-format to GNU format instead of improving this ad-hoc script? Well, GNU support in clang-format seems to be at it's early days so improving diagnostic in check_GNU_style does not seem to be totally useless. In general clan

Re: [PATCH] Support asan-fixed-shadow-offset in GCC

2014-07-21 Thread Yury Gribov
On 07/21/2014 11:00 PM, Alexey Preobrazhensky wrote: This patch adds support for non-fixed shadow in asan stack instrumentation. We probably also need to support non-fixed shadow in the middle-end (the patch only implements it for RTL stack poisoner). -Y

[PATCH] rs6000: fix for PR61396 (wide-int fallout)

2014-07-21 Thread Segher Boessenkool
CONSTANT_P is true for more than just all kinds of constant number. This patch undoes that part of the wide-int patches. Bootstrapped and tested on powerpc64-linux, -m64,-m32,-m32/-mpowerpc64. No regressions (and the testcase mentioned in the PR is fixed, of course). Okay to apply? Segher 201

Re: Patch for constexpr variable templates

2014-07-21 Thread Braden Obrzut
Sure, test cases moved. My FSF paperwork is in place. I don't have write access to the repository though of course. - Braden Obrzut 2014-07-21 Braden Obrzut * decl.c (grokvardecl): Handle specializations of variable templates. (grokdeclarator): Handle variable template id express

Implement N4051 - Allow typename in a template template parameter

2014-07-21 Thread Ed Smith-Rowland
This little annoyance has bugged me a couple of times over the years: template struct A {}; template using B = int; template class X> struct C; C ca; // ok C cb; // ok, not a class template template typename X> struct D; // error, cannot use typename here C++17 it seems allows typename in tem

Re: [PATCH] New check and updates in check_GNU_style script

2014-07-21 Thread Sebastian Pop
What about getting clang-format to GNU format instead of improving this ad-hoc script? http://clang.llvm.org/docs/ClangFormatStyleOptions.html http://reviews.llvm.org/D2371 Thanks, Sebastian PS: Please do not use my @codeaurora.org email address: I do not have access to that email anymore. You ca

Re: [PATCH, rs6000, 4.8] Fix many powerpc*-linux ASAN test suite failures

2014-07-21 Thread Peter Bergner
On Fri, 2014-07-18 at 17:53 +0200, Jakub Jelinek wrote: > On Fri, Jul 18, 2014 at 11:40:31AM -0400, David Edelsohn wrote: > > This patch is okay with me if it is okay with the Release Managers. > > Ok. Ok, I committed this as revision 212899. Thanks! Peter

Re: [PATCH, rs6000, 4.9] Fix many powerpc*-linux ASAN test suite failures

2014-07-21 Thread Peter Bergner
On Fri, 2014-07-18 at 17:54 +0200, Jakub Jelinek wrote: > On Fri, Jul 18, 2014 at 11:38:22AM -0400, David Edelsohn wrote: > > This is okay with me if it is okay with the Release Managers. > > Ok. Ok, I committed this as revision 212898. Thanks! Peter

[PATCH] Support asan-fixed-shadow-offset in GCC

2014-07-21 Thread Alexey Preobrazhensky
Hi all, This patch adds support for non-fixed shadow in asan stack instrumentation. It is required for Kernel AddressSanitizer, as the shadow offset is not known at the compile time, and the shadow may not be allocated during the early boot stages. This option is intended to be triggered by -fsa

[PATCH v2] RTEMS: Add multilibs for ARM

2014-07-21 Thread Sebastian Huber
This change is necessary to support Cortex-M4 and Cortex-R based chips in RTEMS. This patch should be applied to GCC 4.8, 4.9 and mainline. I do not have write access, so in case this gets approved, please commit it for me. gcc/ChangeLog 2014-07-21 Sebastian Huber * config/arm/t-rtem

[PATCH, libffi, alpha]: Use FFI_ASSERT in ffi_closure_osf_inner

2014-07-21 Thread Uros Bizjak
Hello! Attached patch fixes libgo reflect test failure with libffi closures. The gccgo compiler started to use FFI closures recently; the compiler passes ffi_type_void for structures with zero members. ffi_call form src/alpha/ffi.c allows FFI_TYPE_VOID arguments in non-debug mode through the defa

Re: [PATCH, PR61776] verify_flow_info failed: control flow in the middle of basic block with -fprofile-generate

2014-07-21 Thread Wei Mi
By the way, the resetting of const/pure flags loop is also executed during profile-use, but if there is no instrumentation, the reset is unnecessary. The flags are kept until pass_ipa_pure_const fixes them. And because of non-instantaneous ssa update, the fixes are reflected on ssa only after ipa

[PATCH, PR61776] verify_flow_info failed: control flow in the middle of basic block with -fprofile-generate

2014-07-21 Thread Wei Mi
Hi, This patch is to fix: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61776 It records func decls whose const/pure flags are reset during instrumentation. After the loop resetting const/pure flags, find out stmts calling those recorded funcs and perform cfg fixup on them. bootstrap and regressi

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

2014-07-21 Thread Tom Tromey
> "Samuel" == Samuel Bronson writes: Samuel> +# FIXME: The handling of e.g. std::basic_string (at least on char) Samuel> +# probably needs updating to work with Python 3's new string rules. Samuel> +# Samuel> +# In particular, Python 3 has a separate type (called byte) for Samuel> +# bytestri

[PATCH] gcc/toplev.c: Avoid to close 'asm_out_file' when it is 'stdout'

2014-07-21 Thread Chen Gang
'asm_out_file' may be 'stdout', so need check this case before close it. Or 'stdout' may be closed -- since need not open 'stdout', either need not close it. ChangLog: * topleve.c (finalize): Avoid to close 'asm_out_file' when it is 'stdout'. Signed-off-by: Chen Gang --- gcc/toplev.c | 2 +

Re: PR 60414: Patch proposal

2014-07-21 Thread Dominique d'Humières
Le 21 juil. 2014 à 15:03, Andre Vehreschild a écrit : > Hi Dominique, > > thank you very much for your comments. I really appreciate them. ;-) > Unfortunately I am contracted only for a limited number of around 6 bugs. The > control on which bugs to pick is done by compiling a project and res

Re: [GSoC] generation of Gimple code from isl_ast_node_user

2014-07-21 Thread Tobias Grosser
On 21/07/2014 12:25, Roman Gareev wrote: I've asked the community about this. The patch below contains the FIXME. LGTM. Feel free to commit. Thanks, Tobias

Re: Patch for constexpr variable templates

2014-07-21 Thread Ed Smith-Rowland
Braden, I've played with this and it seems to work nicely. Only one comment: Could you put the test cases in the C++14 subdirectory? g++.dg/template/cpp1y/var-templ1.C ^ We should CC Jason on all this. Also, do you have your FSF paperwork in place? Thanks, Ed

Re: [PATCH, i386, PR61827] Fix fuse-caller-save-xmm.c test-case

2014-07-21 Thread Tom de Vries
On 21-07-14 12:40, Uros Bizjak wrote: On Mon, Jul 21, 2014 at 12:34 PM, Tom de Vries wrote: Dominique noticed that the .LC0 check failed on darwin, since the label LC0 is used. This follow-up patch fixes that (and I see now you already Ok-ed this change). Furthermore, I've realized from the c

Re: [PATCH, i386, PR61827] Fix fuse-caller-save-xmm.c test-case

2014-07-21 Thread Uros Bizjak
On Mon, Jul 21, 2014 at 12:34 PM, Tom de Vries wrote: > Dominique noticed that the .LC0 check failed on darwin, since the label LC0 > is used. This follow-up patch fixes that (and I see now you already Ok-ed > this change). > > Furthermore, I've realized from the comments in the PR that for > sol

Re: [PATCH, i386, PR61827] Fix fuse-caller-save-xmm.c test-case

2014-07-21 Thread Tom de Vries
On 21-07-14 09:31, Uros Bizjak wrote: On Sun, Jul 20, 2014 at 12:25 PM, Tom de Vries wrote: this patch fixes the problems in test-case gcc.target/i386/fuse-caller-save-xmm.c reported in PR 61827. I've removed the checks for cfi_def_cfa_offset, which were not robust enough for the different con

Re: [GSoC] generation of Gimple code from isl_ast_node_user

2014-07-21 Thread Roman Gareev
I've asked the community about this. The patch below contains the FIXME. -- Cheers, Roman Gareev. 2014-07-12 Roman Gareev gcc/ * graphite-isl-ast-to-gimple.c: Add inclusion of gimple-ssa.h, tree-into-ssa.h. (ivs_params_clear):

Fwd: [PATCH 3/3]Improve induction variable elimination

2014-07-21 Thread Bin.Cheng
Hi, forward to Zdenek for the review. Thanks, bin -- Forwarded message -- From: Bin Cheng Date: Thu, Jul 17, 2014 at 10:09 AM Subject: [PATCH 3/3]Improve induction variable elimination To: gcc-patches@gcc.gnu.org Hi, Function iv_elimination_compare_lt is used to eliminate ind

Fwd: [PATCH 3/3]Improve induction variable elimination

2014-07-21 Thread Bin.Cheng
Forward to Zdenek for the review. Thanks, bin -- Forwarded message -- From: Bin Cheng Date: Thu, Jul 17, 2014 at 10:09 AM Subject: [PATCH 3/3]Improve induction variable elimination To: gcc-patches@gcc.gnu.org Hi, Function iv_elimination_compare_lt is used to eliminate inducti

Fwd: [PATCH 1/3]Improve induction variable elimination

2014-07-21 Thread Bin.Cheng
Hi, forward to Zdenek for the review. Thanks, bin -- Forwarded message -- From: Bin Cheng Date: Thu, Jul 17, 2014 at 10:07 AM Subject: [PATCH 1/3]Improve induction variable elimination To: gcc-patches@gcc.gnu.org Hi, This is a series of three patches improving induction variab

Re: [PATH] Intel offload library

2014-07-21 Thread Andrey Turetskiy
Ping. On Wed, Jul 2, 2014 at 3:13 PM, Andrey Turetskiy wrote: >> * Don't duplicate the logic for what's a hosted POSIX system; refactor it >> to a common fragment in config/ (I guess it needs to be a shell script >> fragment there rather than an actual autoconf macro, since you're using >> that l

Re: [PATCH 2/2] allow running mklog as a filter

2014-07-21 Thread Trevor Saunders
On Mon, Jul 21, 2014 at 11:49:05AM +0400, Yury Gribov wrote: > On 05/09/2014 07:09 PM, Diego Novillo wrote: > > I slightly prefer the semantics that gets me just the ChangeLog. > > The workflow I'm envisioning is: > > I've commited both patches in r212883 and r12884. Mklog now runs as a filter > a

Re: [GSoC] generation of Gimple code from isl_ast_node_user

2014-07-21 Thread Tobias Grosser
On 21/07/2014 10:25, Roman Gareev wrote: Maybe we should temporary postpone this and add a FIXME that says: “We should remove iv_map.create (loop->num + 1), if it is possible.” What do you think about this? Fine with me. Please post a question on gcc devel to see if someone can explain us t

[PATCH, i386]: Fix PR 61855, _MM_MANTISSA_NORM_ENUM in avx512intrin.h disabled when optimization off

2014-07-21 Thread Uros Bizjak
Hello! 2014-07-21 Uros Bizjak PR target/61855 * config/i386/avx512fintrin.h: Move constants for mantissa extraction out of #ifdef __OPTIMIZE__. testsuite/ChangeLog: 2014-07-21 Uros Bizjak PR target/61855 * gcc.target/i386/pr61855.c: New test. Tested on x86_64-linux-g

[PATCH] Fix mklog to support running from arbitrary folder

2014-07-21 Thread Yury Gribov
Hi all, Current mklog works only if run from GCC top-level folder. The patch allows running from arbitrary directory. I've used Linux directory separators which is probably ok because script already expects Linux environment (dirname, basename, etc.). Ok to commit? -Y commit aa8d7cd3db1f1e

Re: [GSoC] generation of Gimple code from isl_ast_node_user

2014-07-21 Thread Roman Gareev
Maybe we should temporary postpone this and add a FIXME that says: “We should remove iv_map.create (loop->num + 1), if it is possible.” What do you think about this? -- Cheers, Roman Gareev.

Re: [PATCH 2/2] allow running mklog as a filter

2014-07-21 Thread Yury Gribov
On 05/09/2014 07:09 PM, Diego Novillo wrote: > I slightly prefer the semantics that gets me just the ChangeLog. > The workflow I'm envisioning is: I've commited both patches in r212883 and r12884. Mklog now runs as a filter and prints generated ChangeLog to stdout instead of modifying the patch

Re: [PATCH, i386, PR61827] Fix fuse-caller-save-xmm.c test-case

2014-07-21 Thread Uros Bizjak
On Sun, Jul 20, 2014 at 12:25 PM, Tom de Vries wrote: > this patch fixes the problems in test-case > gcc.target/i386/fuse-caller-save-xmm.c reported in PR 61827. I've removed > the checks for cfi_def_cfa_offset, which were not robust enough for the > different configurations. > > Furthermore, I'v