[PING][PATCH, ARM] Fix PR63718, Thumb1 bootstrap -- disable fuse-caller-save for Thumb1

2014-12-02 Thread Tom de Vries
On 20-11-14 12:54, Tom de Vries wrote: Richard, This patch fixes PR63718, which currently breaks Thumb1 bootstrap. The problem is that in Thumb1 mode, we emit the epilogue in RTL, but the last insn - epilogue_insns - does not accurately model the corresponding insns emitted in the asm file. F.i

Re: [PATCH] Fix PR64126

2014-12-02 Thread Richard Biener
On Mon, 1 Dec 2014, Marc Glisse wrote: > On Mon, 1 Dec 2014, Richard Biener wrote: > > > The following fixes PR64126. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > > > Richard. > > > > 2014-12-01 Richard Biener > > > > PR middle-end/64126 > > * match.pd:

Re: [PATCH] Fix PR64137

2014-12-02 Thread Richard Biener
On Mon, 1 Dec 2014, Richard Biener wrote: > On Mon, 1 Dec 2014, FX wrote: > > > Your change is OK (we don’t want to use the type of the result, but the > > type of the argument indeed). > > > > > > > Index: gcc/fortran/trans-intrinsic.c > > > ===

Re: [PATCH] Fix PR15346

2014-12-02 Thread Richard Biener
On Mon, 1 Dec 2014, Joseph Myers wrote: > On Mon, 1 Dec 2014, Richard Biener wrote: > > > +/* Combine two successive divisions. */ > > +(for div (trunc_div ceil_div floor_div round_div exact_div) > > This doesn't seem correct for all kinds of division and signedness of > arguments. > > TRUNC_

Re: [PATCH] Fix PR15346

2014-12-02 Thread Richard Biener
something like: > INT_MIN / 2 / (INT_MIN / -2) == -1 > where > 2 * (INT_MIN / -2) overflows? Hmm, right. It should work if overflow_p && mul != INT_MIN as far as I can see. I am testing the following. Thanks, Richard. 2014-12-02 Richard Biener * match.pd: When comb

Re: [PATCH] Adjust gimple_build_assign* gimple.texi documentation

2014-12-02 Thread Richard Biener
On Tue, 2 Dec 2014, Jakub Jelinek wrote: > Hi! > > Here is an attempt to adjust gimple_build_assign* documentation. > Ok for trunk? Ok. Thanks, Richard. > Note, apparently the documentation has not been adjusted for > the gimple -> gassign * etc. changes, David, can you please work on > adjust

[match-and-simplify] Merge from trunk

2014-12-02 Thread Richard Biener
2014-12-02 Richard Biener Merge from trunk r217561 through r218261.

[PATCH, alpha]: Fix PR 64113, Error: No lda !gpdisp!282 was found

2014-12-02 Thread Uros Bizjak
Hello! As mentioned in the PR, we need accurate gp live analysis to split __tls_get_addr call. Move split from post-reload splitter to peephole2 pass, as is the case with other call insns. 2014-12-02 Uros Bizjak PR target/64113 * config/alpha/alpha.md (call_value_osf_tlsgd): Do not sp

Re: [Patch] Improving jump-thread pass for PR 54742

2014-12-02 Thread Richard Biener
On Mon, Dec 1, 2014 at 10:06 PM, Jeff Law wrote: > On 11/25/14 14:16, Sebastian Pop wrote: >> >> Sebastian Pop wrote: >>> >>> >I will bootstrap and regression test this patch on x86_64-linux and >>> >powerpc64-linux. I will also run it on our internal benchmarks, >>> > coremark, and >>> >the llvm

Re: [testsuite] Fix multiple definitions of _init

2014-12-02 Thread Richard Biener
On Mon, Dec 1, 2014 at 11:48 PM, Oleg Endo wrote: > On Mon, 2014-12-01 at 12:09 +0100, Richard Biener wrote: >> On Mon, Dec 1, 2014 at 8:21 AM, Oleg Endo wrote: >> > Hi, >> > >> > When running the testsuite on a sh-elf configuration, some test cases >> > fail due to multiple definitions of the fu

[PATCH, REPOST] Fix PR fortran/60718

2014-12-02 Thread Bernd Edlinger
Hello Tobias, a long time ago, I posted this patch, but it got forgotten. However the described problem is still unsolved, so I thought my patch should be re-posted now. Boot-strapped and regression-tested on arm-linux-gnueabihf. OK for trunk? Thanks Bernd. On Tue, 15 Apr 2014 13:49:37, Ber

Re: PR 13631 Problems in messages

2014-12-02 Thread Jonathan Wakely
On 01/12/14 22:42 +0100, François Dumont wrote: Hi Here is another proposal that consider all your remarks except one. I finally prefer to go with std::vector of pointers. Dynamically allocating Catalog_info allow to avoid numerous copies of locale when we find this pointer from the catalo

Re: [testsuite] Fix multiple definitions of _init

2014-12-02 Thread Oleg Endo
On Tue, 2014-12-02 at 11:22 +0100, Richard Biener wrote: > On Mon, Dec 1, 2014 at 11:48 PM, Oleg Endo wrote: > > On Mon, 2014-12-01 at 12:09 +0100, Richard Biener wrote: > >> On Mon, Dec 1, 2014 at 8:21 AM, Oleg Endo wrote: > >> > Hi, > >> > > >> > When running the testsuite on a sh-elf configura

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-12-02 Thread Ilya Enkovich
On 05 Nov 11:00, Uros Bizjak wrote: > On Wed, Nov 5, 2014 at 10:35 AM, Ilya Enkovich wrote: > > Hi, > > > > Having stage1 close to end, may we make some decision regarding this > > patch? Having a couple of working variants, may we choose and use one > > of them? > > I propose to wait for Vlad fo

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-12-02 Thread Uros Bizjak
On Tue, Dec 2, 2014 at 12:08 PM, Ilya Enkovich wrote: >> > Having stage1 close to end, may we make some decision regarding this >> > patch? Having a couple of working variants, may we choose and use one >> > of them? >> >> I propose to wait for Vlad for an update about his plans on register >> pr

RE: [PATCH] Improve spillcost of literal pool loads

2014-12-02 Thread Wilco Dijkstra
> Jeff Law wrote: > OK with the appropropriate ChangeLog entires. THe original for > ira-costs.c was fine, so you just need the trivial one for the testcase. ChangeLog below - Jiong, could you commit for me please? 2014-12-02 Wilco Dijkstra * gcc/ira-costs.c (scan_one_insn): Improve

Re: [PATCH, ARM] Fix PR63718, Thumb1 bootstrap -- disable fuse-caller-save for Thumb1

2014-12-02 Thread Ramana Radhakrishnan
On 20/11/14 11:54, Tom de Vries wrote: Richard, This patch fixes PR63718, which currently breaks Thumb1 bootstrap. The problem is that in Thumb1 mode, we emit the epilogue in RTL, but the last insn - epilogue_insns - does not accurately model the corresponding insns emitted in the asm file. F

Re: [PATCH PR59593] [arm] Backport r217772 & r217826 to 4.8 & 4.9

2014-12-02 Thread Ramana Radhakrishnan
On 29/11/14 06:50, Chen Shanyao wrote: I've backported this fix to 4.8 & 4.9 branch. These patches have been tested for armeb-none-eabi-gcc/g++ with qemu, and both the test results were ok. The Changelog should mention all authors of the original patches i.e. include my name. Otherwise th

Re: [rtlanal.c][BE][1/2] Fix vector load/stores to not use ld1/st1

2014-12-02 Thread Alan Hayward
On 21/11/2014 14:08, "Alan Hayward" wrote: > >On 14/11/2014 16:48, "Alan Hayward" wrote: > >>This is a new version of my BE patch from a few weeks ago. >>This is part 1 and covers rtlanal.c. The second part will be aarch64 >>specific. >> >>When combined with the second patch, It fixes up movoi/

Re: [PATCH 1/2, PR 63814] Strengthen cgraph_edge_brings_value_p

2014-12-02 Thread H.J. Lu
On Fri, Nov 21, 2014 at 10:59 AM, Martin Jambor wrote: > Hi, > > PR 63814 is caused by cgraph_edge_brings_value_p misidentifying an > edge to an expanded artificial thunk as an edge to the original node, > which then leads to crazy double-cloning and doubling the thunks along > the call. > > This

[PATCH] rs6000: Fix PR target/64115

2014-12-02 Thread Ulrich Weigand
Hello, as discussed in the PR, this patch removes an invalid ENABLE_CHECKING sanity check in rs6000_delegitimize_address, fixing the ICE. Tested on powerpc64-linux. OK for mainline / 4.9 / 4.8? Bye, Ulrich ChangeLog: PR target/64115 * config/rs6000/rs6000.c (rs6000_delegitimi

Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-02 Thread Manuel López-Ibáñez
On 2 December 2014 at 07:50, Tobias Burnus wrote: > Hi Manuel, > > Manuel López-Ibáñez wrote: >> >> This patch actually does not touch linemap but I will appreciate >> Dodji's comments about the approach. The problem is that in case of >> long lines, the column hint of 120 might be too small, thus

Re: [PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-12-02 Thread Mark Wielaard
On Mon, 2014-12-01 at 14:31 -0700, Jeff Law wrote: > On 11/25/14 15:57, Mark Wielaard wrote: > > This implements the DWARFv5 noreturn proposal: > > http://dwarfstd.org/ShowIssue.php?issue=140331.1 > > > > TREE_THIS_VOLATILE on a FUNCTION_DECL node means the function does not > > return normally. Th

Re: PATCH: ICE: SIGSEGV in decide_alg() with -mmemset-strategy=libcall:-1:align -minline-all-stringops

2014-12-02 Thread Uros Bizjak
On Sat, Nov 29, 2014 at 3:00 PM, H.J. Lu wrote: > When searching for an usable algorithm with -minline-all-stringops, > decide_alg stops when it sees libcall even if there is a usable > algorithm. It goes into an infinite loop. This patch changes > decide_alg to stop searching only if there aren

[patch] Update libstdc++ status docs

2014-12-02 Thread Jonathan Wakely
Update the docs. Committed to trunk. commit 388d7943d85f505381f6e818d2de07978d022498 Author: Jonathan Wakely Date: Tue Dec 2 13:13:33 2014 + * doc/xml/manual/status_cxx2011.xml: Update. * doc/xml/manual/status_cxx2014.xml: Update. * doc/html/manual/status.html: Regenerate.

Re: [PATCH 2/3] Extended if-conversion

2014-12-02 Thread Richard Biener
On Mon, Dec 1, 2014 at 4:53 PM, Yuri Rumyantsev wrote: > Hi Richard, > > I resend you patch1 and patch2 with minor changes: > 1. I renamed flag_force_vectorize to aggressive_if_conv. > 2. Use static cast for the first argument of gimple_phi_arg_edge. > I also very sorry that I sent you bad patch.

Re: [PATCH linemap] Make some asserts fail gracefully

2014-12-02 Thread Dodji Seketeli
Manuel López-Ibáñez writes: > +/* Assert that becomes a conditional expression when not checking. For the sake of clarity towards newcomers, I'd say: Assert that becomes a conditional expression when checking is disabled at compilation time. > + Use this for conditions that should n

[PATCH, CHKP] Don't generate bndret for not instrumented calls

2014-12-02 Thread Ilya Enkovich
Hi, Currently bndret is generated each time we need to get bounds for returned pointer. It causes bndret generated for not instrumented calls incuding builtin function calls. Troubles appear when such builtin call is optimized out - bndret needs to be handled appropriately. Since we don't wa

[PATCH, CHKP] Don't try to optimize bounds returned by strchr

2014-12-02 Thread Ilya Enkovich
Hi, For strchr calls bounds of the first argument are considered as returned which is wrong because NULL may be returned. This patch fixes that. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2014-12-02 Ilya Enkovich * tree-chkp.c (chkp_build_r

Re: [PATCH] rs6000: Fix PR target/64115

2014-12-02 Thread David Edelsohn
On Tue, Dec 2, 2014 at 7:56 AM, Ulrich Weigand wrote: > Hello, > > as discussed in the PR, this patch removes an invalid ENABLE_CHECKING > sanity check in rs6000_delegitimize_address, fixing the ICE. > > Tested on powerpc64-linux. > > OK for mainline / 4.9 / 4.8? > > Bye, > Ulrich > > > ChangeLog:

Re: [PATCH] Improve spillcost of literal pool loads

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 3:34 AM, Wilco Dijkstra wrote: >> Jeff Law wrote: >> OK with the appropropriate ChangeLog entires. THe original for >> ira-costs.c was fine, so you just need the trivial one for the testcase. > > ChangeLog below - Jiong, could you commit for me please? > > 2014-12-02 Wilco

[PATCH, CHKP] Keep instrumentation references consistency when merging cgraph nodes

2014-12-02 Thread Ilya Enkovich
Hi, Currently cgraph nodes merge may break instrumented_version references. It depends on order nodes are read and merged and therefore problem is not nicely reproducible. I couldn't make a small reproducer. This patch fixes problem and 253.perlbmk benchmark build with '-O3 -flto -fcheck-poi

Re: [PATCH] Improve spillcost of literal pool loads

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 5:51 AM, H.J. Lu wrote: > On Tue, Dec 2, 2014 at 3:34 AM, Wilco Dijkstra wrote: >>> Jeff Law wrote: >>> OK with the appropropriate ChangeLog entires. THe original for >>> ira-costs.c was fine, so you just need the trivial one for the testcase. >> >> ChangeLog below - Jiong

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2014-12-02 Thread Kyrill Tkachov
On 23/09/14 09:27, James Greenhalgh wrote: On Mon, Sep 15, 2014 at 11:56:03AM +0100, Andrew Stubbs wrote: On 15/09/14 10:46, Richard Earnshaw wrote: Hmm, I wonder if arm_override_options should reject neon + (arch < 7). Is this more to your taste? Is this really such a good idea? It causes c

Re: PATCH: ICE: SIGSEGV in decide_alg() with -mmemset-strategy=libcall:-1:align -minline-all-stringops

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 5:25 AM, Uros Bizjak wrote: > On Sat, Nov 29, 2014 at 3:00 PM, H.J. Lu wrote: >> When searching for an usable algorithm with -minline-all-stringops, >> decide_alg stops when it sees libcall even if there is a usable >> algorithm. It goes into an infinite loop. This patch

Re: PATCH: ICE: SIGSEGV in decide_alg() with -mmemset-strategy=libcall:-1:align -minline-all-stringops

2014-12-02 Thread Uros Bizjak
On Tue, Dec 2, 2014 at 3:03 PM, H.J. Lu wrote: > On Tue, Dec 2, 2014 at 5:25 AM, Uros Bizjak wrote: >> On Sat, Nov 29, 2014 at 3:00 PM, H.J. Lu wrote: >>> When searching for an usable algorithm with -minline-all-stringops, >>> decide_alg stops when it sees libcall even if there is a usable >>> a

Re: PATCH: ICE: SIGSEGV in decide_alg() with -mmemset-strategy=libcall:-1:align -minline-all-stringops

2014-12-02 Thread H.J. Lu
2-02 Tom de Vries PR rtl-optimization/63718 diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 3397167..211c9e6 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -24464,7 +24464,8 @@ decide_alg (HOST_WIDE_INT count, HOST_WIDE_INT expected_size, *noalign

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-12-02 Thread Marek Polacek
On Fri, Nov 28, 2014 at 09:28:03AM -0500, Jason Merrill wrote: > I was thinking even more detailed: one diagnostic for negative count, one > diagnostic for count larger than the precision of the lhs, and then a third > for overflow. Alright, done. > >+ /* For signed x << y the following: >

Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-02 Thread Dodji Seketeli
Hello Manuel, Tobias, Manuel López-Ibáñez writes: > This patch actually does not touch linemap but I will appreciate > Dodji's comments about the approach. Thanks :-) > The problem is that in case of long lines, the column hint of 120 > might be too small, thus we do not have enough locations

[PATCH, CHKP] Fix instrumentation clones privatization

2014-12-02 Thread Ilya Enkovich
Hi, Currently symbol names privatization doesn't work for instrumentation clones because clones assembler name is transparent alias and therefore alias target should be privatized instead. This patch does it. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya --

[PATCH][1/n] Fix PR14541

2014-12-02 Thread Richard Biener
This is a (tiny) piece of fixing PR14541 which basically complains that most math function simplification doesn't happen on GIMPLE. This is of course because nobody re-builds the nested GENERIC call expressions that would be necessary to trigger the various simplifications implemneted in builtins.

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-12-02 Thread Jason Merrill
On 12/02/2014 09:14 AM, Marek Polacek wrote: On Fri, Nov 28, 2014 at 09:28:03AM -0500, Jason Merrill wrote: I was thinking even more detailed: one diagnostic for negative count, one diagnostic for count larger than the precision of the lhs, and then a third for overflow. Alright, done. Thank

Re: [PATCH 2/3] Extended if-conversion

2014-12-02 Thread Yuri Rumyantsev
Thanks Richard for your quick reply! 1. I agree that we can combine predicate_extended_ and predicate_arbitrary_ to one function as you proposed. 2. What is your opinion about using more simple decision about insertion point - if bb has use of phi result insert phi predication before it and at the

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-12-02 Thread Marek Polacek
On Tue, Dec 02, 2014 at 09:59:26AM -0500, Jason Merrill wrote: > Thanks. These errors also need to be conditional on (!ctx->quiet), and if > we see one of these conditions we need to set *non_constant_p. Ah, sorry. Fixed in the following. Regtested on ppc64-linux, bootstrap in progress. 2014-1

[patch, 4.9] backport parallel header changes to the 4.9 branch

2014-12-02 Thread Matthias Klose
Backport these header changes to the 4.9 branch. No regression, but reported to the Debian BTS. Safe to backport according to Jonathan Wakely. No regressions in the testsuite on x86_64-linux-gnu. Ok for the branch? libstdc++-v3/ 2014-12-02 Matthias Klose PR libstdc++/64103

Re: [patch, 4.9] backport parallel header changes to the 4.9 branch

2014-12-02 Thread Jonathan Wakely
On 02/12/14 16:24 +, Jonathan Wakely wrote: On 02/12/14 17:20 +0100, Matthias Klose wrote: Backport these header changes to the 4.9 branch. No regression, but reported to the Debian BTS. Safe to backport according to Jonathan Wakely. No regressions in the testsuite on x86_64-linux-gnu. Ok

[PATCH][wwwdocs] Add note about removal of -mwords-little-endian option to changes.html for GCC 5

2014-12-02 Thread Kyrill Tkachov
Hi all, Back in July this deprecated option was removed. This patch adds a note to changes.html for that. Looked at the result in firefox, looked ok to me. Ok to commit? Thanks, Kyrill Index: htdocs/gcc-5/changes.html === RCS file

Re: [patch, 4.9] backport parallel header changes to the 4.9 branch

2014-12-02 Thread Jonathan Wakely
On 02/12/14 17:20 +0100, Matthias Klose wrote: Backport these header changes to the 4.9 branch. No regression, but reported to the Debian BTS. Safe to backport according to Jonathan Wakely. No regressions in the testsuite on x86_64-linux-gnu. Ok for the branch? You might as well include the

Re: [PATCH 08/08] PR/64003 workaround (uninit memory in i386.md)

2014-12-02 Thread David Malcolm
On Wed, 2014-11-26 at 10:41 -0700, Jeff Law wrote: > On 11/25/14 18:39, David Malcolm wrote: > > I suspect this is papering over a real problem, but I've been > > applying this workaround locally to keep my valgrind output clean. > > > > gcc/ChangeLog: > > PR/64003 > > * final.c (shorten_br

[PING] [PATCH][AARCH64]Use selected cpu's tuning when no tuning parameter is specified.

2014-12-02 Thread Renlin Li
On 27/11/14 11:27, Renlin Li wrote: Hi all, We have the following code in aarch64_override_options() function. /* The selected cpu may be an architecture, so lookup tuning by core ID. */ if (!selected_tune) selected_tune = &all_cores[selected_cpu->core]; However, the logic here is n

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-12-02 Thread Jason Merrill
OK, thanks. Jason

[PATCH, testsuite, i386]: Add some missing defines to AVX512 testcases

2014-12-02 Thread Uros Bizjak
Hello! 2014-12-02 Uros Bizjak * gcc.target/i386/avx512ifma-vpmaddhuq-2.c: Define AVX512IFMA. * gcc.target/i386/avx512ifma-vpmaddluq-2.c: Ditto. * gcc.target/i386/avx512vbmi-vpermb-2.c: Define AVX512VBMI. * gcc.target/i386/avx512vbmi-vpermi2b-2.c: Ditto. * gcc.target/i386/av

[Patch]: Check __gthread_setspecific return

2014-12-02 Thread Ryan Mansfield
Hi, Underlying pthread_setspecific can return non-zero with ENOMEM or EINVAL. 2014-12-02 Ryan Mansfield * emutls.c (__emutls_get_address): Check __gthread_setspecific returns. OK? Regards, Ryan Mansfield Index: libgcc/emutls.c ===

[C++ Patch] PR 60978

2014-12-02 Thread Paolo Carlini
Hi, another simple issue: this one argues that the warning is overeager when anonymous enums are involved, which often are just used as named constants. Details: maybe write the conditional in a different way; maybe even use && instead of ||. Tested x86_64-linux. Thanks, Paolo.

asan: support for globals in kernel

2014-12-02 Thread Dmitry Vyukov
Hi, The following patch adds support for instrumentation of globals for Linux kernel (-fsanitize=kernel-address). Kernel only supports constructors with default priority, but the rest works fine. OK for trunk? https://codereview.appspot.com/176570043 Index: gcc/ChangeLog ==

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread Sriraman Tallam
Ping. On Mon, Nov 10, 2014 at 3:22 PM, Sriraman Tallam wrote: > Ping. > > On Mon, Oct 6, 2014 at 1:43 PM, Sriraman Tallam wrote: >> Ping. >> >> On Mon, Sep 29, 2014 at 10:57 AM, Sriraman Tallam >> wrote: >>> Ping. >>> >>> On Fri, Sep 19, 2014 at 2:11 PM, Sriraman Tallam >>> wrote: Hi Ri

Re: asan: support for globals in kernel

2014-12-02 Thread Jakub Jelinek
On Tue, Dec 02, 2014 at 09:56:36PM +0400, Dmitry Vyukov wrote: > --- gcc/ChangeLog (revision 218280) > +++ gcc/ChangeLog (working copy) > @@ -1,3 +1,8 @@ > +2014-12-02 Dmitry Vyukov > + > + * asan.c: (asan_finish_file): Use default priority for constructors > + in kernel mode. Seems your MUA is

Re: asan: support for globals in kernel

2014-12-02 Thread Dmitry Vyukov
On Tue, Dec 2, 2014 at 9:04 PM, Jakub Jelinek wrote: > On Tue, Dec 02, 2014 at 09:56:36PM +0400, Dmitry Vyukov wrote: >> --- gcc/ChangeLog (revision 218280) >> +++ gcc/ChangeLog (working copy) >> @@ -1,3 +1,8 @@ >> +2014-12-02 Dmitry Vyukov >> + >> + * asan.c: (asan_finish_file): Use default pr

[PING][PATCH V2] plugin event for C/C++ function definitions

2014-12-02 Thread Andres Tiraboschi
Hi, this patch adds a new plugin event PLUGIN_START_PARSE_FUNCTION and PLUGIN_FINISH_PARSE_FUNCTION that are invoked at start_function and finish_function respectively in the C and C++ frontends. PLUGIN_START_PARSE_FUNCTION is called before parsing the function body. PLUGIN_FINISH_PARSE_FUNCTION

Re: asan: support for globals in kernel

2014-12-02 Thread Jakub Jelinek
On Tue, Dec 02, 2014 at 10:12:30PM +0400, Dmitry Vyukov wrote: > > Shall we backport it to 4.9 branch too? > > If it's doable, it would be nice. Thanks. Bet the same patch will just apply there. > When do we expect next 4.9 release? Probably in March/April timeframe or so, 4.9.2 has been releas

Re: [testsuite] Fix multiple definitions of _init

2014-12-02 Thread Mike Stump
On Nov 30, 2014, at 11:21 PM, Oleg Endo wrote: > When running the testsuite on a sh-elf configuration, some test cases > fail due to multiple definitions of the function '_init'. This is > because on sh-elf every function is automatically prefixed with a '_' > char. When defining a C function 'i

Re: asan: support for globals in kernel

2014-12-02 Thread Dmitry Vyukov
On Tue, Dec 2, 2014 at 9:17 PM, Jakub Jelinek wrote: > On Tue, Dec 02, 2014 at 10:12:30PM +0400, Dmitry Vyukov wrote: >> > Shall we backport it to 4.9 branch too? >> >> If it's doable, it would be nice. Thanks. > > Bet the same patch will just apply there. Do I need to do anything additional for

Re: [PATCH] Fix PR15346

2014-12-02 Thread Joseph Myers
On Tue, 2 Dec 2014, Richard Biener wrote: > > I'm not sure if these forms of division actually occur in places where > > this could cause a problem, but it does look like Ada may enable you to > > generate ROUND_DIV_EXPR. > > Hmm. I thought I was following what extract_muldiv_1 does (but of co

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread H.J. Lu
On Mon, Sep 8, 2014 at 3:19 PM, Sriraman Tallam wrote: > On Tue, Sep 2, 2014 at 1:40 PM, Richard Henderson wrote: >> On 06/20/2014 05:17 PM, Sriraman Tallam wrote: >>> Index: config/i386/i386.c >>> === >>> --- config/i386/i386.c

Re: [PATCH] Fix PR15346

2014-12-02 Thread Joseph Myers
On Tue, 2 Dec 2014, Joseph Myers wrote: > (y), 1)) is not the right condition for rounding away). The following Ada > testcase test_round_div.adb will generate a ROUND_DIV_EXPR which is I should add that I'm not sure if Ada requires correct rounding for fixed-point division converted to integ

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread Uros Bizjak
Hello! > Ping. >> Ping. >>> Ping. Ping. It would probably help reviewers if you pointed to actual path submission [1], which unfortunately contains the explanation in the patch itself [2], which further explains that this functionality is currently only supported with gold, patched with [3].

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 11:19 AM, Uros Bizjak wrote: > Hello! > >> Ping. >>> Ping. Ping. > Ping. > > It would probably help reviewers if you pointed to actual path > submission [1], which unfortunately contains the explanation in the > patch itself [2], which further explains that this fun

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 11:19 AM, Uros Bizjak wrote: > Hello! > >> Ping. >>> Ping. Ping. > Ping. > > It would probably help reviewers if you pointed to actual path > submission [1], which unfortunately contains the explanation in the > patch itself [2], which further explains that this fun

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread Uros Bizjak
On Tue, Dec 2, 2014 at 8:40 PM, H.J. Lu wrote: > On Tue, Dec 2, 2014 at 11:19 AM, Uros Bizjak wrote: >> Hello! >> >>> Ping. Ping. > Ping. >> Ping. >> >> It would probably help reviewers if you pointed to actual path >> submission [1], which unfortunately contains the explanation in t

Re: [PATCH] Make IPA-CP propagate alignment information of pointers

2014-12-02 Thread Martin Jambor
Hi, thanks for the comments. On Mon, Dec 01, 2014 at 11:40:59PM +0100, Jan Hubicka wrote: > > > 2014-11-19 Martin Jambor > > > > > > * ipa-prop.h (ipa_alignment): New type. > > > (ipa_jump_func): New field alignment. > > > (ipcp_transformation_summary) New type. > > > (ipcp_grow_trans

Re: [PATCH 5/6] combine: handle REG_UNUSED in reg_dead_at_p (PR59278)

2014-12-02 Thread Jeff Law
On 12/01/14 16:30, Oleg Endo wrote: On Mon, 2014-12-01 at 10:38 -0700, Jeff Law wrote: On 11/27/14 18:44, Segher Boessenkool wrote: Currently reg_dead_at_p returns 0 for registers that are set but never used. This patch repairs that oversight. This fixes PR59278. 2014-11-27 Segher Boessenk

Re: [Patch] Improving jump-thread pass for PR 54742

2014-12-02 Thread Jeff Law
On 12/02/14 03:15, Richard Biener wrote: I'm a bit worried about compile-time impacts of the all the recursion, but I'm willing to wait and see if it turns out to be a problem in practice. Please consider restricting it to -fexpensive-optimizations (-O2+). Yea, let's go ahead and do that. je

[PATCH] Update docs to reflect use of gimple subclasses

2014-12-02 Thread David Malcolm
On Tue, 2014-12-02 at 08:49 +0100, Jakub Jelinek wrote: Hi! > > Here is an attempt to adjust gimple_build_assign* documentation. > Ok for trunk? > > Note, apparently the documentation has not been adjusted for > the gimple -> gassign * etc. changes, David, can you please work on > adjusting gimpl

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread Jakub Jelinek
On Tue, Dec 02, 2014 at 12:16:09PM -0800, H.J. Lu wrote: > > IMO, nobody will use this highly special x86_64-only option. It would > > be best for gnu-ld to reach feature parity with gold as far as this > > functionality is concerned. In this case, the optimization would be > > auto-configured, and

Re: [PATCH 2/2, PR 63814] Do not re-create expanded artificial thunks

2014-12-02 Thread Martin Jambor
Hi, On Mon, Dec 01, 2014 at 10:43:19PM +0100, Jan Hubicka wrote: > > On Fri, Nov 21, 2014 at 08:18:12PM +0100, Martin Jambor wrote: > > > Hi, > > > > > > when debugging PR 63814 I noticed that when cgraph_node::create_clone > > > was using redirect_edge_duplicating_thunks to redirect two edges to

[PATCH, PR 64153] Check type sizes before V_C_Eing in evaluate_conditions_for_known_args

2014-12-02 Thread Martin Jambor
Hi, apparently it is necessary to check that type sizes match before attempting to fold-V_C_E them in evaluate_conditions_for_known_args. So this patch does this. It passes bootstrap and testing on x86_64-linux and I have verified with a cross compiler that the reported bug is fixed (the generate

Re: [PATCH 08/08] PR/64003 workaround (uninit memory in i386.md)

2014-12-02 Thread Jeff Law
On 12/02/14 09:20, David Malcolm wrote: In short, I believe the problem occurs with a "*jcc_1" insn that jumps forwards, but the full details are in the bug. My first thought is that something must be creating a new insn after shorten_branches is complete or an existing insn that was not on the

Re: attribute handler oddness in MEP and STORMY16 ports

2014-12-02 Thread DJ Delorie
My memories of why I did MeP the way I did are... vague. I recall it had to do with getting the attributes to apply to C++ objects correctly, since C++ objects tend to be "complicated" and gcc didn't always pass me what I expected. > think they are suppose to. They build, but I cant test them.

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 12:01 PM, Uros Bizjak wrote: > On Tue, Dec 2, 2014 at 8:40 PM, H.J. Lu wrote: >> On Tue, Dec 2, 2014 at 11:19 AM, Uros Bizjak wrote: >>> Hello! >>> Ping. > Ping. >> Ping. >>> Ping. >>> >>> It would probably help reviewers if you pointed to actual path >>>

Re: [PATCH, PR 64153] Check type sizes before V_C_Eing in evaluate_conditions_for_known_args

2014-12-02 Thread Jan Hubicka
> Hi, > > apparently it is necessary to check that type sizes match before > attempting to fold-V_C_E them in evaluate_conditions_for_known_args. > So this patch does this. > > It passes bootstrap and testing on x86_64-linux and I have verified > with a cross compiler that the reported bug is fix

[PATCH] fix PR testsuite/64145

2014-12-02 Thread Jack Howarth
The attached patch fixes the regression in the gcc/testsuite/gcc.dg/graphite/isl-codegen-loop-dumping.c testcase caused by the accidental removal of -fgraphite-identity from dg-options at r217315. Okay for gcc trunk? Jack 2014-12-01 Jack Howarth PR tests

Fwd: [PATCH] fix PR testsuite/64145

2014-12-02 Thread Roman Gareev
Looks good to me. Thank you. 2014-12-03 2:09 GMT+05:00 Jack Howarth : > The attached patch fixes the regression in the > gcc/testsuite/gcc.dg/graphite/isl-codegen-loop-dumping.c testcase > caused by the accidental removal of -fgraphite-identity from > dg-options at r217315. Okay for gcc trunk

Re: [PATCH 08/08] PR/64003 workaround (uninit memory in i386.md)

2014-12-02 Thread Jeff Law
On 12/02/14 09:20, David Malcolm wrote: I've spent some time trying to track this down, and I've added detailed notes to the bug. In short, I believe the problem occurs with a "*jcc_1" insn that jumps forwards, but the full details are in the bug. My first thought is that something must be cr

Re: [PATCH][wwwdocs] Add note about removal of -mwords-little-endian option to changes.html for GCC 5

2014-12-02 Thread Gerald Pfeifer
On Tuesday 2014-12-02 16:34, Kyrill Tkachov wrote: Back in July this deprecated option was removed. This patch adds a note to changes.html for that. Looked at the result in firefox, looked ok to me. Ok to commit? Yep. And I very comfortable for you to commit changes like this without asking

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2014-12-02 Thread Ramana Radhakrishnan
On Tue, Dec 2, 2014 at 2:01 PM, Kyrill Tkachov wrote: > > On 23/09/14 09:27, James Greenhalgh wrote: >> >> On Mon, Sep 15, 2014 at 11:56:03AM +0100, Andrew Stubbs wrote: >>> >>> On 15/09/14 10:46, Richard Earnshaw wrote: Hmm, I wonder if arm_override_options should reject neon + (arch <

Re: [PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-12-02 Thread Michael Eager
On 12/01/14 14:02, Cary Coutant wrote: [+cc Michael Eager] Rather than having to lobby to keep it unchanged because we jumped the gun, can we lobby to get the number assigned in the near future rather than in the potentially far future? That feels more cooperative to me :-) Would that make Mi

Re: [testsuite] Fix multiple definitions of _init

2014-12-02 Thread Joseph Myers
On Tue, 2 Dec 2014, Richard Biener wrote: > Joseph may have more experience with how targets should setup > USER_LABEL_PREFIX to avoid this situation. See e.g. config/arm/lib1funcs.S: #define SYM(x) CONCAT1 (__USER_LABEL_PREFIX__, x) (and the associated macro definition of CONCAT1 that uses, et

Re: [C++ Patch] PR 60978

2014-12-02 Thread Jason Merrill
See my comment on the PR; I think the testcase illustrates why we still want this warning for anonymous enums. Jason

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 12:19 PM, Jakub Jelinek wrote: > On Tue, Dec 02, 2014 at 12:16:09PM -0800, H.J. Lu wrote: >> > IMO, nobody will use this highly special x86_64-only option. It would >> > be best for gnu-ld to reach feature parity with gold as far as this >> > functionality is concerned. In t

Re: [C++ Patch] PR 60978

2014-12-02 Thread Paolo Carlini
Hi, On 12/02/2014 11:01 PM, Jason Merrill wrote: See my comment on the PR; I think the testcase illustrates why we still want this warning for anonymous enums. Ok... Thus, barring further discussion, I will simply close the Bug as invalid. Thanks! Paolo.

Re: [PATCH 0/2, AArch64, v3] APM X-Gene 1 cost-table and pipeline model

2014-12-02 Thread Ramana Radhakrishnan
On Fri, Nov 21, 2014 at 6:44 PM, Philipp Tomsich wrote: > The following patch-series adds optimized support for the APM X-Gene 1 > by providing a cost-model and pipeline-model. The pipeline-model has a > few long reservation-chains, but looking at the stats for the generated > NDA shows that it's

Re: [PATCH 1/2] Core definition for APM XGene-1 and associated cost-table.

2014-12-02 Thread Ramana Radhakrishnan
On Fri, Nov 21, 2014 at 6:44 PM, Philipp Tomsich wrote: > To keep this change separately buildable from the pipeline model, > this patch directs the APM XGene-1 to use the generic scheduling > model. > --- > gcc/ChangeLog| 8 +++ > gcc/config/aarch64/aarch64-cores.def |

Re: [PATCH 2/2] Pipeline model for APM XGene-1.

2014-12-02 Thread Ramana Radhakrishnan
On Fri, Nov 21, 2014 at 6:44 PM, Philipp Tomsich wrote: > --- > gcc/ChangeLog | 6 + > gcc/config/aarch64/aarch64.md | 3 +- > gcc/config/arm/xgene1.md | 532 > ++ > 3 files changed, 540 insertions(+), 1 deletion(-) > create mode

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes "GCC generates UNPREDICTABLE STR with Rn = Rt for arm"

2014-12-02 Thread Ramana Radhakrishnan
CCing release maintainers as well as they need to approve this backport if Vlad is happy with it. Vlad - is this ok to go back as it fixes a bug for ARM in the 4.9 tree that came up in building bits of debian. Ramana On Mon, Dec 1, 2014 at 5:24 PM, Renlin Li wrote: > On 01/12/14 15:58, H.J. Lu

[Patch, committed] contrib/download_prerequisites - download ISL 0.14

2014-12-02 Thread Tobias Burnus
Committed as Rev. 218294, now that ISL 0.14 is supported by GCC 5 and ISL 0.14 is in the infrastructure directory. Tobias Index: contrib/ChangeLog === --- contrib/ChangeLog (Revision 218293) +++ contrib/ChangeLog (Arbeitskopie) @@ -

Re: PR 13631 Problems in messages

2014-12-02 Thread François Dumont
So here is another proposal with all your remarks implemented. 2014-12-02 François Dumont DR libstdc++/13631 * include/bits/codecvt.h (codecvt): friend class std::messages. (codecvt): friend class std::messages. * config/locale/gnu/messages_member.h (messages::do_o

Re: [PATCH][ARM] Implement TARGET_SCHED_MACRO_FUSION_PAIR_P

2014-12-02 Thread Ramana Radhakrishnan
On Tue, Nov 11, 2014 at 11:55 AM, Kyrill Tkachov wrote: > Hi all, > > This is the arm implementation of the macro fusion hook. > It tries to fuse movw+movt operations together. It also tries to take lo_sum > RTXs into account since those generate movt instructions as well. > > Bootstrapped and tes

Re: [PATCH driver/diagnostics] init color earlier, add color to driver

2014-12-02 Thread Joseph Myers
On Tue, 2 Dec 2014, Manuel López-Ibáñez wrote: > 2014-12-02 Manuel López-Ibáñez > > * diagnostic.c (diagnostic_color_init): New. > * diagnostic.h: Declare. > * gcc.c (driver::global_initializations): Use it. > (driver_handle_option): Handle -fdiagnostics-color_. > * toplev.

[PATCH obvious/diagnostics] Honor override_column when printing the caret

2014-12-02 Thread Manuel López-Ibáñez
libcpp uses diagnostic->override_column to give a custom column number to diagnostics. This is taken into account when building the prefix, but it was missing when placing the caret. Before: /home/manuel/override_column.c:1:4: warning: "/*" within comment [-Wcomment] /* /* */ ^ After: /home/m

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 2:14 PM, H.J. Lu wrote: > On Tue, Dec 2, 2014 at 12:19 PM, Jakub Jelinek wrote: >> On Tue, Dec 02, 2014 at 12:16:09PM -0800, H.J. Lu wrote: >>> > IMO, nobody will use this highly special x86_64-only option. It would >>> > be best for gnu-ld to reach feature parity with gold

  1   2   >