[PATCH, moxie] Fix CC_REG definition

2015-01-09 Thread Anthony Green
The moxie port had CC_REG referring to a real hard register ($r9) by mistake instead of the virtual CC register. This never resulted in incorrect code, but we would often see $r9 marked as used in a function when it actually wasn't. I'm checking this in. 2015-01-09 Anthony Green

[PATCH, moxie] Tabify assembly output

2015-01-09 Thread Anthony Green
I'm committing the following patch, which cleans up the assembly output by using tabs between opcodes and operands. Thanks, AG 2015-01-09 Anthony Green gr...@moxielogic.com * config/moxie/moxie.md: Tabify assembly output. Index: gcc/config/moxie/moxie.md

Re: [PATCH] IPA ICF: add comparison for target and optimization nodes

2015-01-09 Thread John David Anglin
On Fri, 09 Jan 2015, Kyrill Tkachov wrote: On 09/01/15 16:11, Christophe Lyon wrote: On 9 January 2015 at 11:26, Martin Liška mli...@suse.cz wrote: On 01/09/2015 06:21 AM, Jeff Law wrote: On 01/07/15 04:38, Martin Liška wrote: Hello. Following patch adds support for target and

Re: [PATCH 12/21] PR jit/63854: Add a valgrind suppresion file

2015-01-09 Thread Hans-Peter Nilsson
On Wed, 19 Nov 2014, David Malcolm wrote: On Wed, 2014-11-19 at 10:09 -0700, Jeff Law wrote: On 11/19/14 04:47, Richard Biener wrote: On Wed, Nov 19, 2014 at 11:46 AM, David Malcolm dmalc...@redhat.com wrote: Valgrind complains about uninitialized data within sparseset_bit_p.

libgo patch committed: Pass CGO_LDFLAGS to linker for cgo

2015-01-09 Thread Ian Lance Taylor
This patch from Peter Collingbourne backports a patch from the master repository to pass CGO_LDFLAGS to the linker when using cgo with gccgo. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r b0a83aacb539 libgo/go/cmd/go/build.go ---

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2015-01-09 Thread H.J. Lu
On Fri, Jan 9, 2015 at 12:12 PM, Magnus Granberg zo...@gentoo.org wrote: fredag 09 januari 2015 13.00.14 skrev Daniel Micay: On 09/01/15 12:49 PM, Joseph Myers wrote: On Fri, 9 Jan 2015, Daniel Micay wrote: --with-specs=%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|

Re: Housekeeping work in backends.html

2015-01-09 Thread Bernd Schmidt
On 01/07/2015 12:39 AM, Eric Botcazou wrote: Some ports are missing (lm32, moxie, nios2, nvptx, rl78, rx) so the relevant maintainers are CCed (see 6.3.9 Anatomy of a Target Back End in the doc). The page is directly browsable at https://gcc.gnu.org/backends.html For the moxie, nvptx, rl178

gotools patch committed: Fix for non-bootstrap case

2015-01-09 Thread Ian Lance Taylor
When not bootstrapping, the newly built Go compiler is not passed down to the Go tools as GOC. This patch changes the gotools Makefile to use GOC_FOR_TARGET for a native build. I also set MOSTLYCLEANFILES. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2015-01-09 Ian

Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-09 Thread pinskia
On Jan 9, 2015, at 4:20 AM, Matthew Fortune matthew.fort...@imgtec.com wrote: Robert Suchanek robert.sucha...@imgtec.com writes: gcc/ * simplify-rtx.c (simplify_replace_fn_rtx): Simplify (lo_sum (high x) (const (plus x offset))) to (const (plus x offset)). The fix appears

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Richard Biener
On January 9, 2015 4:10:44 PM CET, Bernd Edlinger bernd.edlin...@hotmail.de wrote: On Fri, 9 Jan 2015 14:04:27, Richard Biener wrote: FYI: the VIEW_CONVERT_EXPR did not fail in the gcc_checking_assert (is_gimple_addressable (base)) but much later, somewhere in tree-cfg.c it dropped out.

[PATCH, fortran] Add gfc_define_builtin_with_spec

2015-01-09 Thread Tom de Vries
Jakub, For the oacc kernels patch series I need a fortran builtin with fn spec attribute (as mentioned here: https://gcc.gnu.org/ml/gcc/2014-12/msg1.html ). Attached patch adds a function gfc_define_builtin_with_spec that allows me to define such a builtin. At this point there's no

Re: [PATCH] rs6000: Fix va_start handling for -m32 -mpowerpc64 ABI_V4

2015-01-09 Thread David Edelsohn
On Fri, Jan 9, 2015 at 5:52 AM, Segher Boessenkool seg...@kernel.crashing.org wrote: This fixes 88 testsuite FAILs. -mpowerpc64 does not change the ABI, but it does change the value of UNITS_PER_WORD. We could use POINTER_SIZE_UNITS instead of 4 here, but that does not seem quite right.

Re: [doc] fix documentation of -fvtable-verify and related options

2015-01-09 Thread Sandra Loosemore
On 01/08/2015 10:10 PM, Jeff Law wrote: On 01/08/15 15:08, Sandra Loosemore wrote: This patch cleans up the documentation of -fvtable-verify, -fvtv-debug, and -fvtv-counts. The substantive change is to correct the location of the debug log files per discussion here:

Re: [PATCH] rs6000: Fix recip tests for -m32 -mpowerpc64

2015-01-09 Thread David Edelsohn
On Fri, Jan 9, 2015 at 1:38 AM, Segher Boessenkool seg...@kernel.crashing.org wrote: This fixes gcc.target/powerpc/recip-[67].c with -m32 -mpowerpc64. Tested etc.; okay for mainline? Segher 2015-01-08 Segher Boessenkool seg...@kernel.crashing.org gcc/testsuite/ *

[PATCH] rs6000: Introducing rs6000_abi_word_mode

2015-01-09 Thread Segher Boessenkool
Some hooks return word_mode by default, which is incorrect for -m32 -mpowerpc64. This patch creates a new function rs6000_abi_word_mode to implement these hooks, and does so. This fixes 163 testuite FAILs. Tested as usual; okay for mainline? 2015-01-09 Segher Boessenkool

RE: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-09 Thread Bernd Edlinger
Hi, On Thu, 8 Jan 2015 22:27:26, Jakub Jelinek wrote: Any objections to approving it now? LGTM. Jakub would it be OK to apply this patch also to the 4.9 testsuite, except for c-c++-common/tsan/bitfield_race.c and g++.dg/tsan/aligned_vs_unaligned_race.C of course? Bernd.

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Bernd Edlinger
On Fri, 9 Jan 2015 14:04:27, Richard Biener wrote: FYI: the VIEW_CONVERT_EXPR did not fail in the gcc_checking_assert (is_gimple_addressable (base)) but much later, somewhere in tree-cfg.c it dropped out. How did it fail there? It doesn't look like VIEW_CONVERT_EXPR is forbidden. without

Re: [nvptx-tools, committed] Also install [...]/nvptx-none/bin/ar and [...]/nvptx-none/bin/ranlib.

2015-01-09 Thread Bernd Schmidt
On 12/23/2014 07:50 PM, Thomas Schwinge wrote: GCC needs this, if nvptx-none-ar and nvptx-none-ranlib aren't found in $PATH. I've pushed the three patches you sent to my github repository. Bernd

Re: [PATCH] IPA ICF: add comparison for target and optimization nodes

2015-01-09 Thread Christophe Lyon
On 9 January 2015 at 11:26, Martin Liška mli...@suse.cz wrote: On 01/09/2015 06:21 AM, Jeff Law wrote: On 01/07/15 04:38, Martin Liška wrote: Hello. Following patch adds support for target and optimization nodes comparison, which is based on Honza's newly added infrastructure. Apart

Re: Patch RFA: Support for building Go tools

2015-01-09 Thread Paolo Bonzini
On 09/01/2015 15:24, Ian Lance Taylor wrote: This should work automatically, the only difference is that you must omit $(LIBGODEP) from the dependencies. What will happen if there is no installed gccgo at the right version? Compilation fails. What should happen? Compilation fails. :)

Re: [PATCH] rs6000: Introducing rs6000_abi_word_mode

2015-01-09 Thread David Edelsohn
On Fri, Jan 9, 2015 at 10:26 AM, Segher Boessenkool seg...@kernel.crashing.org wrote: Some hooks return word_mode by default, which is incorrect for -m32 -mpowerpc64. This patch creates a new function rs6000_abi_word_mode to implement these hooks, and does so. This fixes 163 testuite FAILs.

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 04:32:47PM +0100, Bernd Edlinger wrote: Hi, On Thu, 8 Jan 2015 22:27:26, Jakub Jelinek wrote: Any objections to approving it now? LGTM. Jakub would it be OK to apply this patch also to the 4.9 testsuite, except for c-c++-common/tsan/bitfield_race.c and

Re: [PING^2] Fix gcc_assert in expand_omp_for_static_chunk

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 09:54:12AM +0100, Tom de Vries wrote: 0001-Fix-gcc_assert-in-expand_omp_for_static_chunk.patch 2014-11-12 Tom de Vriest...@codesourcery.com Two spaces before . * omp-low.c (expand_omp_for_static_chunk): Fix assert. Ok, thanks. gcc/omp-low.c | 2 +- 1

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Richard Biener
On Fri, 9 Jan 2015, Richard Biener wrote: On Fri, 9 Jan 2015, Jakub Jelinek wrote: Hi! The following testcase is miscompiled on s390x. The problem is that there is massive cross-jumping going on, and after that post_order_compute decides to call tidy_fallthru_edges, including on an

Re: [PATCH] IPA ICF: refactoring + fix for PR ipa/63569

2015-01-09 Thread Richard Biener
On Mon, Jan 5, 2015 at 2:12 PM, Martin Liška mli...@suse.cz wrote: On 12/19/2014 12:04 PM, Richard Biener wrote: On Thu, Dec 18, 2014 at 6:38 PM, Martin Liška mli...@suse.cz wrote: On 12/17/2014 04:23 PM, Richard Biener wrote: On Wed, Dec 17, 2014 at 12:17 PM, Martin Liška mli...@suse.cz

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 10:36:09AM +0100, Richard Biener wrote: I wonder why post_order_compute calls tidy_fallthru_edges at all - won't that break the just computed postorder? Dunno, but I think it shouldn't break anything, the function doesn't remove any blocks, just in the typical case of an

Re: [x86, PATCH] operand reordering for commutative operations

2015-01-09 Thread Richard Biener
On Mon, Jan 5, 2015 at 9:26 PM, Jeff Law l...@redhat.com wrote: On 12/29/14 06:30, Yuri Rumyantsev wrote: Hi All, Here is a patch which fixed several performance degradation after operand canonicalization (r216728). Very simple approach is used - if operation is commutative and its second

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Bernd Edlinger
Hi, On Fri, 9 Jan 2015 10:57:14, Richard Biener wrote: On Mon, Jan 5, 2015 at 9:00 PM, Jeff Law l...@redhat.com wrote: On 01/03/15 06:49, Bernd Edlinger wrote: Hi, I was experimenting with enabling TSAN for Ada recently. I think this gives rather interesting results. The Instrumentation

Re: Patch RFA: Support for building Go tools

2015-01-09 Thread Paolo Bonzini
On 08/01/2015 22:35, Ian Lance Taylor wrote: +if NATIVE + +# For a native build we build the programs using the newly built libgo +# and install them as regular programs. + +bin_PROGRAMS = go$(EXEEXT) gofmt$(EXEEXT) +libexecsub_PROGRAMS = cgo$(EXEEXT) + +go$(EXEEXT):

[PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Michael Collison
This patch flattens tree.h and tree-core.h. This is a revised patch that does not include tree-core.h as a result of flattening. Version 3 of the patch adds the header files removed from tree-core.h to gcc-plugin.h in order to allow ggc-common.c to compile. This is a recent issue seen on

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Richard Biener
On Mon, Jan 5, 2015 at 9:00 PM, Jeff Law l...@redhat.com wrote: On 01/03/15 06:49, Bernd Edlinger wrote: Hi, I was experimenting with enabling TSAN for Ada recently. I think this gives rather interesting results. The Instrumentation worked almost out of the box, we just have the problem

Re: [PATCH] testsuite/lib/target-supports.exp: Fix check_effective_target_lto

2015-01-09 Thread Thomas Schwinge
Hi! On Fri, 9 Jan 2015 03:40:29 +0300, Ilya Verbin iver...@gmail.com wrote: Currently check_effective_target_lto properly works only in gcc/testsuite/ dir, since it checks for ENABLE_LTO, which is defined in gcc/configure.ac. But it doesn't work in other subdirectories, e.g. in

Re: [PATCH] IPA ICF: add comparison for target and optimization nodes

2015-01-09 Thread Martin Liška
On 01/09/2015 06:21 AM, Jeff Law wrote: On 01/07/15 04:38, Martin Liška wrote: Hello. Following patch adds support for target and optimization nodes comparison, which is based on Honza's newly added infrastructure. Apart from that, there's a small hunk that corrects formatting and removes

[PING^2] Fix gcc_assert in expand_omp_for_static_chunk

2015-01-09 Thread Tom de Vries
On 26-11-14 14:25, Tom de Vries wrote: On 12-11-14 11:00, Tom de Vries wrote: Jakub, this patch fixes a gcc_assert in expand_omp_for_static_chunk. The assert follows a loop with composite loop condition: ... vecedge_var_map *head = redirect_edge_var_map_vector (re); ene =

Re: [PATCH][ARM] FreeBSD arm support, EABI, v2

2015-01-09 Thread Richard Earnshaw
On 08/01/15 20:28, Andreas Tobler wrote: On 08.01.15 17:22, Richard Earnshaw wrote: On 27/11/14 20:56, Andreas Tobler wrote: Hi all, this is the second attempt. I reworked the issues Richard mentioned in the previous review. I also found one issue which will break build/bootstrap if I pass

[PATCH] cgraph_edge: small refactoring

2015-01-09 Thread Martin Liška
Hello. Following patch is motivated by seen utilization of cgraph_edge::redirect_callee in Chromium compiled with LTO. Thus, I decided to move the function to header file as well as few small functions it calls. Changes are just of mechanical nature. Patch has been tested on x86_64-linux-pc

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Richard Biener
On Fri, 9 Jan 2015, Jakub Jelinek wrote: Hi! The following testcase is miscompiled on s390x. The problem is that there is massive cross-jumping going on, and after that post_order_compute decides to call tidy_fallthru_edges, including on an edge from a bb ending with a table jump to a bb

Re: [patch libstdc++] Fix assignability check in uninitialized_copy

2015-01-09 Thread Eelis
On 2015-01-09 19:03, Jonathan Wakely wrote: The attached patch should be correct. Tested x86_64-linux, committed to trunk and 4.9. Awesome, thanks!

Re: [PATCH/expand] PR64011 Adjust bitsize when partial overflow happen for big-endian

2015-01-09 Thread Jiong Wang
2015-01-09 13:39 GMT+00:00 Jiong Wang jiong.w...@arm.com: the following code in store_bit_field_using_insv haven't consider above MEM-REG situation, it always assume bitnum + bitsize is within unit which is wrong. if (BITS_BIG_ENDIAN != BYTES_BIG_ENDIAN) bitnum = unit - bitsize -

Re: [PATCH] IPA ICF: add comparison for target and optimization nodes

2015-01-09 Thread Kyrill Tkachov
On 09/01/15 16:11, Christophe Lyon wrote: On 9 January 2015 at 11:26, Martin Liška mli...@suse.cz wrote: On 01/09/2015 06:21 AM, Jeff Law wrote: On 01/07/15 04:38, Martin Liška wrote: Hello. Following patch adds support for target and optimization nodes comparison, which is based on Honza's

Re: [PATCH] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2015-01-09 Thread Mike Stump
On Jan 8, 2015, at 9:35 PM, Jeff Law l...@redhat.com wrote: Do you want to be a reviewer for libobjc? I think things are fine as is. If things were pinged and there were no response, or if someone wanted to do major updated on the library to bring it up a decade, then we might want to change

Re: [PATCH] Handle CALL_INSN_FUNCTION_USAGE clobbers in regcprop.c

2015-01-09 Thread Tom de Vries
On 09-01-15 11:48, Jakub Jelinek wrote: On Fri, Jan 09, 2015 at 11:35:41AM +0100, Tom de Vries wrote: 2015-01-09 Tom de Vries t...@codesourcery.com PR rtl-optimization/64539 * regcprop.c (copyprop_hardreg_forward_1): Handle clobbers in CALL_INSN_FUNCTION_USAGE. To

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2015-01-09 Thread Joseph Myers
On Fri, 9 Jan 2015, Daniel Micay wrote: --with-specs=%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE -pie} at configure time (using CONFIGURE_SPECS). I have no idea if the above is really the proper spec to use -

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2015-01-09 Thread Daniel Micay
On 09/01/15 12:49 PM, Joseph Myers wrote: On Fri, 9 Jan 2015, Daniel Micay wrote: --with-specs=%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE -pie} at configure time (using CONFIGURE_SPECS). I have no idea if the above

[Patch, AArch64, Testsuite] Check for expected MOVI vectorization.

2015-01-09 Thread Tejas Belagod
Hi, This change: +2014-12-05 Martin Jambor mjam...@suse.cz + PR ipa/64192 ipa-prop.c (ipa_compute_jump_functions_for_edge): Convert alignment from bits to bytes after checking they are byte-aligned. + causes this regression on AArch64. FAIL: gcc.target/aarch64/vect-movi.c

[PATCH, committed] PR jit/64206: delay cleanup of tempdir if the user has requested debuginfo

2015-01-09 Thread David Malcolm
Committed to trunk as r219395. gcc/jit/ChangeLog: PR jit/64206 * docs/internals/test-hello-world.exe.log.txt: Update, the log now shows tempdir creation/cleanup. * docs/_build/texinfo/libgccjit.texi: Regenerate. * jit-logging.h (class gcc::jit::log_user):

Re: [PATCH] rs6000: Fix TARGET_PROMOTE_FUNCTION_MODE

2015-01-09 Thread David Edelsohn
On Thu, Jan 8, 2015 at 8:10 PM, Segher Boessenkool seg...@kernel.crashing.org wrote: As the existing comment explains, we should always promote function arguments and return values. However, notwithstanding its name, default_promote_function_mode_always_promote does not always promote.

Re: [PATCH, fortran] Add gfc_define_builtin_with_spec

2015-01-09 Thread FX
If unused on trunk, why would we commit it there? When your branch is merged, you'll merge it along. Otherwise that defeats the purpose of working on a branch, unless I misunderstand something... FX Le 9 janv. 2015 à 16:37, Tom de Vries tom_devr...@mentor.com a écrit : Jakub, For the

Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-09 Thread Jeff Law
On 01/09/15 04:32, Robert Suchanek wrote: Hi Steven/Vladimir, It's hard to say what the correct fix should be, but it sounds like the address you get after the substitutions should be simplified (folded). Coming back to the original testcase and re-analyzing the problem, it appears that

Re: [PATCH, fortran] Add gfc_define_builtin_with_spec

2015-01-09 Thread Tom de Vries
On 09-01-15 18:11, FX wrote: If unused on trunk, why would we commit it there? When your branch is merged, you'll merge it along. Otherwise that defeats the purpose of working on a branch, unless I misunderstand something... This patch is not branch-specific. Thanks, - Tom FX Le 9

Re: [PATCH] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2015-01-09 Thread Mike Stump
On Jan 8, 2015, at 9:38 PM, Andrew Pinski pins...@gmail.com wrote: 2014-12-24 Dimitris Papavasiliou dpapa...@gmail.com PR libobjc/51891 * libobjc/ivars.c: Add a check for classes without instance variables, which have a NULL ivar list pointer. *

[PATCH, committed] New jit API entrypoint: gcc_jit_context_new_rvalue_from_long

2015-01-09 Thread David Malcolm
Previously it was only possible to create integer constants via gcc_jit_context_new_rvalue_from_int [1], which takes a host int and a gcc_jit_type representing a target type Hence it wasn't possible to create e.g. the constant (long)LONG_MAX if int != long. (strictly speaking, one might be able

[PATCH, committed] Fix build of jit (was Re: [PATCH] Flatten tree.h and tree-core.h (Version 3))

2015-01-09 Thread David Malcolm
On Sat, 2015-01-10 at 01:50 +0530, Prathamesh Kulkarni wrote: On 9 January 2015 at 16:21, Richard Biener richard.guent...@gmail.com wrote: On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison michael.colli...@linaro.org wrote: This patch flattens tree.h and tree-core.h. This is a revised patch

Re: [Patch/combine] PR64304 wrong bitmask passed to force_to_mode in combine_simplify_rtx

2015-01-09 Thread Jiong Wang
2015-01-09 21:29 GMT+00:00 Andrew Pinski pins...@gmail.com: On Fri, Jan 9, 2015 at 12:40 PM, Jeff Law l...@redhat.com wrote: On 01/09/15 06:39, Jiong Wang wrote: as reported at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64304 given the following test: unsigned char byte = 0; void

[PATCH, committed] Simplify jit.dg/test-combination.c

2015-01-09 Thread David Malcolm
jit.dg/test-combination.c was spelling out all of the passing test cases, twice, when test-threads.c already had this as metadata. Move the metadata from test-threads.c into all-non-failing-tests.h, and use it from test-combination.c to avoid this repetition. Before/after test-combination.c both

Re: [patch libstdc++] Fix assignability check in uninitialized_copy

2015-01-09 Thread Jonathan Wakely
On 28/12/14 13:47 +0100, Eelis wrote: On 2014-12-28 00:18, Eelis wrote: Trivial fix attached. Please don't commit this patch. I just noticed that the assignability test is wrong in an additional way: it should look at assignability of /output/ elements, not /input/ elements. As a result,

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Prathamesh Kulkarni
On 9 January 2015 at 16:21, Richard Biener richard.guent...@gmail.com wrote: On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison michael.colli...@linaro.org wrote: This patch flattens tree.h and tree-core.h. This is a revised patch that does not include tree-core.h as a result of flattening.

Re: [Patch/combine] PR64304 wrong bitmask passed to force_to_mode in combine_simplify_rtx

2015-01-09 Thread Jeff Law
On 01/09/15 06:39, Jiong Wang wrote: as reported at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64304 given the following test: unsigned char byte = 0; void set_bit(unsigned int bit, unsigned char value) { unsigned char mask = (unsigned char)(1 (bit 7)); if (!value) {

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2015-01-09 Thread Magnus Granberg
fredag 09 januari 2015 13.00.14 skrev Daniel Micay: On 09/01/15 12:49 PM, Joseph Myers wrote: On Fri, 9 Jan 2015, Daniel Micay wrote: --with-specs=%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE| shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE -pie} at configure

[PATCH] fix visium build

2015-01-09 Thread Prathamesh Kulkarni
Hi, The tree.h and tree-core.h flattening patch: (https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00467.html broke visium build. The attached patch fixes that. Built on visium-elf. OK to commit ? Thank you, Prathamesh 2015-01-09 Prathamesh Kulkarni prathamesh.kulka...@linaro.org *

Re: Patch RFA: Support for building Go tools

2015-01-09 Thread Ian Lance Taylor
On Fri, Jan 9, 2015 at 7:40 AM, Paolo Bonzini bonz...@gnu.org wrote: On 09/01/2015 15:24, Ian Lance Taylor wrote: This should work automatically, the only difference is that you must omit $(LIBGODEP) from the dependencies. What will happen if there is no installed gccgo at the right

Re: Patch RFA: Support for building Go tools

2015-01-09 Thread Ian Lance Taylor
Committed initial gotools patch with following ChangeLog entries: ./: 2015-01-09 Ian Lance Taylor i...@google.com * configure.ac (host_tools): Add gotools. * Makefile.def (host_modules): Add gotools. (dependencies): Add dependency of all-gotools on all-target-libgo.

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Jakub Jelinek
On Sat, Jan 10, 2015 at 01:50:42AM +0530, Prathamesh Kulkarni wrote: I bootstrapped on x86 with all languages. I also bootstrapped on all targets listed in contrib/config-list.mk with c and c++ enabled. Is this okay for trunk? Ok. Committed as r219402 on behalf of Michael. Please

libgo patch commited: Adjust finding gccgo by cmd/go to match upstream

2015-01-09 Thread Ian Lance Taylor
This patch changes the way that cmd/go finds gccgo to match the upstream sources (which had changed since the 1.3 sources currently in libgo). Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 882d8b02b84b libgo/go/cmd/go/build.go ---

Re: [Patch/combine] PR64304 wrong bitmask passed to force_to_mode in combine_simplify_rtx

2015-01-09 Thread Andrew Pinski
On Fri, Jan 9, 2015 at 12:40 PM, Jeff Law l...@redhat.com wrote: On 01/09/15 06:39, Jiong Wang wrote: as reported at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64304 given the following test: unsigned char byte = 0; void set_bit(unsigned int bit, unsigned char value) { unsigned

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Prathamesh Kulkarni
On 10 January 2015 at 02:58, Jakub Jelinek ja...@redhat.com wrote: On Sat, Jan 10, 2015 at 01:50:42AM +0530, Prathamesh Kulkarni wrote: I bootstrapped on x86 with all languages. I also bootstrapped on all targets listed in contrib/config-list.mk with c and c++ enabled. Is this okay for

[PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Jakub Jelinek
Hi! The following testcase is miscompiled on s390x. The problem is that there is massive cross-jumping going on, and after that post_order_compute decides to call tidy_fallthru_edges, including on an edge from a bb ending with a table jump to a bb with now a single successor where all the

Re: nios2 builds still broken due to streamer changes

2015-01-09 Thread Martin Liška
On 12/19/2014 05:10 AM, Sandra Loosemore wrote: On 11/19/2014 09:34 PM, Jan Hubicka wrote: [snip] As for timeline, I have a workshop next week and need to prepare draft for it. So ideally I would like to work on this only after the workshop (ending November 28). I would be also happy to help

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Richard Biener
On Fri, 9 Jan 2015, Jakub Jelinek wrote: On Fri, Jan 09, 2015 at 10:36:09AM +0100, Richard Biener wrote: I wonder why post_order_compute calls tidy_fallthru_edges at all - won't that break the just computed postorder? Dunno, but I think it shouldn't break anything, the function doesn't

Re: [PATCH] IPA ICF: add comparison for target and optimization nodes

2015-01-09 Thread Martin Liška
On 01/07/2015 12:38 PM, Martin Liška wrote: Hello. Following patch adds support for target and optimization nodes comparison, which is based on Honza's newly added infrastructure. Apart from that, there's a small hunk that corrects formatting and removes unnecessary call to a comparison

[PATCH] Handle CALL_INSN_FUNCTION_USAGE clobbers in regcprop.c

2015-01-09 Thread Tom de Vries
Jakub, Attached patch handles CALL_INSN_FUNCTION_USAGE clobbers in copyprop_hardreg_forward_1. Terry reported a cprop_hardreg misbehaviour here ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64154#c2 ), in the context of trying out -fipa-ra for thumb1. The -fipa-ra flag is currently

Re: [PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2015-01-09 Thread Marcus Meissner
Hi, can this be added for GCC 5? It would be interesting for SUSE too. Ciao, Marcus On Mon, Nov 10, 2014 at 09:26:39PM +0100, Magnus Granberg wrote: fredag 01 augusti 2014 10.52.27 skrev Rainer Orth: Hi Magnus, a couple of comments, mostly nits. 2014-07-31 Magnus Granberg

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Richard Biener
On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison michael.colli...@linaro.org wrote: This patch flattens tree.h and tree-core.h. This is a revised patch that does not include tree-core.h as a result of flattening. Version 3 of the patch adds the header files removed from tree-core.h to

Re: LTO streaming of TARGET_OPTIMIZE_NODE

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 12:07:26PM +0100, Thomas Schwinge wrote: On Thu, 8 Jan 2015 15:11:49 +0100, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 20, 2014 at 01:27:08PM +0100, Bernd Schmidt wrote: On 11/13/2014 05:06 AM, Jan Hubicka wrote: this patch adds infrastructure for proper

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Bernd Edlinger
On Fri, 9 Jan 2015 12:04:26, Richard Biener wrote: There may be multiple VIEW_CONVERT_EXPRs in a reference chain so simply stripping the outermost only doesn't work (the assert). Hmm, that did not happen in any of the Ada tests in ada/acats nor in gnat.dg, but with Ada anything may be

RE: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-09 Thread Matthew Fortune
Robert Suchanek robert.sucha...@imgtec.com writes: gcc/ * simplify-rtx.c (simplify_replace_fn_rtx): Simplify (lo_sum (high x) (const (plus x offset))) to (const (plus x offset)). The fix appears valid to me. Just some comments on the test case.

Re: [PATCH 2/3] Extended if-conversion

2015-01-09 Thread Richard Biener
On Mon, Dec 22, 2014 at 3:39 PM, Yuri Rumyantsev ysrum...@gmail.com wrote: Richard, I changed algorithm for bool pattern repair. It turned out that ifcvt_local_dce phaase is required since for test-case I sent you in previous mail vectorization is not performed without dead code elimination:

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2015-01-09 Thread Daniel Micay
On 09/01/15 07:58 AM, Richard Biener wrote: Looking at the actual implementation I wonder why it's not similar to how darwin gets at it default (not sure how it does). Also looking at how DRIVER_SELF_SPECS is used I wonder if the functionality can be enabled with a simple

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Richard Biener
On Fri, 9 Jan 2015, Jakub Jelinek wrote: On Fri, Jan 09, 2015 at 11:59:44AM +0100, Richard Biener wrote: If you want, I can try instead of disabling it for tablejumps just move the label. Yeah, I'd prefer that - it can't be too difficult, no? So like this (tested just on the

Re: [PATCH 1/3] RTEMS: Use MULTILIB_REQUIRED for PowerPC

2015-01-09 Thread Sebastian Huber
Checked in as https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=219384 https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=219389 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail

Re: [PATCH 2/3] RTEMS: Fix MPC8540 multilibs for PowerPC

2015-01-09 Thread Sebastian Huber
Checked in as https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=219385 https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=219390 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail

Re: [PATCH 3/3] RTEMS: Add e6500 multilibs for PowerPC

2015-01-09 Thread Sebastian Huber
Checked in slightly modified as https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=219387 https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=219391 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89

Re: [PATCH][ARM] FreeBSD arm support, EABI, v2

2015-01-09 Thread Andreas Tobler
On 09.01.15 10:27, Richard Earnshaw wrote: On 08/01/15 20:28, Andreas Tobler wrote: On 08.01.15 17:22, Richard Earnshaw wrote: On 27/11/14 20:56, Andreas Tobler wrote: Hi all, this is the second attempt. I reworked the issues Richard mentioned in the previous review. I also found one issue

Re: Patch RFA: Support for building Go tools

2015-01-09 Thread Ian Lance Taylor
On Fri, Jan 9, 2015 at 12:54 AM, Paolo Bonzini bonz...@gnu.org wrote: + +# For a non-native build we have to build the programs using a +# previously built host (or build - host) Go compiler. We should +# only do this if such a compiler is available. Figure this out +# later. + +endif

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 03:10:16PM +0100, Richard Biener wrote: Well, you have until the end of next week ;) For GIMPLE this is a switch with all cases going to the same basic-block, right? I think we optimize that in cleanup_control_expr_graph via the single_succ_p case? No, it is a switch

Re: [PATCH/expand] PR64011 Adjust bitsize when partial overflow happen for big-endian

2015-01-09 Thread Jiong Wang
On 09/01/15 05:46, Jeff Law wrote: On 12/30/14 03:21, Jiong Wang wrote: PR64011 is actually a general problem on all target support bit insertion instructions. we overflow check at the start of store_bit_field_1, but that only check the situation where the field lies completely outside the

[Patch/combine] PR64304 wrong bitmask passed to force_to_mode in combine_simplify_rtx

2015-01-09 Thread Jiong Wang
as reported at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64304 given the following test: unsigned char byte = 0; void set_bit(unsigned int bit, unsigned char value) { unsigned char mask = (unsigned char)(1 (bit 7)); if (!value) { byte = (unsigned char)~mask; } else {

Re: [PATCH 1/2] RTEMS: Rename ARM target config files

2015-01-09 Thread Sebastian Huber
Checked in as https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=219382 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key

Re: [PATCH 2/2] RTEMS: Use MULTILIB_REQUIRED for ARM

2015-01-09 Thread Sebastian Huber
Checked in as https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=219383 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 11:59:44AM +0100, Richard Biener wrote: If you want, I can try instead of disabling it for tablejumps just move the label. Yeah, I'd prefer that - it can't be too difficult, no? So like this (tested just on the testcase, fully bootstrap/regtest will follow)?

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Bernd Edlinger
On Fri, 9 Jan 2015 13:30:45, Jakub Jelinke wrote: On Fri, Jan 09, 2015 at 01:12:09PM +0100, Bernd Edlinger wrote: should be equivalent to if (DECL_P (base) !may_be_aliased (base)) return false; is that right? Yes, well, not exactly, but I wonder if its worth doing the extra check if

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 01:12:09PM +0100, Bernd Edlinger wrote: should be equivalent to if (DECL_P (base) !may_be_aliased (base)) return false; is that right? Yes, well, not exactly, but I wonder if its worth doing the extra check if you only check decl accesses anyway and not

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2015-01-09 Thread Richard Biener
On Tue, Dec 30, 2014 at 10:23 PM, Magnus Granberg zo...@gentoo.org wrote: fredag 14 november 2014 23.31.48 skrev Magnus Granberg: måndag 10 november 2014 21.26.39 skrev Magnus Granberg: Rainer Thanks Rainer for the nits and comments. Have updated the patches and Changelogs. But i

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Richard Biener
On Fri, Jan 9, 2015 at 1:44 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: On Fri, 9 Jan 2015 13:30:45, Jakub Jelinke wrote: On Fri, Jan 09, 2015 at 01:12:09PM +0100, Bernd Edlinger wrote: should be equivalent to if (DECL_P (base) !may_be_aliased (base)) return false; is that

Re: [PATCH, fortran] PR fortran/60255 Deferred character length

2015-01-09 Thread Andre Vehreschild
Hi all, hi Paul, I started to implement the changes requested below, but I stumbled over an oddity: For a deferred length kind4 char array, the length of the string is stored without multiplication by 4 in the length variable attached. So when we now decide to store the length of the string in

[PATCH] rs6000: Fix va_start handling for -m32 -mpowerpc64 ABI_V4

2015-01-09 Thread Segher Boessenkool
This fixes 88 testsuite FAILs. -mpowerpc64 does not change the ABI, but it does change the value of UNITS_PER_WORD. We could use POINTER_SIZE_UNITS instead of 4 here, but that does not seem quite right. This code is for SVR4 only, so a literal 4 isn't so bad I think. Better suggestions welcome

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 11:15:14AM +0100, Richard Biener wrote: On Fri, 9 Jan 2015, Jakub Jelinek wrote: On Fri, Jan 09, 2015 at 10:36:09AM +0100, Richard Biener wrote: I wonder why post_order_compute calls tidy_fallthru_edges at all - won't that break the just computed postorder?

Re: LTO streaming of TARGET_OPTIMIZE_NODE

2015-01-09 Thread Thomas Schwinge
Hi! On Thu, 8 Jan 2015 15:11:49 +0100, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 20, 2014 at 01:27:08PM +0100, Bernd Schmidt wrote: On 11/13/2014 05:06 AM, Jan Hubicka wrote: this patch adds infrastructure for proper streaming and merging of TREE_TARGET_OPTION. This breaks the

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-09 Thread Richard Biener
On Fri, 9 Jan 2015, Jakub Jelinek wrote: On Fri, Jan 09, 2015 at 11:15:14AM +0100, Richard Biener wrote: On Fri, 9 Jan 2015, Jakub Jelinek wrote: On Fri, Jan 09, 2015 at 10:36:09AM +0100, Richard Biener wrote: I wonder why post_order_compute calls tidy_fallthru_edges at all - won't

[PATCH] Fix PR64410, complex vectorization issue

2015-01-09 Thread Richard Biener
This fixes the specific case of complex arithmetic vectorization in the PR which is caused by loads/stores of complex types which the vectorizer does not like. The patch implements two things, first a late variant of gimplify_modify_expr_complex_part in update-address-taken when we can write the

  1   2   >