Re: pr64252.c: fix sizeof(int) assumption

2015-06-05 Thread DJ Delorie
Sorry, I meant unsigned int.

Re: pr64252.c: fix sizeof(int) assumption

2015-06-05 Thread Marc Glisse
On Sat, 6 Jun 2015, DJ Delorie wrote: On targets with 2 byte "int" the vectors are 16 values long, which breaks the index count in __builtin_shuffle() using more than one input vector. Ok? * gcc.dg/pr64252.c: Fix assumption about sizeof(int). 2015-06-05 Thomas Koenig Index: gcc.dg/

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-06-05 Thread Mikhail Maltsev
09.05.2015 1:54, Jeff Law wrote: > On 05/04/2015 02:18 PM, Mikhail Maltsev wrote: [snip] >> I'm trying to continue and the next patch (peep_split.patch, >> peep_split.cl) is addressing the same task in some of the generated code >> (namely, gen_peephole2_* and gen_split_* series of functions). > An

[msp430] support sym+int and sym-sym

2015-06-05 Thread DJ Delorie
Because sizeof(void*) is 4 but POINTER_SIZE is 3, we have to handle some things manually. This is yet another one. Committed. * config/msp430/msp430.c (msp430_asm_integer): Support addition and subtraction too. Index: config/msp430/msp430.c =

pr64252.c: fix sizeof(int) assumption

2015-06-05 Thread DJ Delorie
On targets with 2 byte "int" the vectors are 16 values long, which breaks the index count in __builtin_shuffle() using more than one input vector. Ok? * gcc.dg/pr64252.c: Fix assumption about sizeof(int). 2015-06-05 Thomas Koenig Index: gcc.dg/pr64252.c =

Re: [PR64164] drop copyrename, integrate into expand

2015-06-05 Thread Alexandre Oliva
On Apr 27, 2015, Richard Biener wrote: > This should also mention that is_gimple_reg vars do not have their > address taken. check >> +static tree >> +leader_merge (tree cur, tree next) > Ick - presumably you can't use sth better than a TREE_LIST here? The list was an experiment that never re

Re: [PATCH] PR fortran/66245 -- Check [derived] type spec

2015-06-05 Thread Jerry DeLisle
On 06/05/2015 04:55 PM, Steve Kargl wrote: > The attached patch checks that TYPE IS and CLASS IS > return a type spec or a derived type spec. Regression > tested without any new failures. OK to commit? > OK, thanks, Jerry

[PATCH] PR fortran/66245 -- Check [derived] type spec

2015-06-05 Thread Steve Kargl
The attached patch checks that TYPE IS and CLASS IS return a type spec or a derived type spec. Regression tested without any new failures. OK to commit? 2015-06-05 Steven G. Kargl * match.c (gfc_match_type_is, gfc_match_class_is): Check if the return type spec or derived ty

[patch committed SH] Fix PR target/66410

2015-06-05 Thread Kaz Kojima
The attached patch is to fix PR target/66410 which is an ICE in lra-assigns.c:assign_by_spills with -mlra. The insn *mov[qh]i has Snd/r alternative which is problematic when Snd is memory with index addressing and r is reloading with r0 because only r0 can become the index register on this target.

[PATCH, committed] PR fortran/66347

2015-06-05 Thread Steve Kargl
I've committed the following under and "obviously correct" after regression testing completed without any new failures. 2015-06-05 Steven G. Kargl PR fortran/66347 * resolve.c (apply_default_init_local): Do not dereference a NULL pointer. 2015-06-05 Steven G. Kargl

[s390] Revert TPF C++ library changes

2015-06-05 Thread DJ Delorie
IBM made changes to no longer require 2 versions of libstdc++, so this patch changes things back to the previous (compatible) way. Also, TPF debuggers don't support discriminators, despite what GAS supports, so disable them. Ok? * config/s390/tpf.h (LIBSTDCXX): Change to CPP1. (

Re: Add tree heterogeneous lookup in alternative modes

2015-06-05 Thread Jonathan Wakely
On 05/06/15 23:00 +0200, François Dumont wrote: On 04/06/2015 14:41, Jonathan Wakely wrote: On 03/06/15 21:56 +0200, François Dumont wrote: Hi Here is a patch to add heterogeneous lookup to alternative modes. Excellent. To do so I had to expose __is_transparent as __has_is_transparent t

[patch, testsuite] Remove -fopenmp in dg-options in libgomp.c

2015-06-05 Thread Tom de Vries
Hi, this patch removes superfluous -fopenmp settings. In the case of target-8.c, we remove the whole dg-options line which did not have an -On setting, which means the optimization level at which the testcase compiles is changed from -O0 to the default -O2. Tested with a c build. OK for tru

[patch, testsuite] Remove superfluous -std={c99,gnu99} in libgomp.c

2015-06-05 Thread Tom de Vries
Hi, this patch removes a superfluous -std=c99 or -std=gnu99 setting in the libgomp/testsuite/libgomp.c testcases (and a superfluous -fopenmp setting in some cases as well). The setting is superfluous because -std=gnu11 is the new default for C mode, which allows loop initial declaration. I

Re: [debug-early, jit] Port of jit to debug-early

2015-06-05 Thread Aldy Hernandez
On 06/05/2015 05:17 PM, David Malcolm wrote: On Fri, 2015-06-05 at 16:18 -0400, David Malcolm wrote: On Fri, 2015-06-05 at 15:37 -0400, Aldy Hernandez wrote: On 06/05/2015 03:00 PM, David Malcolm wrote: "jit" isn't part of "all" languages, and currently fails to build on the aldyh/debug-early

Re: [debug-early, jit] Port of jit to debug-early

2015-06-05 Thread David Malcolm
On Fri, 2015-06-05 at 16:18 -0400, David Malcolm wrote: > On Fri, 2015-06-05 at 15:37 -0400, Aldy Hernandez wrote: > > On 06/05/2015 03:00 PM, David Malcolm wrote: > > > "jit" isn't part of "all" languages, and currently fails to build on > > > the aldyh/debug-early branch: > > > > The debug-early

Re: Add tree heterogeneous lookup in alternative modes

2015-06-05 Thread François Dumont
On 04/06/2015 14:41, Jonathan Wakely wrote: On 03/06/15 21:56 +0200, François Dumont wrote: Hi Here is a patch to add heterogeneous lookup to alternative modes. Excellent. To do so I had to expose __is_transparent as __has_is_transparent to avoid confilct with existing __is_transparent.

Re: [wwwdocs] Move gcc/README.Portability to wwwdocs codingconventions.html

2015-06-05 Thread Mikhail Maltsev
05.06.2015 23:45, Ciro Santilli writes: [snip] > +high, consider using __builtin_expect, e.g., like this: > + > + > +if (__builtin_expect (ptr != NULL, 0)) > + free (ptr); > + It's strange, that we don't have macros for this, e.g.: #define likely(x) __builtin_expect(!!(x), 1) #define unlike

Re: [debug-early, jit] Port of jit to debug-early

2015-06-05 Thread David Malcolm
On Fri, 2015-06-05 at 15:37 -0400, Aldy Hernandez wrote: > On 06/05/2015 03:00 PM, David Malcolm wrote: > > "jit" isn't part of "all" languages, and currently fails to build on > > the aldyh/debug-early branch: > > The debug-early work is now in mainline. Feel free to commit when you > deem appr

Re: [wwwdocs] Move gcc/README.Portability to wwwdocs codingconventions.html

2015-06-05 Thread Joseph Myers
On Fri, 5 Jun 2015, Ciro Santilli wrote: > Mentioned as a FIXME under gcc/doc/sourcebuild.texi > > This converts half of README.Portability to wwwdocs. Since GCC is now in C++, what's compatible with C90 (or with any particular C compiler) is no longer relevant. So the question is what's comp

[wwwdocs] Move gcc/README.Portability to wwwdocs codingconventions.html

2015-06-05 Thread Ciro Santilli
Mentioned as a FIXME under gcc/doc/sourcebuild.texi This converts half of README.Portability to wwwdocs. If you think this is fine, before merging I can convert the rest, and also include the patch to GCC that removes README.Portability and the FIXME. --- htdocs/codingconventions.html2014-07

Re: [debug-early, jit] Port of jit to debug-early

2015-06-05 Thread Aldy Hernandez
On 06/05/2015 03:00 PM, David Malcolm wrote: "jit" isn't part of "all" languages, and currently fails to build on the aldyh/debug-early branch: The debug-early work is now in mainline. Feel free to commit when you deem appropriate, since you are the jit maintainer ;-). static void -jit_l

[java] include missing file after debug-early merge

2015-06-05 Thread Aldy Hernandez
Must've crossed paths with Andrew Macleod in his header refactoring or something. I added a call to global_decl_processing() which is now missing the relevant header file. I'm testing this and committing as obvious, once I retest mainline once again. Aldy commit d681ceeaef7dcc598a469d86c60e

C++ PATCH for c++/66405 (ICE with variadic alias template)

2015-06-05 Thread Jason Merrill
When substituting one pack expansion into another, we try to simplify the expansion by substituting one pattern into the other, but this doesn't work in this case, because the argument expansion is partially instantiated (the enclosing class template's parms are bound, but not the member templa

[debug-early, jit] Port of jit to debug-early

2015-06-05 Thread David Malcolm
"jit" isn't part of "all" languages, and currently fails to build on the aldyh/debug-early branch: ../../src/gcc/jit/jit-playback.c: In member function ‘void gcc::jit::playback::context::write_global_decls_2()’: ../../src/gcc/jit/jit-playback.c:710:20: error: ‘const struct gcc_debug_hooks’ has n

Re: Heads-up: testsuite: removed cleanup-ipa-dump, cleanup-rtl-dump,cleanup-tree-dump, cleanup-dump, cleanup-saved-temps

2015-06-05 Thread Mike Stump
On Jun 5, 2015, at 4:02 AM, Tom de Vries wrote: > On 02/06/15 20:40, Bernhard Reutner-Fischer wrote: >> On June 2, 2015 5:38:06 PM GMT+02:00, Bernhard >> Reutner-Fischer wrote: >>> >On June 2, 2015 2:08:47 PM GMT+02:00, Richard Biener >>> > wrote: >> >>Committed. Seems to cause half

[patch] Add std::bool_constant for C++17

2015-06-05 Thread Jonathan Wakely
This implements http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4389.html which was voted into the working paper in Lenexa. Like the last patch, this has a TODO placeholder for the feature-test macro. It also updates the manual to document the status of all the library papers from Lenexa

Re: [debug-early] fix problem with template parameter packs

2015-06-05 Thread Jason Merrill
On 06/05/2015 12:33 PM, Aldy Hernandez wrote: + /* The tree for which this DIE was created for. We use this to Too many "for"s. - fprintf (outfile, "DIE %4ld: %s (%p)\n", + fprintf (outfile, "DIE %4ld: %s (%p)", die->die_offset, dwarf_tag_name (die->die_tag), (void*)

Re: [debug-early] fix problem with template parameter packs

2015-06-05 Thread Aldy Hernandez
On 06/05/2015 12:20 PM, Jason Merrill wrote: Looks good. Jason Attached is the latest against mainline, with the aforementioned change, and without the dumped_early bit. Retested for --enable-languages=all,go,ada, for both GCC and GDB. Let me know how this looks. Aldy gcc/ * dwarf2out.c

[patch] Add std::shared_mutex for C++17

2015-06-05 Thread Jonathan Wakely
This implements http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4508.html which was recently applied to the C++ working paper. The guts of shared_timed_mutex are moved out into two helper classes (one using pthread_rwlock_t and one using std::condition_variable) that implement everything

Re: [debug-early] fix problem with template parameter packs

2015-06-05 Thread Jason Merrill
Looks good. Jason

[patch] Adjust hash-table.h and it's pre-requisite includes.

2015-06-05 Thread Andrew MacLeod
There is a horrible morass of include dependencies between hash-map.h, mem-stats.h and hash-table.h. There are even includes in both directions (mem-stats.h and hash-map.h include each other, as do hash-map.h and hash-table.h.. blech). Some of those files need parts of the other file to compi

Re: [debug-early] fix problem with template parameter packs

2015-06-05 Thread Aldy Hernandez
On 06/05/2015 10:02 AM, Jason Merrill wrote: On 06/04/2015 07:31 PM, Aldy Hernandez wrote: So... if I revert the !declaration change and move the big block below said change, would you be OK with it, or did you still want some changes to it? I'm still hoping to simplify it. Actually, I think

Re: [libstdc++ PATCH] Implement __is_nothrow_swappable and use it

2015-06-05 Thread Jonathan Wakely
On 01/05/15 12:47 +0300, Ville Voutilainen wrote: This patch partially solves the problem described in N4426, which is basically LWG issue 2456, which in turn is caused by CWG DR 1330. Some remarks: - the __is_swappable and __is_nothrow_swappable are at this time not meant to be general traits, t

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-06-05 Thread Ilya Enkovich
On 04 Jun 15:53, Joseph Myers wrote: > On Thu, 4 Jun 2015, Ilya Enkovich wrote: > > > 2015-06-03 18:59 GMT+03:00 Joseph Myers : > > > You could, for example, have > > > > > > #if SOMETHING > > > #define MSG "%nsome msg" > > > #else > > > #define MSG "" > > > #endif > > > > > > and have another spe

Re: [debug-early] fix problem with template parameter packs

2015-06-05 Thread Jason Merrill
On 06/04/2015 07:31 PM, Aldy Hernandez wrote: So... if I revert the !declaration change and move the big block below said change, would you be OK with it, or did you still want some changes to it? I'm still hoping to simplify it. Actually, I think we can just remove the if (old_die && dec

Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code

2015-06-05 Thread Kyrill Tkachov
On 05/06/15 14:11, Richard Earnshaw wrote: On 05/06/15 14:08, Kyrill Tkachov wrote: Hi Shiva, On 05/06/15 10:42, Shiva Chen wrote: Hi, Kyrill I add the testcase as stl-cond.c. Could you help to check the testcase ? If it's OK, Could you help me to apply the patch ? This looks ok to me. O

Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code

2015-06-05 Thread Richard Earnshaw
On 05/06/15 14:08, Kyrill Tkachov wrote: > Hi Shiva, > > On 05/06/15 10:42, Shiva Chen wrote: >> Hi, Kyrill >> >> I add the testcase as stl-cond.c. >> >> Could you help to check the testcase ? >> >> If it's OK, Could you help me to apply the patch ? >> > > This looks ok to me. > One nit on the te

Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code

2015-06-05 Thread Kyrill Tkachov
Hi Shiva, On 05/06/15 10:42, Shiva Chen wrote: Hi, Kyrill I add the testcase as stl-cond.c. Could you help to check the testcase ? If it's OK, Could you help me to apply the patch ? This looks ok to me. One nit on the testcase: diff --git a/gcc/testsuite/gcc.target/arm/stl-cond.c b/gcc/t

Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD

2015-06-05 Thread Arnaud Charlet
Patch is OK. Arno >>> Is a new submission necessary or can this be handled by committer? >> Preferably yes. >>> A new submission will take me a few days because I'm traveling ATM. > > There was a significant amount of bitrot. Apparently right after I > submitted the patch, many macros were adj

Re: [Patch, fortran, PR44672, v9] [F08] ALLOCATE with SOURCE and no array-spec

2015-06-05 Thread Andre Vehreschild
Hi all, attached is the most recent version of the patch. It addresses the standard violation of allocate(foo, source=[bar(something)]), where foo after the allocate was a zero-based array instead of a one-based. Furthermore does this patch fix calling _vptr->_copy () routines, which come without

Re: Heads-up: testsuite: removed cleanup-ipa-dump, cleanup-rtl-dump,cleanup-tree-dump, cleanup-dump, cleanup-saved-temps

2015-06-05 Thread Tom de Vries
On 02/06/15 20:40, Bernhard Reutner-Fischer wrote: On June 2, 2015 5:38:06 PM GMT+02:00, Bernhard Reutner-Fischer wrote: >On June 2, 2015 2:08:47 PM GMT+02:00, Richard Biener > wrote: >> >>Committed. Seems to cause half of the vectorizer tests to be dropped >>and test-summary breaking for m

Re: [debug-early] fix problem with template parameter packs

2015-06-05 Thread Aldy Hernandez
On 06/04/2015 07:31 PM, Aldy Hernandez wrote: On 06/04/2015 02:39 PM, Jason Merrill wrote: On 06/04/2015 02:23 PM, Jason Merrill wrote: On 06/03/2015 10:42 AM, Aldy Hernandez wrote: + /* Die was generated early via dwarf2out_early_global_decl. */ + BOOL_BITFIELD dumped_early : 1; Missed a

Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code

2015-06-05 Thread Shiva Chen
Hi, Kyrill I add the testcase as stl-cond.c. Could you help to check the testcase ? If it's OK, Could you help me to apply the patch ? Thanks, Shiva 2015-06-05 16:34 GMT+08:00 Kyrill Tkachov : > Hi Shiva, > > On 05/06/15 09:29, Shiva Chen wrote: >> >> Hi, Kyrill >> >> I update the patch as R

Re: [C/C++ PATCH] Implement -Wshift-overflow (PR c++/55095) (take 3)

2015-06-05 Thread Marek Polacek
On Thu, Jun 04, 2015 at 09:04:19PM +, Joseph Myers wrote: > The C changes are OK. Jason, do you want to approve the C++ parts? Thanks, Marek

Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code

2015-06-05 Thread Kyrill Tkachov
Hi Shiva, On 05/06/15 09:29, Shiva Chen wrote: Hi, Kyrill I update the patch as Richard's suggestion. - return \"str\t%1, %0\"; + return \"str%(%)\t%1, %0\"; else - return \"stl\t%1, %0\"; + return \"stl%?\t%1, %0\"; } -) + [(set_attr "predicable" "yes") + (set

Re: [libcpp/C PATCH] Fix two ICEs with location offsets (PR c/66415)

2015-06-05 Thread Marek Polacek
On Thu, Jun 04, 2015 at 09:05:51PM +, Joseph Myers wrote: > OK in the absence of objections from Dodji as line map maintainer within > 48 hours. Thanks. [Adding Dodji to CC.] Marek

Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code

2015-06-05 Thread Shiva Chen
Hi, Kyrill I update the patch as Richard's suggestion. - return \"str\t%1, %0\"; + return \"str%(%)\t%1, %0\"; else - return \"stl\t%1, %0\"; + return \"stl%?\t%1, %0\"; } -) + [(set_attr "predicable" "yes") + (set_attr "predicable_short_it" "no")]) + [(set_attr "p

Re: [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc

2015-06-05 Thread Jonathan Wakely
On 4 June 2015 at 16:29, Renlin Li wrote: > Hi Jonathan, > > I have committed it on trunk. > > Is it Okay for me to backport it to branch 5.0, 4.9 to remove failing noise? I accidentally replied off-list yesterday. Backporting this is OK, thanks.

Re: [ARM] Fix neon-reload-class.c testcase

2015-06-05 Thread Kyrill Tkachov
Hi Kugan, On 05/06/15 09:01, Kugan wrote: Hi All, After my patch for cprop is committed (https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=224048), neon-reload-class.c is failing in arm mode. But this is kind of expected behaviour so I looked at the original patch related to neon-reload-cl

[ARM] Fix neon-reload-class.c testcase

2015-06-05 Thread Kugan
Hi All, After my patch for cprop is committed (https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=224048), neon-reload-class.c is failing in arm mode. But this is kind of expected behaviour so I looked at the original patch related to neon-reload-class.c, which is: https://gcc.gnu.org/ml/gcc-p