Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-14 Thread Tim Shen
On Mon, Dec 14, 2015 at 10:03 AM, Jonathan Wakely wrote: > OK then I do understand it and it's definitely OK to commit :-) > > Thanks. > Committed to trunk, gcc 5 and gcc 4.9. -- Regards, Tim Shen

Re: [PATCH 2/2] obsolete openbsd 2.0 and 3.X

2015-12-14 Thread Mike Stump
On Dec 14, 2015, at 7:55 PM, tbsaunde+...@tbsaunde.org wrote: > * config.gcc: Makr openbsd 2.0 and 3.X as obsolete. English: Mark...

Re: [PATCH 1/2] mark *-knetbsd-* as obsolete

2015-12-14 Thread Mike Stump
On Dec 14, 2015, at 7:55 PM, tbsaunde+...@tbsaunde.org wrote: > * config.gcc: mark knetbsd targets as obsolete. English: Mark...

[PATCH 2/2] obsolete openbsd 2.0 and 3.X

2015-12-14 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-12-14 Trevor Saunders * config.gcc: Makr openbsd 2.0 and 3.X as obsolete. --- gcc/config.gcc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/config.gcc b/gcc/config.gcc index 59f77da..35ae048 100644 --- a/gcc/config.gcc +++ b/gcc/c

[PATCH 1/2] mark *-knetbsd-* as obsolete

2015-12-14 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-12-14 Trevor Saunders * config.gcc: mark knetbsd targets as obsolete. --- gcc/config.gcc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config.gcc b/gcc/config.gcc index 882e413..59f77da 100644 --- a/gcc/config.gcc +

[PATCH 0/2] obsolete some old targets

2015-12-14 Thread tbsaunde+gcc
From: Trevor Saunders Hi, http://gcc.gnu.org/ml/gcc-patches/2015-12/msg00365.html reminded me I hadn't gotten around to marking *-knetbsd and openbsd 2/3 obsolete as I offered to do back in the spring. I tested I could still build on x86_64-linux-gnu, and could only cross compile to i386-openbs

[PATCH] c/68868 - atomic_init emits an unnecessary fence

2015-12-14 Thread Martin Sebor
The C atomic_init macro is implemented in terms of simple assignment to the atomic variable pointed to by its first argument. That's inefficient since the variable under initialization must not be accessed by other threads and assignment provides sequentially consistent semantics. The inefficien

Re: RFA (hash-*): PATCH for c++/68309

2015-12-14 Thread Trevor Saunders
> > + hash_map (const hash_map &h, bool ggc = false, > + bool gather_mem_stats = true CXX_MEM_STAT_INFO) sorry about the late response, but wouldn't it be better to make this and the hash_table constructor explicit? Its probably less important than other constructors, but is there a re

Re: [PATCH] Fix PR c++/21802 (two-stage name lookup fails for operators)

2015-12-14 Thread Jason Merrill
OK. Jason

[PATCH] Fix PR c++/21802 (two-stage name lookup fails for operators)

2015-12-14 Thread Patrick Palka
On Mon, 14 Dec 2015, Jason Merrill wrote: > On 12/12/2015 06:32 PM, Patrick Palka wrote: >>> >This should use cp_tree_operand_length. >> Hmm, I don't immediately see how I can use this function here. It >> expects a tree but I dont have an appropriate tree to give to it, only a >> tree_code. > >

Re: [RFC] Request for comments on ivopts patch

2015-12-14 Thread Steve Ellcey
On Mon, 2015-12-14 at 09:57 +0100, Richard Biener wrote: > I don't know enough to assess the effect of this but > > 1) not all archs can do auto-incdec so either the comment is misleading > or the test should probably be amended > 2) I wonder why with the comment ("during the loop") you exclude

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-14 Thread H.J. Lu
On Mon, Dec 14, 2015 at 12:43 PM, Jason Merrill wrote: > On 12/14/2015 03:39 PM, H.J. Lu wrote: >> >> On Mon, Dec 14, 2015 at 12:16 PM, Jason Merrill wrote: >>> >>> On 12/12/2015 01:42 PM, Marc Glisse wrote: On Sat, 12 Dec 2015, Jakub Jelinek wrote: > On Sat, Dec 12, 2015

[PATCH 1/2] [graphite] add more dumps on data dependence graph

2015-12-14 Thread Sebastian Pop
--- gcc/graphite-dependences.c| 31 +++ gcc/graphite-poly.c | 15 ++- gcc/graphite-scop-detection.c | 21 - 3 files changed, 57 insertions(+), 10 deletions(-) diff --git a/gcc/graphite-dependences.c b/gcc/graphite-dependenc

[PATCH 2/2] [graphite] update required isl versions

2015-12-14 Thread Sebastian Pop
we now check the isl version, as there are no real differences in existing files in between isl 0.14 and isl 0.15. --- config/isl.m4| 29 +++ configure| 23 +-- gcc/config.in| 12 gcc/configure

Re: [PATCH] Fix PR c++/21802 (two-stage name lookup fails for operators)

2015-12-14 Thread Jason Merrill
On 12/12/2015 06:32 PM, Patrick Palka wrote: >This should use cp_tree_operand_length. Hmm, I don't immediately see how I can use this function here. It expects a tree but I dont have an appropriate tree to give to it, only a tree_code. True. So let's introduce cp_tree_code_length next to cp

[Patch, libstdc++/68877] Reimplement __is_[nothrow_]swappable

2015-12-14 Thread Daniel Krügler
This is a reimplementation of __is_swappable and __is_nothrow_swappable according to http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4511.html and also adds a missing usage of __is_nothrow_swappable in the swap overload for arrays. Strictly speaking the latter change differs from the Sta

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-14 Thread Jason Merrill
On 12/14/2015 03:39 PM, H.J. Lu wrote: On Mon, Dec 14, 2015 at 12:16 PM, Jason Merrill wrote: On 12/12/2015 01:42 PM, Marc Glisse wrote: On Sat, 12 Dec 2015, Jakub Jelinek wrote: On Sat, Dec 12, 2015 at 09:51:23AM -0500, Jason Merrill wrote: On 12/11/2015 06:52 PM, H.J. Lu wrote: On Thu

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-14 Thread H.J. Lu
On Mon, Dec 14, 2015 at 12:16 PM, Jason Merrill wrote: > On 12/12/2015 01:42 PM, Marc Glisse wrote: >> >> On Sat, 12 Dec 2015, Jakub Jelinek wrote: >> >>> On Sat, Dec 12, 2015 at 09:51:23AM -0500, Jason Merrill wrote: On 12/11/2015 06:52 PM, H.J. Lu wrote: > > On Thu, Dec 10, 201

Re: [gomp4] [WIP] OpenACC bind, nohost clauses

2015-12-14 Thread Cesar Philippidis
On 12/08/2015 11:55 AM, Thomas Schwinge wrote: Just for clarification, we're implementing the bind clause with the semantics defined in OpenACC 2.5, correct? The 2.0a semantics aren't clear. > On Sat, 14 Nov 2015 09:36:36 +0100, I wrote: >> Initial support for the OpenACC bind and nohost clauses

Re: Ping [PATCH] c++/42121 - diagnose invalid flexible array members

2015-12-14 Thread Jason Merrill
On 12/14/2015 11:45 AM, Martin Sebor wrote: + if (NULL_TREE == size) Usually NULL_TREE goes on the right. @@ -8744,6 +8748,7 @@ compute_array_index_type (tree name, tree size, tsubst_flags_t complain) else pedwarn (input_location, OPT_Wpedantic, "ISO C++ forbids zero-s

Re: [PATCH] Fix -fcompare-debug issue in tree-cfgcleanup (PR tree-optimization/66688)

2015-12-14 Thread Richard Biener
On December 14, 2015 9:11:39 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >As the testcase used to show on ppc64le with slightly older trunk, >cleanup_control_flow_bb can be called on a bb with newly noreturn >call followed by debug stmts. With -g0, cleanup_control_flow_bb >removes the fallthru edg

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-14 Thread Jason Merrill
On 12/12/2015 01:42 PM, Marc Glisse wrote: On Sat, 12 Dec 2015, Jakub Jelinek wrote: On Sat, Dec 12, 2015 at 09:51:23AM -0500, Jason Merrill wrote: On 12/11/2015 06:52 PM, H.J. Lu wrote: On Thu, Dec 10, 2015 at 3:24 AM, Richard Biener wrote: On Wed, Dec 9, 2015 at 10:31 PM, Markus Trippelsd

[PATCH] Fix -fcompare-debug issue in cross-jumping (PR rtl-optimization/65980)

2015-12-14 Thread Jakub Jelinek
Hi! rtx_renumbered_equal_p considers two LABEL_REFs equivalent if they have the same next_real_insn, unfortunately next_real_insn doesn't ignore debug insns. It ignores BARRIERs/JUMP_TABLE_DATA insns too, which is IMHO not desirable either, so this patch uses next_nonnote_nondebug_insn instead (w

[PATCH] Fix -fcompare-debug issue in tree-cfgcleanup (PR tree-optimization/66688)

2015-12-14 Thread Jakub Jelinek
Hi! As the testcase used to show on ppc64le with slightly older trunk, cleanup_control_flow_bb can be called on a bb with newly noreturn call followed by debug stmts. With -g0, cleanup_control_flow_bb removes the fallthru edge, so we need to do it even if followed by debug stmts. This patch is o

Re: [BUILDROBOT] "error: null argument where non-null required" on multiple targets

2015-12-14 Thread Jan-Benedict Glaw
On Mon, 2015-12-14 18:54:28 +, Moore, Catherine wrote: > > avr-rtems > > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=478544 > > mipsel-elf > > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=478844 > > mipsisa64r2-sde-elf > > http://tool

[PTX] parameters and return values

2015-12-14 Thread Nathan Sidwell
This patch further cleans up the parameter passing and return machinery. Now both the PTX prototyp emission and the regular gcc hooks use the same underlying functions (or the former uses the gcc hooks directly). There were a few inconsistencies with promotion of QH & HI mode registers -- for

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-14 Thread Tobias Burnus
Alessandro Fanfarillo wrote: In attachment the patch for gcc5-branch. Commited as Rev. 231626. Tobias 2015-12-10 10:03 GMT+01:00 Tobias Burnus : Hi Alessandro (off list), On Thu, Dec 10, 2015 at 09:44:16AM +0100, Alessandro Fanfarillo wrote: Yes, the patch should be applied to GCC 5 too.

Re: [Fortran, Patch} Fix ICE for coarray Critical inside module procedure

2015-12-14 Thread Tobias Burnus
Dear Alessandro, Alessandro Fanfarillo wrote: the compiler returns an ICE when a coarray critical section is used inside a module procedure. The symbols related with the lock variables were left uncommitted inside resolve_critical(). A gfc_commit_symbol after each symbol or a gfc_commit_symbols

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Trevor Saunders
On Mon, Dec 14, 2015 at 05:40:57PM +0100, Markus Trippelsdorf wrote: > On 2015.12.14 at 11:20 -0500, Trevor Saunders wrote: > > On Mon, Dec 14, 2015 at 10:01:27AM +0100, Richard Biener wrote: > > > On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > > > > Markus Trippelsdorf writes: > > > > > >

RE: [BUILDROBOT] "error: null argument where non-null required" on multiple targets

2015-12-14 Thread Moore, Catherine
> -Original Message- > From: Jan-Benedict Glaw [mailto:jbg...@lug-owl.de] > Sent: Sunday, December 06, 2015 4:49 PM > To: Denis Chertykov; Moore, Catherine; Eric Christopher; Matthew Fortune; > David Edelsohn; Alexandre Oliva; Kaz Kojima; Oleg Endo > Cc: Jonathan Wakely; gcc-patches > Sub

Re: [PR 68851] Do not collect thunks in callect_callers

2015-12-14 Thread Jan Hubicka
> Hi, > > in PR 68851, IPA-CP decides to clone for all known contexts, even when > it is not local because the code is not supposed to grow anyway. The > code doing that uses collect_callers method of cgraph_edge to find all > the edges which are to be redirected in such case. However, there is

Fix omnetpp miscompilation

2015-12-14 Thread Jan Hubicka
Hi, this patch is not so nice fix for quite nasty problem with devirtualization and decl merging. Once we determine the call target, we use possible_polymorphic_call_target_p to check if this is type consistent and if not we redirect to builtin_unreachable and do not account this as a hint to the

[PR 68851] Do not collect thunks in callect_callers

2015-12-14 Thread Martin Jambor
Hi, in PR 68851, IPA-CP decides to clone for all known contexts, even when it is not local because the code is not supposed to grow anyway. The code doing that uses collect_callers method of cgraph_edge to find all the edges which are to be redirected in such case. However, there is also an edge

Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-14 Thread Jonathan Wakely
On 14/12/15 09:58 -0800, Tim Shen wrote: On Mon, Dec 14, 2015 at 3:00 AM, Jonathan Wakely wrote: I don't fully understand the patch, but it's OK for trunk, and if you're confident it's definitely correct and safe it's OK for the gcc-5 and gcc-4_9 branches too. Was it just completely wrong befo

Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-14 Thread Tim Shen
On Mon, Dec 14, 2015 at 3:00 AM, Jonathan Wakely wrote: > I don't fully understand the patch, but it's OK for trunk, and if > you're confident it's definitely correct and safe it's OK for the > gcc-5 and gcc-4_9 branches too. > > Was it just completely wrong before, creating a vector of > default-

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Mike Stump
On Dec 14, 2015, at 2:40 AM, Rainer Orth wrote: > As described in PR PR target/67973, newer assemblers on Mac OS X, which > are based on LLVM instead of gas, don't support .stab* directives any > longer. The following patch detects this situation and tries to fall > back to the older gas-based as

Re: [gomp4.5] Handle #pragma omp declare target link

2015-12-14 Thread Ilya Verbin
On Mon, Nov 30, 2015 at 21:49:02 +0100, Jakub Jelinek wrote: > On Mon, Nov 30, 2015 at 11:29:34PM +0300, Ilya Verbin wrote: > > > This looks wrong, both of these clearly could affect anything with > > > DECL_HAS_VALUE_EXPR_P, not just the link vars. > > > So, if you need to handle the "omp declare

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Manuel López-Ibáñez
On 14/12/15 16:40, Markus Trippelsdorf wrote: On 2015.12.14@11:20 -0500, Trevor Saunders wrote: On Mon, Dec 14, 2015@10:01:27AM +0100, Richard Biener wrote: On Sun, Dec 13, 2015@9:03 PM, Andi Kleen wrote: Markus Trippelsdorf writes: Many developers are still using __attribute__((optimize()

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Markus Trippelsdorf
On 2015.12.14 at 11:20 -0500, Trevor Saunders wrote: > On Mon, Dec 14, 2015 at 10:01:27AM +0100, Richard Biener wrote: > > On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > > > Markus Trippelsdorf writes: > > > > > >> Many developers are still using __attribute__((optimize())) in > > >> produc

Re: [gomp4.5] Handle #pragma omp declare target link

2015-12-14 Thread Ilya Verbin
On Fri, Dec 11, 2015 at 18:27:13 +0100, Jakub Jelinek wrote: > On Tue, Dec 08, 2015 at 05:45:59PM +0300, Ilya Verbin wrote: > > @@ -356,6 +361,11 @@ gomp_map_vars (struct gomp_device_descr *devicep, > > size_t mapnum, > > } > > > >gomp_mutex_lock (&devicep->lock); > > + if (devicep->st

Re: Ping [PATCH] c++/42121 - diagnose invalid flexible array members

2015-12-14 Thread Jakub Jelinek
On Mon, Dec 14, 2015 at 09:45:16AM -0700, Martin Sebor wrote: > --- a/gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c > +++ b/gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c > @@ -605,8 +605,11 @@ getrandll (void) >return ret; > } > > +/* Generate a subfield. The object pointe

Ping [PATCH] c++/42121 - diagnose invalid flexible array members

2015-12-14 Thread Martin Sebor
Ping: The most recent patch revealed a problem in the test suite where the g++.dg/compat/struct-layout-1_generate.c program generates structs with invalid flexible array members. The attached patch fixes the generator to avoid that. Jason, Are there any further changes you'd like to suggest fo

Re: [PATCH] Fix -Werror= handling with aliases (PR c/68833)

2015-12-14 Thread Bernd Schmidt
On 12/11/2015 09:18 PM, Jakub Jelinek wrote: Unfortunately, my patch broke some cases with warning aliases that happened to work (by accident) and left some other warning alias cases broken. This patch attempts to fix that (and add Warning keyword to two warning aliases that didn't have it), so

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Trevor Saunders
On Mon, Dec 14, 2015 at 10:01:27AM +0100, Richard Biener wrote: > On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > > Markus Trippelsdorf writes: > > > >> Many developers are still using __attribute__((optimize())) in > >> production code, although it quite broken. > > > > Wo reads documentati

[PATCH 1/3, libgomp] Resolve libgomp plugin deadlock on exit, libgomp proper parts

2015-12-14 Thread Chung-Lin Tang
[sorry, forgot to C gcc-patches in last send] Hi Jakub, these patches are a revision of https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01701.html since that patch set have bitrotten by now. To recap the original situation, due to the way that device locks are held when entering plugin code, a GOM

Re: [PATCH, 4/16] Implement -foffload-alias

2015-12-14 Thread Tom de Vries
On 14/12/15 14:26, Richard Biener wrote: On Sun, 13 Dec 2015, Tom de Vries wrote: On 11/12/15 14:00, Richard Biener wrote: On Fri, 11 Dec 2015, Tom de Vries wrote: On 13/11/15 12:39, Jakub Jelinek wrote: We simply have some compiler internal interface between the caller and callee of the ou

Re: [PATCH] Fix PR68852

2015-12-14 Thread Richard Biener
On Mon, 14 Dec 2015, Richard Biener wrote: > > The following fixes PR68852 - so I finally needed to sit down and > fix the "build-from-scalars" hack in the SLP vectorizer by pretending > we'd have a sane vectorizer IL. Basically I now mark the SLP node > with a proper vect_def_type but I have to

Re: [PIING][PATCH, 9/16] Add pass_parallelize_loops_oacc_kernels

2015-12-14 Thread Richard Biener
On Sun, Dec 13, 2015 at 5:58 PM, Tom de Vries wrote: > On 24/11/15 13:24, Tom de Vries wrote: >> >> On 16/11/15 12:59, Tom de Vries wrote: >>> >>> On 09/11/15 20:52, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: > > Hi, > > this patch series for stage1 trunk

[PATCH] Fix PR68892

2015-12-14 Thread Richard Biener
The following fixes PR68892, the BB vectorizer now happily creates a load of dead vector loads (we had a similar bug with loop single-element interleaving support in the past). Fixed as a side-effect of making the SLP load cost reflect reality. Bootstrapped on x86_64-unknown-linux-gnu, testing i

[PATCH] Fix PR68852

2015-12-14 Thread Richard Biener
The following fixes PR68852 - so I finally needed to sit down and fix the "build-from-scalars" hack in the SLP vectorizer by pretending we'd have a sane vectorizer IL. Basically I now mark the SLP node with a proper vect_def_type but I have to push that down to the stmt-info level whenever sth wo

Re: [PATCH] S/390: Allow to use r1 to r4 as literal pool base.

2015-12-14 Thread Ulrich Weigand
Dominik Vogt wrote: > The attached patch enables using r1 to r4 as the literal pool base pointer if > one of them is unused in a leaf function. The unpatched code supports only r5 > and r13. I don't think that r1 is actually safe here. Note that it may be used (unconditionally) as temp register

Re: adding -Wshadow-local and -Wshadow-compatible-local ?

2015-12-14 Thread Diego Novillo
On Fri, Dec 11, 2015 at 6:41 PM, Jim Meyering wrote: > > Hi Diego, > > I noticed this patch that adds support for improved -Wshadow-related options: > > [google] Add two new -Wshadow warnings (issue4452058) >https://gcc.gnu.org/ml/gcc-patches/2011-04/msg02317.html >https://codereview.app

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Bernd Schmidt
On 12/14/2015 03:20 PM, Richard Biener wrote: But there must be a reason statics/externals are expected and handled in all the callers (and the function). At the time this was written (git rev 60d031234), expand_one_var looked very different. It called a subroutine expand_one_static_var which

Re: [PATCH] Allow embedded timestamps by C/C++ macros to be set externally (2)

2015-12-14 Thread Dhole
Hi, The copyright assignment process is now complete :) Let me know if I'm required to do anything else regarding the patch I sent. Best regards, Dhole

Re: ipa-cp heuristics fixes

2015-12-14 Thread Martin Jambor
Hi, On Fri, Dec 11, 2015 at 10:20:20PM +0100, Jan Hubicka wrote: > Actually I added > if (!ipa_is_param_used (info, i)) > > continue; > > shortcut to gather_context_independent_v

Re: [gomp-nvptx] nvptx backend: implement alloca with -msoft-stack

2015-12-14 Thread Nathan Sidwell
On 12/14/15 08:50, Alexander Monakov wrote: I have committed this patch to the gomp-nvptx branch. Bernd, Nathan, I would appreciate if you could comment on 'define_predicate' changes in nvptx.md. There are three predicates that start like this: if (REG_P (op)) return !HARD_REGISTER_P (o

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Richard Biener
On Mon, Dec 14, 2015 at 1:09 PM, Bernd Schmidt wrote: > On 12/14/2015 10:07 AM, Richard Biener wrote: > >> Note that we also record alignment to make sure we can spill to properly >> aligned stack slots. > > >> I don't see why we don't need to do that for used statics/externs. That >> is >> are y

Re: [RFC] Dump ssaname info for default defs

2015-12-14 Thread Richard Biener
On Mon, Dec 14, 2015 at 11:50 AM, Tom de Vries wrote: > On 14/12/15 09:47, Richard Biener wrote: >> >> On Fri, Dec 11, 2015 at 6:05 PM, Tom de Vries >> wrote: >>> >>> Hi, >>> >>> atm, we dump ssa-name info for lhs-es of statements. That leaves out the >>> ssa >>> names with default defs. >>> >>>

[gomp-nvptx] nvptx backend: implement alloca with -msoft-stack

2015-12-14 Thread Alexander Monakov
This patch implements variable stack allocation for alloca/VLA on NVPTX if -msoft-stack is enabled. In addition to moving the stack pointer, we need to copy the updated pointer into __nvptx_stacks[tid.y]. * config/nvptx/nvptx.c (nvptx_declare_function_name): Emit %outargs using .l

[gomp4] Fix handling of kernel launch mappings.

2015-12-14 Thread James Norris
Hi, The attached patch fixes an issue in the managing of the page-locked buffer which holds the kernel launch mappings. In the process of fixing the issue, I discovered that 'struct map' was no longer needed, so that has been removed as well. Committed to gomp-4_0-branch. Thanks, Jim Index: lib

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Rainer Orth
Hi Iain, >>> Hrm, this needs more investigation, and will affect 10.10 too, since xc7 is >>> the default there. >>> (separate issue, let’s start a new PR, or at least a new thread). >> >> right, but it's only an issue if you switch assemblers (or linkers) used >> by gcc without rebuilding. This

Re: [PATCH] rs6000: Fix a mistake in cstore_si_as_di (PR68865, PR68879)

2015-12-14 Thread David Edelsohn
On Mon, Dec 14, 2015 at 2:04 AM, Segher Boessenkool wrote: > convert_move does not know how to zero-extend a constant integer to the > target mode -- simply because it does not know the target mode. As a > result, 32-bit SImode with the high bit set would be effectively sign- > extended instead o

Re: [PATCH, 4/16] Implement -foffload-alias

2015-12-14 Thread Richard Biener
On Sun, 13 Dec 2015, Tom de Vries wrote: > On 11/12/15 14:00, Richard Biener wrote: > > On Fri, 11 Dec 2015, Tom de Vries wrote: > > > > > On 13/11/15 12:39, Jakub Jelinek wrote: > > > > We simply have some compiler internal interface between the caller and > > > > callee of the outlined regions,

[PATCH 3/3, libgomp] Resolve libgomp plugin deadlock on exit, intelmic parts

2015-12-14 Thread Chung-Lin Tang
Hi Ilya, thanks for the prior review (https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01893.html), This version is mostly a like the prior one, with some minor code updates. Thanks, Chung-Lin 2015-12-14 Chung-Lin Tang * plugin/libgomp-plugin-intelmic.cpp (offload): Change return type

[PATCH 2/3, libgomp] Resolve libgomp plugin deadlock on exit, nvptx parts

2015-12-14 Thread Chung-Lin Tang
These are the nvptx parts. Thanks, Chung-Lin * plugin/plugin-nvptx.c (CUDA_CALL_ERET): New convenience macro. (CUDA_CALL): Likewise. (CUDA_CALL_ASSERT): Likewise. (map_init): Change return type to bool, use CUDA_CALL* macros. (map_fini): Likewise. (

[PATCH] Fix PR68775

2015-12-14 Thread Richard Biener
The following fixes PR68775 a miscompile of 465.tonto on ppc64le. The issue is somewhat hard to trigger as it requires operand swapping to trigger in SLP, thus no testcase (in fact the issue went latent on trunk recently). Bootstrapped and tested on x86_64-unknown-linux-gnu. Richard. 2015-12-1

[visium] skip block move insn test on gr5

2015-12-14 Thread Olivier Hainque
Block move insns are specific to gr6. They aren't available at all on gr5. Committing to mainline with offline agreement from Eric. Olivier 2015-12-14 Olivier Hainque testsuite/ * gcc.target/visium/block_move.c: Skip for gr5. skip-bmd-gr5.diff Description: Binary data

[PATCH] IRA: Fix % constraint modifier handling on disabled alternatives.

2015-12-14 Thread Andreas Krebbel
Hi, the constraint modifier % applies to all the alternatives of a pattern and hence is mostly added to the first constraint of an operand. IRA currently ignores it if the alternative with the % gets disabled by using the `enabled' attribute or if it is not among the preferred alternatives. Fixe

Re: [PATCH 0/3] Re: [PATCH] PR c/68473: sanitize source range-printing within certain macro expansions

2015-12-14 Thread Bernd Schmidt
On 12/11/2015 07:45 PM, David Malcolm wrote: The third patch in the kit is the earlier workaround for the bug; as before it degrades diagnostic-printing to just print a caret for the awkward cases, rather than attempting to print a range. I'm a little confused now, do the first two patches actu

[PATCH][combine] PR rtl-optimization/68651 Try changing rtx from (r + r) to (r << 1) to aid recognition

2015-12-14 Thread Kyrill Tkachov
Hi all, For this PR I want to teach combine to deal with unrecognisable patterns that contain a sub-expression like (x + x) by transforming it into (x << 1) and trying to match the result. This is because some instruction sets like arm and aarch64 can combine shifts with other arithmetic operat

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Bernd Schmidt
On 12/14/2015 10:07 AM, Richard Biener wrote: Note that we also record alignment to make sure we can spill to properly aligned stack slots. I don't see why we don't need to do that for used statics/externs. That is are you sure we never need to spill a var of their type? Why would they be

Re: [PATCH][AArch64] PR target/68696 FAIL: gcc.target/aarch64/vbslq_u64_1.c scan-assembler-times bif\tv 1

2015-12-14 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00826.html Thanks, Kyrill On 08/12/15 09:21, Kyrill Tkachov wrote: Hi all, The test gcc.target/aarch64/vbslq_u64_1.c started failing recently due to some tree-level changes. This just exposed a deficiency in our xor-and-xor pattern for the ve

Re: [Patch AArch64] Reinstate CANNOT_CHANGE_MODE_CLASS to fix pr67609

2015-12-14 Thread Marcus Shawcroft
On 14 December 2015 at 11:01, James Greenhalgh wrote: > On Wed, Dec 09, 2015 at 01:13:20PM +, Marcus Shawcroft wrote: >> On 27 November 2015 at 13:01, James Greenhalgh >> wrote: >> >> > 2015-11-27 James Greenhalgh >> > >> > * config/aarch64/aarch64-protos.h >> > (aarch64_c

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Iain Sandoe
> On 14 Dec 2015, at 11:21, Rainer Orth wrote: > > Hi Iain, > >>> On 14 Dec 2015, at 11:13, Rainer Orth wrote: >>> > However, I'm not really comfortable with this solution. Initially, I > forgot to wrap the -Q option to as in %{gstabs*:...}, which lead to a > bootstrap failure: t

Re: [PATCH 2/4][AArch64] Increase the loop peeling limit

2015-12-14 Thread James Greenhalgh
On Thu, Dec 03, 2015 at 03:07:43PM -0600, Evandro Menezes wrote: > On 11/20/2015 05:53 AM, James Greenhalgh wrote: > >On Thu, Nov 19, 2015 at 04:04:41PM -0600, Evandro Menezes wrote: > >>On 11/05/2015 02:51 PM, Evandro Menezes wrote: > >>>2015-11-05 Evandro Menezes > >>> > >>> gcc/ > >>> > >>>

Re: [PATCH][ARM] PR target/68648: Fold NOT of CONST_INT in andsi_iorsi3_notsi splitter

2015-12-14 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00708.html Thanks, Kyrill On 07/12/15 10:39, Kyrill Tkachov wrote: Hi all, In this PR we ICE because during post-reload splitting we generate the insn: (insn 27 26 11 2 (set (reg:SI 0 r0 [orig:121 D.4992 ] [121]) (and:SI (not:SI (cons

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Rainer Orth
Hi Iain, >> On 14 Dec 2015, at 11:13, Rainer Orth wrote: >> However, I'm not really comfortable with this solution. Initially, I forgot to wrap the -Q option to as in %{gstabs*:...}, which lead to a bootstrap failure: the gas- and LLVM-based assemblers differ in a number of

Re: [PATCH][combine] Don't create LSHIFTRT of zero bits in change_zero_ext

2015-12-14 Thread Kyrill Tkachov
On 11/12/15 01:26, Segher Boessenkool wrote: On Thu, Dec 10, 2015 at 05:05:12PM +0100, Bernd Schmidt wrote: On 12/10/2015 03:36 PM, Kyrill Tkachov wrote: I'm okay with delaying this for next stage 1 if people prefer, though I think it's pretty low risk. I think this is something we should fix

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Iain Sandoe
Hi Rainer, > On 14 Dec 2015, at 11:13, Rainer Orth wrote: > >>> However, I'm not really comfortable with this solution. Initially, I >>> forgot to wrap the -Q option to as in %{gstabs*:...}, which lead to a >>> bootstrap failure: the gas- and LLVM-based assemblers differ in a >>> number of othe

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Rainer Orth
Hi Iain, >> However, I'm not really comfortable with this solution. Initially, I >> forgot to wrap the -Q option to as in %{gstabs*:...}, which lead to a >> bootstrap failure: the gas- and LLVM-based assemblers differ in a >> number of other ways, as can be seen when comparing gcc/auto-host.h: >

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Iain Sandoe
Hi Rainer, Thanks for looking at this! > On 14 Dec 2015, at 10:40, Rainer Orth wrote: > > As described in PR PR target/67973, newer assemblers on Mac OS X, which > are based on LLVM instead of gas, don't support .stab* directives any > longer. The following patch detects this situation and tr

[testsuite] Tweak gcc.dg/torture/pr68264.c for Solaris

2015-12-14 Thread Eric Botcazou
The testcase was already tweaked for Glibc but it needs to be further tweaked because of bugs in Solaris' libm. With the attached patch the test now passes on my SPARC/Solaris 10 and my x86/Solaris 10 test machines. OK for the mainline? 2015-12-14 Eric Botcazou * gcc.dg/torture/pr

Re: [v3 PATCH] Document the implementation of Logical Operator Type Traits.

2015-12-14 Thread Jonathan Wakely
On 12/12/15 22:34 +0200, Ville Voutilainen wrote: Document the implementation of Logical Operator Type Traits. * doc/html/index.html: Regenerate. * doc/html/manual/status.html: Likewise. * doc/xml/manual/status_cxx2017.xml: Add P0013R1 to C++ 201z and to Library Fundamentals 2 TS.

Re: [Patch AArch64] Reinstate CANNOT_CHANGE_MODE_CLASS to fix pr67609

2015-12-14 Thread James Greenhalgh
On Wed, Dec 09, 2015 at 01:13:20PM +, Marcus Shawcroft wrote: > On 27 November 2015 at 13:01, James Greenhalgh > wrote: > > > 2015-11-27 James Greenhalgh > > > > * config/aarch64/aarch64-protos.h > > (aarch64_cannot_change_mode_class): Bring back. > > * config/aarc

Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-14 Thread Jonathan Wakely
On 11/12/15 22:11 -0800, Tim Shen wrote: This is a one-line quick fix for correctness. I bootstrapped trunk and tested on x86_64-pc-linux-gnu, but I wish I can backport it at least to gcc-5-branch. I don't fully understand the patch, but it's OK for trunk, and if you're confident it's definite

Re: [RFC] Dump ssaname info for default defs

2015-12-14 Thread Tom de Vries
On 14/12/15 09:47, Richard Biener wrote: On Fri, Dec 11, 2015 at 6:05 PM, Tom de Vries wrote: Hi, atm, we dump ssa-name info for lhs-es of statements. That leaves out the ssa names with default defs. This proof-of-concept patch prints the ssa-name info for default defs, in the following forma

[build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Rainer Orth
As described in PR PR target/67973, newer assemblers on Mac OS X, which are based on LLVM instead of gas, don't support .stab* directives any longer. The following patch detects this situation and tries to fall back to the older gas-based as if it is still accessible via as -Q. Tested on x86_64-a

[committed] Adjust nvptx-related test annotations

2015-12-14 Thread Alexander Monakov
Hello, I have committed the following testsuite patch as obvious. On NVPTX, __builtin_apply does not work because in emitted assembly all calls (including indirect) are annotated with expected function prototype. As a result, "untyped_assembly" effective-target test was added to skip tests with

RE: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-14 Thread Claudiu Zissulescu
Patches submitted. Thanks, Claudiu > -Original Message- > From: Joern Wolfgang Rennecke [mailto:g...@amylaar.uk] > Sent: Saturday, December 12, 2015 3:49 PM > To: Claudiu Zissulescu; gcc-patches@gcc.gnu.org > Cc: francois.bed...@synopsys.com; jeremy.benn...@embecosm.com > Subject: Re: [PA

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 10:07, wrote: > Note that we also record alignment to make sure we can spill to properly > aligned stack slots. > > I don't see why we don't need to do that for used statics/externs. That is > are you sure we never need to spill a var of their type? No, I'm not, but note that

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Richard Biener
On Mon, Dec 14, 2015 at 9:44 AM, Jan Beulich wrote: On 14.12.15 at 09:35, wrote: >> On Fri, Dec 11, 2015 at 2:54 PM, Bernd Schmidt wrote: >>> On 12/11/2015 02:48 PM, Jan Beulich wrote: Function (or more narrow) scope static variables (as well as others not placed on the stack

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Richard Biener
On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > Markus Trippelsdorf writes: > >> Many developers are still using __attribute__((optimize())) in >> production code, although it quite broken. > > Wo reads documentation? @) If you want to discourage it better warn once > at runtime. We're also

Re: [RFC] Request for comments on ivopts patch

2015-12-14 Thread Richard Biener
On Sat, Dec 12, 2015 at 12:48 AM, Steve Ellcey wrote: > On Wed, 2015-12-09 at 11:24 +0100, Richard Biener wrote: > >> > This second case (without the preference for the original IV) >> > generates better code on MIPS because the final assembly >> > has the increment instructions between the loads

Re: RFA (hash-*): PATCH for c++/68309

2015-12-14 Thread Richard Biener
On Fri, Dec 11, 2015 at 8:05 PM, Jason Merrill wrote: > On 12/11/2015 05:10 AM, Richard Biener wrote: >> >> On Thu, Dec 10, 2015 at 11:03 PM, Jason Merrill wrote: >>> >>> The C++ front end uses a temporary hash table to remember specializations >>> of >>> local variables during template instantia

Re: [RFC] Dump ssaname info for default defs

2015-12-14 Thread Richard Biener
On Fri, Dec 11, 2015 at 6:05 PM, Tom de Vries wrote: > Hi, > > atm, we dump ssa-name info for lhs-es of statements. That leaves out the ssa > names with default defs. > > This proof-of-concept patch prints the ssa-name info for default defs, in > the following format: > ... > __attribute__((noclon

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 09:35, wrote: > On Fri, Dec 11, 2015 at 2:54 PM, Bernd Schmidt wrote: >> On 12/11/2015 02:48 PM, Jan Beulich wrote: >>> >>> Function (or more narrow) scope static variables (as well as others not >>> placed on the stack) should also not have any effect on the stack >>> alignmen

Re: [PATCH] Fix warnings from including fdl.texi into gnat-style.texi

2015-12-14 Thread Tom de Vries
On 08/12/15 19:10, Gerald Pfeifer wrote: Hi Tom, On Tue, 8 Dec 2015, Tom de Vries wrote: Can you approve the fdl part? Let's assume I can. Okay. was the 'Okay' above: - a figure of speech (as I read it), or - an actual approval (conditional on the adding of the comment) ? I should have wri

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Richard Biener
On Fri, Dec 11, 2015 at 2:54 PM, Bernd Schmidt wrote: > On 12/11/2015 02:48 PM, Jan Beulich wrote: >> >> Function (or more narrow) scope static variables (as well as others not >> placed on the stack) should also not have any effect on the stack >> alignment. I noticed the issue first with Linux'e

Re: [PR 68064] Testcase and an assert for an already fixed bug

2015-12-14 Thread Richard Biener
On Fri, Dec 11, 2015 at 12:16 PM, Martin Jambor wrote: > Hi, > > PR 68064 has been fixed by Richi's revision 231246. I would still > like to add the testcase to the testsuite and add a checking assert > so that if ever get zero alignment again, we catch it in the analysis > part of IPA-CP (which

Re: extend shift count warnings to vector types

2015-12-14 Thread Jan Beulich
>>> On 11.12.15 at 21:40, wrote: > On 12/11/2015 12:28 AM, Jan Beulich wrote: >> gcc/c/ >> 2015-12-10 Jan Beulich >> >> * c-fold.c (c_fully_fold_internal): Also emit shift count >> warnings for vector types. >> * c-typeck.c (build_binary_op): Likewise. > Needs testcases for the a

  1   2   >