Re: [PATCH] Fix PR69274, 435.gromacs performance regression due to RA

2016-02-08 Thread Vladimir Makarov
On 02/08/2016 04:09 AM, Richard Biener wrote: With all of the above I'm not sure what to do for GCC 6 (even though you just approved the patch). Going with the patch alternative (just revert swapping parts of the commutative operands) looks like completely bogus though it works for fixing the

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-08 Thread Jonathan Wakely
On 06/02/16 15:31 +, Jonathan Wakely wrote: On 6 February 2016 at 12:51, Gerald Pfeifer wrote: On Fri, 5 Feb 2016, Jonathan Wakely wrote: Can anyone else test this on an older FreeBSD or other target that isn't gnu/aix/hpux? Thank you, Jonathan! I did not have

[PATCH][PR tree-optimization/65917] Record both equivalences from if (x == y) style conditionals

2016-02-08 Thread Jeff Law
This turns out to be far easier than expected. Given a conditional like x == y, we already record the canonicalized x = y equivalence. If we just record y = x then this "just works". The only tricky thing is the following of the SSA_NAME_VALUE chain for the source argument -- we need to

Re: [PATCH] PR preprocessor/69664: fix rich_location::override_column

2016-02-08 Thread Jeff Law
On 02/04/2016 03:51 PM, David Malcolm wrote: In gcc 5 and earlier, struct diagnostic_info had a field: unsigned int override_column; which could be set by the macro: diagnostic_override_column This was only used by the frontends' callbacks for handling errors from libcpp: c_cpp_error for

Re: [PATCH][P1 tree-optimization/68541] Add heuristics to path splitting

2016-02-08 Thread Jeff Law
On 02/08/2016 07:18 AM, Kyrill Tkachov wrote: Hi Jeff, On 05/02/16 23:49, Jeff Law wrote: This patch addresses multiple issues with how we determine when to split paths. The primary motivation is addressing 68541 (P1). As I've gotten testcodes from Ajit, I've been able to look closely at

Re: Fix PR67639

2016-02-08 Thread Jeff Law
On 02/08/2016 07:26 AM, Bernd Schmidt wrote: On 12/21/2015 08:39 PM, Jeff Law wrote: On 12/18/2015 11:38 AM, Bernd Schmidt wrote: In an earlier fix, the following change was made in varasm.c for invalid register variables: --- trunk/gcc/varasm.c2014/08/26 14:59:59214525 +++

Re: Combine simplify_set WORD_REGISTER_OPERATIONS

2016-02-08 Thread Jeff Law
On 01/31/2016 03:16 PM, Alan Modra wrote: The comment says this test is supposed to prevent "a narrower operation than requested", but it actually only allows a larger subreg, not one the same size. Fix that. Bootstrapped and regression tested powerpc64-linux. OK for stage1? Note that this

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Eric Botcazou
> No, but if there is none left why would you want to "fix" SRA? Because I'm afraid this over-aligned type might leak into other places so we would probably be better off not creating it in the first place, all the more so that it is probably useless in most cases. For PR tree-opt/65310, why

Re: [PATCH] PR c++/69139

2016-02-08 Thread Patrick Palka
On Sat, Feb 6, 2016 at 5:25 PM, Adam Butcher wrote: > PR c++/69139 > * cp/parser.c (cp_parser_simple_type_specifier): Don't mistake 'auto' > in trailing return function pointer types as an implicit template > parameter. > > PR

Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump

2016-02-08 Thread Jeff Law
On 02/08/2016 06:07 AM, James Greenhalgh wrote: Hi, As far as I can tell, this testcase will only vectorize for x86_64/i?86 targets, so it should be gated to only check for vectorization on those. Additionally, this test wants to scan the vectorizer dumps, so we ought to add

Re: [RFC] Variants of __typeof

2016-02-08 Thread Jeff Law
On 02/03/2016 11:01 PM, Richard Henderson wrote: While attempting to write some code that uses the new x86 named address space support in gcc 6, I found that __typeof is very unhelpful. In particular, given int __seg_fs *ptr; __typeof(*ptr) obj; OBJ will not be type "int", but "int

Re: [Patch] Update GCC Internals: remove section Preserving virtual SSA form

2016-02-08 Thread Jeff Law
On 01/29/2016 04:24 AM, Nicklas Bo Jensen wrote: Hi, The section "12.3.2 Preserving the virtual SSA form" in GCC Internals is outdated. The two functions it documents push_stmt_changes and pop_stmt_changes have been removed. The functionality have been replaced with update_stmt. update_stmt is

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Richard Biener
On February 8, 2016 5:31:16 PM GMT+01:00, Eric Botcazou wrote: >> No, but if there is none left why would you want to "fix" SRA? > >Because I'm afraid this over-aligned type might leak into other places >so we >would probably be better off not creating it in the first

Re: Fix c/69522, memory management issue in c-parser

2016-02-08 Thread Jeff Law
On 01/29/2016 04:40 AM, Bernd Schmidt wrote: Let's say we have struct a { int x[1]; int y[1]; } x = { 0, { 0 } }; ^ When we reach the marked brace, we call into push_init_level, where we notice that we have implicit initializers (for x[]) lying around that we should deal with

Re: [PR66726] Fixe regression caused by Factor conversion out of COND_EXPR

2016-02-08 Thread Jeff Law
On 01/18/2016 08:52 PM, Kugan wrote: Hi, This is an updated version of https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02196.html. Patch to fix PR66726 missed optimization, factor conversion out of COND_EXPR caused a regression for targets with branch cost greater than i.e., testcase

Re: [PATCH] Fix PR69274, 435.gromacs performance regression due to RA

2016-02-08 Thread Richard Biener
On Fri, 5 Feb 2016, Vladimir Makarov wrote: > On 02/05/2016 04:25 AM, Richard Biener wrote: > > The following patch fixes the performance regression for 435.gromacs > > on x86_64 with AVX2 (Haswell or bdver2) caused by > > > > 2015-12-18 Andreas Krebbel > > > >

Re: [PATCH PR68021]Don't add biv candidate if it's not incremented by a single stmt

2016-02-08 Thread Richard Biener
On Fri, Feb 5, 2016 at 8:20 PM, Bin Cheng wrote: > Hi, > As reported by PR68021, there is an ivopt bug all the time. As designed, > ivopt tries to identify and reuse induction variables in the original input. > Apparently we don't need to compute such original biv because

Re: [PATCH] Fix PR 69282: ICE on 464.h264ref at -O3

2016-02-08 Thread Richard Biener
On Mon, Feb 8, 2016 at 7:22 AM, Andrew Pinski wrote: > Hi, > The problem is that even though expand knows how to expand > VEC_COND when there is no vcond_mask pattern, > expand_vec_cond_expr_p returns false. So this patch allows > expand_vec_cond_expr_p to try the

Re: [PATCH, PR69707] Handle -fdiagnostics-color in lto

2016-02-08 Thread Jakub Jelinek
On Mon, Feb 08, 2016 at 11:34:39AM +0100, Tom de Vries wrote: > Hi, > > when running libgomp.oacc-c-c++-common/parallel-dims.c with -flto > -fno-use-linker-plugin, we run into a failing 'test for excess errors'. > > The problem is that while -fdiagnostics-color=never is passed to gcc, it's > not

Re: [PATCH, PR69599] Fix GOMP/GOACC_parallel optimization in ipa-pta

2016-02-08 Thread Richard Biener
On Mon, 8 Feb 2016, Tom de Vries wrote: > Hi, > > when compiling the fipa-pta tests in the libgomp testsuite (omp-nested-2.c, > pr46032.c) with -flto -flto-partition=max, the tests fail in execution > (PR69599). > > The problem is related to the GOMP/GOACC_parallel optimization we do in >

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Eric Botcazou
> Yes, that place I just fixed. I mean for the SRA case. Are you sure that there is one? expr = build_ref_for_model (loc, agg, access->offset - top_offset, access, gsi, insert_after); if (write) { if

[PATCH, PR59627, c++] Handle DECL_OMP_DECLARE_REDUCTION in discriminator_for_local_entity

2016-02-08 Thread Tom de Vries
Hi, When running libgomp testsuite with -flto, we run into an ICE in the udr-*.C tests. A minimal testcase is in listed in PR59627: ... struct A { int i; }; void foo() { A a; #pragma omp declare reduction (+: A: omp_out.i += omp_in.i) #pragma omp parallel reduction (+: a) ; } ...

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Richard Biener
On Mon, 8 Feb 2016, Eric Botcazou wrote: > > No, that's not over-aliging a salar type, that's preserving alignment > > information on the memory reference. > > What would we lose exactly by lowering the alignment to that of the type? > What's the point in knowing that a 32-bit integer is 64-bit

Re: [AArch64] Remove AARCH64_EXTRA_TUNE_RECIP_SQRT from Cortex-A57 tuning

2016-02-08 Thread James Greenhalgh
On Mon, Feb 01, 2016 at 02:00:01PM +, James Greenhalgh wrote: > On Mon, Jan 25, 2016 at 11:20:46AM +, James Greenhalgh wrote: > > On Mon, Jan 11, 2016 at 12:04:43PM +, James Greenhalgh wrote: > > > > > > Hi, > > > > > > I've seen a couple of large performance issues caused by

Re: [Patch AArch64] GCC 6 regression in vector performance. - Fix vector initialization to happen with lane load instructions.

2016-02-08 Thread James Greenhalgh
On Tue, Feb 02, 2016 at 10:29:29AM +, James Greenhalgh wrote: > On Wed, Jan 20, 2016 at 03:22:11PM +, James Greenhalgh wrote: > > > > Hi, > > > > In a number of cases where we try to create vectors we end up spilling to > > the > > stack and then filling. This is one example distilled

Re: [PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-08 Thread Jakub Jelinek
On Mon, Feb 08, 2016 at 01:46:44PM +0100, Tom de Vries wrote: > [ The pass before pass_omp_simd_clone is pass_dispatcher_calls. It has a > function create_target_clone, similar to simd_clone_create, with a > node.defition and !node.defition part. The !node.defition part does not call >

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Richard Biener
On Mon, 8 Feb 2016, Eric Botcazou wrote: > > Yes, that place I just fixed. I mean for the SRA case. > > Are you sure that there is one? No, but if there is none left why would you want to "fix" SRA? Richard. > expr = build_ref_for_model (loc, agg, access->offset - top_offset, >

[PATCH] Fix split-path-2.c on targets with unsigned characters by default

2016-02-08 Thread Jeff Law
Andreas pointed out the test was failing on aarch64. It turns out it's got to be failing on all targets where characters are unsigned by default as the test assumes characters are signed by default. Opps. The fix is pretty obvious. Just make the array of chars be signed chars. Installed

[Ada] Fix oversight in latest create_var_decl change

2016-02-08 Thread Eric Botcazou
It causes the global uninitialized variables to be put in DATA instead of (the equivalent of) BSS on some platforms like AIX. Fixed thusly, tested on x86_64-suse-linux, applied on the mainline. 2016-02-08 Eric Botcazou * gcc-interface/utils.c

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Eric Botcazou
> This makes it less likely (for example through the PRE path) to trigger > target bugs like PR68273 where targets use type alignment of call > arguments to decide on the ABI. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Thanks. I think that we can also avoid this

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Eric Botcazou
> No, that's not over-aliging a salar type, that's preserving alignment > information on the memory reference. What would we lose exactly by lowering the alignment to that of the type? What's the point in knowing that a 32-bit integer is 64-bit aligned at the GIMPLE level? -- Eric Botcazou

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Richard Biener
On Mon, 8 Feb 2016, Eric Botcazou wrote: > > It helps vectorization. This was specifically introduced to fix a > > regression on powerpc. > > > > See PR65310. > > Indeed, the SRA code was much better before that one liner. ;-) Not sure what to make of this comment ;) Did you see where we

Re: [PATCH 1/2] [ARM] PR68532: Fix up vuzp for big endian

2016-02-08 Thread Kyrill Tkachov
Hi Charles, On 03/02/16 18:59, charles.bay...@linaro.org wrote: From: Charles Baylis gcc/ChangeLog: 2016-02-03 Charles Baylis PR target/68532 * config/arm/arm.c (neon_endian_lane_map): New function.

Re: [PATCH, stage1] Better error recovery for merge-conflict markers

2016-02-08 Thread Bert Wesarg
David, On Thu, Apr 9, 2015 at 10:29 AM, Bert Wesarg wrote: > Hi David, > >> Various tools that operate on source code files will inject markers >> into them when an unfixable conflict occurs in a merger. >> >> There appears to be no blessed standard for these conflict

Re: [PATCH 2/2] [ARM] PR68532 Fix up vzip recognition for big endian

2016-02-08 Thread Kyrill Tkachov
Hi Charles, On 03/02/16 18:59, charles.bay...@linaro.org wrote: From: Charles Baylis gcc/ChangeLog: 2016-02-03 Charles Baylis PR target/68532 * config/arm/arm.c (arm_evpc_neon_vzip): Allow for big endian lane

Re: [PATCH] Fix PR69274, 435.gromacs performance regression due to RA

2016-02-08 Thread Bernd Schmidt
On 02/08/2016 10:09 AM, Richard Biener wrote: The gcc.target/i386/addr-sel-1.c (for PR28940) seems to just started working at some point past in time and thus it was added and the bug closed. You could say RA does a better job after the patch as it uses 1 less register but that restricts the

Re: [PATCH][P1 tree-optimization/68541] Add heuristics to path splitting

2016-02-08 Thread Jeff Law
On 02/06/2016 03:19 AM, Andreas Schwab wrote: Jeff Law writes: diff --git a/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c b/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c new file mode 100644 index 000..aeb926e --- /dev/null +++

[PATCH, PR69599] Fix GOMP/GOACC_parallel optimization in ipa-pta

2016-02-08 Thread Tom de Vries
Hi, when compiling the fipa-pta tests in the libgomp testsuite (omp-nested-2.c, pr46032.c) with -flto -flto-partition=max, the tests fail in execution (PR69599). The problem is related to the GOMP/GOACC_parallel optimization we do in fipa-pta, where we interpret a call GOMP_parallel (_0,

Re: [patch] Fix SSA_NAME_OCCURS_IN_ABNORMAL_PHI issue in backprop

2016-02-08 Thread Richard Biener
On Mon, Feb 8, 2016 at 11:37 AM, Eric Botcazou wrote: > Hi, > > the Ada runtime fails to build for platforms still using the old SJLJ scheme > because of the new GIMPLE backprop pass (hence it's a regression): > > eric@polaris:~/build/gcc/native> gcc/gnat1 -quiet

Re: [PATCH][AArch64] PR target/69161: Don't use special predicate for CCmode comparisons in expressions that require matching modes

2016-02-08 Thread Kyrill Tkachov
Hi James, On 04/02/16 13:49, James Greenhalgh wrote: On Fri, Jan 29, 2016 at 02:27:34PM +, Kyrill Tkachov wrote: Hi all, In this PR we ICE during combine when trying to propagate a comparison into a vec_duplicate, that is we end up creating the rtx: (vec_duplicate:V4SI (eq:CC_NZ

Re: [PR69634] fix debug_insn-inconsistent REG_N_CALLS_CROSSED

2016-02-08 Thread Jeff Law
On 02/06/2016 03:06 AM, Alexandre Oliva wrote: The testcase has a debug insn referencing a pseudo right before an insn that modifies the pseudo. Without debug insns, REG_N_CALLS_CROSSED was zero for that pseudo, so sched_analyze_reg added a dep between the pseudo setter and an earlier

Re: PATCH] Fix PR 31531: A microoptimization of isnegative of signed integer

2016-02-08 Thread Senthil Kumar Selvaraj
Hurugalawadi, Naveen writes: > Hi, > > Please find attached the patch that performs optimization on unsigned values. > > Original fold-const part implemented in match.pd. > > Please review the patch and let us know if it's OK? > > Regression Tested on X86_64 with no regressions. > > Thanks, >

Re: RFA (convert): PATCH for c++/69631 (wrong overflow error with -fwrapv)

2016-02-08 Thread Richard Biener
On Fri, Feb 5, 2016 at 9:34 PM, Jason Merrill wrote: > The problem here was that the call to convert_to_integer_nofold was still > pushing the conversion down into the multiply expression, and when we do the > multiplication in unsigned short it overflows. This patch fixes >

[patch] Fix SSA_NAME_OCCURS_IN_ABNORMAL_PHI issue in backprop

2016-02-08 Thread Eric Botcazou
Hi, the Ada runtime fails to build for platforms still using the old SJLJ scheme because of the new GIMPLE backprop pass (hence it's a regression): eric@polaris:~/build/gcc/native> gcc/gnat1 -quiet a-ncelfu.ads -gnatpg -O -I ~/svn/gcc/gcc/ada/ a-ngcefu.adb: In function

Re: [PATCH, PR59627, c++] Handle DECL_OMP_DECLARE_REDUCTION in discriminator_for_local_entity

2016-02-08 Thread Jakub Jelinek
On Mon, Feb 08, 2016 at 11:20:57AM +0100, Tom de Vries wrote: > When running libgomp testsuite with -flto, we run into an ICE in the udr-*.C > tests. > > A minimal testcase is in listed in PR59627: > ... > struct A { int i; }; > > void foo() > { > A a; > #pragma omp declare reduction (+: A:

libgcc: On AIX, increase chances to find landing pads for exceptions

2016-02-08 Thread Michael Haubenwallner
Hi David, still experiencing exception-not-caught problems with gcc-4.2.4 on AIX leads me to some patch proposed in http://gcc.gnu.org/PR13878 back in 2004 already, ought to be fixed by some different commit since 3.4.0. As long as build systems (even libtool right now) on AIX do export these

Re: PATCH] Fix PR 31531: A microoptimization of isnegative of signed integer

2016-02-08 Thread Richard Biener
On Mon, Feb 8, 2016 at 10:16 AM, Senthil Kumar Selvaraj wrote: > > Hurugalawadi, Naveen writes: > >> Hi, >> >> Please find attached the patch that performs optimization on unsigned values. >> >> Original fold-const part implemented in match.pd. >> >> Please

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Eric Botcazou
> It helps vectorization. This was specifically introduced to fix a > regression on powerpc. > > See PR65310. Indeed, the SRA code was much better before that one liner. ;-) -- Eric Botcazou

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Richard Biener
On Mon, 8 Feb 2016, Eric Botcazou wrote: > > Not sure what to make of this comment ;) > > I guess it was a variant of the usual can-of-worms-opening thing. :-) > > > Did you see where we create the SSA name with the overaligned type? > > In tree-ssa-pre.c:insert_into_preds_of_block: > > (gdb)

PATCH] Fix PR 31531: A microoptimization of isnegative of signed integer

2016-02-08 Thread Hurugalawadi, Naveen
Hi, Please find attached the patch that performs optimization on unsigned values. Original fold-const part implemented in match.pd. Please review the patch and let us know if it's OK? Regression Tested on X86_64 with no regressions. Thanks, Naveen ChangeLog: * match.pd (cmp (convert (bit_not

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Eric Botcazou
> Not sure what to make of this comment ;) I guess it was a variant of the usual can-of-worms-opening thing. :-) > Did you see where we create the SSA name with the overaligned type? In tree-ssa-pre.c:insert_into_preds_of_block: (gdb) p debug_pre_expr(expr) {mem_ref<0B>,yyvsp_1}@.MEM_2 (gdb)

[PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-08 Thread Tom de Vries
Hi, Consider libgomp.fortran/declare-simd-3.f90: ... subroutine bar use declare_simd_2_mod real :: b(128) integer :: i !$omp simd do i = 1, 128 b(i) = i * 2.0 end do !$omp simd do i = 1, 128 b(i) = foo (7.0_8, 5 * i, b(i)) end do do i = 1, 128 if (b(i).ne.(7.0 +

[PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Richard Biener
This makes it less likely (for example through the PRE path) to trigger target bugs like PR68273 where targets use type alignment of call arguments to decide on the ABI. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. IMHO targets should still be fixed. Richard.

Re: [PATCH] Avoid bugs like PR68273 to trigger

2016-02-08 Thread Richard Biener
On Mon, 8 Feb 2016, Eric Botcazou wrote: > > This makes it less likely (for example through the PRE path) to trigger > > target bugs like PR68273 where targets use type alignment of call > > arguments to decide on the ABI. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to

[PATCH, PR69707] Handle -fdiagnostics-color in lto

2016-02-08 Thread Tom de Vries
Hi, when running libgomp.oacc-c-c++-common/parallel-dims.c with -flto -fno-use-linker-plugin, we run into a failing 'test for excess errors'. The problem is that while -fdiagnostics-color=never is passed to gcc, it's not propagated to lto1, and the error message is annotated with color

Re: [PATCH v3] PR48344: Fix unrecognizable insn error with -fstack-limit-register=r2

2016-02-08 Thread Bernd Schmidt
On 01/27/2016 07:12 PM, Kelvin Nilsen wrote: +/* During execution of handle_common_deferred_options (), the Pmode + variable cannot be used because it has not yet been initialized. + For this reason, handling of the OPT_fstack_limit_register_ and + OPT_fstack_limit_symbol_ options is

Re: [Patch AArch64] Restrict 16-bit sqrdml{sa}h instructions to FP_LO_REGS

2016-02-08 Thread James Greenhalgh
On Tue, Jan 26, 2016 at 04:04:47PM +, James Greenhalgh wrote: > > Hi, > > In their forms using 16-bit lanes, the sqrdmlah and sqrdmlsh instruction > available when compiling with -march=armv8.1-a are only usable with > a register number in the range 0 to 15 for operand 3, as gas will point >

testsuite fix

2016-02-08 Thread Mike Stump
I’m running the pretty printer test cases on a target with status wrappers, and that system works by printing the return code on that output. It is dependent upon the last line being terminated by “\n”, as the code that looks for the return code requires the return code at the start of a line.

[doc, committed] fix PR 69722

2016-02-08 Thread Sandra Loosemore
I've checked in this patch to fix a texinfo warning about a mismatch between a menu and corresponding sectioning commands, introduced in r225122. I did a little bit of copy-editing of the text added in that revision while I was in there. -Sandra 2016-02-08 Sandra Loosemore

Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump

2016-02-08 Thread James Greenhalgh
On Mon, Feb 08, 2016 at 04:29:31PM +0300, Yuri Rumyantsev wrote: > Hi James, > > Thanks for reporting this issue. > I prepared slightly different patch since we don't need to add > tree-vect dump option - it is on by default for all tests in /vect > directory. Hm, I added that line as my test

Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump

2016-02-08 Thread Yuri Rumyantsev
Sorry for troubles. One line must be excluded from test: -/* { dg-options "-O3" } */ Here is updated patch. Best regards. Yuri. 2016-02-08 16:40 GMT+03:00 James Greenhalgh : > On Mon, Feb 08, 2016 at 04:29:31PM +0300, Yuri Rumyantsev wrote: >> Hi James, >> >> Thanks

Re: [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables

2016-02-08 Thread Ilya Verbin
On Mon, Feb 08, 2016 at 14:20:11 +0100, Tom de Vries wrote: > On 26/01/16 14:01, Ilya Verbin wrote: > >On Tue, Jan 26, 2016 at 13:21:57 +0100, Tom de Vries wrote: > >>On 25/01/16 14:27, Ilya Verbin wrote: > >>>On Tue, Jan 05, 2016 at 15:56:15 +0100, Tom de Vries wrote: > >diff --git

[Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump

2016-02-08 Thread James Greenhalgh
Hi, As far as I can tell, this testcase will only vectorize for x86_64/i?86 targets, so it should be gated to only check for vectorization on those. Additionally, this test wants to scan the vectorizer dumps, so we ought to add -fdump-tree-vect-all to the options. Checked on aarch64

[PATCH, PR69607] Mark offload symbols as global in lto

2016-02-08 Thread Tom de Vries
Hi, when running libgomp.c testsuite with "-flto -flto-partition=1to1 -fno-toplevel-reorder" we run into many compilation failures like this: ... /tmp/.ltrans0.ltrans.o:(.gnu.offload_funcs+0x1a0): undefined reference to `MAIN__._omp_fn.0'^M ... The problem is that the offload table is

[PATCH] Re: PR c++/69139

2016-02-08 Thread Adam Butcher
The following fixes up the handling of trailing returns with cv/ref specifiers mentioned by TC in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69139#c3. I've added handling of exception and transaction specs too. --- gcc/cp/parser.c | 12 ++--

Re: C++ PATCH for c++/69688 (bogus error with -Wsign-compare)

2016-02-08 Thread Marek Polacek
On Fri, Feb 05, 2016 at 05:36:21PM -0500, Jason Merrill wrote: > On 02/05/2016 05:32 PM, Marek Polacek wrote: > > if (TREE_CODE (type) == ERROR_MARK) > > return NULL_TREE; > > > >+ /* Here, DECL may change value; purge caches. */ > >+ clear_fold_cache (); > >+ clear_cv_cache (); > >+ > >

Re: C++ PATCH for c++/69688 (bogus error with -Wsign-compare)

2016-02-08 Thread Jason Merrill
OK, thanks. Jason

Re: [PATCH, PR69707] Handle -fdiagnostics-color in lto

2016-02-08 Thread Tom de Vries
On 08/02/16 11:42, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 11:34:39AM +0100, Tom de Vries wrote: Hi, when running libgomp.oacc-c-c++-common/parallel-dims.c with -flto -fno-use-linker-plugin, we run into a failing 'test for excess errors'. The problem is that while

Re: [PATCH, PR69707] Handle -fdiagnostics-color in lto

2016-02-08 Thread Jakub Jelinek
On Mon, Feb 08, 2016 at 02:38:17PM +0100, Tom de Vries wrote: > hmm, indeed removing the 'Driver' flag from the fdiagnostics-color= entry in > common.opt breaks the functioning of fdiagnostics-color= in the gcc driver. > > This patch leaves the 'Driver' flag alone, and instead explicitly allows >

Re: [PATCH, PR69607] Mark offload symbols as global in lto

2016-02-08 Thread Ilya Verbin
On Mon, Feb 08, 2016 at 14:00:00 +0100, Tom de Vries wrote: > when running libgomp.c testsuite with "-flto -flto-partition=1to1 > -fno-toplevel-reorder" we run into many compilation failures like this: > ... > /tmp/.ltrans0.ltrans.o:(.gnu.offload_funcs+0x1a0): undefined > reference to

Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump

2016-02-08 Thread Richard Biener
On Mon, Feb 8, 2016 at 2:40 PM, James Greenhalgh wrote: > On Mon, Feb 08, 2016 at 04:29:31PM +0300, Yuri Rumyantsev wrote: >> Hi James, >> >> Thanks for reporting this issue. >> I prepared slightly different patch since we don't need to add >> tree-vect dump option - it

Re: [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables

2016-02-08 Thread Tom de Vries
On 26/01/16 14:01, Ilya Verbin wrote: On Tue, Jan 26, 2016 at 13:21:57 +0100, Tom de Vries wrote: On 25/01/16 14:27, Ilya Verbin wrote: On Tue, Jan 05, 2016 at 15:56:15 +0100, Tom de Vries wrote: diff --git a/gcc/lto-cgraph.c b/gcc/lto-cgraph.c index 62e5454..cdaee41 100644 ---

Re: libgcc: On AIX, increase chances to find landing pads for exceptions

2016-02-08 Thread David Edelsohn
Runtime linking is disabled by default on AIX, and I disabled it for libstdc++. There are two remaining issues: 1) FDEs with overlapping ranges causing problems with exceptions. I'm not sure of the best way to work around this. Your patch is one possible solution. 2) AIX linker garbage

Re: [PATCH][P1 tree-optimization/68541] Add heuristics to path splitting

2016-02-08 Thread Kyrill Tkachov
Hi Jeff, On 05/02/16 23:49, Jeff Law wrote: This patch addresses multiple issues with how we determine when to split paths. The primary motivation is addressing 68541 (P1). As I've gotten testcodes from Ajit, I've been able to look closely at the path splitting opportunities and

Re: Fix PR67639

2016-02-08 Thread Bernd Schmidt
On 12/21/2015 08:39 PM, Jeff Law wrote: On 12/18/2015 11:38 AM, Bernd Schmidt wrote: In an earlier fix, the following change was made in varasm.c for invalid register variables: --- trunk/gcc/varasm.c2014/08/26 14:59:59214525 +++ trunk/gcc/varasm.c2014/08/26 17:06:31214526 @@

Re: [PATCH] PR c++/69139

2016-02-08 Thread Jason Merrill
On 02/06/2016 05:25 PM, Adam Butcher wrote: + if (cp_lexer_next_token_is (parser->lexer, CPP_DEREF)) + have_trailing_return_fn_decl = true; + else if ((cp_lexer_consume_token (parser->lexer)->type + == CPP_OPEN_PAREN) +

Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump

2016-02-08 Thread Yuri Rumyantsev
Hi James, Thanks for reporting this issue. I prepared slightly different patch since we don't need to add tree-vect dump option - it is on by default for all tests in /vect directory. gcc/testsuite/ChangeLog: * gcc.dg/vect/vect-mask-store-move-1.c: Gate dump with x86 target. 2016-02-08 16:07

[PATCH] Fix PR69719

2016-02-08 Thread Richard Biener
The following fixes a latent bug in vect_prune_runtime_alias_test_list, not considering negative offset1 - offset2. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk sofar. Richard. 2016-02-08 Richard Biener PR tree-optimization/69719

Re: [PATCH] Fix PR69274, 435.gromacs performance regression due to RA

2016-02-08 Thread Richard Biener
On February 8, 2016 7:07:46 PM GMT+01:00, Vladimir Makarov wrote: >On 02/08/2016 12:38 PM, Michael Matz wrote: >> >> I think the patch makes perfect sense. ira_setup_alts should have no >> observable behaviour from the outside, except the returned value of >merged >>

[committed] Add testcase for already fixed PR ipa/69239

2016-02-08 Thread Jakub Jelinek
Hi! Honza has fixed this PR in r232356, I've added the testcase as obvious, so that we can close the PR. 2016-02-08 Jakub Jelinek PR ipa/69239 * g++.dg/ipa/pr69239.C: New test. --- gcc/testsuite/g++.dg/ipa/pr69239.C.jj 2016-02-08 18:14:08.807338362

Re: [PATCH] Fix PR c++/69283 (auto deduction fails when ADL is required)

2016-02-08 Thread Jason Merrill
OK. Jason

[PATCH] Fix fnsplit ICE (PR tree-optimization/69209)

2016-02-08 Thread Jakub Jelinek
Hi! This fixes an ICE, where the split part doesn't return a value of a is_gimple_reg_type retval, only compares its address (therefore it is addressable), and the main part only uses the var in return_bb. In that case, retval is not gimple val, but needs to be returned as gimple val. So we need

Re: [PATCH] Fix PR69274, 435.gromacs performance regression due to RA

2016-02-08 Thread Vladimir Makarov
On 02/08/2016 12:38 PM, Michael Matz wrote: I think the patch makes perfect sense. ira_setup_alts should have no observable behaviour from the outside, except the returned value of merged acceptable alternatives. Certainly it has no business to fiddle with recog_data. It only does the

Re: [PATCH, PR69707] Handle -fdiagnostics-color in lto

2016-02-08 Thread Tom de Vries
On 08/02/16 14:54, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 02:38:17PM +0100, Tom de Vries wrote: hmm, indeed removing the 'Driver' flag from the fdiagnostics-color= entry in common.opt breaks the functioning of fdiagnostics-color= in the gcc driver. This patch leaves the 'Driver' flag

Re: [PATCH][P1 tree-optimization/68541] Add heuristics to path splitting

2016-02-08 Thread Jeff Law
On 02/08/2016 10:02 AM, Jeff Law wrote: After this patch I also see: FAIL: gcc.dg/tree-ssa/split-path-1.c scan-tree-dump split-paths "Duplicating join block" on arm, but not on aarch64. My arm-none-eabi cross compiler is configured with: --with-float=hard --with-cpu=cortex-a9 --with-fpu=neon

Re: [PATCH] PR c++/69139

2016-02-08 Thread Adam Butcher
On 2016-02-08 19:14, Patrick Palka wrote: On Mon, 8 Feb 2016, Jason Merrill wrote: On 02/08/2016 11:43 AM, Patrick Palka wrote: BTW, last month I posted a patch for this PR that handles all kinds of specifiers as well __attribute__ specifiers. Patch is at:

Re: [PATCH, PR69599] Fix GOMP/GOACC_parallel optimization in ipa-pta

2016-02-08 Thread Tom de Vries
On 08/02/16 11:54, Richard Biener wrote: On Mon, 8 Feb 2016, Tom de Vries wrote: Hi, when compiling the fipa-pta tests in the libgomp testsuite (omp-nested-2.c, pr46032.c) with -flto -flto-partition=max, the tests fail in execution (PR69599). The problem is related to the GOMP/GOACC_parallel

Re: [PATCH] Make C++ use the enum mode attribute

2016-02-08 Thread Mike Stump
On Feb 6, 2016, at 2:37 PM, Trevor Saunders wrote: > it is allowed if you do something like > > enum X : int; > > but it seems really pointless to support setting the size of something > when the language gives you a standard way to do that. Yes, it is, as long as you

Re: [PATCH, gcc7, aarch64] Add arithmetic overflow patterns

2016-02-08 Thread Richard Henderson
On 02/07/2016 10:58 AM, Michael Collison wrote: Richard, One other question on the patch. I note that when you expand the addv and uaddv patterns you emit rtl using gen_add3_compareV and en_add3_compareC respectively. These patterns use sign_extend and zero_extend respectively. Why do you not

[committed] jit: fix build after r233218 (build_common_tree_nodes, -fshort-double)

2016-02-08 Thread David Malcolm
Looks like r233218's change to build_common_tree_nodes missed the jit subdirectory: ../../src/gcc/jit/dummy-frontend.c: In function ‘bool jit_langhook_init()’: ../../src/gcc/jit/dummy-frontend.c:108:40: error: too many arguments to function ‘void build_common_tree_nodes(bool)’

Re: [PATCH] Fix PR69274, 435.gromacs performance regression due to RA

2016-02-08 Thread Michael Matz
Hi, On Mon, 8 Feb 2016, Richard Biener wrote: > 429.mcf 9120243 37.6 S9120245 37.3 S > 429.mcf 9120224 40.7 S9120241 37.8 * > 429.mcf 9120225 40.5 *9120229 39.9 S >

Re: [RFC] Variants of __typeof

2016-02-08 Thread Andrew MacLeod
mailer decided to send html I guess... for some reason.. all of a sudden... stupid computer. anyway... the original bounced., so here it is again... On 02/08/2016 12:05 PM, Andrew MacLeod wrote: On 02/08/2016 11:21 AM, Jeff Law wrote: On 02/03/2016 11:01 PM, Richard Henderson wrote:

Re: [PATCH] PR c++/69139

2016-02-08 Thread Jason Merrill
On 02/08/2016 11:43 AM, Patrick Palka wrote: BTW, last month I posted a patch for this PR that handles all kinds of specifiers as well __attribute__ specifiers. Patch is at: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg02004.html -- it makes the parser arbitrarily look ahead (while skipping

[patch, fortran] PR56007 Remarkably bad error message with DO array=1,2

2016-02-08 Thread Harald Anlauf
Hi, the simple patch below rejects arrays as do loop index variable before another (confusing) error message is emitted. Two new testcases derived from the PR, plus adaption of one testcase that relies on the old error message. Whoever wants to take it... Harald 2016-02-08 Harald Anlauf

Re: AW: Wonly-top-basic-asm

2016-02-08 Thread David Wohlferd
On 2/7/2016 10:45 PM, Bernd Edlinger wrote: On 8. 2. 2016 04:45, David Wohlferd wrote: I replied with a patch that includes most of the changes you asked for (see inline below). Were you waiting on me for something more? ChangeLog entries are still missing. I'll add them back in the next

Re: [PATCH] Fix fnsplit ICE (PR tree-optimization/69209)

2016-02-08 Thread Richard Biener
On February 8, 2016 7:27:49 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >This fixes an ICE, where the split part doesn't return a value >of a is_gimple_reg_type retval, only compares its address (therefore it >is >addressable), and the main part only uses the var in return_bb.

Re: [PATCH] PR c++/69139

2016-02-08 Thread Patrick Palka
On Mon, 8 Feb 2016, Jason Merrill wrote: On 02/08/2016 11:43 AM, Patrick Palka wrote: BTW, last month I posted a patch for this PR that handles all kinds of specifiers as well __attribute__ specifiers. Patch is at: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg02004.html -- it makes the

Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2016-02-08 Thread Jeff Law
On 01/27/2016 05:14 PM, David Edelsohn wrote: On Wed, Jan 27, 2016 at 6:36 PM, Jeff Law wrote: On 01/27/2016 12:39 PM, David Edelsohn wrote: The new sra-17.c and sra-18.c tests fail on AIX because the regex is too restrictive -- AIX labels don't have exactly the same format.

C++ PATCH for c++/69657 (abs not inlined)

2016-02-08 Thread Jason Merrill
The issue in this bug was that due to changes in the libstdc++ headers, the built-in abs declaration was getting hidden by a using-declaration, so that then when the built-in got an explicit declaration, the original declaration wasn't there anymore and so the new declaration didn't get marked

Re: [PATCH v2] sanitize paths used in regular expression

2016-02-08 Thread Zach Welch
On 01/18/2016 02:45 PM, Zach Welch wrote: > On 01/15/2016 10:48 AM, Mike Stump wrote: >> On Jan 15, 2016, at 10:40 AM, Zachary T Welch >> wrote: >>> Does this version look better? >> >> Ok. >> >>> I am not sure if this the right place to put the new helper, so let me

  1   2   >