[patch, libgfortran] PR78881 [F03] reading from string with DTIO procedure does not work properly

2017-03-21 Thread Jerry DeLisle
Hi all, The attached patch is part 1 of a 2 part patch. This part fixes a few problems with handling of advance= and EOR conditions. This does not resolve the original case in the PR but gets some issues out of the way so I can continue. The most notable change is that per standard, child

Re: [PATCH] have chkp skip flexible member arrays (PR #79986)

2017-03-21 Thread Martin Sebor
Since I've also spent some time on this: my take on this is that the C++ FE should just follow C FE's suit and reject such initializations where possible; it seems they've never worked reliably anyway, and bring more harm than good. I don't see that rejecting such code would cause too much

[libcp1] handle anon aggregates linkage-named by typedefs

2017-03-21 Thread Alexandre Oliva
GDB has had a work-around that uses the typedef name as the name of an anonymous class, struct or union, when introducing them through libcc1's C++ API. It didn't do that for enums, that remained anonymous, and GCC warned about using types without linkage as members of types with linkage, which

[PR80025] avoid cselib rtx_equal infinite recursion on XOR

2017-03-21 Thread Alexandre Oliva
When two VALUEs are recorded in the cselib equivalence table such that they are equivalent to each other XORed with the same expression, if we started a cselib equivalence test between say the odd one and the even one, we'd end up recursing to compare the even one with the odd one, and then again,

Re: [PATCH] restore -Wunused-variable on a typedef'd variable in a function template (PR 79548)

2017-03-21 Thread Martin Sebor
I'm not 100% sure I understand what changes you're suggesting but the attached patch does what I think you're after. Is that what you had in mind? Looks good. Thanks. I just committed it to trunk but forgot to ask for approval to backport it to 6 and 5. Martin

Re: C++ PATCH to fix bogus maybe-uninitialized warning (PR c++/80119)

2017-03-21 Thread Marek Polacek
On Tue, Mar 21, 2017 at 08:41:01PM +0100, Jakub Jelinek wrote: > On Tue, Mar 21, 2017 at 03:27:02PM -0400, Jason Merrill wrote: > > OK. > > > > On Tue, Mar 21, 2017 at 11:38 AM, Marek Polacek wrote: > > > This patch fixes a bogus maybe-uninitialized warning reported in the

Re: [Patch] Inline Variables for the Standard Library (p0607r0)

2017-03-21 Thread Daniel Krügler
2017-03-12 1:04 GMT+01:00 Daniel Krügler : > 2017-03-11 23:14 GMT+01:00 Daniel Krügler : >> 2017-03-11 23:09 GMT+01:00 Tim Song : >>> On Sat, Mar 11, 2017 at 3:37 PM, Daniel Krügler >>> wrote:

Re: [PATCH] Implement LWG 2686, hash

2017-03-21 Thread Daniel Krügler
2017-03-12 13:16 GMT+01:00 Daniel Krügler : > The following is an *untested* patch suggestion, please verify. > > Notes: My interpretation is that hash should be > defined outside of the _GLIBCXX_COMPATIBILITY_CXX0X block, please > double-check that course of action. > >

[PATCH] Fix gimplification of const var initialization from COND_EXPR (PR c++/80129)

2017-03-21 Thread Jakub Jelinek
Hi! For non-gimple reg types var = x ? y : z; is gimplified as x ? (var = y) : (var = z);. The problem is that if var is TREE_READONLY, we can gimplify one of those assignments by promoting them to TREE_STATIC (if not addressable) and making the initializer into their DECL_INITIAL. That doesn't

[PATCH] Don't cross-jump in between frame related and non-frame related insns (PR target/80102, take 3)

2017-03-21 Thread Jakub Jelinek
On Tue, Mar 21, 2017 at 06:53:34PM +0100, Jakub Jelinek wrote: > On Tue, Mar 21, 2017 at 08:41:43AM +0100, Jakub Jelinek wrote: > > On Tue, Mar 21, 2017 at 08:38:20AM +1000, Richard Henderson wrote: > > > On 03/21/2017 07:15 AM, Jakub Jelinek wrote: > > > > Not really sure what we should do if

Re: C++ PATCH to fix bogus maybe-uninitialized warning (PR c++/80119)

2017-03-21 Thread Jakub Jelinek
On Tue, Mar 21, 2017 at 03:27:02PM -0400, Jason Merrill wrote: > OK. > > On Tue, Mar 21, 2017 at 11:38 AM, Marek Polacek wrote: > > This patch fixes a bogus maybe-uninitialized warning reported in the PR. > > The issue is that we're not able to fold away useless

Re: [PATCH] have chkp skip flexible member arrays (PR #79986)

2017-03-21 Thread Jason Merrill
On Tue, Mar 21, 2017 at 11:08 AM, Martin Sebor wrote: > On 03/20/2017 10:27 PM, Jason Merrill wrote: >> >> On Mon, Mar 20, 2017 at 7:58 PM, Martin Sebor wrote: >>> >>> On 03/20/2017 05:51 PM, Jason Merrill wrote: On Mon, Mar 20, 2017 at 7:04 PM,

Re: [PATCH] restore -Wunused-variable on a typedef'd variable in a function template (PR 79548)

2017-03-21 Thread Jason Merrill
On Tue, Mar 21, 2017 at 2:40 PM, Martin Sebor wrote: > On 03/20/2017 03:11 PM, Jason Merrill wrote: >> >> On Thu, Feb 23, 2017 at 6:33 PM, Jason Merrill wrote: >>> >>> On Thu, Feb 23, 2017 at 12:56 PM, Martin Sebor wrote: On

Re: C++ PATCH to fix bogus maybe-uninitialized warning (PR c++/80119)

2017-03-21 Thread Jason Merrill
OK. On Tue, Mar 21, 2017 at 11:38 AM, Marek Polacek wrote: > This patch fixes a bogus maybe-uninitialized warning reported in the PR. > The issue is that we're not able to fold away useless CLEANUP_POINT_EXPRs, > as e.g. in > if (<>) >// bogus warning > Here, the

C++ PATCH for c++/77563, missing ambiguous conversion error

2017-03-21 Thread Jason Merrill
This conversion is ambiguous because of its implicit context; when we try to give the error, we need to preserve that context; a conversion in the context of direct-initialization shouldn't get here anyway. Tested x86_64-pc-linux-gnu, applying to trunk. commit

Re: [PATCH] restore -Wunused-variable on a typedef'd variable in a function template (PR 79548)

2017-03-21 Thread Martin Sebor
On 03/20/2017 03:11 PM, Jason Merrill wrote: On Thu, Feb 23, 2017 at 6:33 PM, Jason Merrill wrote: On Thu, Feb 23, 2017 at 12:56 PM, Martin Sebor wrote: On 02/22/2017 05:43 PM, Jason Merrill wrote: On Wed, Feb 22, 2017 at 3:44 PM, Martin Sebor

Re: [PATCH] gcov: Mark BBs that do not correspond to a line in source code (PR gcov-profile/79891).

2017-03-21 Thread Nathan Sidwell
Martin, Richard, I've read up on the thread, but I'm not sure where you guys are with an actual patch. From what I Richard nailed it in BZ with the comment that the BB should not be associated with any source line. That's a new thing, so I think the gcov format needs extending (at least).

Re: [PR59319] output friends in debug info

2017-03-21 Thread Alexandre Oliva
On Jan 27, 2017, Alexandre Oliva wrote: > On Oct 19, 2016, Alexandre Oliva wrote: >> On Sep 23, 2016, Alexandre Oliva wrote: >>> On Aug 30, 2016, Alexandre Oliva wrote: Handling non-template friends is kind of

Re: install.texi and sparc-*-linux*

2017-03-21 Thread Andreas Schwab
On Mär 21 2017, Gerald Pfeifer wrote: > On Sun, 19 Mar 2017, Andreas Schwab wrote: >>> @anchor{sparc-x-linux} >>> @heading sparc-*-linux* >> The section is now empty. Should it be removed at all? > > I considered that, but then figured we do want to keep this as > an

Re: [PATCH][PR target/80123][7 regression] new constraint wA to prevent r0 use in mtvsrdd

2017-03-21 Thread Segher Boessenkool
On Tue, Mar 21, 2017 at 12:57:43PM -0500, Aaron Sawdey wrote: > Both the fails in 80123 are a situation where vsx_splat_ for V2DI > generates rtl for a mtvsrdd but constraint wr doesn't prevent > allocation of r0 for the input. So new constraint wA combines the > attributes of wr and b -- it is

Trunk patches required for gcc-6-branch to build for msp430

2017-03-21 Thread Jozef Lawrynowicz
r244727 and r243310 from the gcc trunk are needed in the gcc-6-branch to build gcc for the msp430 target with C and C++ support. Would it be possible for these patches to be backported to the gcc-6-branch? The gcc-5-branch builds for msp430 with C and C++ support, so isn't this technically a

[PATCH][PR target/80123][7 regression] new constraint wA to prevent r0 use in mtvsrdd

2017-03-21 Thread Aaron Sawdey
Both the fails in 80123 are a situation where vsx_splat_ for V2DI generates rtl for a mtvsrdd but constraint wr doesn't prevent allocation of r0 for the input. So new constraint wA combines the attributes of wr and b -- it is BASE_REGS if 64-bit and NO_REGS otherwise. Currently doing

[PR c++/80091] GCC 6 ICE with generic lambda

2017-03-21 Thread Nathan Sidwell
This patch fixes a gcc 6. In gcc 6 we see an IDENTIFIER for functions (some) member fns that really resolve at parse time. We resolve them to the same thing at instantiation time, so users don't see a problem. Current GCC is cleaned up, so we see the actual decls when we need to. (and if we

Re: [PATCH] Don't cross-jump in between frame related and non-frame related insns (PR target/80102, take 2)

2017-03-21 Thread Jakub Jelinek
On Tue, Mar 21, 2017 at 08:41:43AM +0100, Jakub Jelinek wrote: > On Tue, Mar 21, 2017 at 08:38:20AM +1000, Richard Henderson wrote: > > On 03/21/2017 07:15 AM, Jakub Jelinek wrote: > > > Not really sure what we should do if both i1 and i2 are frame related, > > > shall > > > we check for each of

Re: [PATCH v3, doc] Revise GCC manual section 6.11, Additional Floating Types

2017-03-21 Thread Joseph Myers
On Sun, 19 Mar 2017, Bill Schmidt wrote: > On Fri, 2017-03-17 at 21:44 +, Joseph Myers wrote: > > On Fri, 17 Mar 2017, Bill Schmidt wrote: > > > > > Joseph, any further comments, or may I commit this? > > > > Is there a current patch version somewhere reflecting all comments so far? > > >

Re: [PATCH v2] Fix PR79908

2017-03-21 Thread Christophe Lyon
On 21 March 2017 at 16:54, Bill Schmidt wrote: > On Mar 21, 2017, at 10:18 AM, Christophe Lyon > wrote: >> >> Since this was committed (r246319), I've noticed that >> GCC cross-compiler fails to build glibc for target aarch64-linux-gnu.

Re: [PATCH 1/3] Error message on target attribute on power target (PR target/79906)

2017-03-21 Thread Segher Boessenkool
On Mon, Mar 13, 2017 at 09:23:51AM +0100, marxin wrote: > gcc/ChangeLog: > > 2017-03-13 Martin Liska > > PR target/79906 > * config/rs6000/rs6000.c (rs6000_inner_target_options): Show > error message instead of an ICE. > > gcc/testsuite/ChangeLog: > >

Re: [PATCH v2] Fix PR79908

2017-03-21 Thread Bill Schmidt
On Mar 21, 2017, at 10:18 AM, Christophe Lyon wrote: > > Since this was committed (r246319), I've noticed that > GCC cross-compiler fails to build glibc for target aarch64-linux-gnu. > > I'm seeing: > In function '_IO_vfscanf_internal': > cc1: internal compiler

Re: [PATCH] omp-offload.c: translation fixes (PR translation/80001)

2017-03-21 Thread Jeff Law
On 03/14/2017 07:04 PM, David Malcolm wrote: Successfully bootstrapped on x86_64-pc-linux-gnu. OK for trunk? (either now in stage 4, or for next stage1?) gcc/ChangeLog: PR translation/80001 * omp-offload.c (oacc_loop_fixed_partitions): Make diagnostics more amenable to

Re: [PATCH] have chkp skip flexible member arrays (PR #79986)

2017-03-21 Thread Marek Polacek
On Tue, Mar 21, 2017 at 09:08:49AM -0600, Martin Sebor wrote: > On 03/20/2017 10:27 PM, Jason Merrill wrote: > > On Mon, Mar 20, 2017 at 7:58 PM, Martin Sebor wrote: > > > On 03/20/2017 05:51 PM, Jason Merrill wrote: > > > > On Mon, Mar 20, 2017 at 7:04 PM, Martin Sebor

Re: [PATCH] avoid relying on getcwd extensions (PR 80047)

2017-03-21 Thread Jeff Law
On 03/15/2017 02:29 PM, Martin Sebor wrote: PR 80047 - fixincludes/fixincl.c: PVS-Studio: Improper Release of Memory Before Removing Last Reference (CWE-401) points out that the fixincludes program calls getcwd with the first argument set to NULL, apparently a Glibc extension, to have the

Re: [PATCH] Fix ICE on invalid with -Walloca-larger-than (PR tree-optimization/80109)

2017-03-21 Thread Jeff Law
On 03/20/2017 12:51 PM, Marek Polacek wrote: We crash with this invalid testcase because we aren't properly checking what we are passing down to get_range_info, i.e., we can't pass a pointer. So fixed by checking the argument first, and calling alloca_type_and_limit if it is of a wrong type.

C++ PATCH to fix bogus maybe-uninitialized warning (PR c++/80119)

2017-03-21 Thread Marek Polacek
This patch fixes a bogus maybe-uninitialized warning reported in the PR. The issue is that we're not able to fold away useless CLEANUP_POINT_EXPRs, as e.g. in if (<>) // bogus warning Here, the cleanup_point was built as <>, which cp_fold_r reduces to <>, but leaves it as that and passes it

Re: [PATCH] have chkp skip flexible member arrays (PR #79986)

2017-03-21 Thread Jeff Law
On 03/21/2017 09:15 AM, Jakub Jelinek wrote: On Tue, Mar 21, 2017 at 09:08:49AM -0600, Martin Sebor wrote: As I understand the schedule, the release is expected sometime in early April. I leave on April 2 for a week, so I have only until then. I don't think that leaves enough time. I'd be

Re: [PATCH v2] Fix PR79908

2017-03-21 Thread Christophe Lyon
Hi On 21 March 2017 at 09:03, Richard Biener wrote: > On Mon, Mar 20, 2017 at 8:15 PM, Bill Schmidt > wrote: >> Hi, >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79908 shows a case where >> pass_stdarg ICEs attempting to gimplify a

Re: [PATCH] have chkp skip flexible member arrays (PR #79986)

2017-03-21 Thread Jakub Jelinek
On Tue, Mar 21, 2017 at 09:08:49AM -0600, Martin Sebor wrote: > As I understand the schedule, the release is expected sometime > in early April. I leave on April 2 for a week, so I have only > until then. I don't think that leaves enough time. I'd be > uncomfortable taking on a project this

[PATCH] Fix doloop ICE (PR rtl-optimization/80112)

2017-03-21 Thread Jakub Jelinek
Hi! doloop_condition_get computes cmp in several places, and in one of them wants to fail if the condition inside of it isn't NE against const0_rtx. The problem with that is that nothing checked what cmp is yet, /* Check for (set (pc) (if_then_else (condition)

Re: [PATCH] have chkp skip flexible member arrays (PR #79986)

2017-03-21 Thread Martin Sebor
On 03/20/2017 10:27 PM, Jason Merrill wrote: On Mon, Mar 20, 2017 at 7:58 PM, Martin Sebor wrote: On 03/20/2017 05:51 PM, Jason Merrill wrote: On Mon, Mar 20, 2017 at 7:04 PM, Martin Sebor wrote: Attached is a minimal patch to avoid an ICE in CHKP upon

[committed] Fix can_combine_p (PR target/80125)

2017-03-21 Thread Jakub Jelinek
Hi! As mentioned in the PR, combiner sometimes artificially splits a parallel into two instructions, the first one not really in the insn stream, both with the same uid and PREV_INSN (i1) == 0 and NEXT_INSN (i1) == i2. In that case, calling reg_used_between_p (x, y, i1) crashes the compiler,

Re: Document PR79806 as a non-bug

2017-03-21 Thread Jeff Law
On 03/15/2017 02:29 PM, Bernd Schmidt wrote: I suggest we apply the following and close the PR as INVALID (not a bug). Ok? Agreed. I've already taken care of BZ. So just apply the patch to the trunk. Jeff

RE: [PATCH] Fix MIPS-specific ICE in gcc.dg/pr77834.c (PR rtl-optimization/79150).

2017-03-21 Thread Toma Tabacu
Hi, > From: Segher Boessenkool > On Mon, Mar 20, 2017 at 10:08:25PM +, Moore, Catherine wrote: > > I'm okay with the workaround for stage 4, but would like to see the pr > > remain > open until a proper fix is installed on trunk. > > Yeah. > Sure, I'll keep it open. > > Toma, would you

Re: [Patch, testsuite] Fix failing overflow-1.c for avr

2017-03-21 Thread Georg-Johann Lay
On 21.03.2017 13:31, Georg-Johann Lay wrote: On 21.03.2017 13:07, Senthil Kumar Selvaraj wrote: Hi, The test assumes 32 bit ints, and expects a constant in the dump that is only valid for 32 bit ints. This trivial patch fixes that by explicitly specifying __UINT32_TYPE__ as the type.

Re: [Patch, testsuite] Fix failing overflow-1.c for avr

2017-03-21 Thread Georg-Johann Lay
On 21.03.2017 13:07, Senthil Kumar Selvaraj wrote: Hi, The test assumes 32 bit ints, and expects a constant in the dump that is only valid for 32 bit ints. This trivial patch fixes that by explicitly specifying __UINT32_TYPE__ as the type. Committed as obvious. Regards Senthil

Re: [PATCH][DOC] Document gcov-dump and fix installation of gcov-tool (PR gcov-profile/80081).

2017-03-21 Thread Richard Biener
On Tue, Mar 21, 2017 at 11:55 AM, Martin Liška wrote: > Hello. > > Apart from introduction of gcov-dump.texi file, I also fixed installation of > gcov-tool.1 man page. > Patch can also build PDF documentation. I'm attaching the new man page. Ok. Thanks, Richard. > Thanks, >

[Patch, testsuite] Fix failing overflow-1.c for avr

2017-03-21 Thread Senthil Kumar Selvaraj
Hi, The test assumes 32 bit ints, and expects a constant in the dump that is only valid for 32 bit ints. This trivial patch fixes that by explicitly specifying __UINT32_TYPE__ as the type. Committed as obvious. Regards Senthil gcc/testsuite/ChangeLog 2017-03-21 Senthil Kumar Selvaraj

[PATCH] Fix PR80122

2017-03-21 Thread Richard Biener
Only now we get a testcase using __builtin_va_arg_pack() and friends two levels deep which doesn't work since we (reliably) perform inlining bottom-up. The following fixes the bug by simply not replacing the builtins with garbage in case the caller wasn't passing args but an argument pack

Re: [PATCH] MPX: Fix option handling.

2017-03-21 Thread Martin Liška
On 03/17/2017 01:17 PM, Rainer Orth wrote: > Jakub Jelinek writes: > >> On Fri, Mar 10, 2017 at 02:09:20PM +0100, Martin Liška wrote: >>> Hello. >>> >>> This is follow-up patch which I agreed on with Jakub. >>> It enables CHKP with LSAN and majority of UBSAN options. >>> >>>

RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.

2017-03-21 Thread Toma Tabacu
> > From: Matthew Fortune > > > > I think the skip is OK here. I'd like to get Catherine's opinion on > > this though too. I don't think we should change the definition of __PIC__ > > for -fPIC on MIPS as multi-got solves 'most' issues. If we start trying to > > figure out what __PIC__ should mean

[PATCH] Fix another profiledbootstrap warning (PR libfortran/79956).

2017-03-21 Thread Martin Liška
Hello. Currently running tests and as the patch is pre-approved by Richi, I'm going to install it afterwards. Martin >From 78af53942b50d6bb47959d263336072f1d7ff6ed Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 21 Mar 2017 11:57:27 +0100 Subject: [PATCH] Fix another

[PATCH][DOC] Document gcov-dump and fix installation of gcov-tool (PR gcov-profile/80081).

2017-03-21 Thread Martin Liška
Hello. Apart from introduction of gcov-dump.texi file, I also fixed installation of gcov-tool.1 man page. Patch can also build PDF documentation. I'm attaching the new man page. Thanks, Martin >From f86849be31029555efee8f5f7b8157ae7d468519 Mon Sep 17 00:00:00 2001 From: marxin

Re: [PATCH][AArch64] Optimized implementation of search_line_fast for the CPP lexer

2017-03-21 Thread Richard Earnshaw (lists)
On 20/03/17 17:27, Andreas Schwab wrote: > On Mär 20 2017, "Richard Earnshaw (lists)" wrote: > >> I don't have access to an ILP32 run-time environment, so I'm not sure >> how I'll be able to check this out. There are some pointer checks in >> the code so it's possible

Re: Patch for GCC plugin hash table corruption bug (ID 80094)

2017-03-21 Thread Richard Biener
On Tue, Mar 21, 2017 at 12:05 AM, Brad Spengler wrote: > Hi, > > As requested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80094 > i'm attaching a patch for the issue described. > > Specifically: > when the plugin_name_args_tab hash table has its 11th entry inserted, it

Re: [PATCH 2/3] Error message on target attribute on aarch64 target (PR target/79889).

2017-03-21 Thread Kyrill Tkachov
Hi Martin, On 13/03/17 08:25, marxin wrote: gcc/testsuite/ChangeLog: 2017-03-13 Martin Liska * g++.dg/ext/mv8.C: Add aarch64* targets. gcc/ChangeLog: 2017-03-13 Martin Liska * config/aarch64/aarch64.c (aarch64_process_target_attr):

Re: [PATCH 2/3] Error message on target attribute on aarch64 target (PR target/79889).

2017-03-21 Thread Martin Liška
PING^ + adding aarch64 maintainer. Thanks, Martin

Re: [PATCH 1/3] Error message on target attribute on power target (PR target/79906)

2017-03-21 Thread Martin Liška
PING^ + adding power maintainer. Thanks, Martin

Re: [PATCH] Fix -fsanitize=thread with -fnon-call-exceptions (PR sanitizer/80110)

2017-03-21 Thread Richard Biener
On Tue, 21 Mar 2017, Jakub Jelinek wrote: > On Tue, Mar 21, 2017 at 09:12:51AM +0100, Richard Biener wrote: > > > libtsan atomics aren't throwing, so if we transform atomics which > > > are throwing with -fnon-call-exceptions, we need to clean up EH stuff. > > > > > > Bootstrapped/regtested on

Re: [PATCH] Fix PR80032 - handle CLOBBER gimplification differently

2017-03-21 Thread Richard Biener
On Mon, 20 Mar 2017, Jakub Jelinek wrote: > On Fri, Mar 17, 2017 at 02:42:27PM +0100, Richard Biener wrote: > > 2017-03-17 Richard Biener > > > > PR tree-optimization/80032 > > * gimplify.c (gimple_push_cleanup): Add force_uncond parameter, > > if set force the

Re: [PATCH] Fix -fsanitize=thread with -fnon-call-exceptions (PR sanitizer/80110)

2017-03-21 Thread Jakub Jelinek
On Tue, Mar 21, 2017 at 09:12:51AM +0100, Richard Biener wrote: > > libtsan atomics aren't throwing, so if we transform atomics which > > are throwing with -fnon-call-exceptions, we need to clean up EH stuff. > > > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > Huh,

Re: [PATCH] Fix -fsanitize=thread with -fnon-call-exceptions (PR sanitizer/80110)

2017-03-21 Thread Richard Biener
On Mon, 20 Mar 2017, Jakub Jelinek wrote: > Hi! > > libtsan atomics aren't throwing, so if we transform atomics which > are throwing with -fnon-call-exceptions, we need to clean up EH stuff. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Huh, but this means with TSAN

Re: [PATCH] Fix -fsanitize=thread -O0 handling of atomics (PR sanitizer/78158)

2017-03-21 Thread Richard Biener
On Mon, 20 Mar 2017, Jakub Jelinek wrote: > Hi! > > libtsan only handles the standard memory model values, so I've added > just in case some new unknown memory model is used bail outs (keeping > the __atomic_* builtins instead of transforming them to __tsan_atomic*). > Except that at -O0 (or if

Re: [PATCH] Fix UB in round_up_loc (PR c/67338)

2017-03-21 Thread Richard Biener
On Mon, 20 Mar 2017, Jakub Jelinek wrote: > Hi! > > divisor is unsigned int parameter, if it is 0x8000, we invoke UB. > val is wide_int, so (int) -divisor achieves the same result without UB. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Ok. Thanks, Richard. >

Re: [PATCH v2] Fix PR79908

2017-03-21 Thread Richard Biener
On Mon, Mar 20, 2017 at 8:15 PM, Bill Schmidt wrote: > Hi, > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79908 shows a case where > pass_stdarg ICEs attempting to gimplify a COMPLEX_EXPR with side > effects as an lvalue. This occurs when the LHS of a VA_ARG has

[PATCH] Don't cross-jump in between frame related and non-frame related insns (PR target/80102, take 2)

2017-03-21 Thread Jakub Jelinek
On Tue, Mar 21, 2017 at 08:38:20AM +1000, Richard Henderson wrote: > On 03/21/2017 07:15 AM, Jakub Jelinek wrote: > > Not really sure what we should do if both i1 and i2 are frame related, shall > > we check for each of the CFA reg notes if they are available and equal? > > Or punt if either of

Re: [C++ PATCH] PR c++/35878

2017-03-21 Thread Ville Voutilainen
On 21 March 2017 at 09:17, Jakub Jelinek wrote: > I've tested in the mean time the following patch with both gcc from yesterday > where > pr35878_3.C fails as expected, and with the latest cc1plus where > it succeeds both with -m32 and -m64. Scanning the tree dump has the >

Re: [C++ PATCH] PR c++/35878

2017-03-21 Thread Jakub Jelinek
On Tue, Mar 21, 2017 at 09:03:54AM +0200, Ville Voutilainen wrote: > On 21 March 2017 at 08:55, Ville Voutilainen > wrote: > >>> +// { dg-options "-O2 --std=gnu++11" } > >> > >> -O2 -std=gnu++11 is enough, no need for double dash --std=gnu++11. > >> > >>> +// { dg-do

Re: [C++ PATCH] PR c++/35878

2017-03-21 Thread Ville Voutilainen
On 21 March 2017 at 08:55, Ville Voutilainen wrote: >>> +// { dg-options "-O2 --std=gnu++11" } >> >> -O2 -std=gnu++11 is enough, no need for double dash --std=gnu++11. >> >>> +// { dg-do compile } >>> +// { dg-final { scan-assembler "test.*%rdi, %rdi" { target

Re: [C++ PATCH] PR c++/35878

2017-03-21 Thread Ville Voutilainen
On 21 March 2017 at 08:48, Jakub Jelinek wrote: > Formatting etc. nits: > >> 2017-03-21 Ville Voutilainen >> >> gcc/ >> >> PR c++/35878 > > This should go into gcc/cp/ ChangeLog > >> * cp/init.c (std_placement_new_fn_p): New. > >

Re: [C++ PATCH] PR c++/35878

2017-03-21 Thread Jakub Jelinek
Hi! On Tue, Mar 21, 2017 at 03:21:11AM +0200, Ville Voutilainen wrote: Formatting etc. nits: > 2017-03-21 Ville Voutilainen > > gcc/ > > PR c++/35878 This should go into gcc/cp/ ChangeLog > * cp/init.c (std_placement_new_fn_p): New. without cp/