Re: [PATCH] replace ICE with error for failed template deduction (PR 84355)

2018-02-23 Thread Jason Merrill
On Sun, Feb 18, 2018 at 11:39 PM, Jason Merrill wrote: > On Fri, Feb 16, 2018 at 4:33 PM, Martin Sebor wrote: >> On 02/16/2018 07:04 AM, Jason Merrill wrote: >>> >>> On Thu, Feb 15, 2018 at 6:36 PM, Martin Sebor wrote: A failed template deduction in template member of a template t

Re: C++ PATCH to fix rejects-valid with constexpr ctor in C++17 (PR c++/83692)

2018-02-23 Thread Jason Merrill
OK, thanks. On Fri, Feb 23, 2018 at 9:29 AM, Marek Polacek wrote: > On Fri, Feb 16, 2018 at 04:10:20PM -0500, Jason Merrill wrote: >> On Mon, Feb 5, 2018 at 1:45 PM, Jason Merrill wrote: >> > On Mon, Feb 5, 2018 at 8:37 AM, Marek Polacek wrote: >> >> On Fri, Feb 02, 2018 at 02:11:27PM -0500, Ja

[PATCH] PR fortran/30792 -- Substring data-implied-do is invalid

2018-02-23 Thread Steve Kargl
The attached patch fixes PR fortran/30792. A substring reference is invalid for a data-implied-do. Regression tested on x86_64-*-freebsd. OK to commit. 2018-02-23 Steven G. Kargl PR fortran/30792 * decl.c (gfc_match_data): Check for invalid substring in data-implied-d

[PATCH] PR libstdc++/84532 prevent unwrapping of reference_wrapper arguments

2018-02-23 Thread Jonathan Wakely
When I refactored the std::thread internals I made it use std::make_tuple, which rather than just DECAY_COPYing the arguments it also unwraps any std::reference_wrapper arguments, which is wrong. This constructs a std::tuple of the decayed types, instead of using make_tuple, so that reference_wrapp

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

2018-02-23 Thread Martin Sebor
On 02/23/2018 02:54 PM, Jakub Jelinek wrote: On Fri, Feb 23, 2018 at 02:46:28PM -0700, Martin Sebor wrote: This doesn't address any of my concerns that it is completely random what {dst,src}ref->base is, apples and oranges; sometimes it is a pointer (e.g. the argument of the function), sometimes

Re: Merge from trunk to gccgo branch

2018-02-23 Thread Ian Lance Taylor
I merged trunk revision 257954 to the gccgo branch. Ian

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Martin Sebor
On 02/23/2018 01:32 PM, Siddhesh Poyarekar wrote: On Saturday 24 February 2018 01:32 AM, Martin Sebor wrote: Casting the address of a function that takes one or more arguments to one that takes fewer is unsafe because when the pointer is used to call the function the extra arguments have indeter

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

2018-02-23 Thread Martin Sebor
On 02/23/2018 01:13 PM, Jakub Jelinek wrote: On Fri, Feb 23, 2018 at 12:57:14PM -0700, Martin Sebor wrote: + /* get_inner_reference is not expected to return null. */ + gcc_assert (base != NULL); + poly_int64 bytepos = exact_div (bitpos, BITS_PER_UNIT); - HOST_WIDE_INT const_off; - if (

Go patch committed: Ignore aliases in fieldtracking info

2018-02-23 Thread Ian Lance Taylor
This patch to the Go frontend ignores aliases when emitting fieldtracking info. We want to track references to fields in the real struct, not in some alias to the struct. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-23 Thread H.J. Lu
On Thu, Feb 22, 2018 at 9:32 AM, H.J. Lu wrote: > On Thu, Feb 22, 2018 at 9:10 AM, Jeff Law wrote: >> On 02/22/2018 07:38 AM, Jan Hubicka wrote: >> >> Hi Jan, >> >> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg02233.html >> >> Is OK for trunk? > > I see that using

[PATCH] Fix up ipa_vr_ggc_hash_traits::hash

2018-02-23 Thread Jakub Jelinek
Hi! ipa_vr_ggc_hash_traits::equal does return a->type == b->type && a->min == b->min && a->max == b->max; so it requires pointer identical type (5 value enum) and min/max, hopefully only INTEGER_CSTs. Honza complained on IRC that during firefox a lot of time is spent in this hash table, probabl

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

2018-02-23 Thread Jakub Jelinek
On Fri, Feb 23, 2018 at 12:57:14PM -0700, Martin Sebor wrote: > + /* get_inner_reference is not expected to return null. */ > + gcc_assert (base != NULL); > + >poly_int64 bytepos = exact_div (bitpos, BITS_PER_UNIT); > > - HOST_WIDE_INT const_off; > - if (!base || !bytepos.is_constant (&c

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Siddhesh Poyarekar
On Saturday 24 February 2018 01:32 AM, Martin Sebor wrote: > Casting the address of a function that takes one or more arguments > to one that takes fewer is unsafe because when the pointer is used > to call the function the extra arguments have indeterminate values. > (This is also why void(*)(void

[Committed] Update Fortran MATMUL documentation

2018-02-23 Thread Steve Kargl
I've committed the following patch after a 'make pdf' to verify that the change is formatted correctly. The patch updates the documentation for Fortran's MATMUL intrinsic. 2018-02-23 Steven G. Kargl * intrinsic.texi: Arguments to MATMUL cannot both be rank one. Index: intrinsic.texi

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Martin Sebor
On 02/23/2018 11:52 AM, Siddhesh Poyarekar wrote: On Saturday 24 February 2018 12:01 AM, Richard Biener wrote: I don't see how the function cast is valid. I've argued for void (*) () to/from void (*) (int), etc. In the past and that was shot down similarly. This looks like exactly the same thi

[PATCH] fix ICE in generic_overlap (PR 84526)

2018-02-23 Thread Martin Sebor
r257860 introduced an unsafe assumption under some conditions that the base object referenced by a memcpy strcpy necessarily has a pointer or array type. The attached patch removes this assumption. In addition, as discussed in the bug and in IRC, the patch also removes a test for the result of g

[PATCH,AIX] aix71.h Increase ISA default

2018-02-23 Thread David Edelsohn
AIX 7.1 minimum hardware is Power6. This patch changes TARGET_DEFAULT to ISA 2.05. Thanks, David * config/rs6000/aix71.h (TARGET_DEFAULT): Change to ISA_2_5_MASKS_EMBEDDED. Index: aix71.h === --- aix71.h (revision 257941) +++ a

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Siddhesh Poyarekar
On Saturday 24 February 2018 12:01 AM, Richard Biener wrote: > I don't see how the function cast is valid. > > I've argued for void (*) () to/from void (*) (int), etc. In the past and that > was shot down similarly. This looks like exactly the same thing. That should not throw a warning becaus

Re: [Patch, fortran] PR83149 [8 Regression] ICE on SELECT CASE: crash_signal in toplev.c:325

2018-02-23 Thread Steve Kargl
On Fri, Feb 23, 2018 at 06:08:23PM +, Paul Richard Thomas wrote: > > The original bug is fixed as 'obvious' in revision 257938. This is > indeed a regression. > > The bug in comments 2 and 7 is fixed in revision 257934. This, > however, is not a regression. The summary will be changed accordi

Re: [PATCH] Add sanitizer support for AArch64 ILP32

2018-02-23 Thread Adhemerval Zanella
On 23/02/2018 11:39, Jakub Jelinek wrote: > On Fri, Feb 23, 2018 at 11:27:19AM -0300, Adhemerval Zanella wrote: >> This patch adds asan support for aarch64 ilp32. It is based on 'official' >> glibc support branch [1] (which is in turn based on Linux branch [2]). >> >> Main changes for libsanitiz

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Richard Biener
On February 23, 2018 5:12:23 PM GMT+01:00, Siddhesh Poyarekar wrote: >On Friday 23 February 2018 09:20 PM, David Malcolm wrote: >> Do we have a PR open for this yet? >> >> I believe this is an example of where this bit (for the Python case): >> https://github.com/imageworks/OpenColorIO/pull/51

Fix overflow in lto-partition.c

2018-02-23 Thread Jan Hubicka
Hi, this patch fixes fork bomb gcc turns into when you compile firefox with LTO and profile feedback. We put partition size to INT_MAX to avoid creation of new partition but because we compute partition_size * 3 / 2 we end up with negative bound and producing individual partition for every new sym

Re: [PATCH] Fix up ipa_vr_ggc_hash_traits::hash

2018-02-23 Thread Richard Biener
On February 23, 2018 6:06:51 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >ipa_vr_ggc_hash_traits::equal does > return a->type == b->type && a->min == b->min && a->max == b->max; >so it requires pointer identical type (5 value enum) and min/max, >hopefully only INTEGER_CSTs. Honza complained on IR

[Patch, fortran] PR83149 [8 Regression] ICE on SELECT CASE: crash_signal in toplev.c:325

2018-02-23 Thread Paul Richard Thomas
Hi All, The original bug is fixed as 'obvious' in revision 257938. This is indeed a regression. The bug in comments 2 and 7 is fixed in revision 257934. This, however, is not a regression. The summary will be changed accordingly. The 'obvious' tag comes about because both bugs have a common orig

[PATCH] Fix *{add,sub,and,ior,xor}v*3 patterns on AVX512* (PR target/84524)

2018-02-23 Thread Jakub Jelinek
Hi! The following testcase is miscompiled with -O3 -mavx512bw, the combiner sees there isn't just *xorv32hi3 define_insn with no masking, but that there is one with masking as well (with the same name) and uses it, but 1) such instruction doesn't really exist, for masking we only have VPXORD and V

Re: [patch, fortran] Bug 84506 - [6/7/8 Regression]INQUIRE(pos=) always sets pos=0 with -fdefault-integer-8

2018-02-23 Thread Steve Kargl
On Fri, Feb 23, 2018 at 08:27:18AM -0800, Jerry DeLisle wrote: > > I will back port to 6 an 7 after approval here. I will use the case in > the PR as a new test case. > > OK for trunk? > > Regards, > > Jerry > > 2018-02-23 Jerry DeLisle > > PR fortran/84506 > * trans-io.c (set

Re: [PATCH] correct -Wrestrict handling of arrays of arrays (PR 84095)

2018-02-23 Thread Jakub Jelinek
On Fri, Feb 23, 2018 at 08:52:19AM -0700, Martin Sebor wrote: > There are a large number of failures in these reports in many > tests that were reported previously (before r257910), suggesting > something else is wrong. They all seem to use -fpic. > > If you referring to some other report or your

Re: [PATCH] Add sanitizer support for AArch64 ILP32

2018-02-23 Thread Jakub Jelinek
On Fri, Feb 23, 2018 at 11:27:19AM -0300, Adhemerval Zanella wrote: > This patch adds asan support for aarch64 ilp32. It is based on 'official' > glibc support branch [1] (which is in turn based on Linux branch [2]). > > Main changes for libsanitizer is the kernel ABI support for internal > sysca

Fwd: Re: [PATCH] PR fortran/84511 -- Fix C_LOC in a transfer statement

2018-02-23 Thread Jerry DeLisle
Forwarded Message Subject: Re: [PATCH] PR fortran/84511 -- Fix C_LOC in a transfer statement Date: Fri, 23 Feb 2018 08:30:29 -0800 From: Jerry DeLisle To: s...@troutmask.apl.washington.edu On 02/22/2018 12:01 PM, Steve Kargl wrote: All, The attached patch handles C_LOC in

Re: [PATCH, rs6000] Update altivec-7 testcase(s).

2018-02-23 Thread Will Schmidt
On Thu, 2018-02-22 at 12:06 -0600, Segher Boessenkool wrote: > Hi Will, > > On Wed, Feb 21, 2018 at 11:33:14AM -0600, Will Schmidt wrote: > > This patch moves the vsx related content from the altivec-7-be test into > > a new vsx-7-be test. > > This fixes up some test failures as seen on older po

Re: [PATCH] Correct debug for -mcall-ms2sysv-xlogues stubs (PR target/83917, take 2)

2018-02-23 Thread Jakub Jelinek
On Thu, Feb 22, 2018 at 03:56:15PM +0100, Jakub Jelinek wrote: > Ok for trunk if it passes bootstrap/regtest on x86_64-linux and i686-linux? Now successfully bootstrapped/regtested on these targets. > 2018-02-22 Jakub Jelinek > > PR debug/83917 > * config/i386/i386-asm.h (PACKAGE_

[patch, fortran] Bug 84506 - [6/7/8 Regression]INQUIRE(pos=) always sets pos=0 with -fdefault-integer-8

2018-02-23 Thread Jerry DeLisle
Hi Folks, This bug is a result of a range check we do on kind=8 unit numbers to make sure they fall within the range values of a kind=4 integer. We were limiting this range to positive values. I think when we introduced the newunit feature which uses negative unit values, we missed this adjust

Re: [PATCH] correct -Wrestrict handling of arrays of arrays (PR 84095)

2018-02-23 Thread Siddhesh Poyarekar
On Friday 23 February 2018 09:22 PM, Martin Sebor wrote: > I see no failures in this test in any of the recently reported > results on any targets except those below: > >   https://gcc.gnu.org/ml/gcc-testresults/2018-02/msg01530.html >   https://gcc.gnu.org/ml/gcc-testresults/2018-02/msg01514.html

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Siddhesh Poyarekar
On Friday 23 February 2018 09:20 PM, David Malcolm wrote: > Do we have a PR open for this yet? > > I believe this is an example of where this bit (for the Python case): > https://github.com/imageworks/OpenColorIO/pull/518 There is now: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84531 Siddhe

Re: [PATCH][committed] Fix ICE in maybe_record_trace_start

2018-02-23 Thread Jeff Law
On 02/22/2018 03:59 AM, Tom de Vries wrote: > On 02/12/2018 07:32 PM, Jeff Law wrote: >> diff --git a/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c >> b/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c >> new file mode 100644 >> index 000..0ca0b9f034b >> --- /dev/null >> +++ b/gcc/

Re: [PATCH] correct -Wrestrict handling of arrays of arrays (PR 84095)

2018-02-23 Thread Martin Sebor
On 02/22/2018 08:17 PM, Siddhesh Poyarekar wrote: On Friday 02 February 2018 05:15 AM, Martin Sebor wrote: PR middle-end/84095 - false-positive -Wrestrict warnings for memcpy within array gcc/ChangeLog: PR middle-end/84095 * gimple-ssa-warn-restrict.c (builtin_memref::extend_of

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread David Malcolm
On Fri, 2018-02-23 at 09:10 +0530, Siddhesh Poyarekar wrote: > Libraries like gtk/glib[1] and python[2] use functions with common > argument subsets to register callbacks. The working idea behind it > is > to have a flag in the structure (or some other pre-determined method) > that specifies how t

Re: [Patch AArch64] Turn on frame pointer / partial fix for PR84521

2018-02-23 Thread David Malcolm
On Fri, 2018-02-23 at 11:32 +, Ramana Radhakrishnan wrote: > This fixes a GCC-8 regression that we accidentally switched off frame > pointers in the AArch64 backend when changing the defaults in the > common > parts of the code. This breaks an ABI decision that was made in GCC > at > the dawn o

Re: [config patch] Fwd from binutils: add ax_pthread.m4 to config/ directory

2018-02-23 Thread Joshua Watt
On Mon, 2018-02-19 at 17:24 -0800, Cary Coutant wrote: > Please see this patch posted to the binutils list: > >https://sourceware.org/ml/binutils/2018-02/msg00260.html > > where Joshua proposes to add the ax_pthread.m4 script, from the > autoconf macro archive, to the config/ directory in ord

Re: [Patch AArch64] Turn on frame pointer / partial fix for PR84521

2018-02-23 Thread Jakub Jelinek
On Fri, Feb 23, 2018 at 11:32:57AM +, Ramana Radhakrishnan wrote: > This fixes a GCC-8 regression that we accidentally switched off frame > pointers in the AArch64 backend when changing the defaults in the common > parts of the code. This breaks an ABI decision that was made in GCC at > the daw

Re: C++ PATCH to fix rejects-valid with constexpr ctor in C++17 (PR c++/83692)

2018-02-23 Thread Marek Polacek
On Fri, Feb 16, 2018 at 04:10:20PM -0500, Jason Merrill wrote: > On Mon, Feb 5, 2018 at 1:45 PM, Jason Merrill wrote: > > On Mon, Feb 5, 2018 at 8:37 AM, Marek Polacek wrote: > >> On Fri, Feb 02, 2018 at 02:11:27PM -0500, Jason Merrill wrote: > >>> On Thu, Jan 25, 2018 at 4:16 PM, Marek Polacek

[PATCH] Add sanitizer support for AArch64 ILP32

2018-02-23 Thread Adhemerval Zanella
This patch adds asan support for aarch64 ilp32. It is based on 'official' glibc support branch [1] (which is in turn based on Linux branch [2]). Main changes for libsanitizer is the kernel ABI support for internal syscalls. Different than x32, ILP32 tries to leverage 32-bits syscalls with kernel

[PATCH] Fix tsan race_on_mutex.c testcase (PR80551)

2018-02-23 Thread Segher Boessenkool
The testcase did not match the glibc internal names while it should. This fixes it. Pre-approved by Jakub in the PR; committing. Segher 2018-02-23 Segher Boessenkool gcc/testsuite/ PR testsuite/80551 * c-c++-common/tsan/race_on_mutex.c: Change regexp to allow __GI__

C++ PATCH for c++/70468, ICE with constructor delegation via typedef.

2018-02-23 Thread Jason Merrill
tsubst_initializer_list needs the same error checking as cp_parser_mem_initializer_list. Tested x86_64-pc-linux-gnu, applying to trunk. commit f51f20ad47d24aee54bfbe26f31c48e0f8a78def Author: Jason Merrill Date: Thu Feb 22 18:06:53 2018 -0500 PR c++/70468 - ICE with constructor del

[Patch, fortran] PR83148 [8 regression] ICE: crash_signal from toplev.c:325

2018-02-23 Thread Paul Richard Thomas
Committed as 'obvious' in revision 257930. Cheers Paul 2018-02-23 Paul Thomas PR fortran/83148 * trans-const.c : Clean up some whitespace issues. * trans-expr.c (gfc_conv_initializer): If an iso_c_binding derived type has a kind value of zero, set it to the default intege

Re: [Patch AArch64] Turn on frame pointer / partial fix for PR84521

2018-02-23 Thread James Greenhalgh
On Fri, Feb 23, 2018 at 11:32:57AM +, Ramana Radhakrishnan wrote: > This fixes a GCC-8 regression that we accidentally switched off frame > pointers in the AArch64 backend when changing the defaults in the common > parts of the code. This breaks an ABI decision that was made in GCC at > the daw

[Patch AArch64] Turn on frame pointer / partial fix for PR84521

2018-02-23 Thread Ramana Radhakrishnan
This fixes a GCC-8 regression that we accidentally switched off frame pointers in the AArch64 backend when changing the defaults in the common parts of the code. This breaks an ABI decision that was made in GCC at the dawn of the port with respect to having a frame pointer at all times. If we real

Re: [PATCH] PR 84519 Handle optional QUIET specifier for STOP and ERROR STOP

2018-02-23 Thread Janne Blomqvist
On Thu, Feb 22, 2018 at 10:16 PM, Steve Kargl wrote: > On Thu, Feb 22, 2018 at 09:42:02PM +0200, Janne Blomqvist wrote: >> Fortran 2018 adds a new QUIET specifier for the STOP and ERROR STOP >> statements, in order to suppress the printing of signaling FP >> exceptions and the stop code. This patc