Re: [C++ Patch] Fix confusing diagnostics for invalid overrides

2018-03-25 Thread Volker Reichelt
On 03/25/2018 08:48 PM, Paolo Carlini wrote: Hi Volker On 25 Mar 2018, at 16:18, Volker Reichelt wrote: Hi, when overriding a virtual function fails, the C++ front-end usually emits two errors: one for the override that fails and one for the function that is

Re: [C++ Patch] Fix confusing diagnostics for invalid overrides

2018-03-25 Thread Paolo Carlini
On 25/03/2018 21:08, Paolo Carlini wrote: ... oh, please also double check that with 'F' you don't need the general location_of instead of D_S_L, which normally goes with 'D' - I don't have my machines at hand to do it myself, sorry. Just checked, DECL_SOURCE_LOCATION is fine. Paolo.

Re: [C++ Patch] Fix confusing diagnostics for invalid overrides

2018-03-25 Thread Paolo Carlini
... oh, please also double check that with 'F' you don't need the general location_of instead of D_S_L, which normally goes with 'D' - I don't have my machines at hand to do it myself, sorry. Paolo

Re: [patch, fortran] Fix character parameter arrays as formats

2018-03-25 Thread Jerry DeLisle
On 03/25/2018 09:11 AM, Thomas Koenig wrote: Hello world, the attached pach fixes the PR by creating one single big string from a parameter array. OK for trunk? Nice, you put it right where I thought it should go in resolution. Yes, OK, Thanks Jerry

Re: [C++ Patch] Fix confusing diagnostics for invalid overrides

2018-03-25 Thread Paolo Carlini
Hi Volker > On 25 Mar 2018, at 16:18, Volker Reichelt wrote: > > Hi, > > when overriding a virtual function fails, the C++ front-end usually > emits two errors: one for the override that fails and one for the > function that is overridden. The second error is

Re: [Patch, fortran] PR84931 - Expansion of array constructor with constant implied-do-object goes sideways

2018-03-25 Thread Thomas König
Hi Paul, Bootstraps and regtests on FC27/x86_64 - OK for trunk, 7- and 6-branches? OK, and thanks for catching these extra cases! In general, I think we should not modifying original test case unless it is necessary, so I would prefer if you could add the extra tests to a separate test case.

[patch, fortran] Fix character parameter arrays as formats

2018-03-25 Thread Thomas Koenig
Hello world, the attached pach fixes the PR by creating one single big string from a parameter array. OK for trunk? Regards Thomas 2018-03-25 Thomas Koenig PR fortran/66709 * io.c: Include constructor.h. (resolve_tag_format): For a

Re: [patch, libgomp testsuite] Replace non-standard call abort by STOP n

2018-03-25 Thread Dominique d'Humières
Hi Thomas, The ChangeLog looks strange, but otherwise the patch applies and get rid of the abort. Looks good to me. Thanks for the work, Dominique

[patch, libgomp testsuite] Replace non-standard call abort by STOP n

2018-03-25 Thread Thomas Koenig
[This is take two, the first one was rejected due to size]. Hello world, the does what the ChangeLog and the Subject say. Regression-tested on x86_64-pc-linux-gnu. OK for trunk? Regards Thomas 2018-03-25 Thomas Koenig PR fortran/84381 *

[C++ Patch] Fix confusing diagnostics for invalid overrides

2018-03-25 Thread Volker Reichelt
Hi, when overriding a virtual function fails, the C++ front-end usually emits two errors: one for the override that fails and one for the function that is overridden. The second error is confusing and should be replaced by a note to be in line with other diagnostics. The attached patch just

[Patch, fortran] PR84931 - Expansion of array constructor with constant implied-do-object goes sideways

2018-03-25 Thread Paul Richard Thomas
Thomas already committed a fix for the original problem (revisions 258641, 258666 & 258667). However, I found another testcase that still failed - that of multiple array constructors with iterators, within an array constructor without an iterator. The attached fixes this and streamlines the

Re: [patch fortran] PR 84924 - Erroneous error in C_F_POINTER

2018-03-25 Thread Dominique d'Humières
Thanks for the quick review. Committed as revision r258843. Dominique > Le 25 mars 2018 à 13:20, Thomas König a écrit : > > Hi Dominique, > >> The attached patch allows scalar noninteroperable scalar derived type with >> -std=f2003 and -std=f2008. >> Regstrapped on

Re: [patch fortran] PR 84924 - Erroneous error in C_F_POINTER

2018-03-25 Thread Thomas König
Hi Dominique, The attached patch allows scalar noninteroperable scalar derived type with -std=f2003 and -std=f2008. Regstrapped on x86_64-apple-darwin17. OK for trunk? OK. Regards Thomas

[patch fortran] PR 84924 - Erroneous error in C_F_POINTER

2018-03-25 Thread Dominique d'Humières
The attached patch allows scalar noninteroperable scalar derived type with -std=f2003 and -std=f2008. Regstrapped on x86_64-apple-darwin17. OK for trunk? Regards, Dominique 2018-03-25 Seth Johnson Dominique d'Humieres PR

[patch, fortran] Simplify constants which come from parameter arrays

2018-03-25 Thread Thomas König
Hello world, the attached patch potentially saves some space in the object file by simplifying access to individual elements of a parameter array, which means that the original parameter may not be needed any more. Regression-tested. OK for trunk? Regards Thomas 2018-03-25 Thomas

New Swedish PO file for 'gcc' (version 8.1-b20180128)

2018-03-25 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Swedish team of translators. The file is available at: http://translationproject.org/latest/gcc/sv.po (This file, 'gcc-8.1-b20180128.sv.po',

[testsuite, committed] Make scan pattern more precise in vrp104.c

2018-03-25 Thread Tom de Vries
[ was: Re: [PATCH][RFC] Make expansion of balanced binary trees of switches on tree level. ] On 08/30/2017 01:10 PM, Martin Liška wrote: diff --git a/gcc/testsuite/gcc.dg/tree-ssa/vrp104.c b/gcc/testsuite/gcc.dg/tree-ssa/vrp104.c index aa3b00a1204..0a952267b29 100644 ---