Re: [doc PATCH] document when GCC ignores attribute aligned

2018-12-03 Thread Sandra Loosemore
On 12/3/18 8:23 PM, Martin Sebor wrote: Last week we agreed to clarify that attribute aligned on a function can decrease its alignment if it hasn't been previously declared with one.  Attached is this change. Besides the above, I also mention that the attribute specifies the alignment of the

Re: [doc PATCH] update attribute docs for C++

2018-12-03 Thread Sandra Loosemore
On 12/3/18 4:23 PM, Martin Sebor wrote: gcc/ChangeLog: * doc/extend.texi (attribute const, pure): Clarify. Index: gcc/doc/extend.texi === --- gcc/doc/extend.texi (revision 266766) +++ gcc/doc/extend.texi (working copy) @@

Fix move_if_noexcept usages in _Hashtable

2018-12-03 Thread François Dumont
Hi   This patch fix a minor problem with usage of std::move_if_noexcept. We use it to move node content if move construtor is noexcept but we eventually use the allocator_type::construct method which might be slightly different. I think it is better to check for this method noexcept

Re: [doc,committed] clarify docs for function attribute "const"

2018-12-03 Thread Sandra Loosemore
On 12/3/18 2:47 PM, Martin Sebor wrote: [snip] Attached is my proposed update.  The user's email suggested going into a lot of detail that I'm not sure would be helpful.  I think it's safer to keep it simple than to try to carefully outline tricky conditions under which some const or pure

Re: [Patch, ppc/darwin 1/2] Fix bootstrap.

2018-12-03 Thread Alan Modra
On Mon, Dec 03, 2018 at 07:14:36PM +, Iain Sandoe wrote: > > > On 3 Dec 2018, at 06:18, Alan Modra wrote: > > > > On Mon, Dec 03, 2018 at 01:26:48AM +, Iain Sandoe wrote: > > >> The first patch makes Darwin share the sysv lowering, up until late in the > >> process when we still use

Re: [RFC][AArch64] Add support for system register based stack protector canary access

2018-12-03 Thread Wilco Dijkstra
Hi, Florian wrote: > For userland, I would like to eventually copy the OpenBSD approach for > architectures which have some form of PC-relative addressing: we can > have multiple random canaries in (RELRO) .rodata in sufficiently close > to the code that needs them (assuming that we have split

[doc PATCH] document when GCC ignores attribute aligned

2018-12-03 Thread Martin Sebor
Last week we agreed to clarify that attribute aligned on a function can decrease its alignment if it hasn't been previously declared with one. Attached is this change. Besides the above, I also mention that the attribute specifies the alignment of the first instruction of the function (in case

Re: [PATCH v3] Make function clone name numbering independent.

2018-12-03 Thread Michael Ploujnikov
On 2018-12-03 12:00 p.m., Michael Ploujnikov wrote: > On 2018-12-01 11:29 a.m., H.J. Lu wrote: >> This caused: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88297 >> > > Sorry about that. Looks like I should have been testing with > --with-build-config=bootstrap-lto rather than just

Re: [patch,opencc] Don't mark OpenACC auto loops as independent inside acc parallel regions

2018-12-03 Thread Julian Brown
On Thu, 20 Sep 2018 09:49:43 -0700 Cesar Philippidis wrote: > OpenACC as a concept of loop independence, in which independent loops > may be executed in parallel across gangs, workers and vectors. Inside > acc parallel regions, if a loop isn't explicitly marked seq or auto, > it is predetermined

Re: [patch,openacc] Set safelen to INT_MAX for oacc independent pragma

2018-12-03 Thread Julian Brown
On Thu, 20 Sep 2018 11:21:28 -0700 Cesar Philippidis wrote: > This is another old gomp4 OpenACC patch which impacts targets that use > simd vectorization, such as the host and AMD GCN, rather than nvptx. > Basically, as the subject states, it sets safelen to INT_MAX for > independent acc loops,

Re: [patch,openacc] Propagate independent clause for OpenACC kernels pass

2018-12-03 Thread Julian Brown
On Thu, 20 Sep 2018 11:06:40 -0700 Cesar Philippidis wrote: > This is another old patch teaches the omp expansion pass how to > propagate the acc loop independent clause to the later stages > throughout compilation. Unfortunately, it didn't include any test > cases. I'm not sure how effective

[doc PATCH] update attribute docs for C++

2018-12-03 Thread Martin Sebor
In a recent discussion a user asked us to clarify the effects of attributes const and pure on member functoons of trivial structs vs. non-trivial classes, and functions with pointer vs. reference arguments. I think this is worth explaining in some general statement rather than for individual

Re: [PATCH 1/2] asm qualifiers (PR55681)

2018-12-03 Thread Joseph Myers
On Sun, 2 Dec 2018, Segher Boessenkool wrote: > PR55681 observes that currently only one qualifier is allowed for > inline asm, so that e.g. "volatile asm" is allowed, "const asm" is also > okay (with a warning), but "const volatile asm" gives an error. Also > "goto" has to be last. > > This

Re: [PATCH] v4: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-12-03 Thread Joseph Myers
On Sat, 1 Dec 2018, Jason Merrill wrote: > Hmm, it looks like the C front-end comptypes will return 1 for e.g. enum and > int. It seems to me that what you want for this warning is actually to check > for the same type. Perhaps you want to use comptypes_check_different_types? > Joseph would

Re: [PING] Re: [PATCH 1/2] C++: more location wrapper nodes (PR c++/43064, PR c++/43486)

2018-12-03 Thread Jeff Law
On 11/19/18 9:51 AM, David Malcolm wrote: > Ping, for these patches: > > [PATCH 1/2] C++: more location wrapper nodes (PR c++/43064, PR c++/43486) > https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00304.html > > [PATCH 2/2] C++: improvements to binary operator diagnostics (PR c++/87504) >

[PATCH v2] C++: improvements to diagnostics using %P (more PR c++/85110)

2018-12-03 Thread David Malcolm
I was going to ping this patch: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00875.html but it has bit-rotted somewhat, so here's a refreshed version of it. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. OK for trunk? Thanks Dave Blurb from v1: This patch is based on

Re: [PATCH 2/9]: C++ P0482R5 char8_t: Core language support

2018-12-03 Thread Jason Merrill
On 12/3/18 4:51 PM, Jason Merrill wrote: On 11/5/18 2:39 PM, Tom Honermann wrote: This patch adds support for the P0482R5 core language changes.  This includes: - The -fchar8_t and -fno_char8_t command line options. - char8_t as a keyword. - The char8_t builtin type as a non-aliasing unsigned

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler

2018-12-03 Thread Joseph Myers
On Sat, 1 Dec 2018, Cary Coutant wrote: > In order to handle arbitrary user input without crashing, perhaps the > demangler should switch from recursive descent parsing to a state > machine, where exhaustion of resources can be handled gracefully. I've wondered if a GCC C/C++ extension could be

Re: [C++ PATCH] Fix xvalue COND_EXPR handling (PR c++/88103)

2018-12-03 Thread Jason Merrill
On Mon, Dec 3, 2018 at 4:36 PM Jakub Jelinek wrote: > > On Mon, Dec 03, 2018 at 02:44:32PM -0500, Jason Merrill wrote: > > > > Is there a reason not to use the 'move' function here? > > > > > > That doesn't work at all. move doesn't call cp_convert, but > > > build_static_cast (though for the

Re: [PATCH v3][C][ADA] use function descriptors instead of trampolines in C

2018-12-03 Thread Jeff Law
On 11/4/18 1:48 PM, Uecker, Martin wrote: > Hi Joseph, > > here is a new version of this patch which adds a warning > for targets which do not support -fno-trampolines and > only runs the test case on architectures where this is > supported. It seems that documentation for this general > feature

Re: [PATCH 2/9]: C++ P0482R5 char8_t: Core language support

2018-12-03 Thread Jason Merrill
On 11/5/18 2:39 PM, Tom Honermann wrote: This patch adds support for the P0482R5 core language changes.  This includes: - The -fchar8_t and -fno_char8_t command line options. - char8_t as a keyword. - The char8_t builtin type as a non-aliasing unsigned integral   character type of size 1. -

Re: [PATCH] Delete powerpcspe

2018-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 02:40:12PM -0700, Jeff Law wrote: > > 2018-12-03 Segher Boessenkool > > > > * contrib/config-list.mk: Remove powerpc-eabispe and powerpc-linux_spe. > > * gcc/config.gcc (Obsolete configurations): Delete powerpc*-*-*spe*. > > (Unsupported targets): Add

Re: [doc,committed] clarify docs for function attribute "const"

2018-12-03 Thread Martin Sebor
On 11/26/18 8:45 PM, Sandra Loosemore wrote: On 11/26/18 8:32 PM, Martin Sebor wrote: On 11/26/18 11:13 AM, Sandra Loosemore wrote: On 11/26/18 10:17 AM, Martin Sebor wrote: On 11/25/18 6:40 PM, Sandra Loosemore wrote: I've checked in the attached patch for PR79738. I think we have lost

Re: [PATCH] Delete powerpcspe

2018-12-03 Thread Jeff Law
On 12/3/18 1:50 PM, Segher Boessenkool wrote: > This deletes powerpcspe, which was deprecated for GCC 8. > > I'm not including the rm -r gcc/config/powerpcspe part in the patch, > see the diffstat summary for why. > > This does not change the testsuite, or libgcc for rs6000 (which still > is

Re: [C++ PATCH] Fix xvalue COND_EXPR handling (PR c++/88103)

2018-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 02:44:32PM -0500, Jason Merrill wrote: > > > Is there a reason not to use the 'move' function here? > > > > That doesn't work at all. move doesn't call cp_convert, but > > build_static_cast (though for the same reference && type). > > But while cp_convert only adds

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-12-03 Thread Julian Brown
On Fri, 30 Nov 2018 16:25:42 +0100 Thomas Schwinge wrote: > In addition to your "(1" token sequence (and similar ones), I suppose > what these code paths in C and C++ are supposed to catch the "wait ()" > case (see line 149 of gcc/testsuite/c-c++-common/goacc/asyncwait-1.c). > > I suppose in C,

Re: [PATCH, i386]: Correct vec_concatv2df alternative

2018-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 09:47:48PM +0100, Uros Bizjak wrote: > All avx512f registers support DFmode. > > 2018-12-03 Uros Bizjak > > * config/i386/sse.md (vec_concatv2df): Change (v,xm,C) > alternative to (v,vm,c). > > Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. >

[PATCH] Delete powerpcspe

2018-12-03 Thread Segher Boessenkool
This deletes powerpcspe, which was deprecated for GCC 8. I'm not including the rm -r gcc/config/powerpcspe part in the patch, see the diffstat summary for why. This does not change the testsuite, or libgcc for rs6000 (which still is shared code with powerpcspe, so can use some cleanup after

[PATCH, i386]: Correct vec_concatv2df alternative

2018-12-03 Thread Uros Bizjak
All avx512f registers support DFmode. 2018-12-03 Uros Bizjak * config/i386/sse.md (vec_concatv2df): Change (v,xm,C) alternative to (v,vm,c). Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline SVN. Uros. Index: config/i386/sse.md

libgo patch committed: Allow buildmode c-archive on ppc64

2018-12-03 Thread Ian Lance Taylor
This libgo patch by Lynn Boger changes the go tool to allow buildmode c-archive for gccgo on ppc64. In buildmodeinit, the c-archive buildmode is flagged as invalid on GNU/Linux ppc64 for gccgo when it should be valid. This happens because the check against the gccgo flag is done after the checks

Re: [PATCH 1/9]: C++ P0482R5 char8_t: Documentation updates

2018-12-03 Thread Jason Merrill
On 11/5/18 2:39 PM, Tom Honermann wrote: This patch adds documentation for new -fchar8_t and -fno-char8_t options. gcc/ChangeLog: 2018-11-04  Tom Honermann  * doc/invoke.texi (-fchar8_t): Document new option. +Enable support for the P0482 proposal including the addition of a +new

Re: [C++ PATCH] Fix xvalue COND_EXPR handling (PR c++/88103)

2018-12-03 Thread Jason Merrill
On 12/2/18 8:07 AM, Jakub Jelinek wrote: On Sat, Dec 01, 2018 at 07:11:08PM -0500, Jason Merrill wrote: On the following testcase, build_conditional_expr_1 tries hard to make sure that if both arguments are xvalue_p (or one is and the other throw) the result is still xvalue_p. But, later on we

Re: [RFC][PATCH]Merge VEC_COND_EXPR into MASK_STORE after loop vectorization

2018-12-03 Thread Jeff Law
On 11/20/18 7:57 AM, Renlin Li wrote: > Hi Richard, > > On 11/14/2018 02:59 PM, Richard Biener wrote: >> On Fri, Nov 9, 2018 at 4:49 PM Renlin Li  wrote: >>> >>> Hi Richard, >>> >>> On 11/09/2018 11:48 AM, Richard Biener wrote: On Thu, Nov 8, 2018 at 5:55 PM Renlin Li  wrote: >

[PATCH] Disallow configuring for powerpc*-*-linux*paired

2018-12-03 Thread Segher Boessenkool
The proper way, that is. Committing to trunk. Segher 2018-12-03 Segher Boessenkool * gcc/config.gcc (Unsupported targets): Add powerpc*-*-linux*paired*. (powerpc*-*-linux*): Don't handle it here. --- gcc/config.gcc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH 2/9][GCC][AArch64][middle-end] Add rules to strip away unneeded type casts in expressions

2018-12-03 Thread Jeff Law
On 11/28/18 10:57 AM, Tamar Christina wrote: > Hi Joseph, > > This is an updated version of my first patch which moves part of the type > conversion code > from convert.c to match.pd because match.pd is able to apply this > transformation in the > presence of intermediate temporary variables. >

Re: [Patch, ppc/darwin 2/2] Make Darwin's call handling follow the style of AIX/ELFv2/sysv.

2018-12-03 Thread Iain Sandoe
> On 3 Dec 2018, at 01:28, Iain Sandoe wrote: > The second patch normalises Darwin’s call handling to follow the same pattern > that Alan introduced recently. revised version, on top of the revised patch 1 attached. I’ve taken the opportunity to reduce the number of TARGET_MACHO

Re: [Patch, ppc/darwin 1/2] Fix bootstrap.

2018-12-03 Thread Iain Sandoe
> On 3 Dec 2018, at 06:18, Alan Modra wrote: > > On Mon, Dec 03, 2018 at 01:26:48AM +, Iain Sandoe wrote: >> The first patch makes Darwin share the sysv lowering, up until late in the >> process when we still use the macho_call_template. This means we need to >> preserve the CALL_LONG

Re: [PATCH] Fix PR64242

2018-12-03 Thread Jeff Law
On 12/3/18 9:25 AM, Jakub Jelinek wrote: > Hi! > > Here is a fix for the testcase, so that it doesn't FAIL pretty much > everywhere. > > On Fri, Nov 30, 2018 at 04:07:31PM -0700, Jeff Law wrote: >>> PR middle-end/64242 >>> * gcc.c-torture/execute/pr64242.c: New test. >> THanks for

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v3]

2018-12-03 Thread Ian Lance Taylor via gcc-patches
On Mon, Dec 3, 2018 at 6:45 AM, Nick Clifton wrote: > Hi Richard, > >>> * The description of the DMGL_RECURSE_LIMIT option in demangle.h has >>> been enhanced to add a note that if the option is not used, then >>> bug reports about stack overflows in the demangler will be rejected. >>

Re: [doc, rfc] document __builtin_setjmp and __builtin_longjmp

2018-12-03 Thread Jeff Law
On 11/30/18 9:57 PM, Sandra Loosemore wrote: > I have written a new patch for PR 59039 to address more of the comments > there, as well as my own complaints about the draft patch attached to > the issue.  I'd like to get some feedback on this one before I commit it. It looks pretty good to me. It

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Fritz Reese
On Mon, Dec 3, 2018 at 12:12 PM Jakub Jelinek wrote: > > On Mon, Dec 03, 2018 at 04:58:51PM +0100, Jakub Jelinek wrote: > > > but I just committed r266745 adjusted for -fdec-include. > > > > Thanks, though it seems what you've committed in options.c is incomplete. > > In the patch you've posted

[committed] Minor H8 warning bugfix

2018-12-03 Thread Jeff Law
I've been seeing the "... reaches end of non-void function ..." warning during my h8 test builds. I wanted to make sure it wasn't a real issue and it isn't. Having done the RCA, the fix is trivial, so we might as well go ahead and fix it :-) This just adds a suitable gcc_unreachable to the

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 04:58:51PM +0100, Jakub Jelinek wrote: > > but I just committed r266745 adjusted for -fdec-include. > > Thanks, though it seems what you've committed in options.c is incomplete. > In the patch you've posted earlier, you've changed also > gfc_init_options and

Re: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach)

2018-12-03 Thread Julian Brown
On Fri, 30 Nov 2018 03:41:09 -0800 Julian Brown wrote: > This is a new version of the patch incorporating > several improvements/bugfixes made on the og8 branch: I released I forgot (again!) to incorporate the changes suggested by Bernhard in:

Re: [PATCH v3] Make function clone name numbering independent.

2018-12-03 Thread Michael Ploujnikov
On 2018-12-01 11:29 a.m., H.J. Lu wrote: > This caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88297 > Sorry about that. Looks like I should have been testing with --with-build-config=bootstrap-lto rather than just --enable-bootstrap. The quick fix would be to undo the patch to

[PATCH, og8] Add OpenACC 2.6 `acc_get_property' support

2018-12-03 Thread Maciej W. Rozycki
Add generic support for the OpenACC 2.6 `acc_get_property' and `acc_get_property_string' routines, as well as full handlers for the host and the NVPTX offload targets and a minimal handler for the HSA offload target. Include test cases for both C/C++ and Fortran support, both producing:

Re: [wwwdocs] Add D language to news, frontends, release notes, and readings.

2018-12-03 Thread Iain Buclaw
On Sun, 2 Dec 2018 at 22:34, Gerald Pfeifer wrote: > > On Sun, 2 Dec 2018, Iain Buclaw wrote: > > I assume that the notes on the about.html page are all that are > > needed to commit and push? > > Yes, they *should*. > > If you run into anything that's missing or have any questions, > just let me

Re: [RFC][AArch64] Add support for system register based stack protector canary access

2018-12-03 Thread Ard Biesheuvel
On Mon, 3 Dec 2018 at 10:55, Ramana Radhakrishnan wrote: > > For quite sometime the kernel guys, (more specifically Ard) have been > talking about using a system register (sp_el0) and an offset from that > for a canary based access. This patchset adds support for a new set of > command line

Re: [PATCH] Fix PR64242

2018-12-03 Thread Jakub Jelinek
Hi! Here is a fix for the testcase, so that it doesn't FAIL pretty much everywhere. On Fri, Nov 30, 2018 at 04:07:31PM -0700, Jeff Law wrote: > > PR middle-end/64242 > > * gcc.c-torture/execute/pr64242.c: New test. > THanks for tracking this down. I'd like to have this run through my >

Re: [committed] C++ PATCH to add test for c++/83856

2018-12-03 Thread Marek Polacek
On Mon, Dec 03, 2018 at 10:14:11AM +0100, Christophe Lyon wrote: > This new test fails on arm and other targets according to > gcc-testresults. On arm, I can see: > /gcc/testsuite/g++.dg/cpp1y/lambda-generic-83856.C:6:27: fatal error: > definition of 'class std::initializer_list<_E>' does not

Re: [committed] Clean up Fortran OpenACC wait clause handling

2018-12-03 Thread Julian Brown
On Fri, 30 Nov 2018 21:48:20 +0100 Thomas Schwinge wrote: > Hi! > > commit 3e3de40a5ab21d72f08071a7a40120dd05608cc1 > Author: tschwinge > Date: Fri Nov 30 20:39:18 2018 + > > Clean up Fortran OpenACC wait clause handling > > "wait" can be deduced from "wait_list". > >

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 10:52:18AM -0500, Fritz Reese wrote: > > I think more than enough time passed, do you plan to commit to trunk now? > > Note, small adjustment will be needed for the addition of flag_dec_include > > in set_dec_flags. > > Jakub- Sorry, yes. I've had other priorities the past

[Ada] Spurious error on dependent expression that is an array

2018-12-03 Thread Pierre-Marie de Rodat
This patch fixes a spurious error on a array expression that is a dependent expression of an if-expression, when the length of the array matches that imposed by the context, but the bounds of both differ, in particular when the expression and the context are both null arrays with different bounds.

[Ada] Fixes for various wrong and missing error messages on ACATS B85100[567]

2018-12-03 Thread Pierre-Marie de Rodat
GNAT was missing errors as well as issuing messages on legal lines in new ACATS tests for illegal renamings of discriminant-dependent components. Cases that are fixed include object names involving qualified expressions, dereference cases, and generic formal access and formal derived types. Better

[Ada] Fix recent regression on array aggregate with dynamic subtype

2018-12-03 Thread Pierre-Marie de Rodat
This prevents either a crash or an assertion failure in gigi on an array with dynamic subtype that is wrongly flagged as static by the front-end because of a recent improvement made in the handling of nested aggregates. The patch reuses the existing Static_Array_Aggregate predicate instead of

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Fritz Reese
> I think more than enough time passed, do you plan to commit to trunk now? > Note, small adjustment will be needed for the addition of flag_dec_include > in set_dec_flags. Jakub- Sorry, yes. I've had other priorities the past few weeks here, but I just committed r266745 adjusted for

[Ada] Add leap seconds for 2015 and 2016

2018-12-03 Thread Pierre-Marie de Rodat
The following patch updates Ada.Calendar and helper utility Xleaps to include the leap seconds for years 2015 and 2016. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-03 Hristian Kirtchev gcc/ada/ * libgnat/a-calend.adb: Update the number of leap seconds. Add the

[Ada] Fix internal error on package instantiation on private type

2018-12-03 Thread Pierre-Marie de Rodat
This fixes an assertion failure in gigi triggered by the instantiation of a generic package, in a visible part of another package, done on a private type whose full view is a type derived from a scalar or an access type. The problem is that the front-end creates and inserts two different freeze

[Ada] A task not executing an entry call consumes an Entry_Call slot

2018-12-03 Thread Pierre-Marie de Rodat
This patch resolves the issue where the ATC Level of a task's first Entry_Call slot corresponds to a task not currently making an entry call. Consequently, the first slot is never used to record an entry call. To resolve this, the ATC Level of a such a task is now one less than the first index of

[Ada] Fix problematic overloading of operator in Ada 95 mode

2018-12-03 Thread Pierre-Marie de Rodat
The change reverts the test deciding whether an initialization procedure can be inherited from parent to derived type to the original implementation, which allowed inheriting a null procedure. This prevents the creation of another null initialization procedure for the derived type, which in turn

[Ada] Fix assertion failures with -gnatde and -gnatdv

2018-12-03 Thread Pierre-Marie de Rodat
This fixes a couple of assertion failures when using -gnatde and -gnatdv on a compiler built with assertions enabled. No functional changes. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-03 Eric Botcazou gcc/ada/ * einfo.adb (Write_Entity_Info): Don't take Scope of

[Ada] Gigi support for OpenACC pragmas

2018-12-03 Thread Pierre-Marie de Rodat
Matching front-end bits to support Acc_Kernels, Acc_Parallel, Acc_Loop and Acc_Data. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-03 Olivier Hainque gcc/ada/ * gcc-interface/lang.opt (fopenacc): New option for Ada. * gcc-interface/misc.c (gnat_handle_option):

[Ada] Adjust the default MALLOC_OBSERVABLE_ALIGNMENT to 2 * POINTER_SIZE

2018-12-03 Thread Pierre-Marie de Rodat
Instead of 2 * LONG_TYPE_SIZE. POINTER_SIZE is believed to be the correct base on more configurations than LONG_TYPE_SIZE and this adjustment prevents the need for local patches to compensate on configurations where the latter is inappropriate, for example x86_64-mingw. Tested on

[Ada] Missing check on if-expression

2018-12-03 Thread Pierre-Marie de Rodat
This patch fixes a constraint check on a dependent expression of an if-expression, when the context if given by a slice or the 'Range of an array. The constraint check is applied if the context is constrained, but the corresponding flag was not set for the index subtype generated for a slice

[PATCH] Fix PR88315

2018-12-03 Thread Richard Biener
While working on improving x264 vectorization I noticed (via enabling epilogue vectorization) that for SAD and DOT_PROD SLP reductions with non-zero initial value we create wrong-code. The following fixes this, removing the ugly backwards-creation of the initial value. Bootstrap & regtest

[PATCH] Fix epilogue vectorization niter more

2018-12-03 Thread Richard Biener
Previous patch exposes another issue with the code - LOOP_VINFO_INT_NITERS is already adjusted for prologue peeling. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2018-12-03 Richard Biener * tree-vect-loop.c (vect_transform_loop): Fix epilogue iterations

Re: [RFC][AArch64] Add support for system register based stack protector canary access

2018-12-03 Thread Florian Weimer
* Ramana Radhakrishnan: > I don't intend to change the defaults in userland, we've discussed this > for user-land in the past and as far as glibc and userland is concerned > we stick to the options as currently existing. The system register > option is really for the kernel to use along with

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Mark Eggleston
On 12/11/2018 20:28, Fritz Reese wrote: Attached is the latest version, which builds and regtests cleanly on x86_64-redhat-linux. OK for trunk, 7-branch, and 8-branch? I'm currently using this patch (pending it being committed) and have some pending patches that use it. I can use the old

[committed] Fix ICE due to bogus operand predicate in H8 port peepholes

2018-12-03 Thread Jeff Law
This is a bit more interesting than the last H8 fix. The H8 has peepholes to optimize masking a value down to a byte. They rely on using gen_lowpart to extract the low byte value of the source operand which works well on the H8 because accessing the low byte of a reg is particularly cheap.

[committed] Make some test names unique

2018-12-03 Thread Jeff Law
The introduction relative line number support in the dg framework was absolutely a good thing in terms of testsuite maintenance. However, it also made it possible to have duplicated testnames. The duplicated names cause our summary analysis scripts major headaches if one of the tests pass and

[PATCH] Tighten PRE/FRE elimination

2018-12-03 Thread Richard Biener
It happily inserted int->float casts if sth goes wrong in VN or elimination. The following restricts it to the expected re-instantiation of function pointer casts. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-12-03 Richard Biener * tree-ssa-sccvn.c

Re: [PATCH] S/390: Add support for section anchors

2018-12-03 Thread Andreas Krebbel
On 29.11.18 13:47, Ilya Leoshkevich wrote: > Bootstrapped and regtested on s390x-redhat-linux and > x86_64-redhat-linux. > > gcc/ChangeLog: > > 2018-09-12 Ilya Leoshkevich > > * common/config/s390/s390-common.c (s390_option_init_struct): > Use section anchors by default. >

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler

2018-12-03 Thread Nick Clifton
Hi Cary, > In order to handle arbitrary user input without crashing, perhaps the > demangler should switch from recursive descent parsing to a state > machine, where exhaustion of resources can be handled gracefully. I think that that would be a better long term fix for the problem, but it is

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v3]

2018-12-03 Thread Nick Clifton
Hi Richard, >> * The description of the DMGL_RECURSE_LIMIT option in demangle.h has >> been enhanced to add a note that if the option is not used, then >> bug reports about stack overflows in the demangler will be rejected. > > Shouldn't we make it fool-proof by instead introducing a

Re: [Darwin] Fix build warnings for libstdc++ [NFC]

2018-12-03 Thread Jonathan Wakely
On 03/12/18 00:37 +, Iain Sandoe wrote: Hi, GCC does not export construction vtable symbols from shared libraries**. The symbols are marked hidden in the objects; for Darwin that makes them also external (“private_extern” is Darwin’s hidden) which means that they show up in the list of

Re: [PATCH] i386; Add -mmanual-endbr and cf_check function attribute

2018-12-03 Thread H.J. Lu
On Mon, Jun 18, 2018 at 2:20 AM Richard Biener wrote: > > On Fri, Jun 15, 2018 at 2:59 PM H.J. Lu wrote: > > > > Currently GCC inserts ENDBR instruction at entries of all non-static > > functions, unless LTO compilation is used. Marking all functions, > > which are not called indirectly with

Re: [PATCH] Fix PR64242

2018-12-03 Thread Christophe Lyon
On Mon, 3 Dec 2018 at 14:35, Richard Biener wrote: > > On Sat, Dec 1, 2018 at 12:07 AM Jeff Law wrote: > > > > On 11/29/18 12:26 PM, Wilco Dijkstra wrote: > > > Fix PR64242 - the middle end expansion for long jmp updates the > > > hard frame pointer before it reads the new stack pointer. This >

[PATCH] Fix PR88301

2018-12-03 Thread Richard Biener
This fixes a missed optimization in EVRP by teaching the code figuring out conditional asserts about conversions that preserve the converted value. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk sofar. Richard. 2018-12-03 Richard Biener PR

[committed] Add testcase from PR tree-optimization/71109

2018-12-03 Thread Jakub Jelinek
Hi! This testcase broke on x86_64-linux with -O3 with r227775 and got fixed or went latent with r236372. I've just committed the testcase to the testsuite as obvious, let's close the PR now. 2018-12-03 Jakub Jelinek PR tree-optimization/71109 *

Re: [PATCH] Fix PR64242

2018-12-03 Thread Richard Biener
On Sat, Dec 1, 2018 at 12:07 AM Jeff Law wrote: > > On 11/29/18 12:26 PM, Wilco Dijkstra wrote: > > Fix PR64242 - the middle end expansion for long jmp updates the > > hard frame pointer before it reads the new stack pointer. This > > results in a corrupted stack pointer if the jmp buffer is a

[PATCH] Fix epilogue upper bound for epilogue vectorization

2018-12-03 Thread Richard Biener
I figured the epilogue vectorization code doesn't compute the correct number of iterations for the epilogue when peeling for gaps is in effect. This prevents epilogue vectorization in some cases and given the code also sets nb_iterations_upper_bound, causes possible wrong-code (I think we

Re: Add a loop versioning pass

2018-12-03 Thread Richard Biener
On Wed, 28 Nov 2018, Richard Sandiford wrote: > Thanks for the review and sorry for the long time replying. Likewise ... > Richard Biener writes: > >> This patch adds a pass that versions loops with variable index strides > >> for the case in which the stride is 1. E.g.: > >> > >> for

[committed] Adjust aarch64/vcond_1.C testcase (PR target/88287)

2018-12-03 Thread Jakub Jelinek
Hi! The x <= -CST => x < -CST + 1 x > -CST=> x >= -CST + 1 x >= CST=> x > CST - 1 x < CST => x <= CST - 1 match.pd canonicalizations which are newly done also for uniform vector

Re: [wwwdocs] readings.html -- two broken z/Architecture links

2018-12-03 Thread Ulrich Weigand
Hi Gerald, > I've been getting > > "A possible equivalent for dz9zr002 was not found." (or similar) > > for these two pages for a while. > > If you have suitable links to cover these, please go ahead and add > them; for the time being I committed the patch below. I've committed the

Re: [PATCH v3][C][ADA] use function descriptors instead of trampolines in C

2018-12-03 Thread Uecker, Martin
Is there a change that we can move forward with this? I think this is a very useful feature and might be especially important if GCC is going to activate -Wtrampoline with  -Wall on some architectures. Best, Martin Am Sonntag, den 04.11.2018, 21:48 +0100 schrieb Martin Uecker: > Hi Joseph, >

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v3]

2018-12-03 Thread Richard Biener
On Fri, Nov 30, 2018 at 6:41 PM Nick Clifton wrote: > > Hi Guys, > > >> I think it would be fine to have a large fixed limit plus a flag to > >> disable the limit. > > Great - in which case please may I present version 3 of the patch. In > this version: > > * The

Re: [RFC][AArch64] Add support for system register based stack protector canary access

2018-12-03 Thread Ramana Radhakrishnan
On 03/12/2018 09:59, Jakub Jelinek wrote: > On Mon, Dec 03, 2018 at 09:55:36AM +, Ramana Radhakrishnan wrote: >> + if (aarch64_stack_protector_guard == SSP_GLOBAL >> + && opts->x_aarch64_stack_protector_guard_offset_str) >> +{ >> + error ("Incompatible options

Re: [RFC][AArch64] Add support for system register based stack protector canary access

2018-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 09:55:36AM +, Ramana Radhakrishnan wrote: > + if (aarch64_stack_protector_guard == SSP_GLOBAL > + && opts->x_aarch64_stack_protector_guard_offset_str) > +{ > + error ("Incompatible options -mstack-protector-guard=global and" Diagnostic messages shouldn't

[RFC][AArch64] Add support for system register based stack protector canary access

2018-12-03 Thread Ramana Radhakrishnan
For quite sometime the kernel guys, (more specifically Ard) have been talking about using a system register (sp_el0) and an offset from that for a canary based access. This patchset adds support for a new set of command line options similar to how powerpc has done this. I don't intend to change

Re: [ARM/FDPIC v4 00/20] FDPIC ABI for ARM

2018-12-03 Thread Christophe Lyon
Ping? The series started here: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01464.html Thanks, Christophe On Mon, 26 Nov 2018 at 11:14, Christophe Lyon wrote: > > Ping? > > Thanks > > On Fri, 16 Nov 2018 at 16:48, Christophe Lyon wrote: > > > > From: Christophe Lyon > > > > Hello, > > > >

Re: [committed] C++ PATCH to add test for c++/83856

2018-12-03 Thread Christophe Lyon
On Sat, 1 Dec 2018 at 23:01, Marek Polacek wrote: > > Tested x86_64-linux, applying to trunk. > > 2018-12-01 Marek Polacek > > PR c++/83856 > * g++.dg/cpp1y/lambda-generic-83856.C: New test. > > diff --git gcc/testsuite/g++.dg/cpp1y/lambda-generic-83856.C >