Make claer, when contributions will be ignored

2018-12-04 Thread Дилян Палаузов
Hello, on 27th October I sent to gcc-patches a mail with the subject “Don’t build gdb/readline/libreadline.a, when --with-system-readline is supplied” and on 14th November I sent a reminder. I got no answer. Before sending the emails I filled a bugzilla ticket. Can you please make it clear,

Re: [PATCH 2/9]: C++ P0482R5 char8_t: Core language support

2018-12-04 Thread Tom Honermann
On 12/3/18 5:01 PM, Jason Merrill wrote: On 12/3/18 4:51 PM, Jason Merrill wrote: On 11/5/18 2:39 PM, Tom Honermann wrote: This patch adds support for the P0482R5 core language changes.  This includes: - The -fchar8_t and -fno_char8_t command line options. - char8_t as a keyword. - The

Re: [PATCH 1/9]: C++ P0482R5 char8_t: Documentation updates

2018-12-04 Thread Tom Honermann
On 12/3/18 2:59 PM, Jason Merrill wrote: On 11/5/18 2:39 PM, Tom Honermann wrote: This patch adds documentation for new -fchar8_t and -fno-char8_t options. gcc/ChangeLog: 2018-11-04  Tom Honermann    * doc/invoke.texi (-fchar8_t): Document new option. +Enable support for the P0482

avoid null ptr deref in cselib_record_sets

2018-12-04 Thread Alexandre Oliva
Jeff Law tells me h8300-elf fails gcc.c-torture/compile/pr49029.c with -O2 -g -mint32 -mh. This patch fixes it. The problem is that strict low part handling in cselib_record_sets assumes src_elt is not NULL. That src_elt is taken from a strict low part set, but it won't always have a src_elt to

Re: [PATCH] [PR85569] skip constexpr target_expr constructor dummy type conversion

2018-12-04 Thread Alexandre Oliva
On Nov 27, 2018, Jason Merrill wrote: > Let's replace the == comparison rather than supplement it. OK with > that change. Thanks, here's what I (re)tested and will install eventually. [PR85569] skip constexpr target_expr constructor dummy type conversion From: Alexandre Oliva The testcase

Re: [PATCH] [PR86397] set p_t_decl while canonicalizing eh specs for mangling

2018-12-04 Thread Alexandre Oliva
On Nov 29, 2018, Jason Merrill wrote: > Let's go with this. And remove the comment. > And the !processing_template_decl is also redundant, since that's > checked at the top of value_dependent_expression_p. I've tested this on i686- and x86_64-linux-gnu. Ok to install? [PR86397] resolve

Fortran patches

2018-12-04 Thread Steve Kargl
I intend to commit the attached patch on Saturday. 2018-12-02 Steven G. Kargl PR fortran/87922 * io.c (gfc_match_open): ASYNCHRONOUS must be scalar. PR fortran/87945 * decl.c (var_element): Inquiry parameter cannot be a data object.

Re: [doc PATCH] update attribute docs for C++

2018-12-04 Thread Sandra Loosemore
On 12/4/18 8:13 PM, Martin Sebor wrote: On 12/4/18 2:04 PM, Sandra Loosemore wrote: On 12/4/18 9:26 AM, Martin Sebor wrote: [snip] +The keyword @code{__attribute__} allows you to specify various special +properties of types.  Some type attributes apply only to structure and +union types, and

[Patch,Testsuite][MIPS][Committed] Adjusted msa compare instructions clti to clei.

2018-12-04 Thread Paul Hua
Hi: Recently gcc optimize msa compare code i<5 from clti_.df $wn,$wn,5 to clei_.df $wn,$wn,4. This patch adjusted testsuite. Committed as obviously. gcc/testsuite/ 2018-12-05 Chenghua Xu * gcc.target/mips/msa.c: Adjusted clti_.df $wn,$wn,5 to clei_.df $wn,$wn,4 in test31.

Re: [PATCH] Fix -fsanitize=address -fstack-protector* (PR sanitizer/88333)

2018-12-04 Thread Jeff Law
On 12/4/18 4:32 PM, Jakub Jelinek wrote: > Hi! > > The current asan.c code requires that the whole block of vars starts and > ends on ASAN_RED_ZONE_SIZE (i.e. 32 byte) boundary, so that it is on 4 byte > boundary in the shadow memory. Normally it is, when frame_offset starts at > 0, but with

Re: [doc PATCH] update attribute docs for C++

2018-12-04 Thread Martin Sebor
On 12/4/18 2:04 PM, Sandra Loosemore wrote: On 12/4/18 9:26 AM, Martin Sebor wrote: Thanks for the comments.  Attached is an updated patch with the typos fixed.  I've left the rest as is. Well, I still think a number of points I commented on before need to be clarified in the text.  If I'm

[PATCH, csky] Force .init_array suppor for GLIBC

2018-12-04 Thread 瞿仙淼
Hi, I have submitted a patch to force .init_array suppor for GLIBC Index: gcc/ChangeLog === --- gcc/ChangeLog (revision 266812) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2018-12-05 Xianmiao Qu + +

libgo: remove AIX flock emulation

2018-12-04 Thread Ian Lance Taylor
This patch by Tobias Klauser removes the somewhat incorrect AIX flock emulation from the syscall package. This is based on the discussion at https://golang.org/issue/29084. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

[PATCH] rs6000: Fix AIX aggregate passing fix

2018-12-04 Thread Segher Boessenkool
David's fix for the AIX aggregate passing from yesterday unfortunately also triggers on powerpc64-linux. This fixes it. David, looking at this once more, does this not need a "&& type" test on AIX? Before the AGGREGATE_TYPE_P test. I suspect it only didn't crash on AIX because AIX doesn't mind

[PATCH] Fix unroll-and-jam (PR tree-optimization/87360)

2018-12-04 Thread Jakub Jelinek
Hi! The following testcases ICE, because tree_loop_unroll_and_jam optimizes one loop and on another one after it fails to analyze data dependencies and returns. The end effect of that is that neither the code at the end of the function to do final cleanups, nor TODO_cleanup_cfg is done, and the

[PATCH] Fix -fsanitize=address -fstack-protector* (PR sanitizer/88333)

2018-12-04 Thread Jakub Jelinek
Hi! The current asan.c code requires that the whole block of vars starts and ends on ASAN_RED_ZONE_SIZE (i.e. 32 byte) boundary, so that it is on 4 byte boundary in the shadow memory. Normally it is, when frame_offset starts at 0, but with -fstack-protector there is the guard above it and in

Re: [PING] Re: [PATCH 1/2] C++: more location wrapper nodes (PR c++/43064, PR c++/43486)

2018-12-04 Thread Jason Merrill
On 12/3/18 5:10 PM, Jeff Law wrote: On 11/19/18 9:51 AM, David Malcolm wrote: Ping, for these patches: [PATCH 1/2] C++: more location wrapper nodes (PR c++/43064, PR c++/43486) https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00304.html [PATCH 2/2] C++: improvements to binary operator

[committed] Add testcase for already fixed PR tree-optimization/87320

2018-12-04 Thread Jakub Jelinek
Hi! I've committed the following testcase for already fixed PR, which has been fixed by the PR87288 fix, after testing on x86_64-linux and i686-linux. 2018-12-04 Jakub Jelinek PR tree-optimization/87320 * gcc.dg/pr87320.c: New test. --- gcc/testsuite/gcc.dg/pr87320.c.jj

[committed] Handle targets with 2 byte wchar_t better in strlenopt-58.c

2018-12-04 Thread Jeff Law
This is another minor testsuite patch. strlenopt-58.c assumes 4 byte wchar_t. On targets with a smaller wchar_t it will get an error/warning. This patch adds a dg-warning on the appropriate lines for targets that do not have 4byte wchar_t. It's been tested on h8 to verify the bogus

Re: [PATCH 1/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit

2018-12-04 Thread Segher Boessenkool
On Tue, Dec 04, 2018 at 02:33:59PM -0600, Paul Clarke wrote: > On 12/04/2018 02:16 PM, Segher Boessenkool wrote: > > On Tue, Dec 04, 2018 at 08:59:03AM -0600, Paul Clarke wrote: > >> @@ -1612,7 +1608,8 @@ _mm_bsrli_si128 (__m128i __A, const int __N) > >>const __v16qu zeros = { 0, 0, 0, 0, 0,

patch to fix PR88317

2018-12-04 Thread Vladimir Makarov
  The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88317   The patch was successfully bootstrapped and tested on x86/x86-64.   I think the test is too big to add it to GCC testsuite.  If Richard implements bitmap poisoning, it would be possible to find a smaller test.  

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-12-04 Thread Segher Boessenkool
On Tue, Dec 04, 2018 at 01:42:52PM -0600, Peter Bergner wrote: > On 11/28/18 3:27 PM, Peter Bergner wrote: > > gcc/ > > PR target/87496 > > * config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow > > -mabi=ieeelongdouble without both -mpopcntd and -mvsx. > > So this "fix"

Re: [PATCH 3/3][rs6000] Enable x86-compat vector intrinsics testing

2018-12-04 Thread Segher Boessenkool
On Tue, Dec 04, 2018 at 09:00:18AM -0600, Paul Clarke wrote: > The testsuite tests for the compatibility implementations of x86 vector > intrinsics for "powerpc" had been inadvertently made to PASS > without actually running the test code. > > This patch removes the code which kept the tests from

[PATCH 1/2] v2: C++: more location wrapper nodes (PR c++/43064, PR c++/43486)

2018-12-04 Thread David Malcolm
The v1 patch: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00304.html has bitrotten somewhat, so here's v2 of the patch, updated relative to r266740. Blurb from v1 patch follows: The C++ frontend gained various location wrapper nodes in r256448 (GCC 8). That patch:

[PATCH 2/2] v2: C++: improvements to binary operator diagnostics (PR c++/87504)

2018-12-04 Thread David Malcolm
The v1 patch: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00303.html has bitrotten somewhat, so here's v2 of the patch, updated relative to r266740. Blurb from v1 patch follows: The C frontend is able (where expression locations are available) to print problems with binary operators in

Re: Fix move_if_noexcept usages in _Hashtable

2018-12-04 Thread François Dumont
On 12/4/18 3:38 PM, Jonathan Wakely wrote: On 04/12/18 07:45 +0100, François Dumont wrote: Hi   This patch fix a minor problem with usage of std::move_if_noexcept. We use it to move node content if move construtor is noexcept but we eventually use the allocator_type::construct method which

[PATCH] testsuite: turn down verbosity of "process-message"

2018-12-04 Thread David Malcolm
When debugging a failing test, I typically invoke DejaGnu at verbosity level 2 (via RUNTESTFLAGS="-v -v dg.exp=something"), so that DejaGnu prints the command line used to invoke the compiler; specifically these two sites: target.exp "Invoking the compiler as " remote.exp "Executing on

[committed] spellcheck.c: add another selftest for PR c/82967

2018-12-04 Thread David Malcolm
This adds another testcase for overzealous spellchecker suggestions, reported on IRC. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Committed to trunk as r266798, under the "obvious" rule. gcc/ChangeLog: PR c/82967 * spellcheck.c (selftest::test_suggestions):

Re: [PATCH 2/3][rs6000] Fix x86-compat vector intrinsics testcases for BE, 32bit

2018-12-04 Thread Segher Boessenkool
Hi! On Tue, Dec 04, 2018 at 08:59:40AM -0600, Paul Clarke wrote: > Fix general endian issues found in the test cases for the compatibility > implementations of the x86 vector intrinsics. (The tests had been > inadvertently made to PASS without actually running the test code. > A later patch

Re: [doc PATCH] update attribute docs for C++

2018-12-04 Thread Sandra Loosemore
On 12/4/18 9:26 AM, Martin Sebor wrote: Thanks for the comments.  Attached is an updated patch with the typos fixed.  I've left the rest as is. Well, I still think a number of points I commented on before need to be clarified in the text. If I'm confused, I think other readers will be,

Re: [PATCH 1/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit

2018-12-04 Thread Paul Clarke
On 12/04/2018 02:16 PM, Segher Boessenkool wrote: > Hi! > > On Tue, Dec 04, 2018 at 08:59:03AM -0600, Paul Clarke wrote: >> Fix general endian and 32-bit mode issues found in the >> compatibility implementations of the x86 vector intrinsics when running the >> associated test suite tests.

Re: [PATCH 1/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit

2018-12-04 Thread Segher Boessenkool
Hi! On Tue, Dec 04, 2018 at 08:59:03AM -0600, Paul Clarke wrote: > Fix general endian and 32-bit mode issues found in the > compatibility implementations of the x86 vector intrinsics when running the > associated test suite tests. (The tests had been inadvertently made to PASS > without actually

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-12-04 Thread Peter Bergner
On 11/28/18 3:27 PM, Peter Bergner wrote: > gcc/ > PR target/87496 > * config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow > -mabi=ieeelongdouble without both -mpopcntd and -mvsx. So this "fix" ended up accidentally disallowing -mabi=ibmlongdouble as well, which

Re: [PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-12-04 Thread Julian Brown
On Tue, 4 Dec 2018 20:12:58 +0100 Jakub Jelinek wrote: > On Tue, Dec 04, 2018 at 07:06:43PM +, Julian Brown wrote: > > Thanks for the review! As it happened though, I had to rewrite a > > lot of the code in this patch for the attach/detach patch, and I > > had meant to withdraw this one.

Re: [PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-12-04 Thread Jakub Jelinek
On Tue, Dec 04, 2018 at 07:06:43PM +, Julian Brown wrote: > Thanks for the review! As it happened though, I had to rewrite a lot of > the code in this patch for the attach/detach patch, and I had meant to > withdraw this one. Many apologies about the wasted time! I mentioned > the superseding

Re: C++ PATCH for c++/88184, ICE when treating name as template-name

2018-12-04 Thread Jason Merrill
OK. On Tue, Dec 4, 2018 at 12:27 PM Marek Polacek wrote: > > On Thu, Nov 29, 2018 at 04:03:50PM -0500, Jason Merrill wrote: > > On 11/29/18 1:28 PM, Marek Polacek wrote: > > > On Wed, Nov 28, 2018 at 10:34:11PM -0500, Jason Merrill wrote: > > > > On 11/28/18 10:48 AM, Marek Polacek wrote: > > > >

Re: [PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-12-04 Thread Julian Brown
Hi Jakub, On Tue, 4 Dec 2018 15:17:08 +0100 Jakub Jelinek wrote: > On Mon, Sep 03, 2018 at 08:46:54PM -0400, Julian Brown wrote: > > 2018-09-03 Cesar Philippidis > > > > gcc/fortran/ > > * openmp.c (gfc_match_omp_variable_list): New allow_derived > > argument.

Re: [doc PATCH] document when GCC ignores attribute aligned

2018-12-04 Thread Martin Sebor
On 12/4/18 12:20 AM, Sandra Loosemore wrote: On 12/3/18 8:23 PM, Martin Sebor wrote: Last week we agreed to clarify that attribute aligned on a function can decrease its alignment if it hasn't been previously declared with one.  Attached is this change. Besides the above, I also mention that

[PATCH PR libstdc++/88341] -

2018-12-04 Thread Ed Smith-Rowland
Committed as obvious 266788. Ed 2018-12-03 Edward Smith-Rowland <3dw...@verizon.net> PR libstdc++/88341 - Complex norm doesn't compile with C++11 * include/std/complex (_S_do_it): Make C++20 constexpr. * testsuite/26_numerics/complex/value_operations/pr88341.cc: New

Re: [PATCH 0/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit

2018-12-04 Thread Segher Boessenkool
On Tue, Dec 04, 2018 at 08:58:15AM -0600, Paul Clarke wrote: > Many of the tests for the x86-compatible vector intrinsics implementations > were protected by "#ifdef __BUILTIN_CPU_SUPPORTS__", which is only enabled > with recent enough glibc that in most environments, the test were silently >

Re: [Patch, ppc/darwin 2/2] Make Darwin's call handling follow the style of AIX/ELFv2/sysv.

2018-12-04 Thread Segher Boessenkool
On Mon, Dec 03, 2018 at 07:18:20PM +, Iain Sandoe wrote: > revised version, on top of the revised patch 1 attached. I’ve taken the > opportunity to reduce the number of TARGET_MACHO conditionals in rs6000.md > (handle in rs6000.c instead) > From 82ac030d49fd2ae78b75a350c5efc59375df42a6 Mon

Re: C++ PATCH for c++/88184, ICE when treating name as template-name

2018-12-04 Thread Marek Polacek
On Thu, Nov 29, 2018 at 04:03:50PM -0500, Jason Merrill wrote: > On 11/29/18 1:28 PM, Marek Polacek wrote: > > On Wed, Nov 28, 2018 at 10:34:11PM -0500, Jason Merrill wrote: > > > On 11/28/18 10:48 AM, Marek Polacek wrote: > > > > Since P0846R0 was implemented, a name will be treated as a > > > >

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-04 Thread Pedro Alves
On 12/04/2018 04:56 PM, Nick Clifton wrote: > Hi Pedro, > >> The issue pointed out by >> >> https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02592.html >> >> is still present in this version. > > Doh! Yes I meant to fix that one too, but forgot. > >> Also, noticed a typo here: >> >>> +/* If

Re: [PATCH, Fortran] pad char to int conversions with spaces instead of zeros (legacy)

2018-12-04 Thread Fritz Reese
On Tue, Dec 4, 2018 at 10:12 AM Jakub Jelinek wrote: > > Just a couple of random comments. > -fdec-pad-with-spaces option name doesn't look right, because it doesn't say > what the option affects. So perhaps have transfer in the option name? [...] > Wouldn't it be better to allow specifying

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-04 Thread Nick Clifton
Hi Pedro, > The issue pointed out by > > https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02592.html > > is still present in this version. Doh! Yes I meant to fix that one too, but forgot. > Also, noticed a typo here: > >> +/* If DMGL_NO_RECURE_LIMIT is not enabled, then this is the value

Re: [RFC][PATCH]Merge VEC_COND_EXPR into MASK_STORE after loop vectorization

2018-12-04 Thread Richard Sandiford
Jeff Law writes: > On 11/20/18 7:57 AM, Renlin Li wrote: >> Hi Richard, >> >> On 11/14/2018 02:59 PM, Richard Biener wrote: >>> On Fri, Nov 9, 2018 at 4:49 PM Renlin Li  wrote: Hi Richard, On 11/09/2018 11:48 AM, Richard Biener wrote: > On Thu, Nov 8, 2018 at 5:55 PM 

Re: [doc PATCH] update attribute docs for C++

2018-12-04 Thread Martin Sebor
On 12/4/18 12:09 AM, Sandra Loosemore wrote: On 12/3/18 4:23 PM, Martin Sebor wrote: gcc/ChangeLog: * doc/extend.texi (attribute const, pure): Clarify. Index: gcc/doc/extend.texi === --- gcc/doc/extend.texi    (revision

Re: patch to fix PR88282

2018-12-04 Thread Richard Sandiford
Vladimir Makarov writes: >   The following patch fixes > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88282 > >   The patch was successfully bootstrapped and tested on > x86/x86-64/ppc64/aarch64. > >   Committed as rev. 266784. > > Index: ChangeLog >

[PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

2018-12-04 Thread Peter Bergner
Hi Segher, We talked about replacing rs6000'c regno_or_subregno() with the generic reg_or_subregno() function from jump.c. I agree the geberic version is better because it has an assert that ensures we have a REG. There were also a couple of places that could use reg_or_subregno() where we

Reduce memory usage of ipa-cp streaming

2018-12-04 Thread Jan Hubicka
Hi, this patch reduces memory usage of WPA for current firefox LTO+FDO build from 10GB to 8.5GB by not allocating vector for jump functions annotating calls to libgcov runtime. Comparing -Q report before and after patch I get: Time variable usr sys

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-12-04 Thread Tom de Vries
On 04-12-18 13:29, Jakub Jelinek wrote: > On Fri, Jun 29, 2018 at 11:19:53AM -0700, Cesar Philippidis wrote: >> The attached patch includes the nvptx and GCC ME reductions enhancements. >> >> Is this patch OK for trunk? It bootstrapped / regression tested cleanly >> for x86_64 with nvptx

[committed, testsuite] Fix PR88310.

2018-12-04 Thread Iain Sandoe
Hi, A new warning was added in 264657 that fires if the profile count data file is missing when -fprofile-use is enabled; this was causing the test for profile + reorder support to fail in the target supports. Applied the following as obvious. Iain Index: gcc/testsuite/ChangeLog

Re: [PATCH] Further rs6000 asm modifier tweaks (PR target/88188)

2018-12-04 Thread Segher Boessenkool
Hi Jakub, On Tue, Dec 04, 2018 at 09:56:45AM +0100, Jakub Jelinek wrote: > This patch adds further tweaks discussed in the last PR88188 mail. Thanks for doing this :-) > ccr_bit now returns -1 instead of failing assertions, so that the caller > can decide what to do with it (fail assertion or

Re: [PATCH 2/2] asm inline

2018-12-04 Thread Richard Sandiford
Segher Boessenkool writes: > diff --git a/gcc/c/c-typeck.c b/gcc/c/c-typeck.c > index 81c520a..9b572d7 100644 > --- a/gcc/c/c-typeck.c > +++ b/gcc/c/c-typeck.c > @@ -10315,7 +10315,7 @@ build_asm_stmt (tree cv_qualifier, tree args) > are subtly different. We use a ASM_EXPR node to represent

Re: [PING] Re: [PATCH 1/2] C++: more location wrapper nodes (PR c++/43064, PR c++/43486)

2018-12-04 Thread David Malcolm
On Mon, 2018-12-03 at 15:10 -0700, Jeff Law wrote: > On 11/19/18 9:51 AM, David Malcolm wrote: > > Ping, for these patches: > > > > [PATCH 1/2] C++: more location wrapper nodes (PR c++/43064, PR > > c++/43486) > > https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00304.html > > > > [PATCH 2/2]

Re: [PATCH, Fortran] pad char to int conversions with spaces instead of zeros (legacy)

2018-12-04 Thread Jakub Jelinek
On Tue, Dec 04, 2018 at 02:47:25PM +, Mark Eggleston wrote: > Here is a patch to considered for incorporation into gfortran adding to its > legacy support. It pads character to integer conversions using spaces > instead of zeros when enabled. > > The pad character is 'undefined' or 'processor

patch to fix PR88282

2018-12-04 Thread Vladimir Makarov
  The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88282   The patch was successfully bootstrapped and tested on x86/x86-64/ppc64/aarch64.   Committed as rev. 266784. Index: ChangeLog === --- ChangeLog

Re: [doc, rfc] document __builtin_setjmp and __builtin_longjmp

2018-12-04 Thread Richard Sandiford
Sandra Loosemore writes: > I have written a new patch for PR 59039 to address more of the comments > there, as well as my own complaints about the draft patch attached to > the issue. I'd like to get some feedback on this one before I commit it. It's a long time since I've worked with these

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v4]

2018-12-04 Thread Pedro Alves
On 12/04/2018 01:59 PM, Nick Clifton wrote: > OK then, here is a fourth revision of the patch. The issue pointed out by https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02592.html is still present in this version. Also, noticed a typo here: > +/* If DMGL_NO_RECURE_LIMIT is not enabled, then

[PATCH 3/3][rs6000] Enable x86-compat vector intrinsics testing

2018-12-04 Thread Paul Clarke
The testsuite tests for the compatibility implementations of x86 vector intrinsics for "powerpc" had been inadvertently made to PASS without actually running the test code. This patch removes the code which kept the tests from running the actual test code. 2018-12-03 Paul A. Clarke

[PATCH 2/3][rs6000] Fix x86-compat vector intrinsics testcases for BE, 32bit

2018-12-04 Thread Paul Clarke
Fix general endian issues found in the test cases for the compatibility implementations of the x86 vector intrinsics. (The tests had been inadvertently made to PASS without actually running the test code. A later patch fixes this issue.) Additionally, a new is added, as some of the APIs therein

[PATCH 1/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit

2018-12-04 Thread Paul Clarke
Fix general endian and 32-bit mode issues found in the compatibility implementations of the x86 vector intrinsics when running the associated test suite tests. (The tests had been inadvertently made to PASS without actually running the test code. A later patch fixes this issue.) In a few cases,

[PATCH 0/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit

2018-12-04 Thread Paul Clarke
Many of the tests for the x86-compatible vector intrinsics implementations were protected by "#ifdef __BUILTIN_CPU_SUPPORTS__", which is only enabled with recent enough glibc that in most environments, the test were silently passing without actually testing anything. Patches which follow: 01: Fix

C++ patch ping

2018-12-04 Thread Jakub Jelinek
Hi! I'd like to ping PR87506 - https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01758.html You've acked the patch with the asserts but that FAILs as mentioned in the above mail. The following has been bootstrapped/regtested and works, can it be committed without those asserts and let those be

[PATCH, Fortran] pad char to int conversions with spaces instead of zeros (legacy)

2018-12-04 Thread Mark Eggleston
Here is a patch to considered for incorporation into gfortran adding to its legacy support. It pads character to integer conversions using spaces instead of zeros when enabled. The pad character is 'undefined' or 'processor dependent' depending on which standard you read. This makes it 0x20

Re: Fix move_if_noexcept usages in _Hashtable

2018-12-04 Thread Jonathan Wakely
On 04/12/18 07:45 +0100, François Dumont wrote: Hi   This patch fix a minor problem with usage of std::move_if_noexcept. We use it to move node content if move construtor is noexcept but we eventually use the allocator_type::construct method which might be slightly different. I think it is

[PATCH] Make std::match_results::_M_resize more useful

2018-12-04 Thread Jonathan Wakely
As both callers of match_results::_M_resize(unsigned) immediately follow it with a loop to update the value of each sub_match, that behaviour can be moved into _M_resize itself. The first caller fills the container with unmatched subs, which can be done with vector::assign, and the second caller

Re: [PATCH, libgo]: Use build.Default.Compiler in go/cmd/vet/types.goq

2018-12-04 Thread Ian Lance Taylor
On Tue, Dec 4, 2018 at 1:56 AM, Uros Bizjak wrote: > > Without this patch go tool vet segfaults on alpha due to unknown > architecture for gc compiler: > > go tool vet: exit status 2 > panic: runtime error: invalid memory address or nil pointer dereference > [signal SIGSEGV: segmentation

Re: [PATCH, OpenACC] Enable GOMP_MAP_FIRSTPRIVATE_INT for OpenACC

2018-12-04 Thread Jakub Jelinek
On Thu, Sep 20, 2018 at 07:38:04PM -0400, Julian Brown wrote: > 2018-09-20 Cesar Philippidis > Julian Brown > > gcc/ > * omp-low.c (maybe_lookup_field_in_outer_ctx): New function. > (convert_to_firstprivate_int): New function. >

Re: [PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-12-04 Thread Jakub Jelinek
On Mon, Sep 03, 2018 at 08:46:54PM -0400, Julian Brown wrote: > 2018-09-03 Cesar Philippidis > > gcc/fortran/ > * openmp.c (gfc_match_omp_variable_list): New allow_derived > argument. (gfc_match_omp_map_clause): Update call to > gfc_match_omp_variable_list.

Re: [PATCH v3] Make function clone name numbering independent.

2018-12-04 Thread Jan Hubicka
> On 2018-12-03 12:00 p.m., Michael Ploujnikov wrote: > > On 2018-12-01 11:29 a.m., H.J. Lu wrote: > >> This caused: > >> > >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88297 > >> > > > > Sorry about that. Looks like I should have been testing with > > --with-build-config=bootstrap-lto rather

Re: [PATCH][OpenACC] update gfortran's tile clause error handling

2018-12-04 Thread Jakub Jelinek
On Tue, Aug 07, 2018 at 02:47:07PM -0700, Cesar Philippidis wrote: > This patch updates how the OpenACC tile clause is handled in the Fortran > FE to match it's behavior in C/C++. Specifically, the tile clause now > errors on negative integer arguments, instead of emitting a warning. > > Is this

Re: [PATCH, OpenACC] (2/2) Fix implicit mapping for array slices on lexically-enclosing data constructs (PR70828)

2018-12-04 Thread Jakub Jelinek
On Tue, Aug 28, 2018 at 03:19:34PM -0400, Julian Brown wrote: > 2018-08-28 Julian Brown > > gcc/fortran/ > * trans-openmp.c (gfc_omp_finish_clause): Don't raise error for > assumed-size array if present in a lexically-enclosing data construct. > > libgomp/ > *

Re: [PATCH, OpenACC] (1/2) Fix implicit mapping for array slices on lexically-enclosing data constructs (PR70828)

2018-12-04 Thread Jakub Jelinek
On Tue, Aug 28, 2018 at 03:19:19PM -0400, Julian Brown wrote: > 2018-08-28 Julian Brown > Cesar Philippidis > > PR middle-end/70828 > > gcc/ > * gimplify.c (gimplify_omp_ctx): Add decl_data_clause hash map. > (new_omp_context): Initialise above. >

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v4]

2018-12-04 Thread Nick Clifton
Hi Ian, >>> Shouldn't we make it fool-proof by instead introducing a >>> DMGL_NO_RECURSION_LIMIT > You don't need my blessing--I wrote that code ages ago--but I agree > with Richard that in practice it's OK to limit recursion depth by > default. Real symbols have very limited recursion

Re: [patch,openacc] Propagate independent clause for OpenACC kernels pass

2018-12-04 Thread Richard Biener
On Tue, 4 Dec 2018, Jakub Jelinek wrote: > On Mon, Dec 03, 2018 at 11:40:39PM +, Julian Brown wrote: > > Jakub asked in the following email at the time of the patch submission > > for the gomp4 branch what the difference was between the new > > marked_independent flag and safelen == INT_MAX:

Re: [patch,openacc] Set safelen to INT_MAX for oacc independent pragma

2018-12-04 Thread Jakub Jelinek
On Thu, Sep 20, 2018 at 11:21:28AM -0700, Cesar Philippidis wrote: > This is another old gomp4 OpenACC patch which impacts targets that use > simd vectorization, such as the host and AMD GCN, rather than nvptx. > Basically, as the subject states, it sets safelen to INT_MAX for > independent acc

Re: [patch] Add OpenACC Fortran support for deviceptr and variable in common blocks

2018-12-04 Thread Chung-Lin Tang
On 2018/12/4 9:30 PM, Jakub Jelinek wrote: && gfc_match_omp_map_clause (>lists[OMP_LIST_MAP], - OMP_MAP_TOFROM)) + OMP_MAP_TOFROM, openacc)) Why? OpenMP doesn't have a copy clause, so I'd expect

Re: [testsuite] Require ucn support in gdc.test/compilable/ddoc12.d (PR d/88039)

2018-12-04 Thread Rainer Orth
Hi Iain, > On Sat, 1 Dec 2018 at 19:28, Iain Buclaw wrote: >> >> On Thu, 29 Nov 2018 at 15:12, Rainer Orth >> wrote: >> > >> > Hi Iain, >> > >> > > On Tue, 27 Nov 2018 at 20:32, Rainer Orth >> > > wrote: >> > >> >> > >> Hi Mike, >> > >> >> > >> > On Nov 27, 2018, at 2:18 AM, Rainer Orth >> >

Re: [patch,openacc] Propagate independent clause for OpenACC kernels pass

2018-12-04 Thread Jakub Jelinek
On Thu, Sep 20, 2018 at 11:06:40AM -0700, Cesar Philippidis wrote: > 2018-XX-YY Chung-Lin Tang > Cesar Philippidis > > gcc/ > * cfgloop.h (struct loop): Add 'bool marked_independent' field. > * omp-expand.c (struct omp_region): Add 'int kind' and > 'bool

Re: [patch,openacc] Propagate independent clause for OpenACC kernels pass

2018-12-04 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 11:40:39PM +, Julian Brown wrote: > Jakub asked in the following email at the time of the patch submission > for the gomp4 branch what the difference was between the new > marked_independent flag and safelen == INT_MAX: > >

Re: [PATCH][OpenACC] Update deviceptr handling during gimplification

2018-12-04 Thread Jakub Jelinek
On Tue, Aug 07, 2018 at 03:09:38PM -0700, Cesar Philippidis wrote: > I had previously posted this patch as part of a monster deviceptr patch > here . This > patch breaks out the generic gimplifier changes. Essentially, with this > patch,

Re: [PATCH] Fix predict-22.c testcase (PR tree-optimization/88285)

2018-12-04 Thread Jeff Law
On 12/4/18 5:11 AM, Jakub Jelinek wrote: > Hi! > > All uses of explicit -freorder-blocks-and-partition needs to be guarded with > freorder effective targets, e.g. arm doesn't support -fprofile-use. > > That said, until PR88310 is fixed, this effectively means the test is > UNSUPPORTED anywhere.

Re: [patch,openacc] Generate sequential loop for OpenACC loop directive inside kernels

2018-12-04 Thread Jakub Jelinek
On Thu, Sep 20, 2018 at 11:57:50AM -0700, Cesar Philippidis wrote: > 2018-XX-YY Cesar Philippidis > > * omp-low.c (install_var_field): New base_pointer_restrict > argument. > (scan_sharing_clauses): Update call to install_var_field. >

Re: [patch] Add OpenACC Fortran support for deviceptr and variable in common blocks

2018-12-04 Thread Jakub Jelinek
On Fri, Jun 29, 2018 at 12:04:58PM -0700, Cesar Philippidis wrote: > 2018-06-29 Cesar Philippidis > James Norris > > gcc/fortran/ > * openmp.c (gfc_match_omp_map_clause): Re-write handling of the > deviceptr clause. Add new common_blocks argument. Propagate it

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-12-04 Thread Michael Ploujnikov
On 2018-12-04 7:48 a.m., Martin Jambor wrote: > Hi, > > On Tue, Sep 04 2018, Michael Ploujnikov wrote: >> >> I've tried building with numbered_clone_function_name replaced by >> suffixed_function_name and with --enable-offload-targets=hsa and >> didn't see any errors in gomp.exp. I don't have a

Re: [PATCH] Fix P0634R3 - Down with typename! testsuite fallout

2018-12-04 Thread Marek Polacek
On Tue, Dec 04, 2018 at 09:42:51AM +0100, Jakub Jelinek wrote: > Hi! > > I've noticed these two tests now FAIL with -std=c++2a, they don't print > any diagnostics. As I believe that was the point of the P0634R3 changes, > this patch adjusts the testcases. Tested on x86_64-linux, ok for trunk? >

Re: [PATCH] Fix PR88301

2018-12-04 Thread Richard Biener
On Tue, 4 Dec 2018, Christophe Lyon wrote: > Hi Richard, > On Mon, 3 Dec 2018 at 14:37, Richard Biener wrote: > > > > > > This fixes a missed optimization in EVRP by teaching the code > > figuring out conditional asserts about conversions that preserve > > the converted value. > > > >

[PATCH][RFC] Poison bitmap_head->obstack

2018-12-04 Thread Richard Biener
This tries to make bugs like that in PR88317 harder to create by introducing a bitmap_release function that can be used as pendant to bitmap_initialize for non-allocated bitmap heads. The function makes sure to poison the bitmaps obstack member so the obstack the bitmap was initialized with can

Re: [PATCH] Fix PR88301

2018-12-04 Thread Christophe Lyon
Hi Richard, On Mon, 3 Dec 2018 at 14:37, Richard Biener wrote: > > > This fixes a missed optimization in EVRP by teaching the code > figuring out conditional asserts about conversions that preserve > the converted value. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk >

Re: OpenACC 2.5 Profiling Interface

2018-12-04 Thread Jakub Jelinek
On Sun, Nov 11, 2018 at 10:31:42PM -0600, Thomas Schwinge wrote: > On Tue, 28 Feb 2017 18:43:36 +0100, I wrote: > > The 2.5 versions of the OpenACC standard added a new chapter "Profiling > > Interface". > > I'd like to get that into trunk. It's not yet complete (that is, doesn't > provide all

Re: [PATCH] Fix predict-22.c testcase (PR tree-optimization/88285)

2018-12-04 Thread Richard Biener
On Tue, 4 Dec 2018, Jakub Jelinek wrote: > Hi! > > All uses of explicit -freorder-blocks-and-partition needs to be guarded with > freorder effective targets, e.g. arm doesn't support -fprofile-use. > > That said, until PR88310 is fixed, this effectively means the test is > UNSUPPORTED anywhere.

Re: [patch] various OpenACC reduction enhancements - test cases

2018-12-04 Thread Jakub Jelinek
On Fri, Jun 29, 2018 at 11:23:21AM -0700, Cesar Philippidis wrote: > Attached are the updated reductions tests cases. Again, these have been > bootstrapped and regression tested cleanly for x86_64 with nvptx > offloading. Is it OK for trunk? If Thomas is ok with this, it is ok for trunk. >

Re: [RFC][AArch64] Add support for system register based stack protector canary access

2018-12-04 Thread Florian Weimer
* Wilco Dijkstra: >> For userland, I would like to eventually copy the OpenBSD approach for >> architectures which have some form of PC-relative addressing: we can >> have multiple random canaries in (RELRO) .rodata in sufficiently close >> to the code that needs them (assuming that we have split

Re: [patch] various OpenACC reduction enhancements - FE changes

2018-12-04 Thread Jakub Jelinek
On Fri, Jun 29, 2018 at 11:22:00AM -0700, Cesar Philippidis wrote: > 2018-06-29 Cesar Philippidis > Nathan Sidwell > > gcc/c/ > * c-parser.c (c_parser_omp_variable_list): New c_omp_region_type > argument. Use it to specialize handling of OMP_CLAUSE_REDUCTION for

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-12-04 Thread Martin Jambor
Hi, On Tue, Sep 04 2018, Michael Ploujnikov wrote: > > I've tried building with numbered_clone_function_name replaced by > suffixed_function_name and with --enable-offload-targets=hsa and > didn't see any errors in gomp.exp. I don't have a readily available > HSA setup so if you could do a quick

*PING*^3 [C++ Patch] – PR C++/88114 - PATCH for destructor not generated for "virtual ~destructor() = default"

2018-12-04 Thread Tobias Burnus
On Wed, Nov 28, 2018 at 09:35:53PM +0100, Tobias Burnus wrote: > On the 25th November 2018, schrieb Tobias Burnus wrote: > > On 21 November 2018, Tobias Burnus wrote: > > > Hello all, > > > > > > if a class contains any 'virtual ... = 0', it's an abstract class > > > and for an > > > abstract

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-12-04 Thread Jakub Jelinek
On Fri, Jun 29, 2018 at 11:19:53AM -0700, Cesar Philippidis wrote: > The attached patch includes the nvptx and GCC ME reductions enhancements. > > Is this patch OK for trunk? It bootstrapped / regression tested cleanly > for x86_64 with nvptx offloading. This is all OpenACC specific code not

Re: [OpenACC] Enable firstprivate OpenACC reductions

2018-12-04 Thread Jakub Jelinek
On Wed, Sep 05, 2018 at 01:08:21PM -0700, Cesar Philippidis wrote: > 2018-XX-YY Cesar Philippidis > Chung-Lin Tang > > gcc/ > * gimplify.c (omp_add_variable): Enable firstprivate reduction > variables. > > gcc/testsuite/ > *

[PATCH] Fix predict-22.c testcase (PR tree-optimization/88285)

2018-12-04 Thread Jakub Jelinek
Hi! All uses of explicit -freorder-blocks-and-partition needs to be guarded with freorder effective targets, e.g. arm doesn't support -fprofile-use. That said, until PR88310 is fixed, this effectively means the test is UNSUPPORTED anywhere. Ok for trunk anyway? 2018-12-04 Jakub Jelinek

  1   2   >