Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Segher Boessenkool
On Fri, May 17, 2019 at 03:30:41PM +1000, Kugan Vivekanandarajah wrote: > On Fri, 17 May 2019 at 13:37, wrote: > > + if (GET_CODE (body) == SET) > > + { > > + rtx set_val = XEXP (body, 1); > > + enum rtx_code code = GET_CODE (set_val); > > + enum rtx_class cls =

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Segher Boessenkool
Hi Kewen, On Thu, May 16, 2019 at 10:35:30PM -0500, li...@linux.ibm.com wrote: > 2) For the other part of target invalid stmt check, as the > hook invalid_within_doloop grep data shows, no all targets > need to check whether invalid instructions exist in doloop. > If we scan all stmts as generic,

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Fri, May 17, 2019 at 02:24:22PM +0800, JunMa wrote: > 2019-05-17  Jun Ma Two spaces before < rather than one. >     PR tree-optimization/90106 >     * gcc.dg/cdce3.c: New test. > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/cdce3.c > @@ -0,0 +1,12 @@ > +/* { dg-do compile } */ Just use one s

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread JunMa
在 2019/5/17 上午11:09, JunMa 写道: 在 2019/5/17 上午6:04, Jakub Jelinek 写道: On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: One possibility is to add -fdump-tree-optimized and scan for /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ resp. /*

Re: [PATCH] i386: Enable MMX intrinsics without SSE/SSE2/SSSE3

2019-05-16 Thread Uros Bizjak
On Thu, May 16, 2019 at 11:59 PM H.J. Lu wrote: > > Since MMX intrinsics are marked with SSE/SSE2/SSSE3 for SSE emulation, > enable them without SSE/SSE2/SSSE3 if MMX is enabled. > > Restore TARGET_3DNOW check, which was changed to TARGET_3DNOW_A by > revision 271235. > > gcc/ > > PR targe

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Kewen.Lin
on 2019/5/17 下午1:30, Kugan Vivekanandarajah wrote: > Hi, > > On Fri, 17 May 2019 at 13:37, wrote: >> >> From: Kewen Lin >> >> +/* Check whether number of iteration computation is too costly for doloop >> + transformation. It expands the gimple sequence to equivalent RTL insn >> + sequence,

Go patch committed: Make value method of direct iface take pointer

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang make value methods of direct interface types take a pointer argument. Currently, a value method of a direct interface type takes the value of the receiver, which is pointer shaped, as the first parameter. When this method is called through interface, w

Strenghten aliasing_component_refs_p

2019-05-16 Thread Jan Hubicka
Hi, this patch cuts walks in aliasing_component_refs_p if the type we look for can not fit into a given type by comparing their sizes. Similar logic already exists in indirect_ref_may_alias_decl_p. When we walk reference a.b.c.d.e looking for type x we only need to do it if sizeof(a)>=sizeof(x) an

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Kugan Vivekanandarajah
Hi, On Fri, 17 May 2019 at 13:37, wrote: > > From: Kewen Lin > > Hi, > > Previous version link: > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html > > Comparing with the previous version, I moved the generic > parts of rs6000 target hook to IVOPTs. But I still kept > the target hook as

Re: Deque code cleanup and optimizations

2019-05-16 Thread François Dumont
Here is the simplified patch. I put back the _M_map checks, we'll see later if those can be removed.     * include/bits/stl_deque.h     (_Deque_iterator<>::__ptr_to): Remove, use std::__ptr_rebind.     (_Deque_base(_Deque_base&&, const allocator_type&)): New.     (_Deque_base::_Deque_impl_data):

Re: LWG2593 Move from allocator state is preserved

2019-05-16 Thread François Dumont
2 other tests needed to be adapted in 21_strings. Attached patch applied. 2019-05-17  François Dumont     Move from state of allocators (LWG2593)     * include/bits/stl_deque.h     (_Deque_base(_Deque_base&&, false_type)): Remove.     (_Deque_base(_Deque_base&&, true_type)): Remove.     (_Deque

[PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-05-16 Thread Feng Xue OS
This patch is meant to give user a way to optimize away those empty loops which are impossible to be recognized by compiler, such as C++ STL container-based loop, void f (std::map &m)   {     for (auto it = m.begin (); it != m.end (); ++it);   } An option "-ffinite-loop" is added t

[PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread linkw
From: Kewen Lin Hi, Previous version link: https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html Comparing with the previous version, I moved the generic parts of rs6000 target hook to IVOPTs. But I still kept the target hook as previous which checks some target specific criteria like inner

New Spanish PO file for 'gcc' (version 9.1.0)

2019-05-16 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: https://translationproject.org/latest/gcc/es.po (This file, 'gcc-9.1.0.es.po', has jus

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread JunMa
在 2019/5/17 上午6:04, Jakub Jelinek 写道: On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: One possibility is to add -fdump-tree-optimized and scan for /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ resp. /* { dg-final { scan-tree-dump "log

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 16 May 2019 at 21:14, Richard Biener wrote: > > On Wed, May 15, 2019 at 4:40 AM wrote: > > > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > * tree-ssa-loop-ivopts.c (get_mem_type_

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Martin Sebor
On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patch fixes quoting, spelling, and other formatting issues in diagnostics issued from files in the c-family/ directory and pointed out by the -Wformat-diag warning. Some of the changes in this patch

Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang intrinsifies the runtime/internal/atomic functions. Currently the runtime/internal/atomic functions are implemented in C using C compiler intrinsics. This patch lets the Go frontend recognize these functions and turn them into intrinsics directly. Bo

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Joseph Myers
On Thu, 16 May 2019, Maxim Kuvyrkov wrote: > Let's avoid mixing the two discussions: (1) converting svn repo to git > (and getting community consensus to switch to git) and (2) deciding on > which branches to keep in the new repo. > > With git, we can always split away unneeded history by remov

Re: [PATCH] soft-fp: Update soft-fp from glibc

2019-05-16 Thread Joseph Myers
On Wed, 15 May 2019, H.J. Lu wrote: > This patch is updating all soft-fp from glibc, most changes are > copyright years update, and changes other than years update are > > * soft-fp/extenddftf2.c: Use "_FP_W_TYPE_SIZE < 64" to check if > 4_FP_W_TYPEs are used for IEEE quad precision.

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: This patch really exposes a significant deficiency in our current implementation of default_target_compile: the order of various flags can be significant, but we only have that order implicitly expressed in the code, whic

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Wed, 15 May 2019 at 16:57, Richard Sandiford wrote: > > Thanks for doing this. > > kugan.vivekanandara...@linaro.org writes: > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > * tree-ssa-loop

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. Some of the changes in this patch are questionable. The diagnostics for

Go patch committed: Add intrinsics for runtime/internal/sys functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang adds intrinsics for runtime/internal/sys functions. runtime/internal/sys.Ctz32/64 and Bswap32/64 are currently implemented with compiler builtin functions. But if they are called from another package, the compiler does not know and therefore cannot tu

[C++ Patch] PR 67184 ("Missed optimization with C++11 final specifier")

2019-05-16 Thread Paolo Carlini
Hi, when Roberto Agostino and I implemented the front-end devirtualization of final overriders we missed this case, where it comes from the base. It seems to me that by way of access_path the existing approach can be neatly extended. Tested x86_64-linux. Thanks, Paolo. /

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Maxim Kuvyrkov wrote: > The scripts convert svn history branch by branch. They rely on git-svn > on convert individual branches. Git-svn is a good tool for converting > individual branches. It is, however, either very slow at converting the > entire GCC repo, or goes int

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: [...] We are not consistent here in `gnat_target_compile' anyway, as you can see from the two existing `concat' invocations, and also the `timeout=300' element. That is the GCC testsuite rather than DejaGnu itself, so it

[PATCH] Remove incorrect assertion from filesystem::absolute

2019-05-16 Thread Jonathan Wakely
The assertion is wrong, it should be *s.end() == 0, but that's not allowed. Just remove it, but keep the comment. * src/c++17/fs_ops.cc (absolute(const path&, error_code&)) [_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Remove bogus assertion. Tested x86_64-w64-mingw32, committed to trunk. c

Re: [PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-16 Thread Segher Boessenkool
On Thu, May 16, 2019 at 12:03:14PM +0100, Iain Sandoe wrote: > I did a quick check... > > dfp.exp most (all?) fail despite > > /* { dg-require-effective-target powerpc_p9vector_ok } */ > > with errors like this… > > error: decimal floating point not supported for this target Okay, so the test

Re: [PATCH] Fix PR 81721: ICE with PCH and Pragma warning and C++ operator

2019-05-16 Thread Joseph Myers
On Mon, 1 Apr 2019, apin...@marvell.com wrote: > From: Andrew Pinski > > Hi, > The problem here is the token->val.node is not saved over > a precompiled header for C++ operator. This can cause an > internal compiler error as we tried to print out the spelling > of the token as we assumed it w

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > One possibility is to add -fdump-tree-optimized and scan for > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" > "optimized" } } */ > resp. > /* { dg-final { scan-tree-dump "log \\(\[^\n\r]*\\); \\\[tail call\

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jonathan Wakely
On 16/05/19 13:07 -0600, Jeff Law wrote: On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov wrote: On May 16, 2019, at 7:22 PM, Jeff Law wrote: On 5/15/19 5:19 AM, Richard Biener wrote: For the official converted repo do we really want all (ol

[PATCH] i386: Enable MMX intrinsics without SSE/SSE2/SSSE3

2019-05-16 Thread H.J. Lu
Since MMX intrinsics are marked with SSE/SSE2/SSSE3 for SSE emulation, enable them without SSE/SSE2/SSSE3 if MMX is enabled. Restore TARGET_3DNOW check, which was changed to TARGET_3DNOW_A by revision 271235. gcc/ PR target/90497 * config/i386/i386-expand.c (ix86_expand_builtin):

[committed] Fix ICE in equal_mem_array_ref_p (PR c++/90484)

2019-05-16 Thread Jakub Jelinek
Hi! As mentioned in the PR, if we are very unlucky and have a hash collision not just when hash % hash table size is equal, but when the whole 32-bit hash is equal, we can actually end up with compatible types (bool vs. unsigned : 1 on the testcase), but sz0 != sz1 (one is 1-bit, the other 8-bit),

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Segher Boessenkool
Hi Jeff, On Thu, May 16, 2019 at 12:41:16PM -0600, Jeff Law wrote: > For architectures like PPC, we probably don't want to use the loop count > for anything else as it's likely expensive to get data in/out of the the > loop count register. That is part of it. Another part is that it costs extra

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Wed, May 08, 2019 at 06:09:06PM +0800, JunMa wrote: > 2019-05-07  Jun Ma > >     PR tree-optimization/90106 >     * gcc.dg/cdce1.c: Check tailcall code generation after cdce pass. >     * gcc.dg/cdce2.c: Likewise. This is wrong and results in UNSUPPORTED failures. Both tests are dg-do run, so

[RFC PATCH] Enhancements to profiledbootstrap

2019-05-16 Thread Arvind Sankar
Hi, I've been playing some with the PGO build infrastructure and have a few changes I thought I'd share and get feedback on whether they're completely crazy or not. I'm not terribly familiar with the innards of the build infra, so would appreciate any comments and suggestions. First, a recap of th

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Hi Janne, I differ there. A longer explanation: fork() is standard POSIX. Not all systems have posix_spawn. For those systems which do not have it, we would cause a regression by simply removing that functionality for this. The patch is OK from my side if you add fork() as a fallback option

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Am 16.05.19 um 22:10 schrieb Janne Blomqvist: On Thu, May 16, 2019 at 10:59 PM Thomas Koenig wrote: Hi Janne, fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.micros

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Ville Voutilainen
On Thu, 16 May 2019 at 23:28, Jonathan Wakely wrote: > Here's what I've tested and am about to commit. Looks good to me.

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
On 16/05/19 12:43 +0100, Jonathan Wakely wrote: On 16/05/19 12:29 +0100, Jonathan Wakely wrote: These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead we

[PATCH] Implement sane variant converting constructor (P0608R3)

2019-05-16 Thread Jonathan Wakely
* include/std/variant (__overload_set): Remove. (_Arr): New helper. (_Build_FUN): New class template to define a single FUN overload, with specializations to prevent unwanted conversions, as per P0608R3. (_Build_FUNs): New class template to build an overload

Re: patches to detect GCC diagnostics

2019-05-16 Thread Martin Sebor
On 5/16/19 8:58 AM, Roland Illig wrote: Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Janne Blomqvist
On Thu, May 16, 2019 at 10:59 PM Thomas Koenig wrote: > > Hi Janne, > > > fork() semantics can be problematic. Most unix style OS'es have > > posix_spawn which can be used to replace fork + exec in many cases. > > For more information see > > e.g. > > https://www.microsoft.com/en-us/research/upl

[PATCH] x86-64: Add vararg ABI tests

2019-05-16 Thread H.J. Lu
We can scan stack for return address to get vector arguments passed on stack. * gcc.target/x86_64/abi/test_varargs-m128.c: New file. * gcc.target/x86_64/abi/avx/test_varargs-m256.c: Likewise. * gcc.target/x86_64/abi/avx512f/test_varargs-m512.c: Likewise. --- .../x86_64/abi

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Hi Janne, fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.microsoft.com/en-us/research/uploads/prod/2019/04/fork-hotos19.pdf This replaces the one use of fork in libgf

[PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Janne Blomqvist
fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.microsoft.com/en-us/research/uploads/prod/2019/04/fork-hotos19.pdf This replaces the one use of fork in libgfortran with p

Re: OpenACC Profiling Interface: 'acc_register_library'

2019-05-16 Thread Thomas Schwinge
Hi Jakub! On Thu, 16 May 2019 17:54:23 +0200, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 05:21:56PM +0200, Thomas Schwinge wrote: > > > Jakub, would you please especially review the non-OpenACC-specific > > > changes here, including the libgomp ABI changes? > > > > Given a baseline that I've

Re: [PATCH 9/12] adjust tests to quoting/spelling diagnostics fixes

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch adjusts the expected test output to the quoting, > spelling and other formatting changes in diagnostics to fix issues > pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-tests.diff > > gcc/testsuite/ChangeLog: >

Re: patches to detect GCC diagnostics

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 04:58:08PM +0200, Roland Illig wrote: > - error ("#pragma GCC target string... is badly formed"); > + error ("%<#pragma GCC target%> string is badly formed"); > - error ("#pragma GCC optimize string... is badly formed"); > + error ("%<#pragma GCC opti

Re: [PATCH 8/12] fix diagnostic quoting/spelling in the middle-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in middle-end files and > pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-midend.diff > > gcc/ChangeLog: > > * bui

Re: [PATCH 6/12] fix diagnostic quoting/spelling in C++

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the C++ front-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-cp.diff > > gcc/cp/ChangeLog: > > * call.c (print_

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c-family.diff > > gcc/c-family/ChangeLog

Re: [PATCH 11/12] fix diagnostic quoting/spelling issues in i386 back-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:33 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the i386 back-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-i386.diff > > gcc/ChangeLog: > > * config/i386/i38

Re: [PATCH 10/12] fix diagnostic quoting/spelling in D

2019-05-16 Thread Jeff Law
On 5/14/19 3:33 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the D front end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-d.diff > > gcc/d/ChangeLog: > > * d/d-builtins.cc (d

Re: [PATCH 3/12] fix diagnostic quoting/spelling in Brig

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the Brig front end and pointed > out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-brig.diff > > gcc/brig/ChangeLog: > > * brigfront

Re: [PATCH 7/12] fix diagnostic quoting/spelling in libgcc

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the libgcc directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-libgcc.diff > > libgcc/ChangeLog: > >

Re: [PATCH 4/12] fix diagnostic quoting/spelling in the C front-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the C front-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c.diff > > gcc/c/ChangeLog: > > * c-decl.c (start_de

Re: [PATCH 2/12] fix diagnostic quoting/spelling in ada

2019-05-16 Thread Jeff Law
On 5/14/19 3:31 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the Ada front and pointed out by > the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-ada.diff > > gcc/ada/ChangeLog: > > * gcc-interface/tr

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jeff Law
On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: > On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov > wrote: >> >>> On May 16, 2019, at 7:22 PM, Jeff Law wrote: >>> >>> On 5/15/19 5:19 AM, Richard Biener wrote: For the official converted repo do we really want all (old) development b

[PATCH] Refactor tree-affine.c to not build GENERIC trees

2019-05-16 Thread Richard Biener
The following picks up the patch from last December, refactoring aff_combination_expand to not use gimple_assign_rhs_to_tree but analyze GIMPLE stmts directly. Last December I was stuck at FAIL: gcc.dg/tree-ssa/ivopts-lt-2.c scan-tree-dump-times ivopts "PHI" 1 FAIL: gcc.dg/tree-ssa/ivopts-lt-2.

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Jeff Law
On 5/16/19 12:46 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: >> >> On 5/15/19 3:03 PM, Alexandre Oliva wrote: >>> On May 15, 2019, Richard Biener wrote: >>> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > > Gimple jump threading does not dup

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: > > On 5/15/19 3:03 PM, Alexandre Oliva wrote: > > On May 15, 2019, Richard Biener wrote: > > > >> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > >>> > >>> Gimple jump threading does not duplicate forwarder blocks that might > >>> be pre

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Jeff Law
On 5/15/19 2:47 AM, Richard Biener wrote: > On Wed, 15 May 2019, Kewen.Lin wrote: > >> on 2019/5/14 下午3:26, Richard Biener wrote: >>> On Tue, May 14, 2019 at 5:10 AM wrote: From: Kewen Lin Previous version link for background: https://gcc.gnu.org/ml/gcc-patches/2019-04/m

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 4:04 PM Martin Jambor wrote: > > Hi Richi, > > On Thu, May 16 2019, Richard Biener wrote: > > On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: > >> > >> Hello, > >> > >> this is a follow-up from a WIP patch I sent here in late December: > >> https://gcc.gnu.org/ml/gcc

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Ramana Radhakrishnan
On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov wrote: > > > On May 16, 2019, at 7:22 PM, Jeff Law wrote: > > > > On 5/15/19 5:19 AM, Richard Biener wrote: > >> > >> For the official converted repo do we really want all (old) > >> development branches to be in the > >> main git repo? I suppose we

Re: [PATCH 2/2] [PR88836][aarch64] Fix CSE to process parallel rtx dest one by one

2019-05-16 Thread Jeff Law
On 5/15/19 8:08 PM, kugan.vivekanandara...@linaro.org wrote: > From: Kugan Vivekanandarajah > > This patch changes cse_insn to process parallel rtx one by one such that > any destination rtx in cse list is invalidated before processing the > next. > > gcc/ChangeLog: > > 2019-05-16 Kugan Viveka

Re: [PATCH] Handle a location with NULL as a file (PR driver/90495)

2019-05-16 Thread Jeff Law
On 5/16/19 5:19 AM, Martin Liška wrote: > Hi. > > With LTO and -fsanitize we end up with a static ctor > (_GLOBAL__sub_I_00099_0_main) that has no source location. > With that stack usage will print '(artificial)' as a location > of the function. > > Patch can bootstrap on x86_64-linux-gnu and su

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Jeff Law
On 5/14/19 10:29 PM, bin.cheng wrote: > Hi, > As noted in PR57534 comment #33, SLSR currently doesn't strength reduce memory > references in reported cases, which conflicts with its comment at the > beginning of file. > The main reason is in functions slsr_process_ref and restructure_reference >

Re: [PATCH] gcc: move assemble_start_function / assemble_end_function to output_mi_thunk

2019-05-16 Thread Max Filippov
On Wed, May 15, 2019 at 2:46 PM Richard Sandiford wrote: > > Max Filippov writes: > > Let backends call assemble_start_function after they have generated > > thunk function body so that a constant pool could be output if it is > > required. This may help backends to avoid implementing custom cons

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Segher Boessenkool
On Thu, May 16, 2019 at 09:25:49AM +0200, Richard Biener wrote: > On Wed, 15 May 2019, Segher Boessenkool wrote: > > > Otherwise I understand that IVOPTs doesn't properly cost > > > the doloop IV update and conditional branch. > > > > Currently it doesn't even *know* something is or isn't a doloop

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
> On May 16, 2019, at 7:22 PM, Jeff Law wrote: > > On 5/15/19 5:19 AM, Richard Biener wrote: >> >> For the official converted repo do we really want all (old) >> development branches to be in the >> main git repo? I suppose we could create a readonly git from the >> state of the whole repositor

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jeff Law
On 5/15/19 5:19 AM, Richard Biener wrote: > > For the official converted repo do we really want all (old) > development branches to be in the > main git repo? I suppose we could create a readonly git from the > state of the whole repository > at the point of conversion (and also keep the SVN in r

Re: [PATCH] Remove a test-case that leads to a huge stack (and file) allocation (PR middle-end/90478).

2019-05-16 Thread Jeff Law
On 5/16/19 5:42 AM, Martin Liška wrote: > Hi. > > I'm going to remove the test as it leads to a huge .s files and stack > allocation at gcc/stmt.c:777 > > Ready for trunk? > Martin > > gcc/testsuite/ChangeLog: > > 2019-05-16 Martin Liska > > PR middle-end/90478 > * gcc.dg/tree-s

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Jeff Law
On 5/15/19 3:03 PM, Alexandre Oliva wrote: > On May 15, 2019, Richard Biener wrote: > >> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: >>> >>> Gimple jump threading does not duplicate forwarder blocks that might >>> be present before or after the copied block. > >> Empty forwarder blo

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Bin.Cheng
On Thu, May 16, 2019 at 11:50 PM Bill Schmidt wrote: > > Thanks, Bin and Richard -- I am out of the office until Tuesday, so will > review > when I get back. Bin, please CC me on SLSR patches as otherwise I might miss > them. Thanks! Thanks for helping. Will do it next time. Thanks, bin > > B

Re: OpenACC Profiling Interface: 'acc_register_library' (was: OpenACC 2.5 Profiling Interface)

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 05:21:56PM +0200, Thomas Schwinge wrote: > > Jakub, would you please especially review the non-OpenACC-specific > > changes here, including the libgomp ABI changes? > > Given a baseline that I've not yet posted ;-) would you please anyway > have a look at the following chan

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Bill Schmidt
Thanks, Bin and Richard -- I am out of the office until Tuesday, so will review when I get back. Bin, please CC me on SLSR patches as otherwise I might miss them. Thanks! Bill On 5/16/19 6:37 AM, Richard Biener wrote: > On Wed, May 15, 2019 at 6:30 AM bin.cheng wrote: >> Hi, >> As noted in PR

Add stats for aliasing_component_refs_p

2019-05-16 Thread Jan Hubicka
Hi, tis patch adds stats for aliasing_component_refs_p oracle into the alias oracle report. Bootstrapped/regtested x86_64-linux, comitted as obvious. This is dump for LTO optimizing tramp3d. Compile time: refs_may_alias_p: 0 disambiguations, 0 queries ref_maybe_used_by_call_p: 248 disambigua

OpenACC Profiling Interface: 'acc_register_library' (was: OpenACC 2.5 Profiling Interface)

2019-05-16 Thread Thomas Schwinge
Hi Jakub! On Sun, 11 Nov 2018 22:31:42 -0600, I wrote: > On Tue, 28 Feb 2017 18:43:36 +0100, I wrote: > > The 2.5 versions of the OpenACC standard added a new chapter "Profiling > > Interface". > > I'd like to get that into trunk. It's not yet complete (that is, doesn't > provide all the informa

Re: [PATCH] fortran: C++ support for generating C prototypes

2019-05-16 Thread Jakub Jelinek
On Wed, May 15, 2019 at 10:41:06PM +0300, Janne Blomqvist wrote: > > 2) I don't think float _Complex is > >passed the same as std::complex and similar for others; > >std::complex is in libstdc++ a C++ class with with > >__complex__ float as its sole non-static data member and with non-t

Re: [PATCH 0/12] detect quoting and punctuation problems in diagnostics

2019-05-16 Thread Martin Sebor
On 5/16/19 4:02 AM, Martin Liška wrote: Hi. Maybe I've install the patches wrongly, but I see following error on ppc64le during bootstrap in stage2: I also noticed it yesterday on x86_64. The %qk was vestige of an earlier attempt to use the pretty-printer to format TREE_CODEs. I have this in

patches to detect GCC diagnostics

2019-05-16 Thread Roland Illig
Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't have to submit i18n bug reports in the for

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Martin Jambor
Hi Richi, On Thu, May 16 2019, Richard Biener wrote: > On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: >> >> Hello, >> >> this is a follow-up from a WIP patch I sent here in late December: >> https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01765.html >> >> Just like the last time, the patch b

Re: [PATCH] OpenMP simd if clause support with runtime determined argument (take 2)

2019-05-16 Thread Richard Biener
On Thu, 16 May 2019, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 11:30:38AM +0200, Richard Biener wrote: > > > note_simd_array_uses indeed does walk the IL and does look at the calls, > > > but I'd need some data structure where to store the argument; we don't > > > have > > > loop_vinfo yet (

[PATCH] OpenMP simd if clause support with runtime determined argument (take 2)

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:30:38AM +0200, Richard Biener wrote: > > note_simd_array_uses indeed does walk the IL and does look at the calls, > > but I'd need some data structure where to store the argument; we don't have > > loop_vinfo yet (we don't have it even before the loop over vector sizes),

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-16 Thread Jonathan Wakely
On 16/05/19 13:30 +0100, Jonathan Wakely wrote: On 16/05/19 11:05 +0100, Jonathan Wakely wrote: On 16/05/19 07:47 +0200, François Dumont wrote: On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are ov

Re: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx

2019-05-16 Thread Dragan Mladjenovic
Ping. From: Dragan Mladjenovic Sent: Thursday, May 9, 2019 12:29 PM To: gcc-patches@gcc.gnu.org Cc: Dragan Mladjenovic; Jakub Jelinek; Matthew Fortune Subject: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx From: "Dragan Mladjenovic" Hi

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 2:52 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:53 PM Martin Liška wrote: >> >> On 5/16/19 1:42 PM, Richard Biener wrote: >>> On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: On 5/16/19 1:24 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:18 PM Martin

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Maciej W. Rozycki
On Wed, 15 May 2019, Jacob Bachmeyer wrote: > This patch really exposes a significant deficiency in our current > implementation of default_target_compile: the order of various flags > can be significant, but we only have that order implicitly expressed in > the code, which goes all the way ba

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:53 PM Martin Liška wrote: > > On 5/16/19 1:42 PM, Richard Biener wrote: > > On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: > >> > >> On 5/16/19 1:24 PM, Richard Biener wrote: > >>> On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: > > Hi. > >

Re: [PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 11:20 AM Thomas De Schampheleire wrote: > > From: Thomas De Schampheleire > > In addition to making -feliminate-unused-debug-symbols work for the DWARF > format (see [1]), make this option the default. This behavior was the case > before, e.g. under gcc 4.9.x. > [1] https:

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-16 Thread Maciej W. Rozycki
On Wed, 15 May 2019, Jacob Bachmeyer wrote: > > Index: gcc/gcc/testsuite/lib/gnat.exp > > === > > --- gcc.orig/gcc/testsuite/lib/gnat.exp > > +++ gcc/gcc/testsuite/lib/gnat.exp > > @@ -167,6 +167,8 @@ proc gnat_target_compile { source

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-16 Thread Jonathan Wakely
On 16/05/19 11:05 +0100, Jonathan Wakely wrote: On 16/05/19 07:47 +0200, François Dumont wrote: On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are overloaded for const and non-const:    const _Equa

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Richard Biener
On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: > > Hello, > > this is a follow-up from a WIP patch I sent here in late December: > https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01765.html > > Just like the last time, the patch below is is a reimplementation of > IPA-SRA to make it a full IP

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 1:42 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: >> >> On 5/16/19 1:24 PM, Richard Biener wrote: >>> On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: Hi. We should not allow target_clones being combined with alias attribute. >>

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: > > On 5/16/19 1:24 PM, Richard Biener wrote: > > On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: > >> > >> Hi. > >> > >> We should not allow target_clones being combined with alias attribute. > >> > >> Patch can bootstrap on x86_64-linux-gn

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
On 16/05/19 12:29 +0100, Jonathan Wakely wrote: These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead we do a runtime branch, marked [[unlikely]] to make

[PATCH] Remove a test-case that leads to a huge stack (and file) allocation (PR middle-end/90478).

2019-05-16 Thread Martin Liška
Hi. I'm going to remove the test as it leads to a huge .s files and stack allocation at gcc/stmt.c:777 Ready for trunk? Martin gcc/testsuite/ChangeLog: 2019-05-16 Martin Liska PR middle-end/90478 * gcc.dg/tree-ssa/pr90478-2.c: Remove. --- gcc/testsuite/gcc.dg/tree-ssa/pr904

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 1:24 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: >> >> Hi. >> >> We should not allow target_clones being combined with alias attribute. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > So t

  1   2   >