Re: [PATCH] [i386] Fix ICE in pass_rpad.

2021-09-18 Thread Jakub Jelinek via Gcc-patches
On Sat, Sep 18, 2021 at 11:09:32AM +0800, liuhongt wrote: > Besides conversion instructions, pass_rpad also handles scalar > sqrt/rsqrt/rcp/round instructions, while r12-3614 should only want to > handle conversion instructions, so fix it. > > Bootstrapped and regtest on x86_64-linux-gnu{-m32,}

Re: [PATCH] [i386] Fix ICE in pass_rpad.

2021-09-18 Thread Hongtao Liu via Gcc-patches
On Sat, Sep 18, 2021 at 3:31 PM Jakub Jelinek wrote: > > On Sat, Sep 18, 2021 at 11:09:32AM +0800, liuhongt wrote: > > Besides conversion instructions, pass_rpad also handles scalar > > sqrt/rsqrt/rcp/round instructions, while r12-3614 should only want to > > handle conversion instructions, so fix

Re: [PATCH] [i386] Fix ICE in pass_rpad.

2021-09-18 Thread Jakub Jelinek via Gcc-patches
On Sat, Sep 18, 2021 at 03:56:42PM +0800, Hongtao Liu wrote: > > Wouldn't it be better to do: > > E_VOIDmode: > > gcc_assert (convert_p); > !convert_p, Must be typo :) Yes, sorry. > > > break; > > default: > > gcc_unreachable (); > > ? > Sur

openmp: Allow private or firstprivate arguments to default clause even for C/C++

2021-09-18 Thread Jakub Jelinek via Gcc-patches
Hi! OpenMP 5.1 allows default(private) or default(firstprivate) even in C/C++, but it behaves the same way as in Fortran only for variables not declared at namespace or file scope. For the namespace/file scope variables it instead behaves as default(none). Bootstrapped/regtested on x86_64-linux

[committed] openmp: Handle unconstrained and reproducible modifiers on order(concurrent)

2021-09-18 Thread Jakub Jelinek via Gcc-patches
Hi! This patch adds handling for unconstrained and reproducible modifiers on order(concurrent) clause. For all static schedules (including auto and no schedule or dist_schedule clauses) I believe what we implement is reproducible, so the patch doesn't do much beyond recognizing those. Note, there

[PATCH] PR middle-end/88173: More constant folding of NaN comparisons.

2021-09-18 Thread Roger Sayle
This patch tackles PR middle-end/88173 where the order of operands in a comparison affects constant folding. As diagnosed by Jason Merrill, "match.pd handles these comparisons very differently". The history is that the middle end, typically canonicalizes comparisons to place constants on the rig

Re: [PATCH/RFC 1/2] WPD: Enable whole program devirtualization

2021-09-18 Thread Feng Xue OS via Gcc-patches
>On 9/16/21 22:29, Feng Xue OS wrote: >>> On 9/16/21 05:25, Feng Xue OS via Gcc-patches wrote: This and following patches are composed to enable full devirtualization under whole program assumption (so also called whole-program devirtualization, WPD for short), which is an enhancemen

Re: [PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-18 Thread Martin Jambor
Hi, On Fri, Sep 17 2021, Segher Boessenkool wrote: > On Fri, Sep 17, 2021 at 05:42:38PM +0800, Kewen.Lin wrote: >> Against v2 [2], this v3 addressed Martin's review comments: >> - Replace HWI auto_vec with unsigned int for target_info >> to avoid overkill (also Segher's comments), adjust som

Re: [PATCH] introduce predicate analysis class

2021-09-18 Thread Martin Sebor via Gcc-patches
On 9/17/21 10:08 PM, Jeff Law wrote: On 9/17/2021 4:05 PM, Martin Sebor wrote: On 9/2/21 10:28 AM, Jeff Law via Gcc-patches wrote: On 8/30/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: The predicate analysis subset of the tree-ssa-uninit pass isn't necessarily specific to the detection

Re: [PATCH] libgcc, i386: Export *hf* and *hc* from libgcc_s.so.1

2021-09-18 Thread Iain Sandoe
Hi Hongtao, > On 8 Sep 2021, at 10:31, Hongtao Liu wrote: > > On Wed, Sep 8, 2021 at 5:09 PM Jakub Jelinek wrote: >> >> On Wed, Sep 08, 2021 at 10:37:17AM +0800, Hongtao Liu wrote: >>> Bootstrapped and regtested on x86_64-linux-gnu{-m32,}. >>> Ok for trunk? >>> >>> libgcc/ChangeLog: >>> >>

[PATCH] Fix middle-end/102395: reg_class having only NO_REGS and ALL_REGS.

2021-09-18 Thread apinski--- via Gcc-patches
From: Andrew Pinski So this is a simple fix is to just add to the assert that sclass and dclass are both greater than or equal to NO_REGS. NO_REGS is documented as the first register class so it should have the value of 0. gcc/ChangeLog: * lra-constraints.c (check_and_process_move): Ass

Re: [PATCH] introduce predicate analysis class

2021-09-18 Thread Martin Sebor via Gcc-patches
On 9/18/21 12:46 PM, Martin Sebor wrote: On 9/17/21 10:08 PM, Jeff Law wrote: On 9/17/2021 4:05 PM, Martin Sebor wrote: On 9/2/21 10:28 AM, Jeff Law via Gcc-patches wrote: On 8/30/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: The predicate analysis subset of the tree-ssa-uninit pass i

Re: [PATCH] Fix middle-end/102395: reg_class having only NO_REGS and ALL_REGS.

2021-09-18 Thread Jeff Law via Gcc-patches
On 9/18/2021 1:16 PM, apinski--- via Gcc-patches wrote: From: Andrew Pinski So this is a simple fix is to just add to the assert that sclass and dclass are both greater than or equal to NO_REGS. NO_REGS is documented as the first register class so it should have the value of 0. gcc/ChangeLo

Re: [PATCH] libgcc, i386: Export *hf* and *hc* from libgcc_s.so.1

2021-09-18 Thread Hongtao Liu via Gcc-patches
On Sunday, September 19, 2021, Iain Sandoe wrote: > Hi Hongtao, > > > On 8 Sep 2021, at 10:31, Hongtao Liu wrote: > > > > On Wed, Sep 8, 2021 at 5:09 PM Jakub Jelinek wrote: > >> > >> On Wed, Sep 08, 2021 at 10:37:17AM +0800, Hongtao Liu wrote: > >>> Bootstrapped and regtested on x86_64-linux-

Re: [PATCH] Remove unused function make_unique_name.

2021-09-18 Thread Jeff Law via Gcc-patches
On 9/13/2021 6:16 PM, Benjamin Peterson wrote: * attribs.c (make_unique_name): Delete. * attribs.h (make_unique_name): Delete. Thanks.  Installed on the trunk. jeff

RE:PIPE GENERATOR

2021-09-18 Thread nayaogroup via Gcc-patches
Hi, my friend Do you have any interesting to import from china? home generator parts、ball valve、pipe is our main product, tell me if you need further info. thanks in advance Best regards PAGE ZU NAYAO GROUP TAIZHOU CHINA

Re: [PATCH] Come up with section_flag enum.

2021-09-18 Thread Jeff Law via Gcc-patches
On 9/7/2021 3:43 AM, Martin Liška wrote: Hi. I'm planning some refactoring related to 'section *' and I noticed we have quite ugly mask definitions (of form 1UL << N), where SECTION_FORGET is unused and #define SECTION_STYLE_MASK 0x60    /* bits used for SECTION_STYLE */ Is actually

Re: [PATCH] Optimize macro: make it more predictable

2021-09-18 Thread Jeff Law via Gcc-patches
On 9/13/2021 7:52 AM, Martin Liška wrote: On 8/27/21 11:05, Richard Biener wrote: So with ignoring darktable which seems completely insane the cases will likely continue to work as intended if we change from the current scheme to appending as proposed. All right, I'm addressing the flag_com

Re: [PATCH] PR middle-end/88173: More constant folding of NaN comparisons.

2021-09-18 Thread Jeff Law via Gcc-patches
On 9/18/2021 2:56 AM, Roger Sayle wrote: This patch tackles PR middle-end/88173 where the order of operands in a comparison affects constant folding. As diagnosed by Jason Merrill, "match.pd handles these comparisons very differently". The history is that the middle end, typically canonicali

Re: [PING] Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-18 Thread Jeff Law via Gcc-patches
On 9/10/2021 1:48 AM, Thomas Schwinge wrote: Hi! Ping. My patches again attached, for easy reference. Grüße Thomas On 2021-09-03T18:33:37+0200, I wrote: Hi! On 2021-09-02T21:09:54+0200, I wrote: On 2021-09-02T15:59:14+0200, I wrote: On 2016-08-05T14:16:58-0400, David Malcolm wrote

Re: [PATCH 1/2] Add gimple_truth_valued_p to match.pd and use it

2021-09-18 Thread Jeff Law via Gcc-patches
On 8/13/2021 6:19 PM, apinski--- via Gcc-patches wrote: From: Andrew Pinski While working on some more boolean optimizations, I noticed that there are places which does SSA_NAME@0 and then look at then either use get_nonzero_bits or ssa_name_has_boolean_range to see if the ssa name had a boo

Re: [PATCH 2/2] Fix 101805: Simplify min/max of boolean arguments

2021-09-18 Thread Jeff Law via Gcc-patches
On 8/13/2021 6:19 PM, apinski--- via Gcc-patches wrote: From: Andrew Pinski I noticed this while Richard B. fixing PR101756. Basically min of two bools is the same as doing an "and" and max of two bools is doing an "ior". gcc/ChangeLog: * match.pd: Add min/max patterns for bool typ