Re: [PATCH v2 RFA] diagnostic: avoid repeating include path

2022-01-14 Thread Jason Merrill via Gcc-patches
On 1/13/22 17:30, David Malcolm wrote: On Thu, 2022-01-13 at 17:08 -0500, Jason Merrill wrote: When a sequence of diagnostic messages bounces back and forth repeatedly between two includes, as with  #include  std::map m ("123", "456"); The output is quite a bit longer than necessary

Re: [PATCH v3 RFC] c++: add color to function decl printing

2022-01-14 Thread Jason Merrill via Gcc-patches
On 1/14/22 16:49, David Malcolm wrote: On Mon, 2021-12-13 at 09:58 -0500, Jason Merrill via Gcc-patches wrote: On 12/13/21 06:02, Jonathan Wakely wrote: On Sun, 12 Dec 2021 at 05:39, Jason Merrill mailto:ja...@redhat.com>> wrote:  >  > In reading C++ diagnostics, it's often hard to find the

[PATCH] libstdc++: Add missing free functions for atomic_flag [PR103934]

2022-01-14 Thread Thomas Rodgers via Gcc-patches
From c2b74fd7cf2668d288f46da42565e5eb954e5e1f Mon Sep 17 00:00:00 2001 From: Thomas Rodgers Date: Fri, 14 Jan 2022 18:30:27 -0800 Subject: [PATCH] libstdc++: Add missing free functions for atomic_flag [PR103934] libstdc++-v3/ChangeLog: PR103934 * include/std/atomic: Add missing free

[PATCH] c++: ICE with noexcept and canonical types [PR101715]

2022-01-14 Thread Marek Polacek via Gcc-patches
This is a "canonical types differ for identical types" ICE, which started with r11-4682. It's a bit tricky to explain. Consider: template struct S { S bar() noexcept(T::value); // #1 S foo() noexcept(T::value); // #2 }; template S S::foo() noexcept(T::value) {} // #3 We ICE

[committed] ada: Fix up handling of ghost units [PR104027]

2022-01-14 Thread Jakub Jelinek via Gcc-patches
Hi! As reported, libgnat-12.so gets PT_GNU_STACK RWE, which means it doesn't work in some SELinux configurations. This is caused by the a-nbnbig.o file, which is a ghost unit and since r12-5670 the FE emits an object file for it, but exits before compile_file has a chance to finalize it e.g. with

Re: [committed] analyzer: fix ICE in taint checker on unary ops [PR104029]

2022-01-14 Thread David Malcolm via Gcc-patches
On Fri, 2022-01-14 at 17:53 -0500, David Malcolm wrote: > gcc/analyzer/ChangeLog: > PR analyzer/104029 > * sm-taint.cc (taint_state_machine::alt_get_inherited_state): > Remove gcc_unreachable from default case for unary ops. > > gcc/testsuite/ChangeLog: > PR

[PATCH] widening_mul, i386: Improve spaceship expansion on x86 [PR103973]

2022-01-14 Thread Jakub Jelinek via Gcc-patches
Hi! C++20: #include auto cmp4way(double a, double b) { return a <=> b; } expands to: ucomisd %xmm1, %xmm0 jp .L8 movl$0, %eax jne .L8 .L2: ret .p2align 4,,10 .p2align 3 .L8: comisd %xmm0, %xmm1 movl$-1,

[committed] analyzer: fix ICE when combining taint states has_ub and has_lb

2022-01-14 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as cc3b67e40140ec79f86e79a96d7fdd169b84faaf. gcc/analyzer/ChangeLog: * sm-taint.cc (taint_state_machine::combine_states): Handle combination of has_ub and has_lb. gcc/testsuite/ChangeLog: *

[committed] analyzer: fix ICE in taint checker on unary ops [PR104029]

2022-01-14 Thread David Malcolm via Gcc-patches
gcc/analyzer/ChangeLog: PR analyzer/104029 * sm-taint.cc (taint_state_machine::alt_get_inherited_state): Remove gcc_unreachable from default case for unary ops. gcc/testsuite/ChangeLog: PR analyzer/104029 * gcc.dg/analyzer/pr104029.c: New test. *

Re: [PATCH] libstdc++: Implement C++20 atomic and atomic

2022-01-14 Thread Jonathan Wakely via Gcc-patches
On Sat, 18 Sept 2021 at 05:12, Thomas Rodgers wrote: > From: Thomas Rodgers > > Let's try this one instead. > > Signed-off-by: Thomas Rodgers > If you're doing DCO "Signed-off-by" commits you don't need FSF copyright notices in the new tests. I no longer put any copyright notices in the

Re: [PATCH v2 RFC] c++: add color to function decl printing

2022-01-14 Thread Jonathan Wakely via Gcc-patches
On Fri, 14 Jan 2022 at 21:49, David Malcolm wrote: > > Jonathan, did you try the v2 patch? > No, sorry.

Re: [PATCH 11/11] libstdc++: Fix ODR issues with different -m flags

2022-01-14 Thread Jonathan Wakely via Gcc-patches
On Mon, 15 Nov 2021 at 08:57, Matthias Kretz wrote: > ping. OK to push? > Sorry for the delay - this is OK for trunk. > On Tuesday, 8 June 2021 14:12:23 CET Matthias Kretz wrote: > > From: Matthias Kretz > > > > Explicitly support use of the stdx::simd implementation in situations > > where

[PATCH, committed] PR fortran/99256 - ICE in variable_check, at fortran/check.c:1012

2022-01-14 Thread Harald Anlauf via Gcc-patches
Dear all, this is a rather satisfying mini-patch which removes code to fix a bug. The intrinsics MOVE_ALLOC, C_F_POINTER, and C_F_PROCPOINTER require deferred checks of part of their actual argument types which may be of "any" type. This however excludes alternate return specifiers which

Re: [Patch][V4][Patch 2/2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables.

2022-01-14 Thread Qing Zhao via Gcc-patches
> On Jan 14, 2022, at 12:58 PM, Martin Sebor wrote: > > On 1/14/22 11:29, Qing Zhao wrote: >>> On Jan 14, 2022, at 12:11 PM, Martin Sebor wrote: >>> >>> On 1/14/22 09:30, Qing Zhao wrote: > On Jan 14, 2022, at 6:45 AM, Richard Biener > wrote: > > On Thu, Jan 13, 2022 at

Re: [PATCH] cprop_hardreg: Workaround for narrow mode != lowpart targets

2022-01-14 Thread Andreas Krebbel via Gcc-patches
On 1/14/22 20:41, Andreas Krebbel via Gcc-patches wrote: > On 1/14/22 08:37, Richard Biener wrote: > ... >> Can the gist of this bug be put into the GCC bugzilla so the rev can >> refer to it? > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104034 > >> Can we have a testcase even? > The testcase

Re: [PATCH] cprop_hardreg: Workaround for narrow mode != lowpart targets

2022-01-14 Thread Andrew Pinski via Gcc-patches
On Fri, Jan 14, 2022 at 11:42 AM Andreas Krebbel via Gcc-patches wrote: > > On 1/14/22 08:37, Richard Biener wrote: > ... > > Can the gist of this bug be put into the GCC bugzilla so the rev can > > refer to it? > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104034 > > > Can we have a testcase

Re: [PATCH] cprop_hardreg: Workaround for narrow mode != lowpart targets

2022-01-14 Thread Andreas Krebbel via Gcc-patches
On 1/14/22 08:37, Richard Biener wrote: ... > Can the gist of this bug be put into the GCC bugzilla so the rev can > refer to it? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104034 > Can we have a testcase even? The testcase from Jakub is in the BZ. However, since it doesn't fail with head I

Re: gcc/configure: out of date

2022-01-14 Thread Iain Buclaw via Gcc-patches
Excerpts from Martin Liška's message of Januar 14, 2022 4:51 pm: > On 1/14/22 16:46, Martin Liška wrote: >> Hello. >> >> I noticed that when I run: >> ACLOCAL=~/bin/automake-1.15.1/bin/aclocal   >> AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf >> >> in gcc subfolder I get the following 

Re: [Patch][V4][Patch 2/2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables.

2022-01-14 Thread Martin Sebor via Gcc-patches
On 1/14/22 11:29, Qing Zhao wrote: On Jan 14, 2022, at 12:11 PM, Martin Sebor wrote: On 1/14/22 09:30, Qing Zhao wrote: On Jan 14, 2022, at 6:45 AM, Richard Biener wrote: On Thu, Jan 13, 2022 at 2:45 AM Qing Zhao wrote: Hi, Richard, This is the updated version for the second patch,

[pushed] vect: Fix uninitialised variable PR104026

2022-01-14 Thread Richard Sandiford via Gcc-patches
As noted by Tobias in the PR, the loop_vec_info constructor wasn't initializing the new partial_load_store_bias field. Tested on aarch64-linux-gnu and pushed as obvious. Richard gcc/ PR middle-end/104026 * tree-vect-loop.c (_loop_vec_info::_loop_vec_info): Initialize

Re: [PATCH] RISC-V: Document the degree of position independence that medany affords

2022-01-14 Thread Palmer Dabbelt
On Thu, 13 Jan 2022 21:54:45 PST (-0800), gcc-patches@gcc.gnu.org wrote: On Fri, Jan 14, 2022 at 4:42 AM Palmer Dabbelt wrote: The code generated by -mcmodel=medany is defined to be position-independent, but is not guarnteed to function correctly when linked into position-independent

Re: [Patch][V4][Patch 2/2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables.

2022-01-14 Thread Qing Zhao
> On Jan 14, 2022, at 12:11 PM, Martin Sebor wrote: > > On 1/14/22 09:30, Qing Zhao wrote: >>> On Jan 14, 2022, at 6:45 AM, Richard Biener >>> wrote: >>> >>> On Thu, Jan 13, 2022 at 2:45 AM Qing Zhao wrote: Hi, Richard, This is the updated version for the second

[PATCH 3/3] tree-cfg: check placement of returns_twice calls

2022-01-14 Thread Alexander Monakov via Gcc-patches
When a returns_twice call has an associated abnormal edge, the edge corresponds to the "second return" from the call. It wouldn't make sense if any executable statements appeared between the call and the destination of the edge (they wouldn't be re-executed upon the "second return"), so verify

[PATCH 2/3] tree-cfg: do not duplicate returns_twice calls

2022-01-14 Thread Alexander Monakov via Gcc-patches
A returns_twice call may have associated abnormal edges that correspond to the "second return" from the call. If the call is duplicated, the copies of those edges also need to be abnormal, but e.g. tracer does not enforce that. Just prohibit the (unlikely to be useful) duplication. gcc/ChangeLog:

[PATCH 1/3] tree-ssa-sink: do not sink to in front of setjmp

2022-01-14 Thread Alexander Monakov via Gcc-patches
gcc/ChangeLog: * tree-ssa-sink.c (select_best_block): Punt if selected block has incoming abnormal edges. gcc/testsuite/ChangeLog: * gcc.dg/setjmp-7.c: New test. --- gcc/testsuite/gcc.dg/setjmp-7.c | 13 + gcc/tree-ssa-sink.c | 6 ++ 2 files

Re: [RFC PATCH] tree-ssa-sink: do not sink to in front of setjmp

2022-01-14 Thread Alexander Monakov via Gcc-patches
> I approved the initial sink patch (maybe not clearly enough). I wasn't entirely happy with that patch. The new version solves this better. > Can you open > a bugreport about the missing CFG verification and list the set of FAILs > (all errors in some passes similar to the one you fixed in

Re: [Patch][V4][Patch 2/2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables.

2022-01-14 Thread Martin Sebor via Gcc-patches
On 1/14/22 09:30, Qing Zhao wrote: On Jan 14, 2022, at 6:45 AM, Richard Biener wrote: On Thu, Jan 13, 2022 at 2:45 AM Qing Zhao wrote: Hi, Richard, This is the updated version for the second patch, which is mainly the change for "Enable -Wuninitialized + -ftrivial-auto-var-init for

[COMMITTED] test to verify -Wformat-overflow uses context-sensitive ranges

2022-01-14 Thread Martin Sebor via Gcc-patches
Converting the strlen/sprintf pass to Ranger has considerably improved the accuracy of -Wformat-overflow warnings: they can avoid triggering for safe input even at -O0 while at the same time detect provable overflow. The conversion didn't come with any tests so in r12-6591 I committed one that

[arm] MVE: Relax addressing modes for full loads and stores

2022-01-14 Thread Andre Vieira (lists) via Gcc-patches
Hi Christophe, This patch relaxes the addressing modes for the mve full load and stores (by full loads and stores I mean non-widening or narrowing loads and stores resp). The code before was requiring a LO_REGNUM for these, where this is only a requirement if the load is widening or the store

Re: [Patch][V4][Patch 2/2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables.

2022-01-14 Thread Qing Zhao
> On Jan 14, 2022, at 6:45 AM, Richard Biener > wrote: > > On Thu, Jan 13, 2022 at 2:45 AM Qing Zhao wrote: >> >> Hi, Richard, >> >> This is the updated version for the second patch, which is mainly the change >> for "Enable -Wuninitialized + -ftrivial-auto-var-init for address taken >>

Re: gcc/configure: out of date

2022-01-14 Thread Martin Liška
On 1/14/22 16:46, Martin Liška wrote: Hello. I noticed that when I run: ACLOCAL=~/bin/automake-1.15.1/bin/aclocal   AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf in gcc subfolder I get the following diff: Have it, started with: commit 7c6ae994fb587c19ca14aebe18dbc9aca83be609 Author:

gcc/configure: out of date

2022-01-14 Thread Martin Liška
Hello. I noticed that when I run: ACLOCAL=~/bin/automake-1.15.1/bin/aclocal AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf in gcc subfolder I get the following diff: diff --git a/gcc/configure b/gcc/configure index d19059e13cc..ff570f73ef5 100755 --- a/gcc/configure +++ b/gcc/configure

Re: [PATCH] testsuite: Robustify aarch64/simd tests against more aggressive DCE

2022-01-14 Thread Marc Poulhies via Gcc-patches
Eric Botcazou writes: >> The new variables seem to be unused, so I think slightly stronger >> DCE could remove the calls even after the patch. Perhaps the containing >> functions should take an int32x4_t *ptr or something, with the calls >> assigning to different ptr[] indices. > > We run a

Re: [PATCH] git-backport: support renamed .cc files in commit message.

2022-01-14 Thread Martin Liška
On 1/14/22 08:44, Bernhard Reutner-Fischer wrote: On Wed, 12 Jan 2022 16:54:46 +0100 Martin Liška wrote: +def replace_file_in_changelog(lines, filename): +if not filename.endswith('.cc'): +return + +# consider all componenets of a path: gcc/ipa-icf.cc +while filename: +

[PATCH][pushed] testsuite: fix dh-warning typo.

2022-01-14 Thread Martin Liška
gcc/testsuite/ChangeLog: * c-c++-common/Walloca-larger-than.c: Fix typo. --- gcc/testsuite/c-c++-common/Walloca-larger-than.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/c-c++-common/Walloca-larger-than.c

[PATCH] i386: Mark some of strict_low_part insn constraints earlyclobbered

2022-01-14 Thread Uros Bizjak via Gcc-patches
While there is practically impossible that input registers are matched with in-out register, better mark the output operand of the split alternative as earlyclobbered - we do output early to the output operand when the insn is split. 2022-01-14 Uroš Bizjak gcc/ChangeLog: *

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2022-01-14 Thread Stephan Bergmann via Gcc-patches
On 14/01/2022 14:28, Marek Polacek wrote: On Fri, Jan 14, 2022 at 10:23:16AM +0100, Stephan Bergmann wrote: On 30/11/2021 16:27, Marek Polacek wrote: I guess we were concerned with programs that generate other programs. Maybe UCNs should be ignored by default. There's still time to adjust the

RE: [PATCH v3 00/15] ARM/MVE use vectors of boolean for predicates

2022-01-14 Thread Kyrylo Tkachov via Gcc-patches
Hi Christophe, Richard, > -Original Message- > From: Gcc-patches bounces+kyrylo.tkachov=arm@gcc.gnu.org> On Behalf Of Richard > Biener via Gcc-patches > Sent: Friday, January 14, 2022 1:33 PM > To: Christophe Lyon > Cc: GCC Patches > Subject: Re: [PATCH v3 00/15] ARM/MVE use

[PATCH][pushed] testsuite: rename files in c-c++-common.

2022-01-14 Thread Martin Liška
Pushed, there should be only .c files in the sub-folder. Martin gcc/testsuite/ChangeLog: * c-c++-common/Walloca-larger-than.C: Moved to... * c-c++-common/Walloca-larger-than.c: ...here. --- .../c-c++-common/{Walloca-larger-than.C => Walloca-larger-than.c} | 0 1 file changed,

Re: [PATCH] rs6000: Use known constant for GET_MODE_NUNITS and similar

2022-01-14 Thread David Edelsohn via Gcc-patches
On Fri, Jan 14, 2022 at 5:42 AM Kewen.Lin wrote: > > on 2022/1/13 下午11:15, David Edelsohn wrote: > > On Thu, Jan 13, 2022 at 7:40 AM Kewen.Lin wrote: > >> > >> Hi David, > >> > >> on 2022/1/13 上午11:12, David Edelsohn wrote: > >>> On Wed, Jan 12, 2022 at 8:56 PM Kewen.Lin wrote: > >

Re: [PATCH] [i386] GLC tuning: Break false dependency for dest register.

2022-01-14 Thread Hongyu Wang via Gcc-patches
> Are there any technical obstacles to introduce subst to > define_{,insn_and_}split? gccint says: define_subst can be used only in define_insn and define_expand, it cannot be used in other expressions (e.g. in define_insn_and_split). I have no idea how to implement it in current infrastructure.

Re: [PATCH v3 00/15] ARM/MVE use vectors of boolean for predicates

2022-01-14 Thread Richard Biener via Gcc-patches
On Fri, Jan 14, 2022 at 2:18 PM Christophe Lyon via Gcc-patches wrote: > > Hi, > > I hadn't realized we are moving to stage 4 this week-end :-( > > The PRs I'm fixing are P3, but without these fixes MVE support is badly > broken, so I think I would be really good to fix that before the buggy >

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2022-01-14 Thread Marek Polacek via Gcc-patches
On Fri, Jan 14, 2022 at 10:23:16AM +0100, Stephan Bergmann wrote: > On 30/11/2021 16:27, Marek Polacek wrote: > > I guess we were concerned with programs that generate other programs. > > Maybe UCNs should be ignored by default. There's still time to adjust > > the behavior. > > Is there any

Re: [PATCH v3 00/15] ARM/MVE use vectors of boolean for predicates

2022-01-14 Thread Christophe Lyon via Gcc-patches
Hi, I hadn't realized we are moving to stage 4 this week-end :-( The PRs I'm fixing are P3, but without these fixes MVE support is badly broken, so I think I would be really good to fix that before the buggy version becomes part of an actual release. Anyway I posted v1 of the patches during

[committed] vect: Check partial vector param for supports_partial_vectors [PR104015]

2022-01-14 Thread Kewen.Lin via Gcc-patches
Hi, As described in PR104015, the function partial_vectors_supported_p mainly checks optabs for partial vectors support query, but we still have one parameter param_vect_partial_vector_usage to control the capability. Power9 introduces vector with length instructions (for len_load/len_store) but

[PATCH] testsuite: Remove executable mode from source files.

2022-01-14 Thread Martin Liška
Pushed to master as obvious. Martin gcc/testsuite/ChangeLog: * g++.dg/vect/pr99149.cc: Remove executable mode. * g++.dg/vect/pr99220.cc: Likewise. * g++.target/i386/avx512vl-pr100738-1.C: Likewise. * g++.target/i386/pr100738-1.C: Likewise. *

Re: [Patch][V4][Patch 2/2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables.

2022-01-14 Thread Richard Biener via Gcc-patches
On Thu, Jan 13, 2022 at 2:45 AM Qing Zhao wrote: > > Hi, Richard, > > This is the updated version for the second patch, which is mainly the change > for "Enable -Wuninitialized + -ftrivial-auto-var-init for address taken > variables”. > > In this update, I mainly made the following change: > >

Re: [patch] Fix reverse SSO issues in IPA-SRA

2022-01-14 Thread Martin Jambor
Hi Eric, On Tue, Jan 11 2022, Eric Botcazou via Gcc-patches wrote: > Hi, > > we recently received the report that the IPA-SRA pass introduced in GCC 10 > does not always play nice with the reverse scalar storage order that can be > used in structures/records/unions. Reading the code, the pass

Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).

2022-01-14 Thread Tobias Burnus
On 14.01.22 12:55, Jakub Jelinek via Fortran wrote: If we want to check intptr_t, we should guard the dg-error with "" { target { lp64 || llp64 } } or so. Well, if we want to use intptr_t, we could use be explicitly as with: use iso_c_binding, only: c_intptr_t ! use omp_lib, only:

Re: [PATCH] libstdc++: Fix 22_locale/numpunct/members/char/3.cc execution test

2022-01-14 Thread Jonathan Wakely via Gcc-patches
On Fri, 14 Jan 2022 at 11:41, Uros Bizjak via Libstdc++ < libstd...@gcc.gnu.org> wrote: > The test fails on Fedora 33+ because nl_NL locale got thousands > separator defined. Use one of ar_SA, bg_BG, bs_BA, pt_PT > or plain C locale instead. > > 2022-01-14 Uroš Bizjak > >

Re: [PATCH] disable aggressive_loop_optimizations until niter ready

2022-01-14 Thread Richard Biener via Gcc-patches
On Fri, 14 Jan 2022, Jiufu Guo wrote: > Richard Biener writes: > > > On Thu, 13 Jan 2022, guojiufu wrote: > > > >> On 2022-01-03 22:30, Richard Biener wrote: > >> > On Wed, 22 Dec 2021, Jiufu Guo wrote: > >> > > >> >> Hi, > >> >> ... > >> >> > >> >> Bootstrap and regtest pass on ppc64* and

Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).

2022-01-14 Thread Jakub Jelinek via Gcc-patches
On Fri, Jan 14, 2022 at 12:45:54PM +0100, Tobias Burnus wrote: > On 14.01.22 10:10, Thomas Schwinge wrote: > > > + integer :: x > > > ... > > > + !$omp parallel allocate (0: x) private(x) ! { dg-error "Expected > > > integer expression of the 'omp_allocator_handle_kind' kind at .1." } > > We

Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).

2022-01-14 Thread Tobias Burnus
Hi all, On 14.01.22 10:10, Thomas Schwinge wrote: + integer :: x ... + !$omp parallel allocate (0: x) private(x) ! { dg-error "Expected integer expression of the 'omp_allocator_handle_kind' kind at .1." } We do for x86_64 default '-m64', but for '-m32' and '-mx32' compilation, we're not

[PATCH] libstdc++: Fix 22_locale/numpunct/members/char/3.cc execution test

2022-01-14 Thread Uros Bizjak via Gcc-patches
The test fails on Fedora 33+ because nl_NL locale got thousands separator defined. Use one of ar_SA, bg_BG, bs_BA, pt_PT or plain C locale instead. 2022-01-14 Uroš Bizjak libstdc++-v3/ChangeLog: * testsuite/22_locale/numpunct/members/char/3.cc (test02): Use pt_PT locale

Re: [PATCH] libstdc++: Add attribute to features deprecated in C++17 [PR91260]

2022-01-14 Thread Jonathan Wakely via Gcc-patches
On Wed, 12 Jan 2022 at 09:34, Jonathan Wakely via Libstdc++ < libstd...@gcc.gnu.org> wrote: > This passes testing (with -std=gnu++98/11/17/20) but is quite a large > patch for this late in stage 3. Does anybody object to doing this now? > The bugs it fixes were closed as INVALID because we're not

[committed] libgfortran: Partly revert my r12-6498 change to fix Solaris build [PR104006]

2022-01-14 Thread Jakub Jelinek via Gcc-patches
Hi! In r12-6498 I've added $(version_dep) to BUILT_SOURCES, previously version_dep on Linux used to be a file in $(srcdir), but with my changes it is a generated file in the object directory (preprocessed version of the $(srcdir) file) and I thought generated files belong to BUILT_SOURCES so that

Re: [PATCH] rs6000: Use known constant for GET_MODE_NUNITS and similar

2022-01-14 Thread Kewen.Lin via Gcc-patches
on 2022/1/13 下午11:15, David Edelsohn wrote: > On Thu, Jan 13, 2022 at 7:40 AM Kewen.Lin wrote: >> >> Hi David, >> >> on 2022/1/13 上午11:12, David Edelsohn wrote: >>> On Wed, Jan 12, 2022 at 8:56 PM Kewen.Lin wrote: Hi, This patch is to clean up some codes with

Re: [AArch64] Enable generation of FRINTNZ instructions

2022-01-14 Thread Richard Sandiford via Gcc-patches
"Andre Vieira (lists)" writes: > diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi > index > 19e89ae502bc2f51db64667b236c1cb669718b02..3b0e4e0875b4392ab6833568b207580ef597a98f > 100644 > --- a/gcc/doc/md.texi > +++ b/gcc/doc/md.texi > @@ -6191,6 +6191,15 @@ operands; otherwise, it may not. > >

Re: [patch] Fix reverse SSO issues in IPA-SRA

2022-01-14 Thread Eric Botcazou via Gcc-patches
> Yes, it must still be copied. OK, revised patch attached, with testcases but they fail only on the 10 and 11 branches because of a change in the heuristics apparently. * ipa-param-manipulation.c (ipa_dump_adjusted_parameters): Dump reverse flag as "reverse" for the sake of

[committed] arc: Add DWARF2 alternate CFA column.

2022-01-14 Thread Claudiu Zissulescu via Gcc-patches
Add DWARF 2 CFA column which tracks the return address from a signal handler context. This value must not correspond to a hard register and must be out of the range of DWARF_FRAME_REGNUM(). gcc/ * config/arc/arc.h (DWARF_FRAME_REGNUM): Update definition.

[committed] arc: Update stack size computation when accumulator registers are available.

2022-01-14 Thread Claudiu Zissulescu via Gcc-patches
When accumulator registers are available in a processor, they need to be save onto stack durring interrupts. We were already doing so, but the stack size was wrongly computed in the case other than ARC600. gcc/ * config/arc/arc.c (arc_compute_frame_size): Remove condition when

[committed] libstdc++: Add C++20 std::make_shared enhancements (P0674R1)

2022-01-14 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64-le-linux, pushed to trunk. N.B. we had a patch from JeanHeyd two years ago adding the first part of this (P0674R1), but this is much simpler, works without concepts, and also adds make_shared_for_overwrite. This adds the overloads of std::make_shared and std::allocate_shared

[committed] libstdc++: Ignore cv-quals when std::allocator constructs

2022-01-14 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux, pushed to trunk. When I added the std::allocator_traits> specialization it broke code like this: std::allocate_shared(std::allocator()); The problem is that allocator_traits>::construct(a, p) now uses std::_Construct(p), which only does a static_cast(p) and so fails

[committed] libstdc++: Use std::construct_at in std::common_iterator [PR103992]

2022-01-14 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux, pushed to trunk. This should have been done as part of the LWG 3574 changes. libstdc++-v3/ChangeLog: PR libstdc++/103992 * include/bits/stl_iterator.h (common_iterator): Use std::construct_at instead of placement new. *

[committed] libstdc++: Document new std::random_device tokens

2022-01-14 Thread Jonathan Wakely via Gcc-patches
Pushed to trunk. libstdc++-v3/ChangeLog: * doc/xml/manual/status_cxx2011.xml: Document new tokens accepted by std::random_device constructor. * doc/html/manual/status.html: Regenerate. --- libstdc++-v3/doc/html/manual/status.html | 13

Re: [PATCH v5 1/1] [ARM] Add support for TLS register based stack protector canary access

2022-01-14 Thread Ard Biesheuvel via Gcc-patches
(+ Richard Earnshaw) On Wed, 12 Jan 2022 at 19:29, Ard Biesheuvel wrote: > > On Wed, 17 Nov 2021 at 18:12, Ard Biesheuvel wrote: > > > > (+ Ramana) > > > > Ping? > > > On Mon, 15 Nov 2021 at 19:04, Ard Biesheuvel wrote: > > > > > > Add support for accessing the stack canary value via the TLS

RE: [AArch32]: correct dot-product RTL patterns.

2022-01-14 Thread Kyrylo Tkachov via Gcc-patches
Hi Tamar, Sorry for the delay. > -Original Message- > From: Tamar Christina > Sent: Tuesday, January 11, 2022 7:10 AM > To: gcc-patches@gcc.gnu.org > Cc: nd ; Ramana Radhakrishnan > ; Richard Earnshaw > ; ni...@redhat.com; Kyrylo Tkachov > > Subject: RE: [AArch32]: correct dot-product

Re: [vect] PR103997: Fix epilogue mode skipping

2022-01-14 Thread Richard Biener via Gcc-patches
On Fri, 14 Jan 2022, Andre Vieira (lists) wrote: > > On 14/01/2022 07:08, Richard Biener wrote: > > On Thu, 13 Jan 2022, Andre Vieira (lists) wrote: > > > >> On 13/01/2022 14:25, Richard Biener wrote: > >>> On Thu, 13 Jan 2022, Andre Vieira (lists) wrote: > >>> > On 13/01/2022 12:36,

[PATCH] nvptx: Add support for 64-bit mul.hi (and other) instructions.

2022-01-14 Thread Roger Sayle
Now that the middle-end MULT_HIGHPART_EXPR pieces are in place, this patch adds support for nvptx's mul.hi.s64 and mul.hi.u64 instructions, as previously reviewed (provisionally pre-approved) back in August 2020: https://gcc.gnu.org/pipermail/gcc-patches/2020-August/551373.html Since then a few

Re: [vect] PR103997: Fix epilogue mode skipping

2022-01-14 Thread Andre Vieira (lists) via Gcc-patches
On 14/01/2022 07:08, Richard Biener wrote: On Thu, 13 Jan 2022, Andre Vieira (lists) wrote: On 13/01/2022 14:25, Richard Biener wrote: On Thu, 13 Jan 2022, Andre Vieira (lists) wrote: On 13/01/2022 12:36, Richard Biener wrote: On Thu, 13 Jan 2022, Andre Vieira (lists) wrote: This time

[PATCH] Start using check-MAINTAINERS.py instead of legacy maintainers-verify.sh.

2022-01-14 Thread Martin Liška
Let's use the new Python script where I added new function check_effective_target_python3 that can be used for python3 detection. Ready to be installed? Thanks, Martin contrib/ChangeLog: * maintainers-verify.sh: Removed. gcc/testsuite/ChangeLog: * gcc.src/maintainers.exp:

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2022-01-14 Thread Stephan Bergmann via Gcc-patches
On 30/11/2021 16:27, Marek Polacek wrote: I guess we were concerned with programs that generate other programs. Maybe UCNs should be ignored by default. There's still time to adjust the behavior. Is there any update on this? Shall I file a bug? As-is, -Wbidi-chars is unusable for building

Re: [PATCH] x86_64: Improvements to arithmetic right shifts of V1TImode values.

2022-01-14 Thread Uros Bizjak via Gcc-patches
On Fri, Jan 14, 2022 at 10:00 AM Roger Sayle wrote: > > > Hi Uros, > Here's a revised version of this patch incorporating your suggestion of using > force_reg instead of emit_move_insn to a pseudo allocated by gen_reg_rtx. > I also took the opportunity to transition the rest of the function (and

Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).

2022-01-14 Thread Thomas Schwinge
Hi Abid! (Remember to CC for 'gcc/fortran/' etc. changes.) On 2022-01-11T22:31:54+, Hafiz Abid Qadeer wrote: > --- /dev/null > +++ b/gcc/testsuite/gfortran.dg/gomp/allocate-2.f90 > @@ -0,0 +1,45 @@ > +! { dg-do compile } > + > +module omp_lib_kinds > + use iso_c_binding, only: c_int,

RE: [PATCH] x86_64: Improvements to arithmetic right shifts of V1TImode values.

2022-01-14 Thread Roger Sayle
Hi Uros, Here's a revised version of this patch incorporating your suggestion of using force_reg instead of emit_move_insn to a pseudo allocated by gen_reg_rtx. I also took the opportunity to transition the rest of the function (and clean-up those around it) to use this preferred idiom. This

Re: [PATCH] Fix tree-optimization/101941: IPA splitting out function with error attribute

2022-01-14 Thread Jan Hubicka via Gcc-patches
> > > > > --- a/gcc/ipa-split.c > > > > > +++ b/gcc/ipa-split.c > > > > > @@ -873,7 +873,7 @@ visit_bb (basic_block bb, basic_block return_bb, > > > > > gimple *stmt = gsi_stmt (bsi); > > > > > tree op; > > > > > ssa_op_iter iter; > > > > > - tree decl; > > > > > +

Re: [PATCH] [i386] GLC tuning: Break false dependency for dest register.

2022-01-14 Thread Uros Bizjak via Gcc-patches
On Fri, Jan 14, 2022 at 7:11 AM Hongyu Wang wrote: > > > > No, the approach is wrong. You have to solve output clearing on RTL > > > level, please look at how e.g. tzcnt false dep is solved: > > > > Actually we have considered such approach before, but we found we need > > to break original

Re: [PATCH] Fix tree-optimization/101941: IPA splitting out function with error attribute

2022-01-14 Thread Martin Liška
PING^1 May I please ping this so that we can can Linux kernel as soon as possible? We would benefit from that for GCC 12.1.0 release. Thanks, Martin On 11/19/21 14:07, Richard Biener via Gcc-patches wrote: On Fri, Nov 19, 2021 at 12:50 PM Andrew Pinski wrote: On Fri, Nov 19, 2021 at 2:16

Re: [PATCH] [i386] GLC tuning: Break false dependency for dest register.

2022-01-14 Thread Uros Bizjak via Gcc-patches
On Fri, Jan 14, 2022 at 6:46 AM Hongyu Wang wrote: > > > No, the approach is wrong. You have to solve output clearing on RTL > > level, please look at how e.g. tzcnt false dep is solved: > > Actually we have considered such approach before, but we found we need > to break original define_insn to

[PATCH][pushed] ARM: fix -Wformat= error

2022-01-14 Thread Martin Liška
gcc/ChangeLog: * common/config/arm/arm-common.c (arm_target_mode): Fix warning: unterminated quoting directive [-Wformat=]. --- gcc/common/config/arm/arm-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/common/config/arm/arm-common.c