On Thu, Dec 15, 2022 at 11:59:49AM -0600, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Dec 14, 2022 at 10:36:03AM +0100, Jakub Jelinek wrote:
> > On Wed, Dec 14, 2022 at 04:46:07PM +0800, Kewen.Lin via Gcc-patches wrote:
> > > Since function useless_type_conversion_p considers two float types are
On 12/10/22 10:54, Iain Sandoe wrote:
From: Andrew Pinski
This is Andrew Pinski's patch, I just did testing, adjusted the test case and
provided the Changelog.
tested on x86-64-Darwin21,
OK for trunk?
Iain
OK.
--- >8 ---
The PR reports that using integer_zero_node triggers a warning for
-W
On 12/15/22 11:15, Patrick Palka wrote:
There's a curious corner case with variadic member using-decls: the
terminal name can also contain a parameter pack, and only through naming
a conversion function, e.g.
using A::operator Ts...;
We currently only handle parameter packs appearing in the
On 12/15/22 14:31, Patrick Palka wrote:
On Thu, 15 Dec 2022, Patrick Palka wrote:
On Thu, 15 Dec 2022, Jason Merrill wrote:
On 12/12/22 12:20, Patrick Palka wrote:
When instantiating a constrained hidden template friend, we need to
substitute into its constraints for sake of declaration matc
On 12/15/22 13:00, Arsen Arsenović wrote:
Hi Jason,
Jason Merrill writes:
On 12/10/22 08:13, Arsen Arsenović wrote:
If the mangler is relied on, functions with extern "C" on them emit multiple
definitions of the same name.
But doing it here interferes with lazy mangling. How about appendi
Hi Arsen,
> On 15 Dec 2022, at 18:00, Arsen Arsenović via Gcc-patches
> wrote:
> Jason Merrill writes:
>
>> On 12/10/22 08:13, Arsen Arsenović wrote:
>>> If the mangler is relied on, functions with extern "C" on them emit multiple
>>> definitions of the same name.
>>
>> But doing it here int
On Thu, Dec 15, 2022 at 07:56:14PM +0100, Jakub Jelinek wrote:
> On Thu, Dec 15, 2022 at 12:49:27PM -0600, Segher Boessenkool wrote:
> > Certainly. But different types with the same mode having different
> > precision is not so very reasonable, and will likely cause other
> > problems as well.
> >
Hi,
On 15.12.22 20:42, Tobias Burnus wrote:
If the libgomp plugin doesn't request special
'host_to_dev_cpy'/'dev_to_host_cpy' for 'gomp_target_rev', then standard
'gomp_copy_host2dev'/'gomp_copy_dev2host' are used, which use
'gomp_device_copy', which expects the device to be locked. (As can be
Hi,
I have not fully tried to understand it, yet.
(A) Regarding the issue of stalling, see als Andrew's patch and the
discussion about it in
"[PATCH] libgomp: fix hang on fatal error",
https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603616.html
and in particular Jakub's two replies.
(b
On Thu, 15 Dec 2022, Patrick Palka wrote:
> On Thu, 15 Dec 2022, Jason Merrill wrote:
>
> > On 12/12/22 12:20, Patrick Palka wrote:
> > > When instantiating a constrained hidden template friend, we need to
> > > substitute into its constraints for sake of declaration matching.
> >
> > Hmm, we sh
The following patch solves a spill problem for
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90706
There are still redundant moves which should be removed to solve PR.
I'll continue my work on this in Jan.
commit 12abd5a7d13209f79664ea603b3f3517f71b8c4f
Author: Vladimir N. Makarov
Date:
Break the _FORTIFY_SOURCE-specific builtins out into a separate
subsection from Object Size Checking built-ins and mention
_FORTIFY_SOURCE in there so that the link between the object size
checking builtins, the helper builtins (e.g. __builtin___memcpy_chk) and
_FORTIFY_SOURCE is clearer.
gcc/Chan
On Thu, 15 Dec 2022, Jason Merrill wrote:
> On 12/12/22 12:20, Patrick Palka wrote:
> > When instantiating a constrained hidden template friend, we need to
> > substitute into its constraints for sake of declaration matching.
>
> Hmm, we shouldn't need to do declaration matching when there's only
On Thu, Dec 15, 2022 at 12:49:27PM -0600, Segher Boessenkool wrote:
> On Thu, Dec 15, 2022 at 06:28:19PM +, Joseph Myers wrote:
> > On Thu, 15 Dec 2022, Kewen.Lin via Gcc-patches wrote:
> > > By investigating the exposed NaN failures, I found it's due to that it
> > > wants
> > > to convert _F
On Thu, Dec 15, 2022 at 06:28:19PM +, Joseph Myers wrote:
> On Thu, 15 Dec 2022, Kewen.Lin via Gcc-patches wrote:
> > By investigating the exposed NaN failures, I found it's due to that it wants
> > to convert _Float128 type constant to long double type constant, it goes
> > through function re
On Thu, 15 Dec 2022, Kewen.Lin via Gcc-patches wrote:
> By investigating the exposed NaN failures, I found it's due to that it wants
> to convert _Float128 type constant to long double type constant, it goes
> through function real_convert which clears the signalling bit in the context
> of !HONOR
Hi Tom!
First "a bit" of context; skip to "the proposed patch" if you'd like to
see just that.
On 2022-02-01T19:31:27+0100, Tom de Vries via Gcc-patches
wrote:
> On a GT 1030, with driver version 470.94 and -mptx=3.1 I run into:
> ...
> FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/paralle
Hi Jason,
Jason Merrill writes:
> On 12/10/22 08:13, Arsen Arsenović wrote:
>> If the mangler is relied on, functions with extern "C" on them emit multiple
>> definitions of the same name.
>
> But doing it here interferes with lazy mangling. How about appending the
> suffix into write_mangled_n
Hi!
On Wed, Dec 14, 2022 at 10:36:03AM +0100, Jakub Jelinek wrote:
> On Wed, Dec 14, 2022 at 04:46:07PM +0800, Kewen.Lin via Gcc-patches wrote:
> > Since function useless_type_conversion_p considers two float types are
> > compatible
> > if they have the same mode, so it doesn't require the expli
> On Wed, Dec 14, 2022 at 4:20 PM Jan Hubicka via Gcc-patches
> wrote:
> >
> > > Hi,
> > >
> > > Honza requested this after reviewing the patch that taught IPA-SRA
> > > that REFERENCE_TYPEs are always non-NULL that the pass also handles
> > > the first parameters of methods, this pointers, in the
On Thu, Dec 15, 2022 at 06:34:30PM +0100, Thomas Schwinge wrote:
> --- a/libgomp/libgomp-plugin.c
> +++ b/libgomp/libgomp-plugin.c
> @@ -82,9 +82,9 @@ GOMP_PLUGIN_fatal (const char *msg, ...)
> void
> GOMP_PLUGIN_target_rev (uint64_t fn_ptr, uint64_t mapnum, uint64_t
> devaddrs_ptr,
>
Hi,
Jason Merrill writes:
>
> I'd actually suggest "off" and "on" since it's really a boolean since
> "always_continue" was dropped.
>
>> + std::cerr << "contract violation in function " <<
>> violation.function_name()
>> +<< " at " << violation.file_name() << ':' << violation.line_number(
Hi,
Jason Merrill writes:
>> The lowercase constants are more consistent with the standard, and it is
>> unlikely that the uppercase versions would've been accepted.
>
> OK.
Thanks. Could you push this for me? I don't have write access.
Have a great day.
--
Arsen Arsenović
signature.asc
D
Hi Jason,
Jason Merrill writes:
> I wonder if you want to wrap the pattern in {} instead of "" so you don't need
> the "special stuff in TCL itself" quoting?
{}s lack generality, for instance, try: puts {unbalanced \}}. I could
try to write a revision that complies with the minimal escaping st
Hi!
On 2022-12-06T08:45:07+0100, Tobias Burnus wrote:
> This patch finally handles reverse offload.
Yay! \o/
The 'libgomp.fortran/reverse-offload-5.f90' test case for nvptx
offloading runs into an error condition (thus, XFAILed) -- but then
blocks until timeout, insted of terminating promptly
On Thu, Dec 15, 2022 at 12:21:21PM -0500, Siddhesh Poyarekar wrote:
> On 2022-12-15 12:09, Jakub Jelinek wrote:
> > > -This is a propagation pass similar to CCP that tries to remove calls
> > > -to @code{__builtin_object_size} when the size of the object can be
> > > -computed at compile-time. Thi
On 2022-12-15 12:09, Jakub Jelinek wrote:
-This is a propagation pass similar to CCP that tries to remove calls
-to @code{__builtin_object_size} when the size of the object can be
-computed at compile-time. This pass is located in
-@file{tree-object-size.cc} and is described by
+This is a propag
On Thu, Dec 15, 2022 at 11:58:14AM -0500, Siddhesh Poyarekar wrote:
> --- a/gcc/doc/extend.texi
> +++ b/gcc/doc/extend.texi
> @@ -14291,8 +14291,14 @@ and GCC does not issue a warning.
> @end deftypefn
>
> @deftypefn {Built-in Function}{size_t} __builtin_object_size (const void *
> @var{ptr},
On 12/8/22 11:42, Patrick Palka wrote:
Here when parsing the class-scope auto constrained by a qualified
concept-id, we first tentatively parse the overall member-declaration as
a deprecated access-declaration, during which we parse C as a
standalone TEMPLATE_ID_EXPR (not part of the auto) and en
__builtin_dynamic_object_size is missing from the full list of builtins,
so add it. Also mention it alongside __builtin_object_size in the
passes description.
gcc/ChangeLog:
* doc/extend.texi (__builtin_dynamic_object_size): Document
builtin.
* doc/passes.texi
(Op
On 12/9/22 16:57, Patrick Palka wrote:
Here during partial instantiation of the constexpr if, extra_local_specs
walks the statement looking for local specializations within to save and
possibly capture. However, we're thwarted by the fact that 'ts' first
appears inside an unevaluated context, an
On 12/10/22 04:33, Jakub Jelinek wrote:
Hi!
The TRUTH_NOT_EXPR case in cp_build_unary_op is one of the spots where
we somewhat fold immediately using invert_truthvalue_loc.
I've tried using
return build1_loc (location, TRUTH_NOT_EXPR, boolean_type_node, arg);
in there instead, but unfortunate
On Thu, 15 Dec 2022 14:54:58 +
Julian Brown wrote:
> On Wed, 7 Dec 2022 17:31:20 +0100
> Tobias Burnus wrote:
>
> > Hi Julian,
> >
> > I think this patch is OK; however, at least for gimplify.cc Jakub
> > needs to have a second look.
>
> Thanks for the review! Here's a new version that
On Thu, Dec 15, 2022 at 11:33:40AM -0500, Siddhesh Poyarekar wrote:
> Fix the documentation to say that object sizes are deduced using
> __builtin_dynamic_object_size.
>
> gcc/ChangeLog:
>
> PR middle-end/70090
> * gcc/doc/invoke.texi (-fsanitize=object-size): Use
> __builtin_dy
Fix the documentation to say that object sizes are deduced using
__builtin_dynamic_object_size.
gcc/ChangeLog:
PR middle-end/70090
* gcc/doc/invoke.texi (-fsanitize=object-size): Use
__builtin_dynamic_object_size instead of
__builtin_object_size.
Signed-off-by: Si
On 12/10/22 04:43, Arsen Arsenović wrote:
This script is a helper used to generate dg-output lines from an existing
program output conveniently. It takes care of escaping Tcl and ARE stuff.
contrib/ChangeLog:
* dg-out-generator.pl: New file.
---
contrib/dg-out-generator.pl | 67 ++
On 12/10/22 04:43, Arsen Arsenović wrote:
From: Jonathan Wakely
Make the output more readable. Don't output anything unless verbose
termination is enabled at configure-time.
libstdc++-v3/ChangeLog:
PR libstdc++/107792
PR libstdc++/107778
* src/experimental/contract.cc
On 12/10/22 04:43, Arsen Arsenović wrote:
The lowercase constants are more consistent with the standard, and it is
unlikely that the uppercase versions would've been accepted.
OK.
gcc/cp/ChangeLog:
* contracts.cc: Rename references to
contract_violation_continuation_mode cons
On 12/12/22 12:20, Patrick Palka wrote:
When instantiating a constrained hidden template friend, we need to
substitute into its constraints for sake of declaration matching.
Hmm, we shouldn't need to do declaration matching when there's only a
single declaration.
For
this substitution we us
There's a curious corner case with variadic member using-decls: the
terminal name can also contain a parameter pack, and only through naming
a conversion function, e.g.
using A::operator Ts...;
We currently only handle parameter packs appearing in the qualifying
scope of a variadic using-decl;
Thanks Thomas!
We've tested it and this brings the startup time back into a reasonable amount!
We'd quite like to see this get into GCC 13.
Regards,
Tamar
> -Original Message-
> From: Thomas Neumann
> Sent: Friday, December 9, 2022 5:34 PM
> To: gcc-patches@gcc.gnu.org
> Cc: H.J. Lu ;
On 12/10/22 08:13, Arsen Arsenović wrote:
If the mangler is relied on, functions with extern "C" on them emit multiple
definitions of the same name.
But doing it here interferes with lazy mangling. How about appending
the suffix into write_mangled_name instead of write_encoding? The
demangl
> On Dec 15, 2022, at 2:47 AM, Richard Biener wrote:
>
> On Wed, 14 Dec 2022, Qing Zhao wrote:
>
>> Hi, Richard,
>>
>> I guess that we now agreed on the following:
>>
>> “ the information that we ran into a trailing array but didn't consider
>> it a flex array because of -fstrict-flex-array
Hi Richard,
Sorry for the delayed response, I couldn't find the time to fully focus on this
topic.
> I'm not sure this is accurate but at least the cost of using an unsupported
> addressing mode should be at least that of the compensating code to
> mangle it to a supported form.
I'm pretty sure
On Thu, Dec 15, 2022 at 04:01:33PM +0100, Thomas Schwinge wrote:
> Or, options are applicable to just one front end, and can just be a no-op
> for others, for shared-language compilation. For example, '-nostdinc++',
> or '-frust-incomplete-and-experimental-compiler-do-not-use' need not
> necessari
Hi!
On 2022-12-15T12:50:44+0100, Jakub Jelinek via Gcc-patches
wrote:
> On Thu, Dec 15, 2022 at 12:39:38PM +0100, Iain Buclaw wrote:
>> For the gdc testsuite, those warnings arise because both language files
>> are compiled in the same invocation (dg-additional-sources "cpp11.cpp"),
>> so it end
On 12/13/22 04:40, Jakub Jelinek wrote:
Hi!
The following patch adds typeinfos for the extended floating point
types and _Float{32,64}x.
Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
OK.
2022-12-13 Jakub Jelinek
PR libstdc++/108075
gcc/cp/
* rtti.c
On Wed, 7 Dec 2022 17:31:20 +0100
Tobias Burnus wrote:
> Hi Julian,
>
> I think this patch is OK; however, at least for gimplify.cc Jakub
> needs to have a second look.
Thanks for the review! Here's a new version that hopefully addresses
your comments. (The gimplify bits change a bit more in
On 12/14/22 12:48, Patrick Palka wrote:
We substitute the qualifying scope of a TYPENAME_TYPE directly using
tsubst_aggr_type (so that we can pass entering_scope=true) instead of
going through tsubst, which means we don't properly reuse typedefs
during this substitution. This ends up causing us
On 12/14/22 19:01, Patrick Palka wrote:
Here we're triggering an overzealous assert in unify during partial
ordering since the member function pointer constants are represented as
ordinary CONSTRUCTORs (with TYPE_PTRMEMFUNC_P TREE_TYPE) but the assert
expects only COMPOUND_LITERAL_P constructors.
It can be replaced by a subshell'd cd just fine.
(cd gcc/m2; autoconf-2.69)
gcc/m2/ChangeLog:
* configure.ac: Stop probing for realpath.
* tools-src/calcpath: Break dependency on realpath, cut
and echo.
* configure: Rebuilt
---
gcc/m2/config
On Thu, Dec 15, 2022 at 02:03:36PM +0100, Andreas Schwab wrote:
> On Dez 15 2022, Jakub Jelinek via Gcc-rust wrote:
>
> > @@ -58,13 +60,15 @@ proc check_compile {basename type conten
> > set options ""
> > }
> > switch -glob -- $contents {
> > - "*/* Assembly*" { set src ${basename
On Dez 15 2022, Jakub Jelinek via Gcc-rust wrote:
> @@ -58,13 +60,15 @@ proc check_compile {basename type conten
> set options ""
> }
> switch -glob -- $contents {
> - "*/* Assembly*" { set src ${basename}[pid].S }
> + "*/\* Assembly*" { set src ${basename}[pid].S }
>
On Dez 15 2022, Jakub Jelinek via Gcc-rust wrote:
> @@ -58,13 +60,15 @@ proc check_compile {basename type conten
> set options ""
> }
> switch -glob -- $contents {
> - "*/* Assembly*" { set src ${basename}[pid].S }
> + "*/\* Assembly*" { set src ${basename}[pid].S }
That's
For the testcase in PR108086 it's visible that we split blocks
multiple times when inlining and that causes us to adjust the
block tail stmt BBs multiple times, once for each split. The
fix is to walk backwards and split from the tail instead.
For a reduced testcase this improves compile-time at
Jakub Jelinek writes:
> On Wed, Dec 14, 2022 at 08:35:07AM +, Gaius Mulley via Gcc-patches wrote:
>> thanks - this is the last patch tick. So I'll actually do the merge now :-)
>
> I've committed following patch to fix up formatting of ChangeLog entries.
Many thanks and apologies for messin
Hi Jakub,
On 12/15/22 13:23, Jakub Jelinek wrote:
Hi!
This patch allows magic comments also for Rust and Modula-2
for effective target tests etc. and fixes up the Assembly entry
- it is a glob, so /* Assembly can match /whatever Assembly and
not just /* Assembly.
Tested on x86_64-linux with
ma
On Thu, 15 Dec 2022, Jakub Jelinek wrote:
> Hi!
>
> This patch allows magic comments also for Rust and Modula-2
> for effective target tests etc. and fixes up the Assembly entry
> - it is a glob, so /* Assembly can match /whatever Assembly and
> not just /* Assembly.
>
> Tested on x86_64-linux w
Hi!
This patch allows magic comments also for Rust and Modula-2
for effective target tests etc. and fixes up the Assembly entry
- it is a glob, so /* Assembly can match /whatever Assembly and
not just /* Assembly.
Tested on x86_64-linux with
make check-g++ RUNTESTFLAGS=i386.exp=pr35513*
and verif
On Thu, Dec 15, 2022 at 12:39:38PM +0100, Iain Buclaw wrote:
> For the gdc testsuite, those warnings arise because both language files
> are compiled in the same invocation (dg-additional-sources "cpp11.cpp"),
> so it ends up looking something like:
>
> gdc -fextern-std=c++11 testcpp11.d cpp11
Excerpts from Jakub Jelinek via Gcc-patches's message of Dezember 15, 2022
12:16 pm:
> We seem to have a problem in other testsuites too:
> grep ' valid for .*but not for' */*.log | sort -u
> gcc/gcc.log:/home/jakub/src/gcc/gcc/testsuite/gcc.dg/pragma-diag-6.c:2:30:
> warning: option '-Wnoexcept'
On Thu, Dec 15, 2022 at 11:14:10AM +0100, Thomas Schwinge wrote:
> Hi!
>
> On 2022-12-15T08:53:13+0100, Richard Biener
> wrote:
> > On Wed, Dec 14, 2022 at 11:58 PM Thomas Schwinge
> > wrote:
> >> On 2022-12-13T14:40:36+0100, Arthur Cohen
> >> wrote:
> >> > We've also added one more commit, w
On 12/14/22 21:03, Michael Förderer via Gcc-patches wrote:
> Dear all,
>
> this is a patch to print the gcov annotations (fallthrough or throw) als
> to uncovered branches.
Hey.
It's fine and I've just pushed the revision on your behalf:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=c263c3eba89
The following avoids a redundant second operand scan on all stmts
during inlining which shows with PR108086.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
PR middle-end/108086
* tree-inline.cc (copy_edges_for_bb): Do not update all
stmts again.
---
gcc/tree
gentle ping
Cupertino Miranda writes:
>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote:
>>> This commit is a follow up of bugzilla #107181.
>>> The commit /a0aafbc/ changed the default implementation of the
>>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the
>>>
Hi!
On 2022-12-15T08:53:13+0100, Richard Biener wrote:
> On Wed, Dec 14, 2022 at 11:58 PM Thomas Schwinge
> wrote:
>> On 2022-12-13T14:40:36+0100, Arthur Cohen wrote:
>> > We've also added one more commit, which only affects files inside the
>> > Rust front-end folder. This commit adds an exper
gentle ping
Cupertino Miranda writes:
> Hi Jeff,
>
> First of all thanks for your quick review.
> Apologies for the delay replying, the message got lost in my inbox.
>
>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote:
>>> Changed target code to select .rodata section for 'const vola
On 13/12/2022 15:30, Richard Biener wrote:
On Fri, Dec 9, 2022 at 2:56 PM Sebastian Huber
wrote:
The code coverage support uses counters to determine which edges in the control
flow graph were executed. If a counter overflows, then the code coverage
information is invalid. Therefore the coun
Hi Honza,
Thanks for the comments.
on 2022/12/14 21:22, Jan Hubicka wrote:
>>> PR middle-end/105818
>>>
>>> gcc/ChangeLog:
>>>
>>> * predict.cc (optimize_function_for_size_p): Further check
>>> optimize_size of fun->decl when it is valid but no cgraph node.
>>>
>>> gcc/testsuite/Chang
On Wed, Dec 14, 2022 at 4:20 PM Jan Hubicka via Gcc-patches
wrote:
>
> > Hi,
> >
> > Honza requested this after reviewing the patch that taught IPA-SRA
> > that REFERENCE_TYPEs are always non-NULL that the pass also handles
> > the first parameters of methods, this pointers, in the same way. So
>
On Thu, 15 Dec 2022, Jakub Jelinek wrote:
> Hi!
>
> The following testcase ICEs, because ccp1 replaced
> s.0_1 = &s;
> __asm__ goto("" : "=r" MEM[(T *)s.0_1] : : : "lab" lab);
> with
> __asm__ goto("" : "=r" s : : : "lab" lab);
> and because s is no longer addressable, we are rewriting
71 matches
Mail list logo
