[PATCH V3] rs6000: Load high and low part of 64bit constant independently

Hi, Compare with previous version, this patch updates the comments only. https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608293.html For a complicate 64bit constant, below is one instruction-sequence to build: lis 9,0x800a ori 9,9,0xabcd sldi 9,9,32 oris 9,

[PATCH-4, rs6000] Change ilp32 target check for some scalar-extract-sig and scalar-insert-exp test cases

Hi, "ilp32" is used in these test cases to make sure test cases only run on a 32-bit environment. Unfortunately, these cases also run with "-m32/-mpowerpc64" which causes unexpected errors. This patch changes the target check to skip if "has_arch_ppc64" is set. So the test cases won't run when ar

[PATCH-3, rs6000] Change mode and insn condition for scalar insert exp instruction

Hi, This patch changes the mode of exponent to GPR in scalar insert exp pattern, as the exponent can be put into a 32-bit register. Also the condition check is changed from TARGET_64BIT to TARGET_POWERPC64. The test cases are modified according to the changes of expand pattern. Bootstrapped

[PATCH-2, rs6000] Change mode and insn condition for scalar extract sig instruction

Hi, This patch changes the return type of __builtin_vsx_scalar_extract_sig from const signed long to const signed long long, so that it can be called with "-m32/-mpowerpc64" option. The bif needs TARGET_POWERPC64 instead of TARGET_64BIT. So the condition check in the expander is changed. The t

[PATCH-1, rs6000] Change mode and insn condition for scalar extract exp instruction

Hi, This patch changes the return type of __builtin_vsx_scalar_extract_exp from const signed long to const signed int, as the exponent can be put in a signed int. It is also inline with the external interface definition of the bif. The mode of exponent operand in "xsxexpdp" is changed to GPR mode

Re: [PATCH V4 2/2] rs6000: use li;x?oris to build constant

Hi, I would like to have a ping on this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608292.html BR, Jeff (Jiufu) Jiufu Guo writes: > Hi, > > For constant C: > If '(c & 0xULL) == 0x' or say: > 32(1) || 1(0) || 15(x) || 16(0), we could use "li

[PATCH] Add link to gmplib.org

Link is missing from install documentation --- gcc/doc/install.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index ccc8d15fd08..18e8709a169 100644 --- a/gcc/doc/install.texi +++ b/gcc/doc/install.texi @@ -396,7 +396,8 @@ inst

Re: [PATCH] [OpenMP] GC unused SIMD clones

On 1/2/23 03:20, Tobias Burnus wrote: On 25.11.22 03:13, Sandra Loosemore wrote: This patch is a followup to my not-yet-reviewed patch [PATCH v4] OpenMP: Generate SIMD clones for functions with "declare target" That patch got reviewed and went into mainline on Nov 15, 2022 as https://gcc.gnu.o

[PATCH] libiberty: Handle Windows nul device in unlink-if-ordinary.c [PR108276]

libiberty/ChangeLog:         * unlink-if-ordinary.c (unlink_if_ordinary): Handle Windows nul device --- libiberty/unlink-if-ordinary.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libiberty/unlink-if-ordinary.c b/libiberty/unlink-if-ordinary.c index 84328b216..ae9090e54 1006

Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]

On Wed, Dec 21, 2022 at 09:40:24PM +, Joseph Myers wrote: > On Wed, 21 Dec 2022, Segher Boessenkool wrote: > > > > --- a/gcc/tree.cc > > > +++ b/gcc/tree.cc > > > @@ -9442,15 +9442,6 @@ build_common_tree_nodes (bool signed_char) > > >if (!targetm.floatn_mode (n, extended).exists (&mode

Re: [PATCH] c++, TLS: Support cross-tu static initialization for targets without alias support [PR106435].

> On 3 Jan 2023, at 22:22, Jason Merrill wrote: > > On 12/7/22 10:39, Iain Sandoe wrote: >> This has been tested on x86_64 and arm64 Darwin and on x86_64 linux gnu. >> The basic patch is live in the homebrew macOS support and so has had quite >> wide coverage on non-trivial codebases. >>

gcc-11: FTBFS on hurd-i386

Source: gcc-11 Version: 11.3.0-10 Severity: important Tags: patch User: debian-h...@lists.debian.org Usertags: hurd Affects: gcc-11, gcc-snapshot X-Debbugs-CC: debian-h...@lists.debian.org Hi, gcc-11-11.3.0-10 in sid FTBFS on hurd-i386 due to failing linkage of pthread_once (same error already fi

Re: [PATCH] c++, TLS: Support cross-tu static initialization for targets without alias support [PR106435].

On 12/7/22 10:39, Iain Sandoe wrote: This has been tested on x86_64 and arm64 Darwin and on x86_64 linux gnu. The basic patch is live in the homebrew macOS support and so has had quite wide coverage on non-trivial codebases. OK for master? Iain Since this actually fixes wrong c

Re: [PATCH] Darwin, crts: Provide scalb and significand as a crt [PR107631]

On Tue, 3 Jan 2023, Iain Sandoe wrote: > 1. Modula-2 should not forward the builtins unless the target supports them, > either by expansion or the relevant lib functions. So that would need > some >configury and conditional build code. Note that such configure tests could only readily

Re: [PATCH] Darwin, crts: Provide scalb and significand as a crt [PR107631]

Thanks Joseph, > On 3 Jan 2023, at 18:15, Joseph Myers wrote: > > On Sat, 31 Dec 2022, Iain Sandoe wrote: > >> builtins.def unconditionally defines these builtins to be DEF_EXT_LIB_BUILTIN >> which expands to the libcall, this is currently hard-wired to FALLBACK_P = >> true. >> >> but, AFAIU

Re: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

> > On Tue, 3 Jan 2023, Jan Hubicka wrote: > > > > * gcc/common/config/i386/i386-common.cc (processor_alias_table): > > > Use CPU_ZNVER4 for znver4. > > > * config/i386/i386.md: Add znver4.md. > > > * config/i386/znver4.md: New. > > OK, > > thanks! > > Honza, I'm curious what are your fu

Re: [PATCH] Darwin, crts: Provide scalb and significand as a crt [PR107631]

On Sat, 31 Dec 2022, Iain Sandoe wrote: > builtins.def unconditionally defines these builtins to be DEF_EXT_LIB_BUILTIN > which expands to the libcall, this is currently hard-wired to FALLBACK_P = > true. > > but, AFAIU the builtins.def descriptions: > > FALLBACK_P should be false if the libc

Re: [PATCH] libgcc: Fix uninitialized RA signing on AArch64 [PR107678]

Hi Richard, > Hmm, but the point of the original patch was to support code generators > that emit DW_CFA_val_expression instead of DW_CFA_AARCH64_negate_ra_state. > Doesn't this patch undo that? Well it wasn't clear from the code or comments that was supported. I've added that back in v2. > Also

Re: [PATCH] tree-optimization/105043: Object Size Checking docs cleanup

On 2022-12-27 13:25, Jeff Law wrote: On 12/15/22 12:25, Siddhesh Poyarekar wrote: Break the _FORTIFY_SOURCE-specific builtins out into a separate subsection from Object Size Checking built-ins and mention _FORTIFY_SOURCE in there so that the link between the object size checking builtins, the

Re: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

On Tue, 3 Jan 2023, Jan Hubicka wrote: > > * gcc/common/config/i386/i386-common.cc (processor_alias_table): > > Use CPU_ZNVER4 for znver4. > > * config/i386/i386.md: Add znver4.md. > > * config/i386/znver4.md: New. > OK, > thanks! Honza, I'm curious what are your further plans f

Re: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

> [Public] > > Hello, > > I have addressed all your comments in this revision of the patch, please find > attached and inlined. > > * I have updated all the latencies with Agner's measurements. > * Incorrect pipelines, loads/stores are addressed. > * The double pumped avx512 insns take one cycl

[ping][PATCH 0/2] __bos and flex arrays

Ping! On 2022-12-21 17:25, Siddhesh Poyarekar wrote: Hi, The first patch in the series is just a minor test cleanup that I did to make sure all tests in a test case run (instead of aborting at first failure) and print the ones that failed. The second patch is the actual fix. The patch intends

Re: [PATCH] Various fixes for DWARF register size computation

On Tue, Jan 03, 2023 at 02:25:21PM +0100, Florian Weimer wrote: > > Though, I still wonder, because all of this is a hack for a single target > > - x86_64-linux -m64 - I think no other target has similar constant > > sizes, > > Really? That's odd. I've tried about 30 cross compilers I had around

Re: [PATCH] Various fixes for DWARF register size computation

* Jakub Jelinek: > On Tue, Jan 03, 2023 at 12:15:23PM +0100, Florian Weimer wrote: >> --- a/gcc/debug.h >> +++ b/gcc/debug.h >> @@ -245,7 +245,18 @@ extern const struct gcc_debug_hooks vmsdbg_debug_hooks; >> >> /* Dwarf2 frame information. */ >> >> -extern int dwarf_reg_sizes_constant (); >>

[PATCH] PR tree-optimization/92342: Optimize b & -(a==c) in match.pd

This patch is an update/tweak of Andrew Pinski's two patches for PR tree-optimization/92342, that were originally posted back in November: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585111.html https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585112.html Technically, the first

Re: [PATCH] Various fixes for DWARF register size computation

On Tue, Jan 03, 2023 at 12:15:23PM +0100, Florian Weimer wrote: > --- a/gcc/debug.h > +++ b/gcc/debug.h > @@ -245,7 +245,18 @@ extern const struct gcc_debug_hooks vmsdbg_debug_hooks; > > /* Dwarf2 frame information. */ > > -extern int dwarf_reg_sizes_constant (); > +/* Query size information

Re: [PATCH] Fix RTL simplifications of FFS, POPCOUNT and PARITY.

On Mon, Jan 02, 2023 at 09:20:33AM -0700, Jeff Law wrote: > On 1/2/23 08:59, Jakub Jelinek wrote: > >See the PR50161 thread in > >https://gcc.gnu.org/legacy-ml/gcc-patches/2011-08/threads.html#01847 Nasty nasty nasty. > >The options are to disallow different modes, which is what my patch did > >(

[PATCH] Various fixes for DWARF register size computation

The previous code had several issues. 1. XALLOCAVEC does not create any objects, so invocating the non-POD poly_uint16 assignment operator is undefined. 2. The default constructor of poly-ints does not create a zero poly-int object (unlike what happens with regular ints). 3. The register siz

Re: [PATCH] expr: Fix up store_expr into SUBREG_PROMOTED_* target [PR108264]

> Am 03.01.2023 um 11:34 schrieb Jakub Jelinek via Gcc-patches > : > > Hi! > > The following testcase ICEs on s390x-linux (e.g. with -march=z13). > The problem is that target is (subreg/s/u:SI (reg/v:DI 66 [ x+-4 ]) 4) > and we call convert_move from temp to the SUBREG_REG of that, expecting

Re: [PATCH] cfgrtl: Don't try to redirect asm goto to EXIT [PR108263]

> Am 03.01.2023 um 11:29 schrieb Jakub Jelinek via Gcc-patches > : > > Hi! > > The following testcase distilled from Linux kernel on ppc64le ICEs, > because fixup_reorder_chain sees a bb with a single fallthru edge > falling into a bb with simple return and decides to redirect > that fallthr

[PATCH] expr: Fix up store_expr into SUBREG_PROMOTED_* target [PR108264]

Hi! The following testcase ICEs on s390x-linux (e.g. with -march=z13). The problem is that target is (subreg/s/u:SI (reg/v:DI 66 [ x+-4 ]) 4) and we call convert_move from temp to the SUBREG_REG of that, expecting to extend the value properly. That works nicely if temp has some scalar integer mod

[PATCH] cfgrtl: Don't try to redirect asm goto to EXIT [PR108263]

Hi! The following testcase distilled from Linux kernel on ppc64le ICEs, because fixup_reorder_chain sees a bb with a single fallthru edge falling into a bb with simple return and decides to redirect that fallthru edge to EXIT. That is possible if the bb ending in the fallthru edge doesn't end wit

[COMMITTED] ada: output.adb: fix newline being inserted when buffer is full

From: Ghjuvan Lacambre Before this commit, when GNAT needed to emit lines longer than the buffer, it accidentally inserted a newline in its output when attempting to flush its buffer. We fix this by using Flush_Buffer instead of Write_Eol in Write_Char. gcc/ada/ * output.adb (Write_Buf

[COMMITTED] ada: Fix format string parsing in GNAT.Formatted_String

From: Ronan Desplanques Before this patch, format strings ending with "%%" (two consecutive percent signs) caused GNAT.Formatted_String."-" to give the wrong output, and cause the various GNAT.Formatted_String."&" to raise exceptions with misleading error messages. Also before this patch, a bug

[COMMITTED] ada: Another small adjustment to special resolution of membership test

From: Eric Botcazou This goes back to the original implementation but keeps the special size test with universal_integer to cope with its limited range. gcc/ada/ * sem_res.adb (Resolve_Membership_Op): Adjust again latest change. Tested on x86_64-pc-linux-gnu, committed on master. ---

[COMMITTED] ada: Fix GNAT.Formatted_String's handling of real values

From: Ronan Desplanques Before this patch, passing a width and a precision through arguments with the "*" syntax always failed for real values in GNAT.Formatted_String's routines. gcc/ada/ * libgnat/g-forstr.adb (P_Flt_Format): Add "*" syntax handling. Tested on x86_64-pc-linux-gnu, co

[COMMITTED] ada: Make Sem_Util.Is_Aliased_View predicate more robust

From: Eric Botcazou The predicate implements the rules of the language so it needs to cope with constructs rewritten by the expander, in particular explicit dereferences that the expander uses liberally for various purposes. This change makes the detection of rewritten calls more robust, pluggin

[COMMITTED] ada: Fix premature finalization of return temporary

From: Eric Botcazou Various parts of the expander and the code generator must have a consistent view on which temporaries generated for return statements must be finalized because they are regular temporaries, and which ones must not be since they are allocated on the return stack directly. The

[COMMITTED] ada: Fix unescaped quotes when combining fdiagnostics-format=json and gnatdJ

From: Ghjuvan Lacambre This commit fixes a small bug where GNAT would emit unescaped quotes in its -fdiagnostics-format=json output when using -gnatdJ and emitting messages about operator functions (e.g. "="). gcc/ada/ * errout.adb (Write_JSON_Span): Escape subprogram name. Tested on x

[COMMITTED] ada: GNAT UGN: Adjust wording in "Platform-specific Information" chapter

From: Joel Brobecker The wording of the introduction paragraph specified an incomplete list of OSes. Rather than trying to update the list, this commit changes the text to make it more general. For those parts of this chapter which only apply to specific OSes, the documentation is written in a wa

[COMMITTED] ada: Fix calling convention of foreign functions returning limited type

From: Eric Botcazou Such functions use neither Ada 2005's build-in-place mechanism nor Ada 95's return-by-reference mechanism, but instead the common calling convention of functions returning a nonlimited by-reference type. gcc/ada/ * exp_ch6.adb (Is_Build_In_Place_Function): Adjust com

[COMMITTED] ada: Make Apply_Discriminant_Check.Denotes_Explicit_Dereference more robust

From: Eric Botcazou The predicate implements the rules of the language so it needs to cope with constructs rewritten by the expander, in particular explicit dereferences that the expander uses liberally for various purposes. This change makes the detection of rewritten calls more robust and adds

[COMMITTED] ada: Fix parsing bug in GNAT.Formatted_String

From: Ronan Desplanques Before this patch, GNAT.Formatted_String.Formatted_String failed to handle format strings with two or more specifiers whose widths were specified with the "*" syntax. This patch makes the parser correctly reset its bits of state related to width and precision parsing when

[COMMITTED] ada: Simplify [Small_]Integer_Type_For

From: Bob Duff Make Small_Integer_Type_For call Integer_Type_For, so they share most of the code. Remove Standard_Long_Integer from consideration, because that's different on different machines (32- or 64-bit). Standard_Integer or Standard_Long_Long_Integer will be chosen. gcc/ada/ * e

[COMMITTED] ada: Adapt frontend optimization for aggregate assignment

The frontend currently relies on gigi to use efficient assignment in particular cases like: Some_Var.all := (others => (others => 0)); gigi would use memset to clear memory pointed to by Some_Var. In the case of an access with a Designated_Storage_Model aspect with a Copy_To procedure, memset

[COMMITTED] ada: Fix detection of function calls in object declarations

From: Eric Botcazou The current code has relied on Original_Node to detect rewritten function calls in object declarations but that's not robust enough in the presence of function calls written in object notation. gcc/ada/ * exp_util.ads (Is_Captured_Function_Call): Declare. * e

[COMMITTED] ada: Cannot reference ghost entity in class-wide precondition

From: Javier Miranda gcc/ada/ * ghost.adb (Is_OK_Declaration): A reference to a Ghost entity may appear within the class-wide precondition of a helper subprogram. This context is treated as suitable because it was already verified when we were analyzing the origin

[COMMITTED] ada: Fix support of Default_Component_Value aspect on derived types

From: Eric Botcazou The support of the Default_Component_Value aspect on derived constrained array types is broken because of a couple of issues: 1) the derived types incorrectly inherit the initialization procedure of the ancestor types and 2) the propagation of the aspect does not work for cons

Re: [PATCH 2/4] Initial Emeraldrapids Support

On Tue, Jan 3, 2023 at 9:39 AM Hu, Lin1 wrote: > > gcc/ChangeLog: > > * common/config/i386/cpuinfo.h (get_intel_cpu): Handle Emeraldrapids. > * common/config/i386/i386-common.cc: Add Emeraldrapids. OK. Thanks, Uros. > --- > gcc/common/config/i386/cpuinfo.h | 2 ++ > gcc/co

Re: [PATCH 1/4] i386: Remove Meteorlake's family_model

On Tue, Jan 3, 2023 at 9:39 AM Hu, Lin1 wrote: > > Hi all, > > This patch aims to modified meteorlake's family_model. > > Regtested on x86_64-pc-linux-gnu. Ok for trunk? > > BRs, > Lin > > gcc/ChangeLog: > > * common/config/i386/cpuinfo.h (get_intel_cpu): Remove case 0xb5 > for met

Re: [x86 PATCH] Improve ix86_expand_int_movcc to allow condition (mask) sharing.

On Mon, Jan 2, 2023 at 11:50 AM Roger Sayle wrote: > > > This patch modifies the way that ix86_expand_int_movcc generates RTL, > to allow the condition mask to be shared/reused between multiple > conditional move sequences. Such redundancy is common when RTL > if-conversion transforms non-trivial

RE: [PATCH] loading float member of parameter stored via int registers

Sorry for send this mail. I enter the wrong command line. -Original Message- From: Gcc-patches On Behalf Of Segher Boessenkool Sent: Tuesday, January 3, 2023 5:00 PM To: Andrew Pinski Cc: Jiufu Guo ; Jiufu Guo via Gcc-patches ; Richard Biener ; Richard Biener ; dje@gmail.com; li..

Re: [PATCH] loading float member of parameter stored via int registers

Hi! On Fri, Dec 30, 2022 at 12:30:04AM -0800, Andrew Pinski wrote: > On Thu, Dec 29, 2022 at 11:45 PM Segher Boessenkool > wrote: > > Ah! This simply shows rs6000_modes_tieable_p is decidedly non-optimal: > > it does not allow tying a scalar float to anything else. No such thing > > is required

RE: [PATCH 2/4] Initial Emeraldrapids Support

"PATCH 2 Initial Emeraldrapids Support" aims to support Emeraldrapids for GCC. It's my mistake, resulting in the omission of its information. -Original Message- From: Liu, Hongtao Sent: Tuesday, January 3, 2023 4:48 PM To: Hu, Lin1 ; gcc-patches@gcc.gnu.org Cc: ubiz...@gmail.com Subject

RE: [PATCH 2/4] Initial Emeraldrapids Support

There are actually only two patches, not four, and the subject *Patch 2/4* should be a typo. > -Original Message- > From: Hu, Lin1 > Sent: Tuesday, January 3, 2023 4:37 PM > To: gcc-patches@gcc.gnu.org > Cc: Liu, Hongtao ; ubiz...@gmail.com > Subject: [PATCH 2/4] Initial Emeraldrapids Su

[PATCH 2/4] Initial Emeraldrapids Support

gcc/ChangeLog: * common/config/i386/cpuinfo.h (get_intel_cpu): Handle Emeraldrapids. * common/config/i386/i386-common.cc: Add Emeraldrapids. --- gcc/common/config/i386/cpuinfo.h | 2 ++ gcc/common/config/i386/i386-common.cc | 2 ++ 2 files changed, 4 insertions(+) diff --git

[PATCH 1/4] i386: Remove Meteorlake's family_model

Hi all, This patch aims to modified meteorlake's family_model. Regtested on x86_64-pc-linux-gnu. Ok for trunk? BRs, Lin gcc/ChangeLog: * common/config/i386/cpuinfo.h (get_intel_cpu): Remove case 0xb5 for meteorlake. --- gcc/common/config/i386/cpuinfo.h | 1 - 1 file changed, 1