[PATCH 3/4] ree: Improve functionality of ree pass for rs6000 target.

2023-06-07 Thread Ajit Agarwal via Gcc-patches
Hello All: This patch provide functionality to improve ree pass for rs6000 target. Eliminated sign_extend/zero_extend/AND with varying constants. Bootstrapped and regtested on powerpc64-linux-gnu. Thanks & Regards Ajit ree: Improve ree pass for rs6000 target For rs6000 target we see redundant

[PATCH] libiberty: pex-unix.c: Make pex_unix_cleanup signature always match body.

2023-06-07 Thread Costas Argyris via Gcc-patches
I saw this while working on something else: pex_unix_cleanup signature doesn't always match the body of the function in terms of ATTRIBUTE_UNUSED. If the conditional code in the body is compiled, then ATTRIBUTE_UNUSED isn't correct. This change makes it always match, thereby making it a bit

Re: [PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-06-07 Thread Aldy Hernandez via Gcc-patches
On 5/26/23 18:17, Martin Jambor wrote: Hello, On Mon, May 22 2023, Aldy Hernandez wrote: I've adjusted the patch with some minor cleanups that came up when I implemented the rest of the IPA revamp. Rested. OK? On Wed, May 17, 2023 at 4:31 PM Aldy Hernandez wrote: This converts the

Re: [PATCH 1/4][V4][RISC-V] support cm.push cm.pop cm.popret in zcmp

2023-06-07 Thread jiawei
Seems there are some indent format problems in the patch, could you fix them :) ``` patch:509: indent with spaces. x_save_size = riscv_stack_align (num_multi_push * UNITS_PER_WORD); error: patch failed: gcc/config/riscv/riscv.cc:5652 error: gcc/config/riscv/riscv.cc: patch does not

Re: [PATCH] Implement ipa_vr hashing.

2023-06-07 Thread Aldy Hernandez via Gcc-patches
On 5/29/23 16:51, Martin Jambor wrote: Hi, On Mon, May 22 2023, Aldy Hernandez via Gcc-patches wrote: Implement hashing for ipa_vr. When all is said and done, all these patches incurr a 7.64% slowdown for ipa-cp, with is entirely covered by the similar 7% increase in this area last week.

Re: [PATCH] rs6000: Add builtins for IEEE 128-bit floating point values

2023-06-07 Thread Kewen.Lin via Gcc-patches
Hi, on 2023/6/7 03:54, Carl Love wrote: > On Mon, 2023-06-05 at 16:45 +0800, Kewen.Lin wrote: >> Hi Carl, >> >> on 2023/5/2 23:52, Carl Love via Gcc-patches wrote: >>> GCC maintainers: >>> >>> The following patch adds three buitins for inserting and extracting >>> the >>> exponent and significand

Re: Support 'UNSUPPORTED: [...]: exception handling disabled' for libstdc++ testing (was: Support in the GCC(/C++) test suites for '-fno-exceptions')

2023-06-07 Thread Thomas Schwinge
Hi! On 2023-06-07T09:12:31+0100, Jonathan Wakely wrote: > On Wed, 7 Jun 2023 at 08:13, Thomas Schwinge wrote: >> On 2023-06-06T20:31:21+0100, Jonathan Wakely wrote: >> > On Tue, 6 Jun 2023 at 20:14, Thomas Schwinge >> > wrote: >> >> This issue comes up in context of me working on C++ support

RE: [PATCH v5] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-07 Thread Li, Pan2 via Gcc-patches
Thanks Juzhe for reviewing. I see, this way may have even smaller code change which treats the zvfhmin as minimal base sub extension. I will have a try for PATCH V6. Pan From: juzhe.zh...@rivai.ai Sent: Wednesday, June 7, 2023 4:27 PM To: Li, Pan2 ; gcc-patches Cc: Robin Dapp ; jeffreyalaw ;

Re: [PATCH] modula2: Fix bootstrap

2023-06-07 Thread Andre Vieira (lists) via Gcc-patches
Thanks Jakub! I do need those includes and sorry I broke your bootstrap it didn't show up on my aarch64-unknown-linux-gnu bootstrap, I'm guessing the rules there were just run in a different order. Glad you were able to fix it :) On 06/06/2023 22:28, Jakub Jelinek wrote: Hi! internal-fn.h

[patch,avr]: Improve bit-extractions as of PR109907.

2023-06-07 Thread Georg-Johann Lay
This patch improves bit-extractions on AVR. Andrew added some patches so that more bit extractions are recognized in the middle-end and rtl optimizers. The patch adds pattern for "extzv" and replaces the deprecated "extzv". There are still situations where expensive shifts are passed down to

Ping #2: [patch,avr] Fix PR109650 wrong code

2023-06-07 Thread Georg-Johann Lay
Ping #2 for: https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618976.html https://gcc.gnu.org/pipermail/gcc-patches/attachments/20230519/9536bf8c/attachment-0001.bin Ping #1: https://gcc.gnu.org/pipermail/gcc-patches/2023-May/620098.html Johann Am 19.05.23 um 10:49 schrieb Georg-Johann

Re: [PATCH v5] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-07 Thread juzhe.zh...@rivai.ai
In this patch, you add TARGET_ZVFH into VF iterator which is not correct. When TARGET_ZVFH is true, TARGET_ZVFHMIN is always true. For vfadd, it is true we should enable "vfadd" for TARGET_ZVFH For vle16, we should enable for TARGET_ZVFHMIN. This patch will disable both "vle16" and "vfadd" for

[PATCH V2] Optimize '(X - N * M) / N' to 'X / N - M' if valid

2023-06-07 Thread Jiufu Guo via Gcc-patches
Hi, This patch tries to optimize "(X - N * M) / N" to "X / N - M". For C code, "/" towards zero (trunc_div), and "X - N * M" maybe wrap/overflow/underflow. So, it is valid that "X - N * M" does not cross zero and does not wrap/overflow/underflow. Compare with previous version:

[testsuite] bump some tsvc timeouts

2023-06-07 Thread Alexandre Oliva via Gcc-patches
Several tests are timing out when targeting x86-*-vxworks with qemu. Bump their timeout factor. for gcc/testsuite/ChangeLog * gcc.dg/vect/tsvc/vect-tsvc-s116.c: Bump timeout factor. * gcc.dg/vect/tsvc/vect-tsvc-s241.c: Likewise. * gcc.dg/vect/tsvc/vect-tsvc-s254.c:

Re: Support 'UNSUPPORTED: [...]: exception handling disabled' for libstdc++ testing (was: Support in the GCC(/C++) test suites for '-fno-exceptions')

2023-06-07 Thread Jonathan Wakely via Gcc-patches
On Wed, 7 Jun 2023 at 08:13, Thomas Schwinge wrote: > Hi! > > On 2023-06-06T20:31:21+0100, Jonathan Wakely wrote: > > On Tue, 6 Jun 2023 at 20:14, Thomas Schwinge > > wrote: > >> This issue comes up in context of me working on C++ support for GCN and > >> nvptx target. Those targets shall

Re: [PATCH v5] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-07 Thread juzhe.zh...@rivai.ai
I am not sure for load/stores of FP16 vector should be gated by ZVFHMIN or ZVFH? Since IMHO, load/stores of FP16 is no different from load/stores of INT16? juzhe.zh...@rivai.ai From: pan2.li Date: 2023-06-07 16:06 To: gcc-patches CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li; yanzhang.wang

RE: [PATCH v3] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-07 Thread Li, Pan2 via Gcc-patches
Minor change in PATCH V5, please help to turn to V5 as below, sorry for inconvenient. https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620890.html Pan From: Li, Pan2 Sent: Wednesday, June 7, 2023 2:57 PM To: 'juzhe.zh...@rivai.ai' ; 'gcc-patches' Cc: 'Kito.cheng' ; Wang, Yanzhang

Re: [committed] libstdc++: Update list of known symbol versions for abi-check

2023-06-07 Thread Jonathan Wakely via Gcc-patches
On Wed, 7 Jun 2023 at 05:43, François Dumont wrote: > > On 06/06/2023 17:59, Jonathan Wakely via Libstdc++ wrote: > > Tested x86_64-linux and powerpc64le-linux. Pushed to trunk. > > > > -- >8 -- > > > > Add the recently added CXXABI_1.3.15 version. Also remove two "frozen" > > versions from the

[PATCH v5] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-07 Thread Pan Li via Gcc-patches
From: Pan Li This patch would like to refactor the requirement of both the ZVFH and ZVFHMIN. The related define_insn and iterator will take the requirement based on the ZVFHMIN and ZVFH. Please note the ZVFH will cover the ZVFHMIN instructions. This patch add one test for this. Signed-off-by:

Re: Re: [PATCH V3] VECT: Add SELECT_VL support

2023-06-07 Thread juzhe.zh...@rivai.ai
Hi, Richi. Thanks for review. >> At least for VMAT_GATHER_SCATTER you wouldn't execute this function >> but get into >>This function belongs to tree-vect-data-refs.cc alongside the >>other vect_create_data_ref_* functions. I want to support data reference pointer adjusted by outcome of SELECT_VL.

Re: [PATCH] LoongArch: Change jumptable's register constraint to 'q' [PR110136]

2023-06-07 Thread Lulu Cheng
在 2023/6/7 下午3:37, WANG Xuerui 写道: On 2023/6/7 11:36, Lulu Cheng wrote: 在 2023/6/7 上午11:26, WANG Xuerui 写道: Hi, On 2023/6/7 10:31, Lulu Cheng wrote: If the $ra register is modified during the jump to the jump table, the hardware branch prediction function will be broken, resulting in a

[PATCH v2] LoongArch:Change the default value of LARCH_CALL_RATIO to 6 on the LoongArch architecture.

2023-06-07 Thread chen xiaolong via Gcc-patches
During the regression testing of the LoongArch architecture GCC, it was found that the tests in the pr90883.C file failed. The problem was modulated and found that the error was caused by setting the macro LARCH_CALL_RATIO to a too large value. Combined with the actual LoongArch

Re: [PATCH V3] VECT: Add SELECT_VL support

2023-06-07 Thread Richard Biener via Gcc-patches
On Mon, 5 Jun 2023, juzhe.zh...@rivai.ai wrote: > From: Ju-Zhe Zhong > > Co-authored-by: Richard Sandiford > > This patch address comments from Richard and rebase to trunk. > > This patch is adding SELECT_VL middle-end support > allow target have target dependent optimization in case of >

Re: [PATCH] LoongArch: Change jumptable's register constraint to 'q' [PR110136]

2023-06-07 Thread WANG Xuerui
On 2023/6/7 11:36, Lulu Cheng wrote: 在 2023/6/7 上午11:26, WANG Xuerui 写道: Hi, On 2023/6/7 10:31, Lulu Cheng wrote: If the $ra register is modified during the jump to the jump table, the hardware branch prediction function will be broken, resulting in a significant increase in the branch

Re: [r14-1579 Regression] FAIL: gfortran.dg/gomp/target-update-1.f90 -O scan-tree-dump gimple "#pragma omp target update to\\(c \\[len: [0-9]+\\]\\) to\\(present:a \\[len: [0-9]+\\]\\) to\\(e \\[len:

2023-06-07 Thread Maxim Kuvyrkov via Gcc-patches
Hi Tobias, We are also seeing this failure on arm-linux-gnueabihf. It seems the problem is different order of variables in output: - c a e d b versus expected - c a e b d This is tree-dump output on arm-linux-gnueabihf: #pragma omp target update to(c [len: 4]) to(present:a [len: 4000])

Support 'UNSUPPORTED: [...]: exception handling disabled' for libstdc++ testing (was: Support in the GCC(/C++) test suites for '-fno-exceptions')

2023-06-07 Thread Thomas Schwinge
Hi! On 2023-06-06T20:31:21+0100, Jonathan Wakely wrote: > On Tue, 6 Jun 2023 at 20:14, Thomas Schwinge > wrote: >> This issue comes up in context of me working on C++ support for GCN and >> nvptx target. Those targets shall default to '-fno-exceptions' -- or, >> "in other words",

Re: [PATCH 1/2] Match: zero_one_valued_p should match 0 constants too

2023-06-07 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 06, 2023 at 05:17:05PM -0700, Andrew Pinski via Gcc-patches wrote: > While working on `bool0 ? bool1 : bool2` I noticed that > zero_one_valued_p does not match on the constant zero > as in that case tree_nonzero_bits will return 0 and > that is different from 1. > > OK? Bootstrapped

Re: [x86 PATCH] PR target/31985: Improve memory operand use with doubleword add.

2023-06-07 Thread Uros Bizjak via Gcc-patches
On Wed, Jun 7, 2023 at 8:32 AM Uros Bizjak wrote: > > On Wed, Jun 7, 2023 at 1:05 AM Roger Sayle wrote: > > > > > > This patch addresses the last remaining issue with PR target/31985, that > > GCC could make better use of memory addressing modes when implementing > > double word addition. This

RE: [PATCH v3] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-07 Thread Li, Pan2 via Gcc-patches
Update the PATCH V4 as below, sorry for missed the v4 prefix in subject. https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620879.html Pan From: Li, Pan2 Sent: Wednesday, June 7, 2023 2:21 PM To: juzhe.zh...@rivai.ai; gcc-patches Cc: Kito.cheng ; Wang, Yanzhang Subject: RE: [PATCH v3]

[PATCH] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-07 Thread Pan Li via Gcc-patches
From: Pan Li This patch would like to refactor the requirement of both the ZVFH and ZVFHMIN. The related define_insn and iterator will take the requirement based on the ZVFHMIN and ZVFH. Please note the ZVFH will cover the ZVFHMIN instructions. This patch add one test for this. Signed-off-by:

Re: [x86 PATCH] PR target/31985: Improve memory operand use with doubleword add.

2023-06-07 Thread Uros Bizjak via Gcc-patches
On Wed, Jun 7, 2023 at 1:05 AM Roger Sayle wrote: > > > This patch addresses the last remaining issue with PR target/31985, that > GCC could make better use of memory addressing modes when implementing > double word addition. This is achieved by adding a define_insn_and_split > that combines an

[PATCH] Add parentheses to clarify precedence between operators [PR106907]

2023-06-07 Thread P Jeevitha via Gcc-patches
PR106907 has few warnings spotted from cppcheck. Inorder to clarify the order of precedence between operators added parentheses to explicitly group operations based on desired order of evaluation. 2023-06-07 Jeevitha Palanisamy gcc/ PR target/106907 * config/gcn/gcn.cc

RE: [PATCH v3] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-07 Thread Li, Pan2 via Gcc-patches
Thanks JuZhe, make sense, will update the V4 for this change. Pan From: juzhe.zh...@rivai.ai Sent: Wednesday, June 7, 2023 12:21 PM To: Li, Pan2 ; gcc-patches Cc: Kito.cheng ; Li, Pan2 ; Wang, Yanzhang Subject: Re: [PATCH v3] RISC-V: Refactor requirement of ZVFH and ZVFHMIN. HI, + (VNx1SF

Re: [x86 PATCH] Add support for stc, clc and cmc instructions in i386.md

2023-06-07 Thread Uros Bizjak via Gcc-patches
On Tue, Jun 6, 2023 at 11:00 PM Roger Sayle wrote: > > > Hi Uros, > Might you willing to approve the patch without the *x86_clc pieces? > These can be submitted later, when they are actually used. For now, > we're arguing about the performance of a pattern that's not yet > generated on an

Re: [PATCH 1/4] rs6000: build constant via li;rotldi

2023-06-07 Thread Jiufu Guo via Gcc-patches
Hi David, David Edelsohn writes: > > Hi, Jiufu > * config/rs6000/rs6000.cc (can_be_rotated_to_possitive_li): New > function. > (can_be_rotated_to_negative_li): New function. > (can_be_built_by_li_and_rotldi): New function. > (rs6000_emit_set_long_const): Call

<    1   2