Re: Ping: [PATCH][Arm] Enable MVE SIMD modes for vectorization

2020-10-12 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 8 Oct 2020 at 16:22, Christophe Lyon wrote: > > On Thu, 8 Oct 2020 at 16:08, Dennis Zhang wrote: > > > > Hi Christophe, > > > > On 08/10/2020 14:14, Christophe Lyon wrote: > > > Hi, > > > > > > > > > On T

Re: [PATCH] arm: Fix multiple inheritance thunks for thumb-1 with -mpure-code

2020-10-12 Thread Christophe Lyon via Gcc-patches
On Thu, 8 Oct 2020 at 11:58, Richard Earnshaw wrote: > > On 08/10/2020 10:07, Christophe Lyon via Gcc-patches wrote: > > On Tue, 6 Oct 2020 at 18:02, Richard Earnshaw > > wrote: > >> > >> On 29/09/2020 20:50, Christophe Lyon via Gcc-patches wrote: > >&g

Re: Ping: [PATCH][Arm] Enable MVE SIMD modes for vectorization

2020-10-08 Thread Christophe Lyon via Gcc-patches
On Thu, 8 Oct 2020 at 16:08, Dennis Zhang wrote: > > Hi Christophe, > > On 08/10/2020 14:14, Christophe Lyon wrote: > > Hi, > > > > > > On Tue, 6 Oct 2020 at 15:37, Dennis Zhang via Gcc-patches > > wrote: > >> > >> On 9/16/20 4:00

Re: Ping: [PATCH][Arm] Enable MVE SIMD modes for vectorization

2020-10-08 Thread Christophe Lyon via Gcc-patches
Hi, On Tue, 6 Oct 2020 at 15:37, Dennis Zhang via Gcc-patches wrote: > > On 9/16/20 4:00 PM, Dennis Zhang wrote: > > Hi all, > > > > This patch enables SIMD modes for MVE auto-vectorization. > > In this patch, the integer and float MVE SIMD modes are returned by > > arm_preferred_simd_mode (TARG

Re: [PATCH] arm: Fix multiple inheritance thunks for thumb-1 with -mpure-code

2020-10-08 Thread Christophe Lyon via Gcc-patches
On Tue, 6 Oct 2020 at 18:02, Richard Earnshaw wrote: > > On 29/09/2020 20:50, Christophe Lyon via Gcc-patches wrote: > > When mi_delta is > 255 and -mpure-code is used, we cannot load delta > > from code memory (like we do without -mpure-code). > > > > This patch

testsuite: [arm] add -mthumb to arm/cortex-m55 tests

2020-10-07 Thread Christophe Lyon via Gcc-patches
The recently added arm/cortex-m55-* tests fail if the compiler does not default to thumb code. This patch adds -mthumb to the dg-additional-options, which fixes the problem in most cases. When running the tests with an incompatible -march= value, the tests also fail because it conflicts with -mcp

Re: [PATCH] divmod: Match and expand DIVMOD even in some cases of constant divisor [PR97282]

2020-10-07 Thread Christophe Lyon via Gcc-patches
On Tue, 6 Oct 2020 at 11:42, Christophe Lyon wrote: > > Hi Jakub, > > On Tue, 6 Oct 2020 at 10:13, Richard Biener wrote: > > > > On Tue, 6 Oct 2020, Jakub Jelinek wrote: > > > > > Hi! > > > > > > As written in the comment, tree-ssa-math-op

[PATCH v2] arm: [MVE] Remove illegal intrinsics

2020-10-06 Thread Christophe Lyon via Gcc-patches
__arm_vqdmlahq_n_u32 __arm_vmlaldavaxq_p_u32 __arm_vmlaldavaxq_p_u16 v2: rebased after Srinath's reorganization patch 2020-10-06 Christophe Lyon gcc/ PR target/96914 * config/arm/arm_mve.h (vqrdmlashq_n_u8, vqrdmlashq_n_u16) (vqrdmlashq_n_u32, vqrdmlahq

[PATCH v2] arm: [MVE[ Add vqdmlashq intrinsics

2020-10-06 Thread Christophe Lyon via Gcc-patches
This patch adds: vqdmlashq_m_n_s16 vqdmlashq_m_n_s32 vqdmlashq_m_n_s8 vqdmlashq_n_s16 vqdmlashq_n_s32 vqdmlashq_n_s8 v2: rebased after Srinath's reorganization patch 2020-10-05 Christophe Lyon gcc/ PR target/96914 * config/arm/arm_mve.h (vqdmlashq, vqdmla

Re: [PATCH] divmod: Match and expand DIVMOD even in some cases of constant divisor [PR97282]

2020-10-06 Thread Christophe Lyon via Gcc-patches
Hi Jakub, On Tue, 6 Oct 2020 at 10:13, Richard Biener wrote: > > On Tue, 6 Oct 2020, Jakub Jelinek wrote: > > > Hi! > > > > As written in the comment, tree-ssa-math-opts.c wouldn't create a DIVMOD > > ifn call for division + modulo by constant for the fear that during > > expansion we could gener

Re: [PATCH 1/2] arm: Avoid indirection with -mpure-code on v6m (PR96967)

2020-10-06 Thread Christophe Lyon via Gcc-patches
ping? On Mon, 28 Sep 2020 at 11:09, Christophe Lyon wrote: > > With -mpure-code on v6m (thumb-1), to avoid a useless indirection when > building the address of a symbol, we want to consider SYMBOL_REF as a > legitimate constant. This way, we build the address using a series of &

Re: [PATCH 2/2] arm: Improve handling of relocations with small offsets with -mpure-code on v6m (PR96770)

2020-10-06 Thread Christophe Lyon via Gcc-patches
ping? On Mon, 28 Sep 2020 at 11:09, Christophe Lyon wrote: > > With -mpure-code on v6m (thumb-1), we can use small offsets with > upper/lower relocations to avoid the extra addition of the > offset. > > This patch accepts expressions symbol+offset as legitimate constants >

Re: [PATCH] arm: Fix multiple inheritance thunks for thumb-1 with -mpure-code

2020-10-06 Thread Christophe Lyon via Gcc-patches
ping? On Tue, 29 Sep 2020 at 21:50, Christophe Lyon wrote: > > When mi_delta is > 255 and -mpure-code is used, we cannot load delta > from code memory (like we do without -mpure-code). > > This patch builds the value of mi_delta into r3 with a series of > movs/adds/lsls

[PATCH] arm: [MVE] Remove illegal intrinsics

2020-10-06 Thread Christophe Lyon via Gcc-patches
__arm_vqdmlahq_n_u32 __arm_vmlaldavaxq_p_u32 __arm_vmlaldavaxq_p_u16 2020-10-06 Christophe Lyon gcc/ PR target/96914 * config/arm/arm_mve.h (vqrdmlashq_n_u8, vqrdmlashq_n_u16) (vqrdmlashq_n_u32, vqrdmlahq_n_u8, vqrdmlahq_n_u16) (vqrdmlahq_n_u32

[PATCH] arm: [MVE[ Add vqdmlashq intrinsics

2020-10-05 Thread Christophe Lyon via Gcc-patches
This patch adds: vqdmlashq_m_n_s16 vqdmlashq_m_n_s32 vqdmlashq_m_n_s8 vqdmlashq_n_s16 vqdmlashq_n_s32 vqdmlashq_n_s8 2020-10-05 Christophe Lyon gcc/ * config/arm/arm_mve.h (vqdmlashq, vqdmlashq_m): Define. * config/arm/arm_mve_builtins.def (vqdmlashq_n_s

[PATCH] arm: [MVE] Add missing __arm_vcvtnq_u32_f32 intrinsic (PR 96914)

2020-10-05 Thread Christophe Lyon via Gcc-patches
__arm_vcvtnq_u32_f32 was missing from arm_mve.h, although the s32_f32 and [su]16_f16 versions were present. This patch adds the missing version and testcase, which are cut-and-paste from the other versions. 2020-10-05 Christophe Lyon gcc/ * config/arm/arm_mve.h

Re: c++: Hash table iteration for namespace-member spelling suggestions

2020-10-05 Thread Christophe Lyon via Gcc-patches
On Fri, 2 Oct 2020 at 20:23, Nathan Sidwell wrote: > > > For 'no such binding' errors, we iterate over binding levels to find a > close match. At the namespace level we were using DECL_ANTICIPATED to > skip undeclared builtins. But (a) there are other unnameable things > there and (b) decl-antic

Re: Track access ranges in ipa-modref

2020-10-05 Thread Christophe Lyon via Gcc-patches
On Fri, 2 Oct 2020 at 10:37, Jan Hubicka wrote: > > Hi, > this patch implements tracking of access ranges. This is only applied when > base pointer is an arugment. Incrementally i will extend it to also track > TBAA basetype so we can disambiguate ranges for accesses to same basetype > (which mak

Re: [PATCH] arm: Add missing vec_cmp and vcond patterns

2020-10-05 Thread Christophe Lyon via Gcc-patches
On Thu, 1 Oct 2020 at 16:10, Richard Sandiford via Gcc-patches wrote: > > This patch does several things at once: > > (1) Add vector compare patterns (vec_cmp and vec_cmpu). > > (2) Add vector selects between floating-point modes when the > values being compared are integers (affects vcond and

Re: [committed] aarch64: Tweak movti and movtf patterns

2020-10-01 Thread Christophe Lyon via Gcc-patches
On Wed, 30 Sep 2020 at 12:53, Richard Sandiford via Gcc-patches wrote: > > movti lacked an way of zeroing an FPR, meaning that we'd do: > > mov x0, 0 > mov x1, 0 > fmovd0, x0 > fmovv0.d[1], x1 > > instead of just: > > moviv0.2d, #0 > > mo

Re: [committed] libstdc++: Use __libc_single_threaded to optimise atomics [PR 96817]

2020-10-01 Thread Christophe Lyon via Gcc-patches
On Wed, 30 Sep 2020 at 22:44, Jonathan Wakely wrote: > > On 30/09/20 16:03 +0100, Jonathan Wakely wrote: > >On 29/09/20 13:51 +0200, Christophe Lyon via Libstdc++ wrote: > >>On Sat, 26 Sep 2020 at 21:42, Jonathan Wakely via Gcc-patches > >> wrote: > >>> &

Re: [PING][PATCH] aarch64: Don't generate invalid zero/sign-extend syntax

2020-09-30 Thread Christophe Lyon via Gcc-patches
On Wed, 30 Sep 2020 at 16:03, Alex Coplan wrote: > > Ping. Are these testsuite fixes for ILP32 OK? > LGTM, by looking at the patch (I didn't run it in ilp32 mode) Thanks Christophe > On 18/09/2020 17:15, Alex Coplan wrote: > > Hi Christophe, > > > > On 08/0

Re: [PATCH 1/1] arm: [testsuite] Skip thumb2-cond-cmp tests on Cortex-M [PR94595]

2020-09-30 Thread Christophe Lyon via Gcc-patches
Ping? On Thu, 24 Sep 2020 at 15:18, Christophe Lyon wrote: > > Ping? > > On Mon, 7 Sep 2020 at 18:13, Christophe Lyon > wrote: > > > > Since r204778 (g571880a0a4c512195aa7d41929ba6795190887b2), we favor > > branches over IT blocks on Cortex-M. As a result, ins

Re: Ping: [PATCH] arm: Add new vector mode macros

2020-09-30 Thread Christophe Lyon via Gcc-patches
On Tue, 29 Sep 2020 at 12:38, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Richard Sandiford > > Sent: 29 September 2020 11:27 > > To: Kyrylo Tkachov > > Cc: gcc-patches@gcc.gnu.org; ni...@redhat.com; Richard Earnshaw > > ; Ramana Radhakrishnan > > ; Dennis Zhang > > > >

[PATCH] arm: Fix multiple inheritance thunks for thumb-1 with -mpure-code

2020-09-29 Thread Christophe Lyon via Gcc-patches
at the end of the thunk since we don't use them with -mpure-code. No need for new testcases, this bug was already identified by eg. pr46287-3.C 2020-09-29 Christophe Lyon gcc/ * config/arm/arm.c (arm_thumb1_mi_thunk): Build mi_delta in r3 and do not emit function

Re: [committed] libstdc++: Use __libc_single_threaded to optimise atomics [PR 96817]

2020-09-29 Thread Christophe Lyon via Gcc-patches
On Sat, 26 Sep 2020 at 21:42, Jonathan Wakely via Gcc-patches wrote: > > Glibc 2.32 adds a global variable that says whether the process is > single-threaded. We can use this to decide whether to elide atomic > operations, as a more precise and reliable indicator than > __gthread_active_p. > > Thi

Re: [PATCH] arm: Add a couple of extra stack-protector tests

2020-09-28 Thread Christophe Lyon via Gcc-patches
On Wed, 23 Sep 2020 at 20:33, Richard Sandiford wrote: > > These tests were inspired by the corresponding aarch64 ones that I just > committed. They already pass. > > Tested on arm-linux-gnueabi, arm-linux-gnueabihf and armeb-eabi. > OK for trunk? > > Richard > > > gcc/testsuite/ > * gcc.

Re: Fix handling of gimple_clobber in ipa_modref

2020-09-28 Thread Christophe Lyon via Gcc-patches
Hi Honza, On Sat, 26 Sep 2020 at 22:03, Jan Hubicka wrote: > > > On September 26, 2020 12:04:24 AM GMT+02:00, Jan Hubicka > > wrote: > > >Hi, > > >while adding check for gimple_clobber I reversed the return value > > >so instead of ignoring the statement ipa-modref gives up. Fixed thus. > > >

[PATCH 2/2] arm: Improve handling of relocations with small offsets with -mpure-code on v6m (PR96770)

2020-09-28 Thread Christophe Lyon via Gcc-patches
thumb-1 [0..255]. It also makes sure that thumb1_movsi_insn emits an error in case we try to use it with an unsupported RTL construct. 2020-09-28 Christophe Lyon gcc/ * config/arm/arm.c (thumb_legitimate_constant_p): Accept (symbol_ref + addend) when literal pool is

[PATCH 1/2] arm: Avoid indirection with -mpure-code on v6m (PR96967)

2020-09-28 Thread Christophe Lyon via Gcc-patches
fixes a missing "clob" conds attribute for thumb1_movsi_insn, needed because that alternative clobbers the flags. 2020-09-28 Christophe Lyon gcc/ * config/arm/arm.c (thumb_legitimate_constant_p): Add support for disabled literal pool in thumb-1. * config/

testsuite: [aarch64] Fix aarch64/advsimd-intrinsics/v{trn, uzp, zip}_half.c

2020-09-25 Thread Christophe Lyon via Gcc-patches
are skipped on arm*, so there is no impact on that target. 2020-09-25 Christophe Lyon gcc/testsuite/ PR target/71233 * gcc.target/aarch64/advsimd-intrinsics/vtrn_half.c: Remove declarations of vector, vector2, vector_res for float64x2 type. * gcc.tar

Re: [PATCH 1/1] arm: [testsuite] Skip thumb2-cond-cmp tests on Cortex-M [PR94595]

2020-09-24 Thread Christophe Lyon via Gcc-patches
Ping? On Mon, 7 Sep 2020 at 18:13, Christophe Lyon wrote: > > Since r204778 (g571880a0a4c512195aa7d41929ba6795190887b2), we favor > branches over IT blocks on Cortex-M. As a result, instead of > generating two nested IT blocks in thumb2-cond-cmp-[1234].c, we > generate either a

Re: [PATCH 2/3] Use MiB unit when displaying memory allocation.

2020-09-22 Thread Christophe Lyon via Gcc-patches
On Wed, 2 Sep 2020 at 15:29, Martin Liška wrote: > > On 9/1/20 4:04 PM, Jan Hubicka wrote: > >> The patch is about usage of MiB in memory allocation reports. > >> I see it much better readable than values displayed in KiB: > >> > >> Reading object files: tramp3d-v4.o {GC released 1 MiB} {GC 19 MiB

[PATCH] [arm] gcc.target/arm/cs*: Use dg-add-options arm_arch_v8_1m_main

2020-09-21 Thread Christophe Lyon via Gcc-patches
These testcases need thumb mode, which may not be the default. Using dg-add-options arm_arch_v8_1m_main ensures that -mthumb is used and makes the test pass in more configurations. 2020-09-21 Christophe Lyon gcc/testsuite/ * gcc.target/arm/csinc-1.c: Use dg-add-options

Re: [PATCH] CSE negated multiplications and divisions

2020-09-18 Thread Christophe Lyon via Gcc-patches
On Thu, 17 Sep 2020 at 13:20, Richard Biener wrote: > > This adds the capability to look for available negated multiplications > and divisions, replacing them with cheaper negates. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. > This patch caused a regression in fortran, I file

Re: [PATCH] libiberty/pex-win32.c: Initialize orig_err

2020-09-18 Thread Christophe Lyon via Gcc-patches
On Thu, 17 Sep 2020 at 23:33, Jeff Law wrote: > > > On 9/14/20 3:29 AM, Christophe Lyon via Gcc-patches wrote: > > Initializing orig_err avoids a warning: "may be used uninitialized". > > > > 2020-09-14 Torbjörn SVENSSON > > Christophe Lyon >

Re: [PATCH] libgcc/config/arm/fp16.c: Add missing prototypes

2020-09-17 Thread Christophe Lyon via Gcc-patches
On Thu, 17 Sep 2020 at 12:27, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: 11 September 2020 20:05 > > To: Kyrylo Tkachov > > Cc: i...@airs.com; gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH] lib

Re: [PATCH V2] vec: don't select partial vectors when looping on full vectors

2020-09-17 Thread Christophe Lyon via Gcc-patches
On Wed, 16 Sep 2020 at 15:40, Andrea Corallo wrote: > > Richard Sandiford writes: > > > OK with two incredibly petty comments fixed: > > [...] > > Installed with the two suggestions as 052204fac58. > Hi, There is a typo with clastb_8.c: gcc.target/aarch64/sve/clastb_8.c -march=armv8.2-a+sve: er

Re: [PATCH] fixincludes/fixfixes.c: Fix 'set but not used' warning.

2020-09-17 Thread Christophe Lyon via Gcc-patches
On Thu, 17 Sep 2020 at 06:16, Jeff Law wrote: > > > On 9/11/20 6:21 AM, Christophe Lyon via Gcc-patches wrote: > > pz_tmp_base and pz_tmp_dot are always set, but used only when > > _PC_NAME_MAX is defined. > > > > This patch moves their declaration and definition

Re: [aarch64] Backport missing NEON intrinsics to GCC8

2020-09-16 Thread Christophe Lyon via Gcc-patches
On Wed, 16 Sep 2020 at 07:21, Pop, Sebastian via Gcc-patches wrote: > > Thanks Kyrill for your review. > > I committed the patches to the gcc-8 branch: > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=2c55e6caa9432b2c1f081cb3aeddd36abec03233 > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=a4004

[PATCH] libiberty/pex-win32.c: Initialize orig_err

2020-09-14 Thread Christophe Lyon via Gcc-patches
Initializing orig_err avoids a warning: "may be used uninitialized". 2020-09-14 Torbjörn SVENSSON Christophe Lyon libiberty/ * pex-win32 (pex_win32_exec_child): Initialize orig_err. --- libiberty/pex-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH] options: Save and restore opts_set for Optimization and Target options

2020-09-14 Thread Christophe Lyon via Gcc-patches
On Mon, 14 Sep 2020 at 08:33, Richard Biener wrote: > > On Sun, 13 Sep 2020, Jakub Jelinek wrote: > > > On Fri, Sep 11, 2020 at 11:29:52AM +0200, Jakub Jelinek via Gcc-patches > > wrote: > > > On Fri, Sep 11, 2020 at 09:46:37AM +0200, Christophe Lyon via Gcc-pat

Re: [PATCH] libgcc/config/arm/fp16.c: Add missing prototypes

2020-09-11 Thread Christophe Lyon via Gcc-patches
On Fri, 11 Sep 2020 at 14:35, Kyrylo Tkachov wrote: > > Hi Christophe, > > > -Original Message- > > From: Gcc-patches On Behalf Of > > Christophe Lyon via Gcc-patches > > Sent: 11 September 2020 13:23 > > To: gcc-patches@gcc.gnu.org; i...@airs.com

[PATCH] libstdc++-v3/libsupc++/eh_call.cc: Avoid "set but not used" warning

2020-09-11 Thread Christophe Lyon via Gcc-patches
When building with -fno-exceptions, bad_exception_allowed is set but not used, causing a warning during the build. This patch adds __attribute__((unused)) to avoid it. 2020-09-11 Torbjörn SVENSSON Christophe Lyon libstdc++-v3/ * libsupc++/eh_call.cc: Avoid warning

[PATCH] libstdc++-v3/libsupc++/eh_call.cc: Avoid warning with -fno-exceptions.

2020-09-11 Thread Christophe Lyon via Gcc-patches
b731a20) 2020-09-11 Torbjörn SVENSSON Christophe Lyon libstdc++-v3/ * libsupc++/eh_call.cc: Avoid warning with -fno-exceptions. --- libstdc++-v3/libsupc++/eh_call.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/libsupc++/eh_call.cc b/

[PATCH] libgcc/config/arm/fp16.c: Add missing prototypes

2020-09-11 Thread Christophe Lyon via Gcc-patches
o previous prototype for '__gnu_d2h_alternative' [-Wmissing-prototypes] 2020-09-11 Torbjörn SVENSSON Christophe Lyon libgcc/ * config/arm/fp16.c (__gnu_h2f_internal, __gnu_f2h_ieee) (__gnu_h2f_ieee, __gnu_f2h_alternative, __gnu_h2f_alternative)

[PATCH] libstdc++-v3/include/bits/regex_error.h: Avoid warning with -fno-exceptions.

2020-09-11 Thread Christophe Lyon via Gcc-patches
When building with -fno-exceptions, __GLIBCXX_THROW_OR_ABORT expands to abort(), causing warnings: unused parameter '__ecode' unused parameter '__what' This patch adds __attribute__((unused)) to avoid them. 2020-09-11 Torbjörn SVENSSON Christophe Lyon

[PATCH] fixincludes/fixfixes.c: Fix 'set but not used' warning.

2020-09-11 Thread Christophe Lyon via Gcc-patches
pz_tmp_base and pz_tmp_dot are always set, but used only when _PC_NAME_MAX is defined. This patch moves their declaration and definition undef #ifdef _PC_NAME_MAX to avoid this warning. 2020-09-11 Torbjörn SVENSSON Christophe Lyon fixincludes/ * fixfixes.c

Re: [PATCH] arm: Fix up arm_override_options_after_change [PR96939]

2020-09-11 Thread Christophe Lyon via Gcc-patches
On Tue, 8 Sep 2020 at 10:45, Jakub Jelinek via Gcc-patches wrote: > > Hi! > > As mentioned in the PR, the testcase fails to link, because when set_cfun is > being called on the crc function, arm_override_options_after_change is > called from set_cfun -> invoke_set_current_function_hook: > /*

Re: [PATCH] code generate live lanes in basic-block vectorization

2020-09-08 Thread Christophe Lyon via Gcc-patches
On Tue, 8 Sep 2020 at 14:15, Richard Biener wrote: > > On Tue, 8 Sep 2020, Christophe Lyon wrote: > > > Hi Richard, > > > > On Fri, 4 Sep 2020 at 15:42, Richard Biener wrote: > > > > > > The following adds the capability to code-generate live lanes

Re: [PATCH] code generate live lanes in basic-block vectorization

2020-09-08 Thread Christophe Lyon via Gcc-patches
Hi Richard, On Fri, 4 Sep 2020 at 15:42, Richard Biener wrote: > > The following adds the capability to code-generate live lanes in > basic-block vectorization using lane extracts from vector stmts > rather than keeping the original scalar code around for those. > This eventually makes previously

Re: [PATCH] aarch64: Don't generate invalid zero/sign-extend syntax

2020-09-08 Thread Christophe Lyon via Gcc-patches
On Mon, 17 Aug 2020 at 11:00, Alex Coplan wrote: > > Hello, > > Given the following C function: > > double *f(double *p, unsigned x) > { > return p + x; > } > > prior to this patch, GCC at -O2 would generate: > > f: > add x0, x0, x1, uxtw 3 > ret > > but this add instructio

[PATCH 1/1] arm: [testsuite] Skip thumb2-cond-cmp tests on Cortex-M [PR94595]

2020-09-07 Thread Christophe Lyon via Gcc-patches
branch costs. I tried to relax the scan-assembler directives using eg. cmpne|subne or cmpgt|ble but that seemed fragile. OK? 2020-09-07 Christophe Lyon gcc/testsuite/ PR target/94595 * gcc.target/arm/thumb2-cond-cmp-1.c: Skip if arm_cortex_m. * gcc.target/arm

[PATCH] arm: Improve immediate generation for thumb-1 with -mpurecode [PR96769]

2020-09-03 Thread Christophe Lyon via Gcc-patches
-code: f3: movsr0, #136 lslsr0, r0, #21 bx lr f3_2: movwr0, #22136 movtr0, 4660 bx lr 2020-08-28 Christophe Lyon PR target/96769 gcc/ * config/arm/thumb1.md: Move movsi splitter for

Re: [committed] improve handling of offset wraparound in -Wstringop-overread

2020-09-02 Thread Christophe Lyon via Gcc-patches
On Wed, 2 Sep 2020 at 00:12, Martin Sebor via Gcc-patches wrote: > > ILP32 failures in a test added for the new -Wstringop-overread > option exposed an unnecessarily restrictive handling of offsets > in ranges with an upper bound that's apparently less than > the lower bound. I have relaxed the h

Re: [PATCH] separate reading past the end from -Wstringop-overflow

2020-09-01 Thread Christophe Lyon via Gcc-patches
On Mon, 31 Aug 2020 at 23:50, Martin Sebor wrote: > > On 8/31/20 4:51 AM, Christophe Lyon wrote: > > Hi, > > > ... > > > > I pushed a small aarch64 patch as obvious: > > 2020-08-31 Christophe Lyon > > > > gcc/testsuite/ > &

Re: [PATCH] separate reading past the end from -Wstringop-overflow

2020-08-31 Thread Christophe Lyon via Gcc-patches
tr-nonstring-4.c: Same. > > * gcc.dg/attr-nonstring.c: Expect -Wstringop-overread. > > * gcc.dg/builtin-stringop-chk-5.c: Adjust comment. > > * gcc.dg/builtin-stringop-chk-8.c: Enable -Wstringop-overread instead > > of -Wstringop-overflow. > >

Re: [PATCH] arm: Fix switch tables for thumb-1 with -mpure-code [PR96768]

2020-08-28 Thread Christophe Lyon via Gcc-patches
On Fri, 28 Aug 2020 at 16:27, Richard Earnshaw wrote: > > On 28/08/2020 14:24, Christophe Lyon via Gcc-patches wrote: > > On Fri, 28 Aug 2020 at 14:00, Richard Earnshaw > > wrote: > >> > >> On 27/08/2020 14:27, Christophe Lyon via Gcc-patches wrote: >

Re: [PATCH] arm: Fix switch tables for thumb-1 with -mpure-code [PR96768]

2020-08-28 Thread Christophe Lyon via Gcc-patches
On Fri, 28 Aug 2020 at 14:00, Richard Earnshaw wrote: > > On 27/08/2020 14:27, Christophe Lyon via Gcc-patches wrote: > > In comment 14 from PR94538, it was suggested to switch off jump tables > > on thumb-1 cores when using -mpure-code, like we already do for thumb-2. > &g

Re: [PATCH] streamline TARGET_MEM_REF dumping

2020-08-28 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 27 Aug 2020 at 13:07, Richard Biener wrote: > > The following streamlines TARGET_MEM_REF dumping building > on what we do for MEM_REF and thus dumping things like > access type, TBAA type and base/clique. I've changed it > to do semantic dumping aka base + offset + step * index > ra

Re: [PATCH] lra: Canonicalize mult to shift in address reloads

2020-08-28 Thread Christophe Lyon via Gcc-patches
Hi Alex, On Wed, 26 Aug 2020 at 17:15, Alex Coplan wrote: > > Thanks for the review, both. > > On 26/08/2020 09:19, Vladimir Makarov wrote: > > > > On 2020-08-26 5:06 a.m., Richard Sandiford wrote: > > > Alex Coplan writes: > > > > > > Minor nit, should be formatted as: > > > > > > static rtx >

Re: [PATCH] tree-optimization/96579 - another special-operands fix in reassoc

2020-08-28 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 27 Aug 2020 at 10:04, Richard Biener wrote: > > This makes sure to put special-ops expanded rhs left where > expression rewrite expects it. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. > > 2020-08-27 Richard Biener > > PR tree-optimization/96579 >

[PATCH] arm: Fix switch tables for thumb-1 with -mpure-code [PR96768]

2020-08-27 Thread Christophe Lyon via Gcc-patches
adds a new test, since the existing no-casesi.c did not catch this problem. Tested by running the whole testsuite with -mpure-code -mcpu=cortex-m0 -mfloat-abi=soft, no regression and the new test passes (and fails without the fix). 2020-08-27 Christophe Lyon gcc/ * config/arm

Re: [PATCH] arm: Fix -mpure-code support/-mslow-flash-data for armv8-m.base [PR94538]

2020-08-27 Thread Christophe Lyon via Gcc-patches
On Thu, 27 Aug 2020 at 11:02, Ramana Radhakrishnan wrote: > > On Mon, Aug 24, 2020 at 4:35 PM Christophe Lyon > wrote: > > > > On Mon, 24 Aug 2020 at 11:09, Christophe Lyon > > wrote: > > > > > > On Sat, 22 Aug 2020 at 00:44, Ramana Radhakrishnan

Re: [PATCH] arm: Fix -mpure-code support/-mslow-flash-data for armv8-m.base [PR94538]

2020-08-24 Thread Christophe Lyon via Gcc-patches
On Mon, 24 Aug 2020 at 11:09, Christophe Lyon wrote: > > On Sat, 22 Aug 2020 at 00:44, Ramana Radhakrishnan > wrote: > > > > On Wed, Aug 19, 2020 at 10:32 AM Christophe Lyon via Gcc-patches > > wrote: > > > > > > armv8-m.base (cortex-m23) has the

Re: [PATCH] arm: Fix -mpure-code support/-mslow-flash-data for armv8-m.base [PR94538]

2020-08-24 Thread Christophe Lyon via Gcc-patches
On Sat, 22 Aug 2020 at 00:44, Ramana Radhakrishnan wrote: > > On Wed, Aug 19, 2020 at 10:32 AM Christophe Lyon via Gcc-patches > wrote: > > > > armv8-m.base (cortex-m23) has the movt instruction, so we need to > > disable the define_split to generate a constant in this

[PATCH] [obvious] testsuite: Remove test for arm32 in arm_soft_ok

2020-08-20 Thread Christophe Lyon via Gcc-patches
-08-20 Christophe Lyon gcc/testsuite/ * lib/target-supports.exp (arm_soft_ok): Remove arm32 check. --- gcc/testsuite/lib/target-supports.exp | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib

[PATCH] [obvious] testsuite: Skip arm/pure-code tests for arm*-*-uclinuxfdpiceabi

2020-08-20 Thread Christophe Lyon via Gcc-patches
FDPIC it uses PIC code, which is incompatible with -mpure-code, so we want to skip these tests for arm*-*-uclinuxfdpiceabi. This patch also fixes a typo where the final closing bracket was commented out. Committed as obvious. 2020-08-20 Christophe Lyon gcc/testsuite

[PATCH] arm: Fix -mpure-code support/-mslow-flash-data for armv8-m.base [PR94538]

2020-08-19 Thread Christophe Lyon via Gcc-patches
with instructions like movs r0, #:upper8_15:1234 (Internal error in md_apply_fix) We now generate movs r0, 4 instead. 2020-08-19 Christophe Lyon gcc/ChangeLog: * config/arm/thumb1.md: Disable set-constant splitter when TARGET_HAVE_MOVT. (thumb1_movsi_insn): Fix -mpure

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-18 Thread Christophe Lyon via Gcc-patches
u have any suggestions on this fix? > > All the best, > Peixin > > > -Original Message- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Thursday, August 13, 2020 8:19 PM > To: Christophe Lyon > Cc: qiaopeixin ; gcc-patches@gcc.gnu.org >

Re: [PATCH] improve memcmp and memchr constant folding (PR 78257)

2020-08-15 Thread Christophe Lyon via Gcc-patches
Hi Martin, On Sat, 15 Aug 2020 at 01:14, Martin Sebor via Gcc-patches wrote: > > On 8/13/20 11:44 AM, Martin Sebor wrote: > > On 8/13/20 10:21 AM, Jeff Law wrote: > >> On Fri, 2020-07-31 at 17:55 -0600, Martin Sebor via Gcc-patches wrote: > >>> The folders for these functions (and some others) c

Re: [committed] analyzer: fix initialization from constant pool [PR96609, PR96616]

2020-08-15 Thread Christophe Lyon via Gcc-patches
On Sat, 15 Aug 2020 at 00:52, David Malcolm wrote: > > PR testsuite/96609 and PR analyzer/96616 report various testsuite > failures seen on powerpc64, aarch64, and arm in new tests added by > r11-2694-g808f4dfeb3a95f50f15e71148e5c1067f90a126d. > > Some of these failures (in gcc.dg/analyzer/init.c,

Re: Backporting streaming and enum changes

2020-08-14 Thread Christophe Lyon via Gcc-patches
On Fri, 14 Aug 2020 at 11:21, Jan Hubicka wrote: > > > Hi, > > > > > > Since this was backported as > > > r10-8623-g0d96c3424bbb5e5f994b78c8f65d8704d215be54, > > > > Yes, after discussion with Jakub on IRC. > > > I've noticed ICEs on arm and aarch64: > > > gcc.dg/pr34457-1.c (internal compile

Re: [committed] analyzer: rewrite of region and value-handling

2020-08-14 Thread Christophe Lyon via Gcc-patches
Hi David, On Thu, 13 Aug 2020 at 22:58, David Malcolm via Gcc-patches wrote: > > This large patch reimplements how the analyzer tracks regions and > values. > > Elimination of region_id and svalue_id > ** > > The patch eliminates region_id and svalue_id in fav

Re: Backporting streaming and enum changes

2020-08-14 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 6 Aug 2020 at 16:39, Richard Biener wrote: > > On Thu, 6 Aug 2020, Jan Hubicka wrote: > > > Hello, > > as discussed some time ago, I would like to discuss possibility to > > backport the straming and enum improvements. The motivation is that > > this brings quite noticeable improveme

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-13 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 13 Aug 2020 at 03:54, qiaopeixin wrote: > > Thanks for the review and commit. > > All the best, > Peixin > > -Original Message- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: 2020年8月13日 0:25 > To: qiaopeixin > Cc: gcc-patches@gcc.gnu.org > Subject: Re:

Re: [PATCH] arm: Clear canary value after stack_protect_test [PR96191]

2020-08-12 Thread Christophe Lyon via Gcc-patches
On Tue, 11 Aug 2020 at 18:42, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Mon, 10 Aug 2020 at 17:27, Richard Sandiford > > wrote: > >> > >> Christophe Lyon writes: > >> > On Wed, 5 Aug 2020 at 16:33, Richard Sandiford >

Re: [PATCH] testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts

2020-08-12 Thread Christophe Lyon via Gcc-patches
On Tue, 11 Aug 2020 at 18:40, Richard Sandiford wrote: > > Christophe Lyon via Gcc-patches writes: > > This patch fixes an incorrect parameter passing for $gcc_opts, which > > produces a DejaGnu error: (DejaGnu) proc "gcc_opts" does not exist. > > Huh, wonder h

Re: [AArch64] Upgrade integer MLA intrinsics to GCC vector extensions

2020-08-12 Thread Christophe Lyon via Gcc-patches
Hi James, On Wed, 12 Aug 2020 at 10:40, James Greenhalgh wrote: > > > Hi, > > As subject, this patch rewrites the mla intrinsics to use a + b * c rather > than inline assembler, thereby opening them to CSE, scheduling, etc. > > Bootstrapped and tested on aarch64-none-linux-gnu. > Do we have test

[PATCH] testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts

2020-08-11 Thread Christophe Lyon via Gcc-patches
This patch fixes an incorrect parameter passing for $gcc_opts, which produces a DejaGnu error: (DejaGnu) proc "gcc_opts" does not exist. 2020-08-11 Christophe Lyon gcc/testsuite/ * gcc.target/arm/multilib.exp: Fix parameter passing for gcc_opts. diff --git a/gcc

Re: [PATCH] arm: Clear canary value after stack_protect_test [PR96191]

2020-08-11 Thread Christophe Lyon via Gcc-patches
On Mon, 10 Aug 2020 at 17:27, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Wed, 5 Aug 2020 at 16:33, Richard Sandiford > > wrote: > >> > >> The stack_protect_test patterns were leaving the canary value in the > >> temporary register,

Re: [PATCH] arm: Clear canary value after stack_protect_test [PR96191]

2020-08-10 Thread Christophe Lyon via Gcc-patches
On Wed, 5 Aug 2020 at 16:33, Richard Sandiford wrote: > > The stack_protect_test patterns were leaving the canary value in the > temporary register, meaning that it was often still in registers on > return from the function. An attacker might therefore have been > able to use it to defeat stack-s

Re: VEC_COND_EXPR optimizations v2

2020-08-06 Thread Christophe Lyon via Gcc-patches
On Thu, 6 Aug 2020 at 13:42, Marc Glisse wrote: > > On Thu, 6 Aug 2020, Christophe Lyon wrote: > > > On Thu, 6 Aug 2020 at 11:06, Marc Glisse wrote: > >> > >> On Thu, 6 Aug 2020, Christophe Lyon wrote: > >> > >>>>> 2020-08-05 Marc

Re: VEC_COND_EXPR optimizations v2

2020-08-06 Thread Christophe Lyon via Gcc-patches
On Thu, 6 Aug 2020 at 11:06, Marc Glisse wrote: > > On Thu, 6 Aug 2020, Christophe Lyon wrote: > > >>> 2020-08-05 Marc Glisse > >>> > >>> PR tree-optimization/95906 > >>> PR target/70314 > >>> * mat

Re: VEC_COND_EXPR optimizations v2

2020-08-06 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, 5 Aug 2020 at 16:24, Richard Biener via Gcc-patches wrote: > > On Wed, Aug 5, 2020 at 3:33 PM Marc Glisse wrote: > > > > New version that passed bootstrap+regtest during the night. > > > > When vector comparisons were forced to use vec_cond_expr, we lost a number > > of > > optimiz

Re: testsuite: missed testcase

2020-07-10 Thread Christophe Lyon via Gcc-patches
argets that do not support openmp (I saw problems on arm-eabi and aarch64-elf using newlib, where -lpthread was failing). I'm pushing the attached patch as obvious. Thanks Christophe > -- > Nathan Sidwell From 2f06fb713845dd4777f8b659cbe008a2a131cd80 Mon Sep 17 00:00:00 2001 From: Christop

Re: [PATCH][GCC][Arm] PR target/95646: Do not clobber callee saved registers with CMSE

2020-07-07 Thread Christophe Lyon via Gcc-patches
Hi, On Mon, 6 Jul 2020 at 16:31, Andre Vieira (lists) wrote: > > > On 30/06/2020 14:50, Andre Vieira (lists) wrote: > > > > On 29/06/2020 11:15, Christophe Lyon wrote: > >> On Mon, 29 Jun 2020 at 10:56, Andre Vieira (lists) > >> wrote: > >>&g

Re: [PATCH] arm: Warn if IRQ handler is not compiled with -mgeneral-regs-only [PR target/94743]

2020-07-01 Thread Christophe Lyon via Gcc-patches
On Tue, 30 Jun 2020 at 15:34, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: 30 June 2020 14:32 > > To: Kyrylo Tkachov > > Cc: gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH] arm: Warn if IRQ handler

Re: [PATCH] arm: Warn if IRQ handler is not compiled with -mgeneral-regs-only [PR target/94743]

2020-06-30 Thread Christophe Lyon via Gcc-patches
On Tue, 30 Jun 2020 at 15:16, Kyrylo Tkachov wrote: > > Hi Christophe, > > Sorry for the delay. > > > -Original Message- > > From: Gcc-patches On Behalf Of > > Christophe Lyon via Gcc-patches > > Sent: 29 April 2020 16:19 > > To: gcc-patches@

Re: [PATCH v2] arm: Warn if IRQ handler is not compiled with -mgeneral-regs-only [PR target/94743]

2020-06-29 Thread Christophe Lyon via Gcc-patches
Ping? On Tue, 9 Jun 2020 at 11:48, Christophe Lyon wrote: > > Ping? > > Maybe I could mention that LLVM emits a warning in this case > (https://reviews.llvm.org/D28820). > > Thanks, > > Christophe > > > On Wed, 3 Jun 2020 at 15:23, Christophe Lyon > wrote

Re: [PATCH][GCC][Arm] PR target/95646: Do not clobber callee saved registers with CMSE

2020-06-29 Thread Christophe Lyon via Gcc-patches
On Mon, 29 Jun 2020 at 10:56, Andre Vieira (lists) wrote: > > > On 23/06/2020 21:52, Christophe Lyon wrote: > > On Tue, 23 Jun 2020 at 15:28, Andre Vieira (lists) > > wrote: > >> On 23/06/2020 13:10, Kyrylo Tkachov wrote: > >>>> -Original

Re: [PATCH] libgomp, fortran: Apply if clause to all sub-constructs in combined OpenMP constructs

2020-06-26 Thread Christophe Lyon via Gcc-patches
On Thu, 25 Jun 2020 at 15:24, Kwok Cheung Yeung wrote: > > On 24/06/2020 6:29 pm, Tobias Burnus wrote: > > Hi Kwok, > > > > the TODO is fixed by the attached patch; I would be happy if you could > > handle > > this patch, > > e.g. together with your patch – or as follow up. > > > > (Lightly teste

Re: [PATCH][GCC][Arm] PR target/95646: Do not clobber callee saved registers with CMSE

2020-06-23 Thread Christophe Lyon via Gcc-patches
On Tue, 23 Jun 2020 at 15:28, Andre Vieira (lists) wrote: > > On 23/06/2020 13:10, Kyrylo Tkachov wrote: > > > >> -Original Message- > >> From: Andre Vieira (lists) > >> Sent: 22 June 2020 09:52 > >> To: gcc-patches@gcc.gnu.org > >> Cc: Kyrylo Tkachov > >> Subject: [PATCH][GCC][Arm] PR t

Re: [PATCH][GCC-10 Backport] arm: Fix MVE scalar shift intrinsics code-gen.

2020-06-18 Thread Christophe Lyon via Gcc-patches
On Thu, 18 Jun 2020 at 17:34, Srinath Parvathaneni wrote: > > Hi, > > > -Original Message- > > From: Christophe Lyon > > Sent: 18 June 2020 16:06 > > To: Kyrylo Tkachov > > Cc: Srinath Parvathaneni ; gcc- > > patc...@gcc.gnu.org > >

Re: [committed] Fix use of inaccessible member in pr85503.C [PR95716]

2020-06-18 Thread Christophe Lyon via Gcc-patches
On Thu, 18 Jun 2020 at 16:56, Patrick Palka wrote: > > On Thu, 18 Jun 2020, Christophe Lyon wrote: > > > Hi, > > > > On Wed, 17 Jun 2020 at 15:16, Patrick Palka via Gcc-patches > > wrote: > > > > > > The recent PR41437 fix exposed a late

Re: [PATCH][GCC-10 Backport] arm: Fix MVE scalar shift intrinsics code-gen.

2020-06-18 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 18 Jun 2020 at 11:43, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Srinath Parvathaneni > > Sent: 17 June 2020 17:17 > > To: gcc-patches@gcc.gnu.org > > Cc: Kyrylo Tkachov > > Subject: [PATCH][GCC-10 Backport] arm: Fix MVE scalar shift intrinsics code- > > ge

Re: [committed] Fix use of inaccessible member in pr85503.C [PR95716]

2020-06-18 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, 17 Jun 2020 at 15:16, Patrick Palka via Gcc-patches wrote: > > The recent PR41437 fix exposed a latent use of an inaccessible member in > the below testcase. > > Committed as obvious after verifying that the testcase no longer fails to > compile due to the reported access error. > I'

Re: [PATCH][GCC] arm: Fix the failing mve scalar shift execution tests.

2020-06-18 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 18 Jun 2020 at 15:30, Srinath Parvathaneni wrote: > > Hello, > > In GCC testsuite the MVE scalar shift execution tests > (mve_scalar_shifts[1-4].c) are failings > because of executing them on target hardware which doesn't support MVE > instructions. This patch > restricts those tes

Re: [PATCH] avoid false positives due to compute_objsize (PR 95353)

2020-06-12 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 11 Jun 2020 at 22:37, Rainer Orth wrote: > > Hi Martin, > > > The compute_objsize() function started out as a thin wrapper around > > compute_builtin_object_size(), but over time developed its own > > features to compensate for the other function's limitations (such > > as its inabil

Re: [PATCH v2] arm: Warn if IRQ handler is not compiled with -mgeneral-regs-only [PR target/94743]

2020-06-09 Thread Christophe Lyon via Gcc-patches
Ping? Maybe I could mention that LLVM emits a warning in this case (https://reviews.llvm.org/D28820). Thanks, Christophe On Wed, 3 Jun 2020 at 15:23, Christophe Lyon wrote: > > Ping? > https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545747.html > > On Wed, 27 May 2020 at 13

<    6   7   8   9   10   11   12   13   14   15   >