On Wed, Sep 14, 2016 at 5:49 AM, Mark Wielaard wrote:
> On Wed, 2016-09-14 at 05:39 -0700, Ian Lance Taylor wrote:
>> On Wed, Sep 14, 2016 at 1:30 AM, Mark Wielaard wrote:
>> > On Wed, 2016-09-14 at 00:00 -0400, Jason Merrill wrote:
>> >> I wonder about spelling
On Mon, Sep 12, 2016 at 7:05 AM, Eric Gallager wrote:
> On 9/11/16, Manuel López-Ibáñez wrote:
>> On 11/09/16 14:02, Mark Wielaard wrote:
>>> -Wshadow-local which warns if a local variable shadows another local
>>> variable or parameter,
>>>
>>>
Hi Diego,
I noticed this patch that adds support for improved -Wshadow-related options:
[google] Add two new -Wshadow warnings (issue4452058)
https://gcc.gnu.org/ml/gcc-patches/2011-04/msg02317.html
https://codereview.appspot.com/4452058/
Here are the proposed descriptions:
Arnaud Charlet wrote:
Also note: the line numbers listed below work for me with yesterday's
up-to-date trunk, but if you want to use these commands, you should rerun
the commands above so that the line numbers reflect your actual sources.
)
This is just a heads up.
I'm not volunteering to
Joseph S. Myers wrote:
I've applied this patch to fix what seemed to be some of the more
straightforward cases covered by gcc/ChangeLog.
Thanks. I've run the same thing on gettext and reported the results upstream.
Joseph S. Myers wrote:
On Tue, 29 May 2012, Jim Meyering wrote:
Running the following command spots over 1500 typos, and suggests fixes:
$ git ls-files|misspellings -f -|grep -v '^ERROR:'|perl -pe \
's/^(.*?)\[(\d+)\]: (\w+) - (.*?)$/sed -i '\''${2}s!$3!$4!'\'' $1/' k
This command
Richard Guenther wrote:
On Sat, Apr 21, 2012 at 5:53 PM, Jim Meyering j...@meyering.net wrote:
I see that no one responded when I posted this in February.
Ok to commit, now?
Ok.
Thanks. Pushed.
I see that no one responded when I posted this in February.
Ok to commit, now?
2012-02-24 Jim Meyering meyer...@redhat.com
* genattrtab.c (gen_attr): Avoid NULL-deref after diagnosing
absence of an define_enum call.
diff --git a/gcc/genattrtab.c b/gcc/genattrtab.c
index
Richard Guenther wrote:
On Thu, Apr 19, 2012 at 10:35 PM, Jim Meyering j...@meyering.net wrote:
Richard Guenther wrote:
Sure, my point was that the
if (strlen (m-name) = sizeof buf)
{
error (%s:%d:mode name \%s\ is too long,
m-file, m-line, m-name
-name, strlen (m-name) + 1).
Ok to commit?
2012-04-19 Jim Meyering meyer...@redhat.com
genmodes: remove misleading use of strncpy
* genmodes.c (make_complex_modes): Avoid unnecessary use of strncpy.
We verified above that the string(including trailing NUL) fits in buf
Richard Guenther wrote:
On Thu, Apr 19, 2012 at 12:42 PM, Jim Meyering j...@meyering.net wrote:
Found by inspection.
Seeing this strncpy use without the usual following NUL-termination,
my reflex was that it was a buffer overrun candidate, but then I
realized this is gcc, so that's not very
Richard Guenther wrote:
On Thu, Apr 19, 2012 at 2:13 PM, Jim Meyering j...@meyering.net wrote:
Richard Guenther wrote:
On Thu, Apr 19, 2012 at 12:42 PM, Jim Meyering j...@meyering.net wrote:
Found by inspection.
Seeing this strncpy use without the usual following NUL-termination,
my reflex
Richard Guenther wrote:
...
The patch is ok with caching strlen and using memcpy.
Like this, I presume:
[alternatively, declare and compute m_len on a separate line,
just before the comparison:
size_t m_len = strlen (m-name);
I'd actually prefer that, but don't know if decl-after-stmt
was easy to eliminate, and
I pulled the two identical snprintf calls out of the if block and
replaced them with the buf[0] assignment and memcpy.
2012-04-19 Jim Meyering meyer...@redhat.com
* genmodes.c (make_complex_modes): Don't truncate a mode name of
length 7 or more when
This fixes a coverity-spotted issue.
A NULL et could be dereferenced after the diagnostic is issued.
2012-02-24 Jim Meyering meyer...@redhat.com
genattrtab: avoid NULL-deref on error
* genattrtab.c (gen_attr): Avoid NULL-deref after diagnosing
absence of an defin_enum
Mike Stump wrote:
On Apr 10, 2011, at 2:07 PM, Jim Meyering wrote:
$ git ls-files .|xargs perl -0777 -n -e 'while (/\b(it)\s+\1\b/gms)'
-e '{$n=($` =~ tr/\n/\n/ + 1); ($v=$)=~s/\n/\\n/g; print
$ARGV:$n:$v\n}'|grep -v ChangeLog
gcc/config/cris/cris.opt:152:it it
gcc/gensupport.c:1066:it\n
to nonzero values in my environment)
This was the culprit:
FAIL: gcc.dg/matrix/transpose-3.c execution,-fprofile-use
-fipa-matrix-reorg -fdump-ipa-matrix-reorg -O3 -fwhole-program -fno-tree-fre
From 7e50b781d25170cf5bbe5f6247607c5dca879009 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer
Janne Blomqvist wrote:
On Thu, Mar 24, 2011 at 18:51, Jim Meyering j...@meyering.net wrote:
Janne Blomqvist wrote:
On Tue, Mar 8, 2011 at 19:53, Jim Meyering j...@meyering.net wrote:
Relative to v2, I've added libgo/ to the list of exempt directories and
added
this recently discussed
Mike Stump wrote:
On Apr 16, 2011, at 4:04 AM, Gerald Pfeifer ger...@pfeifer.com wrote:
On Fri, 15 Apr 2011, Mike Stump wrote:
I think these are obvious.
Which means that you can commit them without getting explicit approval
Well, technically, it means nothing... It only means something if
Janne Blomqvist wrote:
On Mon, Apr 18, 2011 at 18:08, Jim Meyering j...@meyering.net wrote:
I've rebased and divided/reordered these changes as you suggested.
Here are the fortran parts. I'll post the other parts separately.
Parts 1 and 3 are manual. Part 2 is the big mechanical change
with a following else,
and another to restore a conditional that should not have been
removed.
A final(?) bootstrap and make check is running now.
From d64b103b57c3785bb66a8c456ef4c0ec992f4852 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 3 Jan 2011 16:52:37 +0100
Tom Tromey wrote:
Jim == Jim Meyering j...@meyering.net writes:
Jim Since v3, I've rebased these and moved the fortran changes to precede
Jim these (changing gfc_free to free introduced a few more instances
Jim that this transformation deals with). As mentioned before, the
Jim conditional
Janne Blomqvist wrote:
On Thu, Mar 24, 2011 at 18:51, Jim Meyering j...@meyering.net wrote:
Janne Blomqvist wrote:
On Tue, Mar 8, 2011 at 19:53, Jim Meyering j...@meyering.net wrote:
Relative to v2, I've added libgo/ to the list of exempt directories and
added
this recently discussed
Signed-off-by: Jim Meyering meyer...@redhat.com
---
While most of these are in comments, the corrections
in gcc/tree-cfg.c and gcc/config/sh/constraints.md are in strings.
The former at least is marked for translation, and hence appears
in every .po file.
gcc/config/alpha/vms-unwind.h
Janne Blomqvist wrote:
On Fri, Apr 15, 2011 at 10:54, Jim Meyering j...@meyering.net wrote:
Janne Blomqvist wrote:
On Thu, Mar 24, 2011 at 18:51, Jim Meyering j...@meyering.net wrote:
Janne Blomqvist wrote:
On Tue, Mar 8, 2011 at 19:53, Jim Meyering j...@meyering.net wrote:
Relative to v2
Mike Stump wrote:
On Apr 10, 2011, at 4:54 AM, Jim Meyering wrote:
I've noticed/fixed a few occurrences of doubled words like the the,
I've fixed the obviously wrong ones in gcc/.* excluding ada and go. I
don't hate Ada and go, since I don't pretend to keep up on rules to
their parts
Mike Stump wrote:
On Apr 10, 2011, at 4:54 AM, Jim Meyering wrote:
I've noticed/fixed a few occurrences of doubled words like the the,
to to
I fixed all the non-surious matches in the gcc/testsuite. if if in
the fortran testsuite was the major spurious match. Thanks.
Thanks.
Yet more
Janne Blomqvist wrote:
On Tue, Mar 8, 2011 at 19:53, Jim Meyering j...@meyering.net wrote:
Relative to v2, I've added libgo/ to the list of exempt directories and added
this recently discussed gfc_free patch, at the request of Tobias Burnus.
Also, I corrected an error in fortran's ChangeLog
Jakub Jelinek wrote:
On Tue, Mar 15, 2011 at 11:02:38AM +0100, Jim Meyering wrote:
Instead of please let us know, maybe recommend using
__builtin_expect instead? E.g. something like
if (__builtin_expect (ptr != NULL, 0))
free (ptr);
Good idea. Thanks.
Though how about avoiding
Janne Blomqvist wrote:
...
Hi Janne,
These requested changes are in addition to (and independent of)
the changes that I've already posted here.
Yes, it was perhaps a bit unreasonable to ask you to fix this. OTOH
with your changes gfc_free() was just a wrapper around free() and
should thus
Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 8 Mar 2011 13:54:13 +0100
Subject: [PATCH] avoid memory overrun in a test leading to potential double-free
* testsuite/test-expandargv.c (writeout_test): Fix off-by-one error:
i.e., do copy the trailing NUL byte
Dr Andrew John Hughes wrote:
On 22:47 Mon 07 Mar , Joseph S. Myers wrote:
On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote:
http://gcc.gnu.org/codingconventions.html says Classpath changes should
go
via Classpath upstream, not directly into GCC. I don't know if that's
still
Rainer Orth wrote:
Jim Meyering j...@meyering.net writes:
the change at hand. And please don't change the alignment of entries
with multiple email addresses.
Changing 8-spaces to a TAB does not affect alignment when you're
looking at the ChangeLog file itself with standard tab setting
33 matches
Mail list logo