Re: [PATCH 1/3] gdb.trace: Move more target dependencies to trace-support.exp

2016-02-20 Thread Marcin Kościelnicki
Whoops, sorry for that mail - I typoed gdb-patches to gcc-patches. On 20/02/16 14:56, Marcin Kościelnicki wrote: While groveling through the old PPC64 tracepoint support patch, I've noticed a few target dependencies in the testsuite that both me and Antoine missed for s390 and ARM tracepoints

[PATCH 1/3] gdb.trace: Move more target dependencies to trace-support.exp

2016-02-20 Thread Marcin Kościelnicki
@@ -1,3 +1,14 @@ +2016-02-19 Marcin Kościelnicki <koria...@0x04.net> + + * gdb.trace/entry-values.exp: Move call_insn setting to + trace-support.exp. + * gdb.trace/ftrace.exp: Move arg0exp setting to trace-support.exp. + * gdb.trace/mi-trace-unavailab

[PATCH 3/3] gdb.trace: Remove unnecessary target check from ftrace.exp.

2016-02-20 Thread Marcin Kościelnicki
/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2016-02-19 Marcin Kościelnicki <koria...@0x04.net> + * gdb.trace/ftrace.exp: Remove unnecessary target check. + +2016-02-19 Marcin Kościelnicki <koria...@0x04.net> + * gdb.trace/entry-values.exp: Surround $call_insn with '\y'.

[PATCH 2/3] gdb.trace: Surround $call_insn with \y in entry-values.exp

2016-02-20 Thread Marcin Kościelnicki
og @@ -1,5 +1,10 @@ 2016-02-19 Marcin Kościelnicki <koria...@0x04.net> + * gdb.trace/entry-values.exp: Surround $call_insn with '\y'. + * lib/trace-support.exp: Change x86_64 call_insn to 'callq'. + +2016-02-19 Marcin Kościelnicki <koria...@0x04.net> + * gdb.

Re: [PATCH] s390: New mcount call sequence for z900+ CPUs in 31-bit mode.

2016-02-15 Thread Marcin Kościelnicki
On 21/01/16 14:03, Marcin Kościelnicki wrote: On TARGET_CPU_ZARCH && !TARGET_64BIT, we can use a similiar lean mcount call sequence to TARGET_64BIT. The longer sequences are now used only on deprecated g5/g6 CPUs. Tested on s390-ibm-linux-gnu on RHEL 7.2. gcc/ChangeLog: * con

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-15 Thread Marcin Kościelnicki
On 15/02/16 11:21, Andreas Krebbel wrote: On 02/14/2016 05:01 PM, Marcin Kościelnicki wrote: libgcc/ChangeLog: * config.host: Use t-stack and t-stack-s390 for s390*-*-linux. * config/s390/morestack.S: New file. * config/s390/t-stack-s390: New file. * generic

[PATCH] s390: Add -fsplit-stack support

2016-02-14 Thread Marcin Kościelnicki
+++ b/gcc/ChangeLog @@ -1,3 +1,33 @@ +2016-02-14 Marcin Kościelnicki <koria...@0x04.net> + + * common/config/s390/s390-common.c (s390_supports_split_stack): + New function. + (TARGET_SUPPORTS_SPLIT_STACK): New macro. + * config/s390/s390-protos.

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-10 Thread Marcin Kościelnicki
On 04/02/16 13:44, Marcin Kościelnicki wrote: On 03/02/16 18:27, Ulrich Weigand wrote: Marcin KoÅ›cielnicki wrote: libgcc/ChangeLog: * config.host: Use t-stack and t-stack-s390 for s390*-*-linux. * config/s390/morestack.S: New file. * config/s390/t-stack-s390: New file

[PATCH] testsuite/s390: Add __morestack test.

2016-02-07 Thread Marcin Kościelnicki
/testsuite/gcc.target/s390/morestack.c diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 8f528b2..26d600f 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2016-02-05 Marcin Kościelnicki <koria...@0x04.net>: + + * gcc.targe

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-05 Thread Marcin Kościelnicki
-msmall-exec, it doesn't really matter much either.) Ah right, I've added PC16DBL to the "always call" list. Bye, Ulrich I've updated and resubmitted the gold patch. Marcin Kościelnicki

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-04 Thread Marcin Kościelnicki
On 03/02/16 18:27, Ulrich Weigand wrote: Marcin Kościelnicki wrote: libgcc/ChangeLog: * config.host: Use t-stack and t-stack-s390 for s390*-*-linux. * config/s390/morestack.S: New file. * config/s390/t-stack-s390: New file. * generic-morestack.c

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-04 Thread Marcin Kościelnicki
bjects using split stack. Bye, Ulrich Fair enough. Here's what I'm going to implement in gold: - any PLT relocation: call - PC32DBL on a larl: non-call - PC32DBL otherwise: call - any other relocation: non-call Does that sound right? Marcin Kościelnicki

[PATCH] s390: Add -fsplit-stack support

2016-02-03 Thread Marcin Kościelnicki
@@ +2016-02-03 Marcin Kościelnicki <koria...@0x04.net> + + * common/config/s390/s390-common.c (s390_supports_split_stack): + New function. + (TARGET_SUPPORTS_SPLIT_STACK): New macro. + * config/s390/s390-protos.h: Add s390_expand_split_stack_prologue. + * config/s39

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-03 Thread Marcin Kościelnicki
The second issue I'm still not sure about is the magic nop marker for frameless functions. In an earlier mail you wrote: Both currently supported architectures always emit split-stack code on every function. At least for rs6000 this doesn't appear to be true; in

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-02 Thread Marcin Kościelnicki
On 02/02/16 19:33, Ulrich Weigand wrote: Marcin Kościelnicki wrote: Here we go. I've also removed the "see below", since I don't really see anything below... The "see below" refers to this code (which I agree isn't really obvious): if (TARGET_TPF_PROFILING) { /* Generate a

[PATCH] s390: Add -fsplit-stack support

2016-02-02 Thread Marcin Kościelnicki
eLog b/gcc/ChangeLog index 9a2cec8..568dff4 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,33 @@ +2016-02-02 Marcin Kościelnicki <koria...@0x04.net> + + * common/config/s390/s390-common.c (s390_supports_split_stack): + New function. + (TARGET_SUPPORTS_SPLIT_S

[PATCH] s390: Add -fsplit-stack support

2016-02-02 Thread Marcin Kościelnicki
onfig/s390/morestack.S create mode 100644 libgcc/config/s390/t-stack-s390 diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9a2cec8..af86079 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,40 @@ +2016-02-02 Marcin Kościelnicki <koria...@0x04.net> + + * common/config/s3

[PATCH] s390: Add -fsplit-stack support

2016-02-02 Thread Marcin Kościelnicki
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9a2cec8..af86079 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,40 @@ +2016-02-02 Marcin Kościelnicki <koria...@0x04.net> + + * common/config/s390/s390-common.c (s390_supports_split_stack): + New fu

Re: [PATCH] s390: Add -fsplit-stack support

2016-01-29 Thread Marcin Kościelnicki
, -Andreas- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c881d52..71f6f38 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,38 @@ 2016-01-16 Marcin Kościelnicki <koria...@0x04.net> + * common/config/s390/s390-common.c (s390_supports_split_stack): + New fu

Re: [PATCH 4/5] Don't mark targets of unconditional jumps with side effects as FALLTHRU.

2016-01-22 Thread Marcin Kościelnicki
On 22/01/16 08:44, Andreas Krebbel wrote: On 01/22/2016 12:10 AM, Jeff Law wrote: On 01/21/2016 03:05 AM, Andreas Krebbel wrote: On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: When an unconditional jump with side effects targets an immediately following label, rtl_tidy_fallthru_edge

Re: [PATCH 5/5] s390: Add -fsplit-stack support

2016-01-21 Thread Marcin Kościelnicki
On 21/01/16 11:12, Andreas Krebbel wrote: On 01/15/2016 10:08 PM, Marcin Kościelnicki wrote: On 15/01/16 19:38, Andreas Krebbel wrote: Marcin, your implementation looks very good to me. Thanks! But please be aware that we deprecated the support of g5 and g6 and intend to remove that code

[PATCH] s390: New mcount call sequence for z900+ CPUs in 31-bit mode.

2016-01-21 Thread Marcin Kościelnicki
-- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2016-01-21 Marcin Kościelnicki <koria...@0x04.net> + + * config/s390/s390.c (s390_function_profiler): Add a new sequence + for z900+ CPUs in 31-bit mode. + 2016-01-21 Richard Biener <rguent...@suse.de> * gra

Re: [PATCH 4/5] Don't mark targets of unconditional jumps with side effects as FALLTHRU.

2016-01-21 Thread Marcin Kościelnicki
On 21/01/16 11:05, Andreas Krebbel wrote: On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: When an unconditional jump with side effects targets an immediately following label, rtl_tidy_fallthru_edge is called. Since it has side effects, it doesn't remove the jump, but the label is still

Re: [PATCH 2/5] s390: Fix missing .size directives.

2016-01-21 Thread Marcin Kościelnicki
On 21/01/16 10:58, Andreas Krebbel wrote: On 01/20/2016 02:16 PM, Andreas Krebbel wrote: On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: It seems at some point the .size hook was hijacked to emit some machine-specific directives, and the actual .size directive was forgotten. This caused

Re: [PATCH 1/5] s390: Use proper read-only data section for literals.

2016-01-20 Thread Marcin Kościelnicki
On 20/01/16 14:11, Andreas Krebbel wrote: On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: Previously, .rodata was hardcoded. For C++ vague linkage functions, this resulted in needlessly duplicated literals. With the new split stack support, this resulted in link errors, due to .rodata

[PATCH] s390: Add -fsplit-stack support

2016-01-16 Thread Marcin Kościelnicki
(-) create mode 100644 libgcc/config/s390/morestack.S create mode 100644 libgcc/config/s390/t-stack-s390 diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c881d52..71f6f38 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,38 @@ 2016-01-16 Marcin Kościelnicki <koria...@0x04.

Re: [PATCH 5/5] s390: Add -fsplit-stack support

2016-01-15 Thread Marcin Kościelnicki
don't need #3 anymore once g5/g6 support is removed, but #4 might still be necessary - we still have that unconditional jump. Marcin Kościelnicki

Re: [RFC] [PR 68191] s390: Add -fsplit-stack support.

2016-01-03 Thread Marcin Kościelnicki
On 03/01/16 04:20, Ian Lance Taylor wrote: On Sat, Jan 2, 2016 at 11:16 AM, Marcin Kościelnicki <koria...@0x04.net> wrote: The differences start in the __morestack calling convention. Basically, since pushing things on stuck is unwieldy and there's only one free register (%r0 could b

Re: [RFC] [PR 68191] s390: Add -fsplit-stack support.

2016-01-03 Thread Marcin Kościelnicki
On 03/01/16 04:20, Ian Lance Taylor wrote: On Sat, Jan 2, 2016 at 11:16 AM, Marcin Kościelnicki <koria...@0x04.net> wrote: The differences start in the __morestack calling convention. Basically, since pushing things on stuck is unwieldy and there's only one free register (%r0 could b

[PATCH 5/5] s390: Add -fsplit-stack support

2016-01-02 Thread Marcin Kościelnicki
/ChangeLog b/gcc/ChangeLog index 4c7046f..a4f4dff 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,46 @@ 2016-01-02 Marcin Kościelnicki <koria...@0x04.net> + * common/config/s390/s390-common.c (s390_supports_split_stack): + New function. + (TARGET_SUPPORTS_SPLIT

[PATCH 1/5] s390: Use proper read-only data section for literals.

2016-01-02 Thread Marcin Kościelnicki
insertions(+), 2 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 23ce209..2c572a7 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2016-01-02 Marcin Kościelnicki <koria...@0x04.net> + + * config/s390/s390.md (pool_section_start): Use switch_to_s

[PATCH 2/5] s390: Fix missing .size directives.

2016-01-02 Thread Marcin Kościelnicki
/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,10 @@ 2016-01-02 Marcin Kościelnicki <koria...@0x04.net> + * config/s390/s390.c (s390_asm_declare_function_size): Add code + to actually emit the .size directive. + +2016-01-02 Marcin Kościelnicki <koria...@0x04.net> + *

[RFC] [PR 68191] s390: Add -fsplit-stack support.

2016-01-02 Thread Marcin Kościelnicki
Here's my attempt at adding -fsplit-stack support for s390 targets (bug 68191). Patches 1 and 2 fix s390-specific issues affecting split stack code, and can be pushed independently of the main course. Patches 3 and 4 attempt to fix target-independent issues involving unconditional jumps with

[PATCH 3/5] Fix NOTE_INSN_PROLOGUE_END after unconditional jump.

2016-01-02 Thread Marcin Kościelnicki
/ChangeLog @@ -1,5 +1,11 @@ 2016-01-02 Marcin Kościelnicki <koria...@0x04.net> + * function.c (reposition_prologue_and_epilogue_notes): Avoid + verification error if the last insn of prologue is an unconditional + jump. + +2016-01-02 Marcin Kościelnicki <koria...

[PATCH 4/5] Don't mark targets of unconditional jumps with side effects as FALLTHRU.

2016-01-02 Thread Marcin Kościelnicki
/gcc/ChangeLog @@ -1,5 +1,10 @@ 2016-01-02 Marcin Kościelnicki <koria...@0x04.net> + * cfgrtl.c (rtl_tidy_fallthru_edge): Bail for unconditional jumps + with side effects. + +2016-01-02 Marcin Kościelnicki <koria...@0x04.net> +