[PATCH, 4.4] Backport of the fix for PR 49886 (again)

2011-09-16 Thread Martin Jambor
difference from the previously approved patch is exactly what has been approved for trunk (and finally seems to work), I will commit this on Monday unless someone objects. Thanks, Martin 2011-09-15 Martin Jambor PR middle-end/49886 * ipa-split.c (split_function): Do not change

[PATCH] Do not store/stream binfos in jump functions

2011-09-16 Thread Martin Jambor
f LTO-building Firefox with it. OK for trunk? Thanks, Martin 2011-09-15 Martin Jambor * ipa-prop.h (jump_func_type): Updated comments. (ipa_known_type_data): New type. (ipa_jump_func): Use it to describe known type jump functions. * ipa-p

Re: [PATCH] Do not store/stream binfos in jump functions

2011-09-19 Thread Martin Jambor
Hi, On Fri, Sep 16, 2011 at 04:29:44PM +0200, Jan Hubicka wrote: > > > > * ipa-prop.h (jump_func_type): Updated comments. > > (ipa_known_type_data): New type. > > (ipa_jump_func): Use it to describe known type jump functions. > > * ipa-prop.c (ipa_print_node_jump_functions_for_edg

Re: [PATCH] Do not store/stream binfos in jump functions

2011-09-23 Thread Martin Jambor
ert I added to ipa_value_from_known_type_jfunc. Therefore I have committed a slightly different version with that assert replaced by a test. Thanks, Martin 2011-09-23 Martin Jambor * ipa-prop.h (jump_func_type): Updated comments. (ipa_known_type_data): New t

Re: [PR 47382] We cannot simply fold OBJ_TYPE_REF at all in 4.6

2011-09-23 Thread Martin Jambor
Hi, On Thu, Sep 22, 2011 at 06:36:43PM +1200, Maxim Kuvyrkov wrote: > On 9/02/2011, at 6:53 AM, Martin Jambor wrote: > > > > > This patch basically disables all intraprocedural devirtualization > > simply because that transformation relies on assumptions that no >

Re: Preserve callee cgraph edges when callgraph profiles sections are requested. (issue5101042)

2011-09-23 Thread Martin Jambor
Hi, On Thu, Sep 22, 2011 at 04:24:47PM -0700, Xinliang David Li wrote: > ok for google branches. > > (Did a little digging -- the remove pass is added because ipa-inline > did not do a good job updating the call graph so there might be some > inconsistency. However the affinity information needs

Re: Fix type of SRAed enum accesses

2011-09-27 Thread Martin Jambor
Hi, On Tue, Sep 27, 2011 at 03:26:03PM +0100, Richard Sandiford wrote: > This patch fixes a miscompilation of stage1 c-parser.o in an ARM bootstrap. > When an access to an enum field was SRAed, a component ref used the type > of the integer temporary variable instead of the type of the enum. > It

[PATCH, 4.4, PR 52430] IPA-CP has to clone or leave alone externally_visible nodes

2012-03-01 Thread Martin Jambor
ed and tested on x86_64-linux, OK for the branch? Thanks, Martin 2012-02-29 Martin Jambor PR tree-optimization/52430 * ipa-cp.c (ipcp_initialize_node_lattices): Also consider node->local.externally_visible as needed. Index: gcc

Re: [PATCH, 4.4, PR 52430] IPA-CP has to clone or leave alone externally_visible nodes

2012-03-06 Thread Martin Jambor
Hi, On Fri, Mar 02, 2012 at 06:54:13PM +1300, Maxim Kuvyrkov wrote: > On 2/03/2012, at 1:53 AM, Martin Jambor wrote: > > > Hi, > > > > the following patch backports 4.5 behavior to 4.4 IPA-CP > > initialization when it decides which nodes need to be duplicated

[PATCH] Proper use of decl_function_context in dwar2out.c

2012-03-08 Thread Martin Jambor
OK for the branch once 4.7.0 is out? Thanks, Martin 2012-03-07 Martin Jambor * dwarf2out.c (dwarf2out_decl): Use result of decl_function_context rather than DECL_CONTEXT. Index: src/gcc/dwarf2out.c === --- sr

[PATCH 0/3] Fixing expansion of misaligned MEM_REFs on strict-alignment targets

2012-03-12 Thread Martin Jambor
Hi, this is another iteration of my effort to fix expansion of misaligned memory accesses on strict-alignment platforms (which was suggested by Richi in http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00931.html, my previous attempt was posted as http://gcc.gnu.org/ml/gcc-patches/2012-02/msg01378.htm

[PATCH 1/3] Misaligned top level MEM_REFs on LHS of assignments

2012-03-12 Thread Martin Jambor
even if the other patches still undergo review. Thanks, Martin 2012-03-08 Martin Jambor * expr.c (expand_assignment): Handle misaligned scalar writes to memory through top-level MEM_REFs by calling store_bit_field. * testsuite/gcc.dg/misaligned-expand-2.c: New test

[PATCH 3/3] Misaligned MEM_REF reads

2012-03-12 Thread Martin Jambor
2012-03-09 Martin Jambor * expr.c (expand_expr_real_1): handle misaligned scalar reads from memory through MEM_REFs by calling extract_bit_field. * testsuite/gcc.dg/misaligned-expand-1.c: New test. Index: src/gcc/expr.c

[PATCH 2/3] Move MEM_REF expansion to a new function

2012-03-12 Thread Martin Jambor
nd ia64-linux. Thanks in advance for any comments, Martin 2012-03-09 Martin Jambor * expr.c (expand_mem_ref_to_mem_rtx): New function. (expand_assignment): Call it when expanding a MEM_REF on the LHS. (expand_expr_real_1): Likewis

Re: [PATCH 2/3] Move MEM_REF expansion to a new function

2012-03-12 Thread Martin Jambor
Hi, On Mon, Mar 12, 2012 at 04:26:21PM +0100, Michael Matz wrote: > Hi, > > On Mon, 12 Mar 2012, Martin Jambor wrote: > > > when we expand a misaligned MEM_REF on the LHS, we must not call the > > code in expand_expr_real_1 if the subsequent patch is applied, because >

Re: [PATCH 3/3] Misaligned MEM_REF reads

2012-03-14 Thread Martin Jambor
Hi, On Mon, Mar 12, 2012 at 03:09:04PM +0100, Martin Jambor wrote: > Hi, > > this patch is very similar to the one I posted before > (http://gcc.gnu.org/ml/gcc-patches/2012-02/msg01377.html) except that > it is now adjusted to sit on top of the new one before this and does >

Re: [PATCH] Proper use of decl_function_context in dwar2out.c

2012-03-16 Thread Martin Jambor
Hi, On Mon, Mar 12, 2012 at 11:51:05AM +0100, Richard Guenther wrote: > On Thu, Mar 8, 2012 at 12:18 PM, Jakub Jelinek wrote: > > On Thu, Mar 08, 2012 at 12:06:46PM +0100, Martin Jambor wrote: > >>        /* For local statics lookup proper context die.  */ > >> -

Re: [PATCH] Proper use of decl_function_context in dwar2out.c

2012-03-16 Thread Martin Jambor
Hi, On Fri, Mar 16, 2012 at 05:14:38PM +0100, Martin Jambor wrote: > On Mon, Mar 12, 2012 at 11:51:05AM +0100, Richard Guenther wrote: > > On Thu, Mar 8, 2012 at 12:18 PM, Jakub Jelinek wrote: > > > On Thu, Mar 08, 2012 at 12:06:46PM +0100, Martin Jambor wrote: > > >&g

[PATCH] Replace a SRA FIXME with an assert

2012-03-20 Thread Martin Jambor
size inconsistencies in assignments but we are not planning to do anything with them in foreseeable future (and perhaps add a note to the bug). So, which should it be? Thanks, Martin 2011-01-06 Martin Jambor * tree-sra.c (build_accesses_from_assign): Make size equality test

Re: [PATCH] Replace a SRA FIXME with an assert

2012-03-20 Thread Martin Jambor
Hi, On Tue, Mar 20, 2012 at 04:08:31PM +0100, Richard Guenther wrote: > On Tue, 20 Mar 2012, Martin Jambor wrote: > > > Hi, > > > > this patch which removes one of only two FIXMEs in tree-sra.c has been > > sitting in my patch queue for over a year. Ye

Re: [RFC PATCH 0/3] Fixing expansion of misaligned MEM_REFs on strict-alignment targets

2012-03-21 Thread Martin Jambor
Hi, On Tue, Mar 20, 2012 at 08:16:04PM +0100, Georg-Johann Lay wrote: > Martin Jambor wrote: > > Hi, > > > > this is another iteration of my attempts to fix expansion of > > misaligned memory accesses on strict-alignment platforms (which was > > suggested by R

Re: [PATCH] Replace a SRA FIXME with an assert

2012-03-23 Thread Martin Jambor
On Wed, Mar 21, 2012 at 08:46:49AM +0100, Richard Guenther wrote: > On Tue, 20 Mar 2012, Martin Jambor wrote: > > > Hi, > > > > On Tue, Mar 20, 2012 at 04:08:31PM +0100, Richard Guenther wrote: > > > On Tue, 20 Mar 2012, Martin Jambor wrote: > > > >

[PATCH] Remove strict-alignment checks in SRA

2012-03-23 Thread Martin Jambor
-linux, x86_64-linux and i686-linux. OK for trunk? Thanks, Martin 2012-03-20 Martin Jambor PR tree-optimization/50052 * tree-sra.c (tree_non_aligned_mem_p): Removed. (tree_non_aligned_mem_for_access_p): Likewise. (build_accesses_from_assign): Removed strict

[PATCH, PR 52693] Do not construct memory accesses to unscalarizable regions

2012-03-27 Thread Martin Jambor
the process of testing equivalents for the 4.5 and 4.6 branches (the diff contexts differ slightly). OK for everywhere if all tests pass? Thanks, Martin 2012-03-24 Martin Jambor PR middle-end/52693 * tree-sra.c (sra_modify_assign): Do not call load_assign_lhs_subre

[PATCH] Remove bogus assert from CCP's insert_clobbers_for_var

2012-03-28 Thread Martin Jambor
these), I thought it best to just remove the assert by the following simple patch, bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2012-03-28 Martin Jambor * tree-ssa-ccp.c (insert_clobbers_for_var): Do not assert that there is a builtin_stack_save

[PATCH] Dissociate store_expr's temp from exp so that it is not marked as addressable

2012-03-29 Thread Martin Jambor
x and helped my patch which uncovered this issue to reach stage 3 of bootstrap. What do you think, is it OK for trunk? Thanks, Martin 2012-03-30 Martin Jambor * expr.c (non_mem_decl_p): New function with half of previous functionality of... (mem_ref_refers_to_non_

Re: [PATCH] Dissociate store_expr's temp from exp so that it is not marked as addressable

2012-03-31 Thread Martin Jambor
Hi, On Fri, Mar 30, 2012 at 10:03:59AM +0200, Richard Guenther wrote: > On Fri, 30 Mar 2012, Martin Jambor wrote: > > > Hi, > > > > when testing a patch of mine on sparc64-linux, I came across an Ada > > bootstrap failure due to a structure DECL which was ma

Re: [PATCH] Remove bogus assert from CCP's insert_clobbers_for_var

2012-03-31 Thread Martin Jambor
Hi, On Fri, Mar 30, 2012 at 01:23:00PM +0200, Eric Botcazou wrote: > > On IRC I've been told that is OK and the that CCP cannot make such > > assumtions. Since it is only a missed-optimization if the call to the > > builtin is not found and processed (basically PR 51491 again but only > > in case

Re: [PATCH] Dissociate store_expr's temp from exp so that it is not marked as addressable

2012-04-04 Thread Martin Jambor
ia64-linux, I'm currently having problems bootsrapping sparc64 which is what I need this mainly for but those are unelated and this should help. Thanks, Martin 2012-04-03 Martin Jambor * expr.c (expand_expr_real_1): Pass type, not the expression, to set_mem_attributes for

[RFC] Should SRA stop producing COMPONENT_REF for non-bit-fields (again)?

2012-04-04 Thread Martin Jambor
pler, is it not? The patch fulfills the criteria to be committed and I can do it soon. OTOH, keeping it so on a number of platforms takes quite a lot of time (and has uncovered some non-related bugs) so I'd like to know whether it's worth it. Thanks, Martin 2012-03-20 Martin Jamb

Re: [PATCH] Dissociate store_expr's temp from exp so that it is not marked as addressable

2012-04-12 Thread Martin Jambor
Hi, On Fri, Apr 06, 2012 at 06:13:20PM +0200, Eric Botcazou wrote: > > 2012-04-03 Martin Jambor > > > > * expr.c (expand_expr_real_1): Pass type, not the expression, to > > set_mem_attributes for a memory temporary. Do not call the > > function fo

Re: [RFC] Should SRA stop producing COMPONENT_REF for non-bit-fields (again)?

2012-04-12 Thread Martin Jambor
Hi, On Wed, Apr 04, 2012 at 04:42:05PM +0200, Richard Guenther wrote: > On Wed, 4 Apr 2012, Martin Jambor wrote: > > > Hi everyone, especially Richi and Eric, > > > > I'd like to know what is your attitude to changing SRA's > > build_ref_for_model

[PATCH, PR 52939] Gracefully deal with fold_ctor_reference returning NULL during devirtualization

2012-04-13 Thread Martin Jambor
which is something gimple_get_virt_method_for_binfo cannot cope with. The patch below avoids it by simply testing for that value and bailing out. Bootstrapped and tested on x86_64-linux, OK for trunk? Thanks, Martin 2012-04-12 Martin Jambor PR middle-end/52939 * gimple

Re: [RFC] Should SRA stop producing COMPONENT_REF for non-bit-fields (again)?

2012-04-13 Thread Martin Jambor
On Fri, Apr 13, 2012 at 01:57:33PM +0200, Rainer Orth wrote: > Richard Guenther writes: > > >> Anyway, the patch I posted previously would risk re-introducing PR > >> 50386 and PR 50326, even though they are very unlikely with just > >> bit-fields. So my current working version is the following,

Re: [PATCH, PR 52939] Gracefully deal with fold_ctor_reference returning NULL during devirtualization

2012-04-13 Thread Martin Jambor
Hi, On Fri, Apr 13, 2012 at 04:13:13PM +0200, Richard Guenther wrote: > On Fri, 13 Apr 2012, Martin Jambor wrote: > > > Hi, > > > > currently we ICE when attempting to devirtualize a call to a virtual > > method introduced in a descendant but with a base which is

Re: [PATCH] Dissociate store_expr's temp from exp so that it is not marked as addressable

2012-04-17 Thread Martin Jambor
dependency may be missed. > > If we don't put the alias set of the reference on one of the MEM, then I > don't > think that we need to put it on the other MEM. That's what's done for the > first, non-bitfield temporary now. > > > 2012-04-10 Martin Jambor

[PATCH, PR 51583] One more missing force_gimple_operand in SRA

2011-12-16 Thread Martin Jambor
of trunk without any problems, a bootstrap and testsuite run on top of the 4.6 branch is currently running. OK for both if it passes? Thanks, Martin 2011-12-16 Martin Jambor PR tree-optimization/51583 * tree-sra.c (load_assign_lhs_subreplacements): Call

[PATCH, PR 51600] IPA-CP workaround for negative size cloning estimates

2011-12-21 Thread Martin Jambor
proceed with their testing. Bootstrapped and tested on x86-64-linux with no regressions. OK for trunk? Thanks, Martin 2011-12-20 Martin Jambor PR tree-optimization/51600 * ipa-cp.c (estimate_local_effects): Turn also negative size estimates to plus one. * gcc

[PATCH] Remove some newlines from tree-into-ssa.c dumps

2011-12-21 Thread Martin Jambor
luous "\n" stuff. I actually included this in a bootstrap and testsuite run, unsurprisingly it caused no issues. OK for trunk now? Thanks, Martin 2011-12-20 Martin Jambor * tree-into-ssa.c (rewrite_update_stmt): Do not dump extra newlines. (rewrite_update_enter_b

Re: [PATCH, PR 51600] IPA-CP workaround for negative size cloning estimates

2011-12-22 Thread Martin Jambor
Hi, On Wed, Dec 21, 2011 at 05:29:51PM +0100, Jan Hubicka wrote: > > Hi, > > > > given that we already have a workaround for zero size increase > > estimates from estimate_ipcp_clone_size_and_time, I see little reason > > not to extend it to negative values too, 0 is really just as bad as -2 > >

[PR 51759, 4.5] Backport the fix for PR 45644 to the 4.5 branch

2012-01-06 Thread Martin Jambor
4.5 times. Bootstrapped and tested on x86_64-linux, unless someone objects, I will commit it to the branch and the new test to both the 4.6 branch and the trunk on Monday. Thanks, Martin 2012-01-06 Martin Jambor PR tree-optimization/51759 Backport from mainline 2010-09-

[RFC] Fixing expansion of misaligned MEM_REFs on strict-alignment targets

2012-01-06 Thread Martin Jambor
Hi, I'm trying to teach our expander how to deal with misaligned MEM_REFs on strict alignment targets. We currently generate code which leads to bus error signals due to misaligned accesses. I admit my motivation is not any target in particular but simply being able to produce misaligned MEM_REF

[PATCH, PR 50444] Decrease MEM_REF TYPE_ALIGN in build_ref_for_offset

2012-01-12 Thread Martin Jambor
his. Is it the good direction, should I commit the patch (to trunk and the 4.6 branch) if it passes? Thanks, Martin 2012-01-12 Martin Jambor PR tree-optimization/50444 * tree-sra.c (build_ref_for_offset): Decrease the alignment of the type of the created MEM_REF if n

Re: [PATCH, PR 50444] Decrease MEM_REF TYPE_ALIGN in build_ref_for_offset

2012-01-12 Thread Martin Jambor
Hi, On Thu, Jan 12, 2012 at 03:23:31PM +0100, Richard Guenther wrote: > On Thu, 12 Jan 2012, Martin Jambor wrote: > > > Hi, > > > > I tend to believe that this is the SRA part of a fix for PR 50444 (and > > possibly some strict alignment SRA-related bugs too

[PATCH, PR 51782] Derive rtx address space from base object

2012-02-21 Thread Martin Jambor
the patch if his tests pass too. Thanks, Martin 2012-02-20 Martin Jambor PR tree-optimizaion/51782 * emit-rtl.c (set_mem_attributes_minus_bitpos): Set address space according to the base object. Index: src/gcc/emit-rtl.c

[RFC PATCH 1/3] Misaligned top level MEM_REFs on LHS of assignments

2012-02-27 Thread Martin Jambor
fail with movmisalign. Thanks, Martin 2012-02-28 Martin Jambor * expr.c (expand_assignment): Handle misaligned scalar writes to memory through top-level MEM_REFs by calling store_bit_field. * testsuite/gcc.dg/misaligned-expand-2.c: New test. Index: src/gcc/expr.c

[RFC PATCH 0/3] Fixing expansion of misaligned MEM_REFs on strict-alignment targets

2012-02-27 Thread Martin Jambor
Hi, this is another iteration of my attempts to fix expansion of misaligned memory accesses on strict-alignment platforms (which was suggested by Richi in http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00931.html and my first attempt was posted as http://gcc.gnu.org/ml/gcc-patches/2012-01/msg00319.h

[RFC PATCH 2/3] Misaligned MEM_REFs within handled_components on LHS of assignments

2012-02-27 Thread Martin Jambor
at -O1). Therefore I added a condition to punt on complex modes. Thanks, Martin 2012-02-28 Martin Jambor * expr.c (expand_assignment): Handle misaligned scalar writes to memory through MEM_REFs within handled_components by calling store_bit_field

[RFC PATCH 3/3] Misaligned MEM_REF reads

2012-02-27 Thread Martin Jambor
SLOW_UNALIGNED_ACCESS instead of STRICT_ALIGNMENT there?). Thanks, Martin 2012-02-28 Martin Jambor * expr.c (expand_expr_real_1): handle misaligned scalar reads from memory through MEM_REFs by calling extract_bit_field. * testsuite/gcc.dg/misaligned-expand-1.c: New

Re: [gcn][patch] Add -mgpu option and plumb in assembler/linker

2017-05-29 Thread Martin Jambor
Hello Andrew, I apologize for taking so long to reply, I was traveling for two past weeks and just before that we suffered some local infrastructure issues that prevented me from working on this too. On Fri, Apr 28, 2017 at 06:06:39PM +0100, Andrew Stubbs wrote: > This patch, for the "gcn" branch

Re: SSA range class and removal of VR_ANTI_RANGEs

2017-05-29 Thread Martin Jambor
Hi, On Wed, May 24, 2017 at 10:25:40AM +0200, Richard Biener wrote: > Well, anti-ranges are "evil" for actual working with ranges. They are nice > for optimizing the storage requirements though. > > As I'm replying late I'll add that yes, it does make a difference in memory > use. We've seen th

[PR 80898] Propagate grp_write from disqualified SRA candidates

2017-06-01 Thread Martin Jambor
x86_64-linux without any issues. OK for trunk? Thanks, Martin 2017-06-01 Martin Jambor PR tree-optimization/80898 * tree-sra.c (process_subtree_disqualification): Removed. (disqualify_candidate): Do not call process_subtree_disqualification

[PATCH] Trivial fix in dump_access_tree_1

2017-06-12 Thread Martin Jambor
). Thanks, Martin 2017-06-12 Martin Jambor * tree-sra.c (dump_access_tree_1): Fix accidental dumping to stderr instead of f. --- gcc/tree-sra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index f25818f4481..42879adbad1

[PR80803 1/2] Streamline SRA access enqueuing

2017-06-12 Thread Martin Jambor
Go), powerpc64le-linux (all languages except Ada but including Go) and Aarch64-linux (the same). OK for trunk? Thanks, Martin 2017-06-08 Martin Jambor * tree-sra.c (add_access_to_work_queue): Only enqueue accesses that have a first_link. (sort_and_splice_var_accesses): Do

[PR80803 2/2] Diligent queuing in SRA grp_write prop

2017-06-12 Thread Martin Jambor
Martin Jambor PR tree-optimization/80803 PR tree-optimization/81063 * tree-sra.c (subtree_mark_written_and_enqueue): Move up in the file. (propagate_subaccesses_across_link): Enqueue subtree whneve necessary instead of relying on the caller. testsuite

[PR 81477] Set versionable regardless of optimization level

2017-07-28 Thread Martin Jambor
2017-07-27 Martin Jambor PR hsa/81477 * ipa-fnsummary.c (ipa_fn_summary_generate): Set versionable regardless of optimization level. --- gcc/ipa-fnsummary.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gcc/ipa-fnsummary.c b/gcc/ipa-fnsumma

Re: Add option for whether ceil etc. can raise "inexact", adjust x86 conditions

2017-08-15 Thread Martin Jambor
Hi Joseph, On Thu, May 26, 2016 at 09:02:02PM +, Joseph Myers wrote: > On Thu, 26 May 2016, Jan Hubicka wrote: > > > > > +ffp-int-builtin-inexact > > > > +Common Report Var(flag_fp_int_builtin_inexact) Optimization > > > > +Allow built-in functions ceil, floor, round, trunc to raise > > > >

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

2017-01-06 Thread Martin Jambor
Hi, On Wed, Dec 14, 2016 at 01:12:11PM +0100, Richard Biener wrote: > On Wed, Dec 14, 2016 at 11:15 AM, Martin Jambor wrote: > > ... > > +/* Emulate effects of unary OPERATION and/or conversion from SRC_TYPE to > > + DST_TYPE on value range in SRC_VR and store it to

Re: [hsa] Exclude parallel outlines from hsa_callable_functions_p

2017-01-11 Thread Martin Jambor
Hi, On Fri, Dec 02, 2016 at 02:55:46PM +0100, Martin Jambor wrote: > Hi, > > after the merge of nvidia OpenMP implementation, the normal parallel > outline functions were also marked as "omp declare target" which lead > to them being cloned and compiled to HSA which is n

[hsa] Rename hsa.[ch] to hsa-common.[ch]

2017-01-20 Thread Martin Jambor
unfortunate coincidence the names conflicted anyway. I am bootstrapping the patch, I will commit it to trunk shortly afterwards. Thanks, Martin 2017-01-20 Martin Jambor * hsa.h: Renaed to hsa-common.h. Adjusted a comment. * hsa.c: Renaed to hsa-common.c. Change

[PR 79108] Put ipa_node_params to GC memory

2017-01-20 Thread Martin Jambor
sanitizers and multilib disabled. (It is now a part of an undergoing LTO bootstrap with everything). OK for trunk? Thanks, Martin 2017-01-19 Martin Jambor PR ipa/79108 * ipa-prop.h (ipa_param_descriptor): Anotate with with GTY(()). (ipa_node_params): Annotate with

Re: [PATCH] Fix PR78515

2017-01-20 Thread Martin Jambor
Hi, On Fri, Nov 25, 2016 at 02:55:29PM +0100, Richard Biener wrote: > On Fri, 25 Nov 2016, Martin Jambor wrote: > > ... > > > > There's still that odd 'stmt2' > > > hanging around that gets set to sth else than stmt with > > > > > >

Re: [PATCH] BRIG frontend: request for a global review

2017-01-23 Thread Martin Jambor
Hi, On Mon, Jan 23, 2017 at 12:56:13PM +0100, Richard Biener wrote: > On Fri, Jan 20, 2017 at 6:25 PM, Pekka Jääskeläinen > wrote: > > Hi Richard, > > > > On Fri, Jan 20, 2017 at 10:26 AM, Richard Biener > > wrote: > >> So the #ifdef ENABLE_BRIG_FE shouldn't be needed anymore (nor the > >> con

[PR 79198] Call ipa-prop func summary destructor

2017-01-24 Thread Martin Jambor
n IRC, Markus and David confirmed the first patches fixes the issue for them too. Because of that and because the fix is rather simple, I am going to commit both patches as obvious. Thanks and sorry for the breakage, Martin [PR 79198] Call ipa-prop func summary destructor 2017-01-23 Martin J

Re: [PR 79108] Put ipa_node_params to GC memory

2017-01-24 Thread Martin Jambor
Hi, On Mon, Jan 23, 2017 at 11:05:03PM +0100, Rainer Orth wrote: > Hi Martin, > > > when I fixed PR 78365 by streaming types of parameters that might not > > have been anywhere else, I forgot that I was holding them in non-GC > > memory and so I caused PR 79108. The following patch fixes it by >

Re: [PATCH] BRIG frontend: request for a global review

2017-01-24 Thread Martin Jambor
Hi, On Mon, Jan 23, 2017 at 02:11:37PM +0100, Richard Biener wrote: > On Mon, Jan 23, 2017 at 1:02 PM, Martin Jambor wrote: > > Hi, > > > > > > On Mon, Jan 23, 2017 at 12:56:13PM +0100, Richard Biener wrote: > >> On Fri, Jan 20, 2017 at 6:25 PM, Pekka Jääskelä

Re: [PATCH] Fix various issues in check_effective_target_hsa_offloading_selected_nocache

2017-01-26 Thread Martin Jambor
Hi Jakub, On Thu, Jan 26, 2017 at 02:29:51PM +0100, Jakub Jelinek wrote: > Hi! > > I've noticed that the file &1 in libgomp/testsuite/ directory after make > check and left over hsa_offloading_src*.exe files. > After looking more carefully, I found various issues. > 1) the way check_compile is in

Re: [PATCH] BRIG frontend: request for a global review

2017-01-27 Thread Martin Jambor
Hi, I have just committed the patch, as it is, except that a couple of two-spaces-after Pekka's name in Changelogs had already been corrected (sorry for that mistake) and I have also On Fri, Jan 27, 2017 at 10:31:34AM +0200, Pekka Jääskeläinen wrote: > --- a/gcc/brig/ChangeLog > +++ b/gcc/brig/Ch

Re: [wwwdocs] Document in changes.html -fcode-hoisting, -fipa-bit-cp, -fipa-vrp, -fsplit-loops, GCJ removal, x86 ISA additions, -fshrink-wrap-separate etc.

2017-01-31 Thread Martin Jambor
Hi, On Sun, Jan 29, 2017 at 07:55:18PM +0100, Jakub Jelinek wrote: > On Sun, Jan 29, 2017 at 06:08:32PM +0530, Prathamesh Kulkarni wrote: > > > + A new interprocedural bitwise constant propagation optimization > > > + has been added, which propagates knowledge about which bits of > > > variable

Re: [wwwdocs] Document in changes.html -fcode-hoisting, -fipa-bit-cp, -fipa-vrp, -fsplit-loops, GCJ removal, x86 ISA additions, -fshrink-wrap-separate etc.

2017-01-31 Thread Martin Jambor
On Tue, Jan 31, 2017 at 05:31:41PM +0100, Jakub Jelinek wrote: > On Tue, Jan 31, 2017 at 12:15:36PM +0100, Martin Jambor wrote: > > > I've committed it as is, feel free to propose changes. But before that, > > > we > > > should figure out what to do with

Re: [RFC] Bug lto/78140

2017-02-02 Thread Martin Jambor
Hi, I am sorry, I am apparently not really able to follow all email this week and am mostly skimming through this thread too, but... On Thu, Feb 02, 2017 at 01:48:26PM +0100, Jan Hubicka wrote: > > > > 2017-02-02 Kugan Vivekanandarajah > > > > * ipa-cp.c (ipcp_store_bits_results): Co

Re: [PATCH] Fix memory leaks in IPA CP (PR ipa/79337).

2017-02-02 Thread Martin Jambor
Hi, On Thu, Feb 02, 2017 at 01:53:35PM +0100, Martin Liska wrote: > Hello. > > As mentioned in the PR, there is memory leak that is caused by fact, that > ipa_node_params_t > does release memory just in ipa_node_params_t::remove. That's wrong because > the callback is called > just when cgraph_

[PR 79375] Avoid passing NULL by reference

2017-02-07 Thread Martin Jambor
such circumstances. Bootstrapped and tested on x86_64-linux. I think it is quite obvious and so will commit it tomorrow, because I have rto run now. Thanks, Martin 2017-02-04 Martin Jambor PR ipa/79375 * ipa-prop.c (ipa_alloc_node_params): Make static, return bool

[PATCH] Properly deprecate -fipa-cp-alignment

2017-02-08 Thread Martin Jambor
t a proper bootstrap before committing if ACKed. OK for trunk as it is? Thanks, Martin 2017-02-08 Martin Jambor * common.opt (-finstrument-functions-exclude-file-list): Remove Var and Optimization, Document as deprecated and superseded by -fipa-bit-cp. * doc/i

[PR 78687] Set SRA grp_write lazily

2017-04-27 Thread Martin Jambor
ite of SRA is unlikely to happen in time for GCC 8, I'd like t commit it to trunk. Needless to say, it passes bootstrap and testing on x86_64-linux. What do you think? Martin 2017-03-15 Martin Jambor PR tree-optimization/78687 * tree-sra.c (access): N

Re: [gcn][patch] Add -mgpu option and plumb in assembler/linker

2017-05-02 Thread Martin Jambor
Hi Andrew, sorry for replying only now but yesterday was public holiday here and I am still only in the process of recovering from a long weekend. While the only objection I have is the C++ style comment in config/gcn/gcn.c, another problem, for me at least... On Fri, Apr 28, 2017 at 06:06:39PM

Re: Update ipa-cp to new time metrics

2017-05-03 Thread Martin Jambor
Hi, On Tue, May 02, 2017 at 11:33:28AM +0200, Jan Hubicka wrote: > Hi, > this patch makes ipa-cp to use nonspecialized time as a base for decision > about > cloning. I wonder about the capping - we perhaps want to use sreals further > in > the code because time differences can be large (with pr

Re: [RFC PATCH 0/3] Call summary class

2017-05-03 Thread Martin Jambor
On Mon, Feb 27, 2017 at 05:36:48PM +0100, Martin Jambor wrote: > Hello, > > the patch sequence in this thread adds a call_summary class, which is > analogous to function_summary we already have but which gathers > information about call graph edges, rather than nodes. >

[PR 80622] Treat const pools as initialized in SRA

2017-05-04 Thread Martin Jambor
appropriate places and moves the test in question to an earlier time, which is a tiny bit cheaper because it may avoid unnecessary re-invocation of propagate_subaccesses_across_link. Bootstrapped and tested on x86_64-linux, OK for trunk? Thanks, Martin 2017-05-04 Martin Jambor PR tree

Re: [RFC] Assert DECL_ABSTRACT_ORIGIN is different from the decl itself

2016-12-01 Thread Martin Jambor
Hello, On Wed, Nov 30, 2016 at 02:09:19PM +0100, Martin Jambor wrote: > On Tue, Nov 29, 2016 at 10:17:02AM -0700, Jeff Law wrote: > > > > ... > > > > So it seems that rather than an assert that we should just not walk down a > > self-referencing DECL_ABSTRAC

[hsa] Exclude parallel outlines from hsa_callable_functions_p

2016-12-02 Thread Martin Jambor
lines from hsa_callable_functions_p 2016-11-29 Martin Jambor * hsa.c (hsa_callable_function_p): Return false for artificial functions. --- gcc/hsa.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gcc/hsa.c b/gcc/hsa.c index f881e78..31e3252 100644 --- a/gcc/hsa.c

Re: [PR 70965] Schedule extra pass_rebuild_cgraph_edges

2016-12-02 Thread Martin Jambor
Hi, On Fri, Nov 25, 2016 at 02:10:51PM +0100, Jan Hubicka wrote: > > On Thu, Nov 24, 2016 at 5:44 PM, Martin Jambor wrote: > > > > > > ... > > > > > > 2016-11-24 Martin Jambor > > > > > > gcc/ > > > * pas

Re: PR78599

2016-12-02 Thread Martin Jambor
Hi, On Thu, Dec 01, 2016 at 01:43:16PM +0100, Richard Biener wrote: > On Thu, Dec 1, 2016 at 11:07 AM, Prathamesh Kulkarni > wrote: > > Hi, > > As mentioned in PR, the issue seems to be that in > > propagate_bits_accross_jump_functions(), > > ipa_get_type() returns record_type during WPA and henc

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

2016-12-07 Thread Martin Jambor
Hello Kugan, sorry, I have lost track of this patch and re-discovered it only now. On Mon, Nov 28, 2016 at 04:25:00PM +1100, kugan wrote: > Hi, > > On 24/11/16 19:48, Richard Biener wrote: > > On Wed, Nov 23, 2016 at 4:33 PM, Martin Jambor wrote: > > > Hi, > > &g

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

2016-12-09 Thread Martin Jambor
Hi, On Fri, Dec 09, 2016 at 03:36:44PM +1100, kugan wrote: > On 07/12/16 21:08, Martin Jambor wrote: > > On Mon, Nov 28, 2016 at 04:25:00PM +1100, kugan wrote: > > > > ... > > > > > Here is a patch that does this. To fox PR78365, in > > >

Re: [PATCH] omp-low.c split

2016-12-09 Thread Martin Jambor
Hi, On Fri, Dec 09, 2016 at 04:25:10PM +0300, Alexander Monakov wrote: > Hi Martin, > > Just one quick question -- do you know if config/nvptx/nvptx.c needs changes > with this patch? I see it has an '#include "omp-low.h"', and it seems your > patch is renaming some functions -- is the intention

Re: [PATCH] omp-low.c split

2016-12-13 Thread Martin Jambor
Hi, On Fri, Dec 09, 2016 at 07:18:54PM +0300, Alexander Monakov wrote: > On Fri, 9 Dec 2016, Jakub Jelinek wrote: > > Can you post an incremental patch fixing those issues? > > A few small nits I found while reading the patch. > > First of all, please use 'git diff --patience' (or --histogram) w

Re: [PATCH] omp-low.c split

2016-12-13 Thread Martin Jambor
Hi, On Tue, Dec 13, 2016 at 12:43:16PM +0100, Jakub Jelinek wrote: > On Tue, Dec 13, 2016 at 12:39:01PM +0100, Thomas Schwinge wrote: > > On Fri, 9 Dec 2016 14:08:21 +0100, Martin Jambor wrote: > > > this is the promised attempt at splitting omp-low.c [...] > > > >

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

2016-12-14 Thread Martin Jambor
The patch passes bootstrap, lto-boostrap (of C, C++ and Fortran) and testing on x86_64-linux. What do you think? Martin 2016-12-13 Martin Jambor PR ipa/78365 * ipa-prop.h (ipa_jump_func): New field pased_type. * ipa-cp.c (ipa_vr_operation_and_type_effects): New functi

Re: [PATCH] omp-low.c split

2016-12-14 Thread Martin Jambor
Hi, On Wed, Dec 14, 2016 at 02:14:32PM +0100, Thomas Schwinge wrote: > > I still couldn't allocate time to review the patch, but at least I now > have tested it -- no regressions. Great, thanks! > As I suppose you want to commit this > as sooner than later ;-) and you already have approval as I

Re: [PATCH] Formatting and spelling fixes for ipa-cp.c

2016-12-15 Thread Martin Jambor
On Thu, Dec 15, 2016 at 05:51:25PM +0100, Jakub Jelinek wrote: > Hi! > > When looking at the noipa attribute, I've been initially changing > ipa-cp.c, and noticed some bad spellings (various functions called *accross* > rather than *across*) and tons of bad formatting, sometimes e.g. indentation >

Re: [PATCH] Fix IPA CP where it forgot to add a reference in cgraph

2016-12-20 Thread Martin Jambor
Hi, On Mon, Dec 19, 2016 at 11:09:52AM +0100, Martin Liska wrote: > Hello. > > Building mariadb with -flto exposes a bug which I also used to see > in Firefox. It's caused by IPA CP starting from r236418, where the > pass started to propagate const VAR_DECLs. Problem is that the pass > does not u

[HSA, PR 82416] Do not extend operands to at least 32 bits

2017-10-09 Thread Martin Jambor
larger. Tested on an HSA APU, tested by Pekka, bootstrapped on an x86_64-linux with HSA generation enabled, committed to trunk a few moments ago. Thanks, Martin 2017-10-09 Martin Jambor PR hsa/82416 gcc/ * hsa-common.h (hsa_op_with_type): New method extend_int_to_32bit

[RFC, PR 80689] Copy small aggregates element-wise

2017-10-13 Thread Martin Jambor
advance for any comments, Martin 2017-10-12 Martin Jambor PR target/80689 * tree-sra.h: New file. * ipa-prop.h: Moved declaration of build_ref_for_offset to tree-sra.h. * expr.c: Include params.h and tree-sra.h. (emit_move_elementwise): New f

Re: [PATCH, RFC] Add a pass counter for "are we there yet" purposes

2017-10-23 Thread Martin Jambor
Hi, On Mon, Oct 16, 2017 at 06:15:06PM +0200, Richard Biener wrote: > I guess that might help. I have the feeling that querying for 'did > pass X run' is wrong conceptually. The reason why I liked the idea is that I could unify SRA and early-SRA passes and their behavior would only differ accordi

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Martin Jambor
Hi, On Tue, Oct 17, 2017 at 01:34:54PM +0200, Richard Biener wrote: > On Fri, Oct 13, 2017 at 6:13 PM, Martin Jambor wrote: > > Hi, > > > > I'd like to request comments to the patch below which aims to fix PR > > 80689, which is an instance of a store-to-load for

[hsa] Add missing guard in OMP gridification

2017-10-27 Thread Martin Jambor
hanks, Martin 2017-10-10 Martin Jambor * omp-grid.c (grid_attempt_target_gridification): Also insert a condition whether loop should be executed at all. --- gcc/omp-grid.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/omp-grid.c b/gcc/omp-grid.c index a7b6f6

[PR 81702] Remove devirtualization assert

2017-10-31 Thread Martin Jambor
. Bootstrapped and tested on x86_64-linux, I will commit it to teunk as pre-approved in Bugzilla in a few moments. I will commit it tomorrow to the gcc-7-branch after testing it there too. Thanks, Martin 2017-10-31 Martin Jambor PR c++/81702 * gimple-fold.c

[PR 82078] Enqueue all SRA links for write flag propagation

2017-09-06 Thread Martin Jambor
. Bootstrapped and tested on x86_64-linux without any issues. OK for trunk? Thanks, Martin 2017-09-05 Martin Jambor PR tree-optimization/82078 gcc/ * tree-sra.c (sort_and_splice_var_accesses): Move call to add_access_to_work_queue... (build_accesses_from_assign

[HSA, PR 82119] Make HSA resilient to side-effects of split_edge

2017-09-11 Thread Martin Jambor
libgomp testsuite failures. Fixed thusly. I have tested the patch on HSA capable APU and also did full bootstrap and testing, I will commit in a few moments. Martin 2017-09-11 Martin Jambor PR hsa/82119 * hsa-gen.c (gen_hsa_phi_from_gimple_phi): Process ADDR_EXPRs in

<    3   4   5   6   7   8   9   10   11   12   >