[PATCH] m68k: restore bootstrap

2024-02-18 Thread Mikael Pettersson
m68k fails to bootstrap since -ffold-mem-offsets was introduced, in what looks like wrong-code during stage2. To restore bootstrap this disables -ffold-mem-offsets on m68k. It's not ideal, but better than keeping bootstraps broken until the root cause is debugged and fixed. Tested with a

[PATCH] Avoid ICE in single-bit logical RMWs on m68k-uclinux [PR108640]

2024-01-18 Thread Mikael Pettersson
When generating RMW logical operations on m68k, the backend recognizes single-bit operations and rewrites them as bit instructions on operands adjusted to address the intended byte. When offsetting the addresses the backend keeps the modes as SImode, even though the actual access will be in

[PATCH] Avoid ICE on m68k -fzero-call-used-regs -fpic [PR110934]

2024-01-17 Thread Mikael Pettersson
PR110934 is a problem on m68k where -fzero-call-used-regs -fpic ICEs when clearing an FP register. The generic code generates an XFmode move of zero to that register, which becomes an XFmode load from initialized data, which due to -fpic uses a non-constant address, which the backend rejects.

Re: [PATCH] Avoid ICE with m68k-elf -malign-int and libcalls

2024-01-16 Thread Mikael Pettersson
On Thu, 4 Jan 2024 14:39:23 -0700, Jeff Law wrote: > On 1/4/24 02:23, Mikael Pettersson wrote: > > emit_library_call_value_1 calls emit_push_insn with NULL_TREE > > for TYPE. Sometimes emit_push_insn needs to assign a temp with > > that TYPE, which causes a segfault. > &

Re: [PATCH] Avoid ICE with m68k-elf -malign-int and libcalls

2024-01-16 Thread Mikael Pettersson
On Thu, 4 Jan 2024 14:39:23 -0700, Jeff Law wrote: > On 1/4/24 02:23, Mikael Pettersson wrote: > > emit_library_call_value_1 calls emit_push_insn with NULL_TREE > > for TYPE. Sometimes emit_push_insn needs to assign a temp with > > that TYPE, which causes a segfault. > &

[PATCH] Avoid ICE with m68k-elf -malign-int and libcalls

2024-01-04 Thread Mikael Pettersson
Mikael Pettersson PR target/82420 PR target/111279 * expr.cc (emit_push_insn): If TYPE is NULL compute it from MODE before calling assign_temp. gcc/teststuite/ 2024-01-03 Mikael Pettersson PR target/82420 * gcc.target/m68k/pr82420.c: New test

[PATCH] wrong code on m68k with -mlong-jump-table-offsets and -malign-int (PR target/112413)

2023-12-11 Thread Mikael Pettersson
commit rights to I would need assistance applying this. 2023-12-11 Mikael Pettersson PR target/112413 * config/m68k/linux.h (ASM_RETURN_CASE_JUMP): For TARGET_LONG_JUMP_TABLE_OFFSETS, reference the jump table via its label. * config/m68k/m68kelf.h

[PATCH] fix pdp11_expand_epilogue (PR target/107841)

2023-07-13 Thread Mikael Pettersson via Gcc-patches
If the stack frame only contains an alloca area, then pdp11_expand_epilogue fails to deallocate it, resulting in callee-saved registers and the return address being restored from the wrong stack slots. Fixed by adding || cfun->calls_alloca to the condition for deallocating the frame. Tested with

Re: [PATCH] add glibc-stdint.h to vax and lm32 linux target (PR target/105525)

2023-05-22 Thread Mikael Pettersson via Gcc-patches
On Mon, May 22, 2023 at 3:57 PM Jan-Benedict Glaw wrote: > > Hi! > > On Mon, 2023-05-22 14:10:48 +0100, Maciej W. Rozycki > wrote: > > On Fri, 19 May 2023, Mikael Pettersson wrote: > > > The background is that I maintain a script to build GCC-based crosses to

Re: [PATCH] add glibc-stdint.h to vax and lm32 linux target (PR target/105525)

2023-05-19 Thread Mikael Pettersson via Gcc-patches
gt; > > unsatisfied references to __INTPTR_TYPE__ and __UINTPTR_TYPE__, > > > caused by these two targets failing to provide glibc-stdint.h. > > > > > > Fixed thusly, tested by building crosses, which now succeeds. > > > > > > Ok for trunk? (Note I don't

[PATCH] add glibc-stdint.h to vax and lm32 linux target (PR target/105525)

2023-04-28 Thread Mikael Pettersson via Gcc-patches
, which now succeeds. Ok for trunk? (Note I don't have commit rights.) 2023-04-28 Mikael Pettersson PR target/105525 * config.gcc (vax-*-linux*): Add glibc-stdint.h. (lm32-*-uclinux*): Likewise. --- gcc/config.gcc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-08 Thread Mikael Pettersson via Gcc-patches
ot;mingw32.h" +#endif + #ifndef IN_RTS /* For gnat1/gnatbind compilation: cannot use unwind.h, as it is for the target. So mimic configure... From 44a276e7900a506ee4b6f85d25ae5d96a11bd91e Mon Sep 17 00:00:00 2001 From: Mikael Pettersson Date: Mon, 8 Mar 2021 22:31:16 +0100 Sub

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-07 Thread Mikael Pettersson via Gcc-patches
On Sun, Jan 10, 2021 at 2:04 PM Mikael Pettersson wrote: > > On Sun, Jan 10, 2021 at 11:57 AM Arnaud Charlet wrote: > > > > > This fixes a compilation error preventing bootstrap with Ada on > > > x86_64-pc-cygwin. See PR bootstrap/94918 for details. > > > &

Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-02-26 Thread Mikael Pettersson via Gcc-patches
pdated. > > > > Thanks, here's the revised patch. > > OK, thanks. I forgot to mention that I don't have commit rights to gcc, so can someone please commit this for me? Thanks. > > > gcc/ada/ > > > > 2021-02-05 Mikael Pettersson > > > >

[PATCH] don't enable DWARF5 by default on Windows (PR98860)

2021-02-08 Thread Mikael Pettersson via Gcc-patches
ppens even with the very latest binutils master. Fixed by updating SUBTARGET_OVERRIDE_OPTIONS to set dwarf_version to 4 unless the user explicitly requested another version. I see some other targets did the same. Tested on Cygwin64 and mingw-w64. Ok for master? 2021-02-08 Mikael Pettersson

Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-02-05 Thread Mikael Pettersson via Gcc-patches
oes not declare it, causing a hard error. > > > > Fixed by defining _GNU_SOURCE before including . > > > > Ok for the master branch? > > > > gcc/ada/ > > > > 2021-02-03 Mikael Pettersson > > > > PR bootstrap/98590 > >

[PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-02-03 Thread Mikael Pettersson via Gcc-patches
for the master branch? gcc/ada/ 2021-02-03 Mikael Pettersson PR bootstrap/98590 * cstreams.c: Ensure fileno_unlocked() is visible on Cygwin. diff --git a/gcc/ada/cstreams.c b/gcc/ada/cstreams.c index 4e00dedbbd6..9d2f41c5269 100644 --- a/gcc/ada/cstreams.c +++ b/gcc/ada/cstreams.c

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-01-10 Thread Mikael Pettersson via Gcc-patches
e fix matches what Ada's mingw32.h does. Tested by bootstrapping this and the preliminary workaround for PR98590 on x86_64-pc-cygwin. Ok for master and branches? libgcc/ 2021-01-10 Mikael Pettersson PR bootstrap/94918 * unwind-generic.h (__SEH__): Prevent windows.h from includin

[PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-01-10 Thread Mikael Pettersson via Gcc-patches
it applied. Tested by bootstrapping this and the preliminary workaround for PR98590 on x86_64-pc-cygwin. Ok for master and branches? (Patch also attached to protect it against gmail formatting.) gcc/ada/ 2021-01-10 Mikael Pettersson PR bootstrap/94918 * raise-gcc.c: (__SEH__

Re: [PATCH] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2020-05-03 Thread Mikael Pettersson via Gcc-patches
1 with Ada on x86_64-pc-cygwin. See PR bootstrap/94918 for details. Tested by bootstrapping on x86_64-pc-cygwin, and since it touches code shared with mingw, also by building a cross to x86_64-w64-mingw32. Ok for master and gcc-10 branch? (I don't have commit rights, so I will need assistanc

[PATCH] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2020-05-02 Thread Mikael Pettersson via Gcc-patches
-10 branch? (I don't have commit rights, so I will need assistance with that.) (The patch is also attached, since gmail _will_ corrupt this text.) gcc/ada/ 2020-05-02 Mikael Pettersson PR bootstrap/94918 * mingw32.h: Prevent windows.h from including emmintrin.h on Cygwin64

Re: [PATCH 0/4] Eliminate cc0 from m68k

2019-11-20 Thread Mikael Pettersson
On Wed, Nov 20, 2019 at 3:16 PM Bernd Schmidt wrote: > > On 11/20/19 2:50 PM, Mikael Pettersson wrote: > > On Mon, Nov 18, 2019 at 9:57 PM Mikael Pettersson > > wrote: > >> > >> On Mon, Nov 18, 2019 at 8:31 PM Bernd Schmidt > >> wrote: &

Re: [PATCH 0/4] Eliminate cc0 from m68k

2019-11-20 Thread Mikael Pettersson
On Mon, Nov 18, 2019 at 9:57 PM Mikael Pettersson wrote: > > On Mon, Nov 18, 2019 at 8:31 PM Bernd Schmidt wrote: > > > > Hi Mikael, > > > > > This fixed the problem, thanks. > > > > Could you also run the testsuite to see if you can reproduce t

Re: [PATCH 0/4] Eliminate cc0 from m68k

2019-11-18 Thread Mikael Pettersson
On Mon, Nov 18, 2019 at 8:31 PM Bernd Schmidt wrote: > > Hi Mikael, > > > This fixed the problem, thanks. > > Could you also run the testsuite to see if you can reproduce the > g++.old-deja failures Andreas reported? Yes, but it will probably take another week before the native bootstrap (on

Re: [PATCH 0/4] Eliminate cc0 from m68k

2019-11-17 Thread Mikael Pettersson
On Sun, Nov 17, 2019 at 5:57 PM Andreas Schwab wrote: > > On Nov 17 2019, Mikael Pettersson wrote: > > > /tmp/ccJA1qws.s:4828: Error: operands mismatch -- statement `seq %a1' > > ignored > > /tmp/ccJA1qws.s:7344: Error: operands mismatch -- statement `seq %a1' >

Re: [PATCH 0/4] Eliminate cc0 from m68k

2019-11-17 Thread Mikael Pettersson
On Wed, 13 Nov 2019 14:04:59 +0100, Bernd Schmidt wrote: > This is a set of patches to convert m68k so that it no longer uses cc0. Thank you for doing this. I attempted a native bootstrap of gcc-10-20191110 (r278028) plus the five patches posted so far on m68k-linux (aranym), but it failed in

Re: [PATCH][M68K] allow long offsets in jump tables (wrong-code PR target/57583)

2017-01-06 Thread Mikael Pettersson
Jeff Law writes: > On 01/06/2017 09:08 AM, Mikael Pettersson wrote: > > This fixes / works-around the wrong-code PR57583 on M68K, caused by > > overflowing the 16-bit jump table offsets the backend uses. > > > > Ideally the backend should define CASE_VECTOR_SHORTE

[PATCH][M68K] allow long offsets in jump tables (wrong-code PR target/57583)

2017-01-06 Thread Mikael Pettersson
"mednafen" with it, which previously failed; I also tested earlier versions. Is this Ok for trunk? /Mikael gcc/ 2017-01-06 Mikael Pettersson <mikpeli...@gmail.com> PR target/57583 * config/m68k/m68k.opt (LONG_JUMP_TABLE_OFFSETS): New option. * con

[PATCH] unbreak libsanitizer build on sparc-linux (PR 67899)

2016-09-12 Thread Mikael Pettersson
. Is this Ok for trunk and 5/6 branches? (Note: I don't have commit rights so if this is approved I would need help to get it applied.) Thanks, /Mikael libsanitizer/ 2016-09-12 Mikael Pettersson <mikpeli...@gmail.com> PR sanitizer/67899 * sanitizer_

Re: Patches to fix GCC's C++ exception_handling on NetBSD/VAX

2016-03-27 Thread Mikael Pettersson
Jake Hamby writes: > As an added bonus, I see that my patch set also included an old m68k patch > that had been sitting in my tree, which fixes a crash when -m68040 is > defined. > I may have submitted it to port-m68k before. It hasn't been tested with the > new compiler either. Here's that

Re: Fix PR44281 (bad RA with global regs)

2016-02-29 Thread Mikael Pettersson
Michael Matz writes: > > > FWIW: signal handlers need no consideration (if they were allowed to > > > inspect/alter global reg vars we would have lost and no improvement on > > > fixed_regs[] could be done). They are explicitely documented to not be > > > able to access global reg vars.

RE: [PATCH] Fix another wrong-code bug with -fstrict-volatile-bitfields

2015-03-14 Thread Mikael Pettersson
Bernd Edlinger writes: Hi, are there any more comments on this? I would like to apply the patch as is, unless we find a a way to get to a test case, maybe with a cross-compiler, where the MODE_ALIGNMENT is different from MODE_BITSIZE. Currently, I think that does not happen.

Re: [4.8] backport PR57748 fixes (wrong-code and ICE regression)

2015-01-26 Thread Mikael Pettersson
Richard Biener writes: On Sun, Jan 25, 2015 at 3:25 PM, Mikael Pettersson mikpeli...@gmail.com wrote: This backports the fixes for PR middle-end/57748, a wrong-code and ICE regression, to the 4.8 branch. Tested extensively on x86_64, powerpc64, sparc64, ARMv{5,7}, and m68k

[4.8] backport PR57748 fixes (wrong-code and ICE regression)

2015-01-25 Thread Mikael Pettersson
This backports the fixes for PR middle-end/57748, a wrong-code and ICE regression, to the 4.8 branch. Tested extensively on x86_64, powerpc64, sparc64, ARMv{5,7}, and m68k. Ok for 4.8? (I don't have commit rights.) /Mikael gcc/ 2015-01-25 Mikael Pettersson mikpeli...@gmail.com

Re: [PATCH] Fix incorrect folding of bitfield in a union on big endian target

2014-08-11 Thread Mikael Pettersson
Thomas Preud'homme writes: In the code dealing with folding of structure and union initialization, there is a check that the size of the constructor is the same as the field being read. However, in the case of bitfield this test can be wrong because it relies on TYPE_SIZE to get the

Re: [committed] Use __kernel_cmpxchg for __sync_lock_release

2014-07-18 Thread Mikael Pettersson
John David Anglin writes: Because the atomic sync functions in config/pa/linux-atomic.c are not lock free, we need to use __kernel_cmpxchg for the __sync_lock_release. This was found in glibc's pthread_spin_unlock implementation. Tested on hppa-unknown-linux-gnu. Committed to

Re: [RFC] HOST_WIDE_INT transition steps

2014-05-20 Thread Mikael Pettersson
Richard Biener writes: The following is my current idea on progressing on the HOST_WIDE_INT removal ... And HOST_WIDEST_FAST_INT for which I don't have a very good suggestion other than either keeping it, unconditionally using 'long' (thus simply remove

Re: [SPARC] Fix PR target/60941

2014-04-26 Thread Mikael Pettersson
Eric Botcazou writes: Not clear to me, (2U i) should be zero if the shift count is masked. 2U 31 is undefined behavior on those targets. Precisely not, or else we are not talking about the same notion of masking. I believe Jakub is referring to the following in the C standard:

[4.8] backport fixes for wrong-code PR57425 and PR57569

2014-03-15 Thread Mikael Pettersson
for powerpc64le on IBM's 4.8 branch. Ok for 4.8 branch? Thanks, /Mikael (I don't have commit rights, but Bill has agreed to do the commit if this backport is approved.) gcc/ 2014-03-15 Mikael Pettersson mikpeli...@gmail.com Backport from mainline: 2013-06-20 Joern Rennecke

Re: [PATCH][RFC] fix reload causing ICE in subreg_get_info on m68k (PR58369)

2013-10-18 Thread Mikael Pettersson
Jeff Law writes: On 09/28/13 09:30, Mikael Pettersson wrote: This patch fixes PR58369, an ICE in subreg_get_info when compiling boost for m68k-linux. choose_reload_regs attempts to reload a DFmode (8-byte) reg, finds an XFmode (12-byte) reg in last_reg, and calls

[PATCH][RFC] fix reload causing ICE in subreg_get_info on m68k (PR58369)

2013-09-28 Thread Mikael Pettersson
backend really wants that, and I think it just papers over a generic bug.] Tested with trunk and 4.8 on {m68k,sparc64,powerpc64}-linux (big-endian), and on x86_64-linux/armv5tel-linux-gnueabi (little-endian). No regressions. Comments? Is this Ok for trunk? gcc/ 2013-09-28 Mikael Pettersson

Re: [patch c] Fix target/57848: internal compiler error on builtin and '#pragma GCC target()' option

2013-09-13 Thread Mikael Pettersson
Kai Tietz writes: Hello, this patch fixes a wrong assumption in c_builtin_function_ext_scope. The check for never being called on preexisting symbols (with meaning), isn't correct as the turning on of builtins via pragmas wasn't considered. The following sample demonstrate this

Re: [PATCH 1/2] fix PR49847 ICE-on-HAVE_cc0 regression from PR50780 changes

2013-08-29 Thread Mikael Pettersson
Jeff Law writes: * cse.c (fold_rtx) second case CC0: If prev_insn_cc0 is NULL don't call equiv_constant on it. I can't help but feel something different needs to be done here. It's always been the case that those two insns are expected to be contiguous and there's going to be

[PATCH 2/2] fix PR48835 ICE-on-HAVE_cc0 regression from PR50780 changes

2013-08-28 Thread Mikael Pettersson
, no regressions. This patch has been in a 4.7-based production compiler on m68k-linux since early 2013. Ok for trunk and 4.8? [If approved I'll need help to commit it as I don't have commit rights.] gcc/ 2013-08-28 Mikael Pettersson mi...@it.uu.se PR ada/48835 * cse.c (fold_rtx) first case

[PATCH 1/2] fix PR49847 ICE-on-HAVE_cc0 regression from PR50780 changes

2013-08-28 Thread Mikael Pettersson
compilers on m68k-linux since early 2012, and in a 4.7-based compiler since early 2013. Ok for trunk and 4.8? [If approved I'll need help to commit it as I don't have commit rights.] gcc/ 2013-08-28 Mikael Pettersson mi...@it.uu.se PR rtl-optimization/49847 * cse.c (fold_rtx

Re: [Patch ARM] Fix PR19599 tail

2013-07-29 Thread Mikael Pettersson
Ramana Radhakrishnan writes: Hi, This fixes up the issues with PR target/19599 and the issues we've had around it. ... 2013-07-25 Ramana Radhakrishnan ramana.radhakrish...@arm.com PR target/19599 PR target/57731 PR target/57748 Are you sure

Re: [PATCH] Fold VEC_[LR]SHIFT_EXPR (PR tree-optimization/57051)

2013-05-16 Thread Mikael Pettersson
Jakub Jelinek writes: On Thu, Apr 25, 2013 at 11:47:02PM +0200, Jakub Jelinek wrote: This patch adds folding of constant arguments v and v, which helps to optimize the testcase from the PR back into constant store after vectorized loop is unrolled. As this fixes a regression on the

Re: [wwwdocs] gcc-4.8/porting_to.html

2013-03-13 Thread Mikael Pettersson
Benjamin De Kosnik writes: Hey! Here is the first pass at the 4.8 porting documentation. .. + memset(p1, 0, sizeof(p1)); // error, use memcopy s/memcopy/memcpy/ + memset(p1, 0, sizeof(p1)); // error, use memcopy likewise + pTo fix, either use memcopy or dereference the last

Re: [wwwdocs] gcc-4.8/porting_to.html

2013-03-13 Thread Mikael Pettersson
Alexander Monakov writes: On Wed, 13 Mar 2013, Mikael Pettersson wrote: Benjamin De Kosnik writes: Hey! Here is the first pass at the 4.8 porting documentation. .. + memset(p1, 0, sizeof(p1)); // error, use memcopy s/memcopy/memcpy/ It doesn't make

Re: [5/8] Tweak bitfield alignment handling

2012-11-20 Thread Mikael Pettersson
John David Anglin writes: On Sun, 18 Nov 2012, Richard Sandiford wrote: HOST_WIDE_INT start = bitpos_ - (bitpos_ % unit); if (bitregion_start_ start bitregion_start_) break; - if (bitregion_end_ start + unit bitregion_end_ + 1) + if (start + unit

Re: Fix PR tree-optimization/53729 (Re: [PATCH] Fix PR tree-optimization/53636)

2012-06-25 Thread Mikael Pettersson
Ulrich Weigand writes: Richard Guenther wrote: In this testcase the alignment of arr[i] should be irrelevant - it is not part of the stmts that are going to be vectorized. But of course this may be simply an odering issue in how we analyze data-references / statements in

Re: [PATCH] Fix PR tree-optimization/53636 (SLP generates invalid misaligned access)

2012-06-20 Thread Mikael Pettersson
Richard Guenther writes: On Tue, Jun 19, 2012 at 11:36 PM, Mikael Pettersson mi...@it.uu.se wrote: Richard Guenther writes:   On Fri, Jun 15, 2012 at 5:00 PM, Ulrich Weigand uweig...@de.ibm.com wrote:   Richard Guenther wrote:   On Fri, Jun 15, 2012 at 3:13 PM, Ulrich Weigand

Re: [PATCH] Fix PR tree-optimization/53636 (SLP generates invalid misaligned access)

2012-06-19 Thread Mikael Pettersson
Richard Guenther writes: On Fri, Jun 15, 2012 at 5:00 PM, Ulrich Weigand uweig...@de.ibm.com wrote: Richard Guenther wrote: On Fri, Jun 15, 2012 at 3:13 PM, Ulrich Weigand uweig...@de.ibm.com wrote: However, there is a second case where we need to check every pass: if we're not

[PATCH] PR libffi/52223: Define FLAGS_TO_PASS for libffi

2012-02-23 Thread Mikael Pettersson
. OK for trunk and affected branches? (If approved I'll need from someone with svn write access to get it applied.) /Mikael libffi/ 2012-02-23 Mikael Pettersson mi...@it.uu.se PR libffi/52223 * Makefile.am (FLAGS_TO_PASS): Define. * Makefile.in: Regenerate. --- gcc

Re: [committed] 4 backports from trunk to 4.6 branch

2011-12-12 Thread Mikael Pettersson
Jakub Jelinek writes: On Sun, Dec 11, 2011 at 02:48:52PM +0100, Mikael Pettersson wrote: This patch, r182112 on 4.6 branch, caused a test suite regression on arm-linux-gnueabi: +FAIL: gcc.c-torture/execute/20050713-1.c compilation, -O2 (internal compiler error) +UNRESOLVED

Re: [committed] Another 4.6 backport (PR tree-optimization/50078)

2011-12-11 Thread Mikael Pettersson
Jakub Jelinek writes: Hi! Bootstrapped/regtested on x86_64-linux and i686-linux, committed to 4.6 branch. 2011-12-09 Jakub Jelinek ja...@redhat.com Backport from mainline 2011-12-08 Jakub Jelinek ja...@redhat.com PR tree-optimization/51466 *

Re: [committed] 4 backports from trunk to 4.6 branch

2011-12-11 Thread Mikael Pettersson
Jakub Jelinek writes: Hi! Bootstrapped/regtested on x86_64-linux and i686-linux, committed to 4.6 branch: ... 2011-12-08 Jakub Jelinek ja...@redhat.com Backport from mainline 2011-12-05 Jakub Jelinek ja...@redhat.com Eric Botcazou

Re: Adjust omp-low test for alignment

2011-12-02 Thread Mikael Pettersson
Hans-Peter Nilsson writes: BTW, on the topic, I cringe whenever I see futexes expressed as plain int, they absolutely have to have at least natural alignment which is not always true e.g. in structs. People, please keep the atomic types target-overridable in libraries. +1 for

Re: [PATCH 0/2] Add atomic support to m68k

2011-11-25 Thread Mikael Pettersson
Richard Henderson writes: On 11/23/2011 06:46 AM, Mikael Pettersson wrote: +FAIL: c-c++-common/gomp/atomic-10.c scan-tree-dump-times ompexp __atomic_fetch_add 4 +FAIL: c-c++-common/gomp/atomic-3.c scan-tree-dump-times ompexp xyzzy, 4 1 +FAIL: c-c++-common/gomp/atomic-9.c scan

Re: [PATCH 0/2] Add atomic support to m68k

2011-11-23 Thread Mikael Pettersson
Mikael Pettersson writes: Richard Henderson writes: The first patch adds support for the m68k-linux syscall. The second patch adds native support for the m680[2346]0 CAS instruction, and the m68000/Coldfire TAS instruction. Both tested only via cross-compile

Re: [PATCH 0/2] Add atomic support to m68k

2011-11-19 Thread Mikael Pettersson
Richard Henderson writes: The first patch adds support for the m68k-linux syscall. The second patch adds native support for the m680[2346]0 CAS instruction, and the m68000/Coldfire TAS instruction. Both tested only via cross-compile. Please test... Thanks Richard. I'm

Re: [PATCH] Fix computed gotos on m68k

2011-10-18 Thread Mikael Pettersson
Julian Brown writes: Hi, This patch fixes computed gotos on m68k, and probably other targets too (the fix is in the middle end). Several tests fail at present with -O3 -fomit-frame-pointer. This is the same bug as PR47918. As described in that PR trail, the bug can be triggered also

Re: [PATCH] fix -Wsign-compare error in objc-act.c (PR objc/50743)

2011-10-17 Thread Mikael Pettersson
Nicola Pero writes: (I don't have svn write access so I'll need someone else to commit it if it's approved.) I can apply it for you. But ... do you have a copyright assignment in place for contributions to GCC ? The patch looks small and trivial enough that I think I can apply it

[PATCH] fix -Wsign-compare error in objc-act.c (PR objc/50743)

2011-10-16 Thread Mikael Pettersson
? (I don't have svn write access so I'll need someone else to commit it if it's approved.) /Mikael gcc/objc/ 2011-10-16 Mikael Pettersson mi...@it.uu.se PR objc/50743 * objc-act.c (check_duplicates): Cast TREE_VEC_LENGTH result to size_t to avoid signed/unsigned comparison

[PATCH] fix -Werror=maybe-uninitialized in tree-ssa-loop-ivopts.c (PR bootstrap/50218)

2011-08-28 Thread Mikael Pettersson
/impossible 'comp' values. Ok for trunk? (I don't have svn write access.) /Mikael gcc/ 2011-08-20 Mikael Pettersson mi...@it.uu.se PR bootstrap/50218 * tree-ssa-loop-ivopts.c (determine_use_iv_cost_condition): Initialize comp. --- gcc-4.7-20110827/gcc/tree-ssa-loop-ivopts.c

[PATCH] make assign_hard_reg's saved_nregs conditional to unbreak ARM bootstrap (PR50146)

2011-08-22 Thread Mikael Pettersson
access so I'll need help to commit it. /Mikael gcc/ 2011-08-22 Mikael Pettersson mi...@it.uu.se PR bootstrap/50146 * ira-color.c (assign_hard_reg): Move saved_nregs declaration to #ifndef HONOR_REG_ALLOC_ORDER block. --- gcc-4.7-20110820/gcc/ira-color.c.~1

[PATCH,PR50005] fix -Wsign-compare warning in ipa-inline-analysis.c

2011-08-08 Thread Mikael Pettersson
. Pre-approved by Jan Hubicka in the PR trail. Ok for trunk? (I don't have svn write access.) (The warning is only visible with the C FE due to an unrelated C++ FE diagnostics bug, which I've filed as PR50012.) /Mikael gcc/ 2011-08-08 Mikael Pettersson mi...@it.uu.se PR tree

Re: [PATCH] unbreak attribute((optimize(...))) on m68k (PR47908)

2011-07-30 Thread Mikael Pettersson
Andreas Schwab writes: Mikael Pettersson mi...@it.uu.se writes: 2011-07-28 Mikael Pettersson mi...@it.uu.se PR target/47908 * config/m68k/m68k.c (m68k_override_options_after_change): New function. Disable instruction scheduling for non-ColdFire targets

[PATCH] unbreak attribute((optimize(...))) on m68k (PR47908)

2011-07-28 Thread Mikael Pettersson
for trunk and 4.6? (4.5 and 4.4 need a slightly different fix which I can provide if needed.) /Mikael gcc/ 2011-07-28 Mikael Pettersson mi...@it.uu.se PR target/47908 * config/m68k/m68k.c (m68k_override_options_after_change): New function. Disable instruction scheduling

[PATCH] make attribute((returns_twice)) actually work (PR tree-optimization/49243)

2011-06-02 Thread Mikael Pettersson
Mikael Pettersson mi...@it.uu.se PR tree-optimization/49243 * calls.c (setjmp_call_p): Also check if fndecl has the returns_twice attribute. gcc/testsuite/ 2011-06-02 Mikael Pettersson mi...@it.uu.se PR tree-optimization/49243 * gcc.dg/pr49243.c: New

Re: Cleaning up expand optabs code

2011-03-29 Thread Mikael Pettersson
Richard Sandiford writes: Andreas Krebbel kreb...@linux.vnet.ibm.com writes: On 03/22/2011 06:48 PM, Richard Henderson wrote: Ok. Watch out for other target problems this week. This unfortunately broke bootstrap on s390. This is PR 48263. Since it seems to be affecting

Re: Cleaning up expand optabs code

2011-03-29 Thread Mikael Pettersson
Richard Sandiford writes: Mikael Pettersson mi...@it.uu.se writes: Richard Sandiford writes: Andreas Krebbel kreb...@linux.vnet.ibm.com writes: On 03/22/2011 06:48 PM, Richard Henderson wrote: Ok. Watch out for other target problems this week