Re: [PATCH] Add myself to MAINTAINERS

2020-03-11 Thread binbin via Gcc-patches
Hi, On 2020/3/12 上午10:19, Bin Bin Lv wrote: Hi, This adds myself to MAINTAINERS in the Write After Approval section. gcc/ChangeLog 2020-03-11 Bin Bin Lv * MAINTAINERS (Write After Approval): Add myself. --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-11 Thread binbin via Gcc-patches
Hi, On 2020/3/10 上午10:30, binbin wrote: Hi, On 2020/3/9 下午10:32, Segher Boessenkool wrote: Hi! On Mon, Mar 09, 2020 at 01:58:01PM +0800, binbin wrote: 2020-03-09  Bin Bin Lv  * config/rs6000/rs6000-internal.h (altivec_builtin_mask_for_load, builtin_mode_to_type[MAX_MACHINE_MODE][2

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-09 Thread binbin
Hi, On 2020/3/9 下午10:32, Segher Boessenkool wrote: Hi! On Mon, Mar 09, 2020 at 01:58:01PM +0800, binbin wrote: 2020-03-09 Bin Bin Lv * config/rs6000/rs6000-internal.h (altivec_builtin_mask_for_load, builtin_mode_to_type[MAX_MACHINE_MODE][2]): Remove the declaration. Just

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-09 Thread binbin
Hi Segher, On 2020/3/6 下午11:25, Segher Boessenkool wrote: Hi! On Fri, Mar 06, 2020 at 10:20:08AM +0800, binbin wrote: OK, changed the code. Bootstrap and regression tests were done on powerpc64le-linux-gnu (LE) with no regressions. Thanks for your suggestion. Yes, this is fine, approved

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-08 Thread binbin
Hi Segher, On 2020/3/5 下午6:42, Segher Boessenkool wrote: Hi Bin Bin, On Thu, Mar 05, 2020 at 10:31:39AM +0800, binbin wrote: On 2020/3/5 上午2:35, Segher Boessenkool wrote: On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: * config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-05 Thread binbin
Hi Kewen and Segher, On 2020/3/6 上午10:02, binbin wrote: On 2020/3/4 下午6:35, Kewen.Lin wrote: on 2020/3/4 下午3:24, binbin wrote: Hi On 2020/3/4 上午8:33, Segher Boessenkool wrote: Hi! On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote: Rewrite the declaration of toc_section from

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-04 Thread binbin
Hi Segher, On 2020/3/5 上午2:35, Segher Boessenkool wrote: On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: * config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the header file for MAX_MACHINE_MODE. The changelog entry should say *what* file is included, and under what

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-03 Thread binbin
Hi On 2020/3/4 上午8:33, Segher Boessenkool wrote: Hi! On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote: Rewrite the declaration of toc_section from the source file rs6000.c to its header file for standardizing the code. diff --git a/gcc/config/rs6000/rs6000.c

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-03 Thread binbin
Hi On 2020/3/4 上午8:25, Segher Boessenkool wrote: Hi! On Tue, Mar 03, 2020 at 09:40:47AM -0600, Bin Bin Lv wrote: The source file rs6000.c was split up into several smaller source files through commit 1acf024. However, variable "altivec_builtin_mask_for_load" and