Re: [4.7][google] Adding a new option -fstack-protector-strong. (issue 5461043)

2012-01-30 Thread 沈涵
Hi, ping? Could someone take a look at this patch, it has already been reviewed several rounds. I'm to submit it to gcc trunk. Thanks, -Han On Wed, Jan 25, 2012 at 9:41 PM, davi...@google.com wrote: ok for google branches with the above changes. Please continue to seek upstream approval.

Re: [4.7][google] Adding a new option -fstack-protector-strong. (issue 5461043)

2012-01-25 Thread 沈涵
Hi, David and Rong, thanks a lot! Modified code uploaded as patch 8 and is also included at the end of email body. Ref - http://codereview.appspot.com/5461043 Regards, -Han == Patch start diff --git a/gcc/cfgexpand.c b/gcc/cfgexpand.c index 6d31e90..131c1b9 100644 --- a/gcc/cfgexpand.c +++

Re: [4.7][google] Adding a new option -fstack-protector-strong. (issue 5461043)

2012-01-25 Thread davidxl
ok for google branches with the above changes. Please continue to seek upstream approval. David http://codereview.appspot.com/5461043/diff/19001/gcc/doc/invoke.texi File gcc/doc/invoke.texi (right): http://codereview.appspot.com/5461043/diff/19001/gcc/doc/invoke.texi#newcode403

Re: [4.7][google] Adding a new option -fstack-protector-strong. (issue 5461043)

2012-01-24 Thread xur
OK for google branches. http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c File gcc/cfgexpand.c (right): http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1597 gcc/cfgexpand.c:1597: contain an array or are arrays. */ , before or, and two spaces before */.

Re: [4.7][google] Adding a new option -fstack-protector-strong. (issue 5461043)

2012-01-24 Thread davidxl
Also need to update doc/invoke.texi file for the new option. http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c File gcc/cfgexpand.c (right): http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1531 gcc/cfgexpand.c:1531: record_or_union_type_has_array