Ping: Re: [DWARF] Fix multiple register spanning location.

2013-06-11 Thread Christian Bruel
Hello, May I have a review from the DWARF, the ARM and RS6000 maintainers for comments/approval ? http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01613.html Needed to fix the powerpc-spe bootstrap referenced in bugzilla #57389 Many Thanks Christian Christian Bruel wrote: >> However I feel a li

Re: [DWARF] Fix multiple register spanning location.

2013-05-28 Thread Kaz Kojima
Christian Bruel wrote: > However I feel a little bit uncomfortable with this solution that > doesn't seem to fix the root cause. The dbx_register_number hooks is > called basically from two places : dwarf2cfi.c and dwarf2out.c. That > show different uses: either we want to refer to the hard regno

Re: [DWARF] Fix multiple register spanning location.

2013-05-27 Thread Christian Bruel
On 05/16/2013 12:27 AM, Cary Coutant wrote: >>> How about using dbx_reg_number (XVECEXP (regs, 0, i)) instead? The >>> bare use of DBX_REGISTER_NUMBER earlier in that function is protected >>> by a gcc_assert, but this one isn't. >> For the respective targets maintainers that drop into the thread:

Re: [DWARF] Fix multiple register spanning location.

2013-05-21 Thread Christian Bruel
Yes, this looks good. OK for trunk, but please add a note about those additional changes you made to the ChangeLog entry. Thanks! Thanks, done with this entry: 2013-05-21 Christian Bruel * dwarf2out.c (multiple_reg_loc_descriptor): Use dbx_reg_number for spanning register

Re: [DWARF] Fix multiple register spanning location.

2013-05-15 Thread Cary Coutant
> > How about using dbx_reg_number (XVECEXP (regs, 0, i)) instead? The > > bare use of DBX_REGISTER_NUMBER earlier in that function is protected > > by a gcc_assert, but this one isn't. > > OK dbx_reg_number better than DBX_REGISTER_NUMBER here. > while we are on it, it looks like the spanning ca

Re: [DWARF] Fix multiple register spanning location.

2013-05-07 Thread Christian Bruel
Hello, On 04/30/2013 09:05 PM, Cary Coutant wrote > > How about using dbx_reg_number (XVECEXP (regs, 0, i)) instead? The > bare use of DBX_REGISTER_NUMBER earlier in that function is protected > by a gcc_assert, but this one isn't. OK dbx_reg_number better than DBX_REGISTER_NUMBER here. while w

Re: [DWARF] Fix multiple register spanning location.

2013-04-30 Thread Cary Coutant
2013-04-26 Christian Bruel * dwarf2out.c (multiple_reg_loc_descriptor): Use DBX_REGISTER_NUMBER for spaning registers. s/spaning/spanning/ Index: dwarf2out.c === --- dwarf2out.c (revision 198287) +++ dwarf2out.c

[DWARF] Fix multiple register spanning location.

2013-04-29 Thread Christian Bruel
Hello, We noticed a few failures with the gdb testsuite due to incorrect mapping of floating point, noticed on SH that defines both TARGET_DWARF_REGISTER_SPAN and DBX_REGISTER_NUMBER. The problem was that the converted pseudo reg was never converted to the dbx format when fed from 'multiple_reg_l