Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-17 Thread Mikael Morin
Le 17/07/2015 21:39, Mikael Morin a écrit : >> It seems that this commit has changed the scanning of >> other testcases. >> > Will fix. > Done: https://gcc.gnu.org/r225965 (trunk) https://gcc.gnu.org/r225969 (5 branch) Mikael Index: gcc/testsuite/gfortran.dg/coarray_collectives_16.f90

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-17 Thread Mikael Morin
Le 17/07/2015 20:40, Steve Kargl a écrit : > On Fri, Jul 17, 2015 at 03:50:26PM +0200, Mikael Morin wrote: >> Le 17/07/2015 11:02, Mikael Morin a écrit : >>> Le 16/07/2015 16:34, Damian Rouson a écrit : Alternatively, if it?s easy, please feel free to add the directives and commit. >>>

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-17 Thread Steve Kargl
On Fri, Jul 17, 2015 at 03:50:26PM +0200, Mikael Morin wrote: > Le 17/07/2015 11:02, Mikael Morin a écrit : > > Le 16/07/2015 16:34, Damian Rouson a écrit : > >> Alternatively, if it?s easy, please feel free to add the directives and > >> commit. > >> > > > Never mind, I'll take care of it all.

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-17 Thread Alessandro Fanfarillo
Thanks a lot! 2015-07-17 15:50 GMT+02:00 Mikael Morin : > Le 17/07/2015 11:02, Mikael Morin a écrit : >> Le 16/07/2015 16:34, Damian Rouson a écrit : >>> Alternatively, if it’s easy, please feel free to add the directives and >>> commit. >>> > >> Never mind, I'll take care of it all. >> > This is

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-17 Thread Damian Rouson
Thank you! Damian > On Jul 17, 2015, at 9:50 AM, Mikael Morin wrote: > > Le 17/07/2015 11:02, Mikael Morin a écrit : >> Le 16/07/2015 16:34, Damian Rouson a écrit : >>> Alternatively, if it’s easy, please feel free to add the directives and >>> commit. >>> > >> Never mind, I'll take care o

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-17 Thread Mikael Morin
Le 17/07/2015 11:02, Mikael Morin a écrit : > Le 16/07/2015 16:34, Damian Rouson a écrit : >> Alternatively, if it’s easy, please feel free to add the directives and >> commit. >> > Never mind, I'll take care of it all. > This is what I have committed: https://gcc.gnu.org/r225930 (trunk) https

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-17 Thread Mikael Morin
Le 16/07/2015 16:34, Damian Rouson a écrit : > Alternatively, if it’s easy, please feel free to add the directives and > commit. > It's not very difficult, but there is some pain getting the number of escape backslashes right. Never mind, I'll take care of it all. Mikael

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-16 Thread Damian Rouson
> On Jul 15, 2015, at 8:58 AM, Mikael Morin wrote: > > The patch itself looks good to me. > A ChangeLog entry should be provided with it. > The test is missing the usual dejagnu pattern matching directives to > check the generated code. > Do you have commit rights? Hi Mikael, Thanks for the q

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-15 Thread Mikael Morin
Hello, Le 13/07/2015 17:31, Alessandro Fanfarillo a écrit : > Dear all, > > during the implementation of co_reduce in OpenCoarrays I noticed that > GFortran passes a pointer to function instead of the function name to > co_reduce. > More exactly there are two address operators ('&') in a row (th

[Fortran, Patch] Passing function pointer to co_reduce

2015-07-13 Thread Alessandro Fanfarillo
Dear all, during the implementation of co_reduce in OpenCoarrays I noticed that GFortran passes a pointer to function instead of the function name to co_reduce. Currently the compiler produces the following call: _gfortran_caf_co_reduce (&desc.0, &simple_reduction, 0, 0, 0B, 0B, 0, 0); where si