Re: [PATCH, ARM] Do not set ARM_ARCH_ISA_THUMB for armv5

2016-05-31 Thread Thomas Preudhomme
On Friday 27 May 2016 14:01:22 Kyrill Tkachov wrote: > On 27/05/16 13:51, Thomas Preudhomme wrote: > > On Tuesday 24 May 2016 18:00:27 Kyrill Tkachov wrote: > >> Hi Thomas, > > > > Hi Kyrill, > > > >>> +/* Nonzero if chip supports Thumb. */ > >>> +extern int arm_arch_thumb; > >>> + > >> > >> Bi

Re: [PATCH, ARM] Do not set ARM_ARCH_ISA_THUMB for armv5

2016-05-27 Thread Kyrill Tkachov
On 27/05/16 13:51, Thomas Preudhomme wrote: On Tuesday 24 May 2016 18:00:27 Kyrill Tkachov wrote: Hi Thomas, Hi Kyrill, +/* Nonzero if chip supports Thumb. */ +extern int arm_arch_thumb; + Bit of bikeshedding really, but I think a better name would be arm_arch_thumb1. This is because we a

Re: [PATCH, ARM] Do not set ARM_ARCH_ISA_THUMB for armv5

2016-05-27 Thread Thomas Preudhomme
On Tuesday 24 May 2016 18:00:27 Kyrill Tkachov wrote: > Hi Thomas, Hi Kyrill, > > > > +/* Nonzero if chip supports Thumb. */ > > +extern int arm_arch_thumb; > > + > > Bit of bikeshedding really, but I think a better name would be > arm_arch_thumb1. > This is because we also have the macros TA

Re: [PATCH, ARM] Do not set ARM_ARCH_ISA_THUMB for armv5

2016-05-25 Thread Thomas Preudhomme
On Tuesday 24 May 2016 18:00:27 Kyrill Tkachov wrote: > Hi Thomas, > > On 10/05/16 14:26, Thomas Preudhomme wrote: > > Hi, > > > > ARM_ARCH_ISA_THUMB is currently set to 1 when compiling for armv5 despite > > armv5 not supporting Thumb instructions (armv5t does): > > > > arm-none-eabi-gcc -dM -m

Re: [PATCH, ARM] Do not set ARM_ARCH_ISA_THUMB for armv5

2016-05-24 Thread Kyrill Tkachov
Hi Thomas, On 10/05/16 14:26, Thomas Preudhomme wrote: Hi, ARM_ARCH_ISA_THUMB is currently set to 1 when compiling for armv5 despite armv5 not supporting Thumb instructions (armv5t does): arm-none-eabi-gcc -dM -march=armv5 -E - < /dev/null | grep ISA_THUMB #define __ARM_ARCH_ISA_THUMB 1 The r

[PATCH, ARM] Do not set ARM_ARCH_ISA_THUMB for armv5

2016-05-10 Thread Thomas Preudhomme
Hi, ARM_ARCH_ISA_THUMB is currently set to 1 when compiling for armv5 despite armv5 not supporting Thumb instructions (armv5t does): arm-none-eabi-gcc -dM -march=armv5 -E - < /dev/null | grep ISA_THUMB #define __ARM_ARCH_ISA_THUMB 1 The reason is TARGET_ARM_ARCH_ISA_THUMB being set to 1 if targ