Re: [PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-29 Thread Richard Biener
On Tue, Oct 28, 2014 at 5:14 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes PR63664 and PR63574. Problem is in NULL types for labels not handled by ICF properly. I assume it is OK for labels to have NULL type and added check into ICF rather then fixed label

Re: [PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-29 Thread Ilya Enkovich
On 29 Oct 10:34, Richard Biener wrote: On Tue, Oct 28, 2014 at 5:14 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes PR63664 and PR63574. Problem is in NULL types for labels not handled by ICF properly. I assume it is OK for labels to have NULL type and added

Re: [PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-29 Thread Martin Liška
On 10/29/2014 02:45 PM, Ilya Enkovich wrote: On 29 Oct 10:34, Richard Biener wrote: On Tue, Oct 28, 2014 at 5:14 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes PR63664 and PR63574. Problem is in NULL types for labels not handled by ICF properly. I assume it is OK for

Re: [PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-29 Thread Ilya Enkovich
2014-10-29 17:01 GMT+03:00 Martin Liška mli...@suse.cz: On 10/29/2014 02:45 PM, Ilya Enkovich wrote: On 29 Oct 10:34, Richard Biener wrote: On Tue, Oct 28, 2014 at 5:14 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes PR63664 and PR63574. Problem is in NULL types for

Re: [PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-29 Thread Martin Liška
On 10/29/2014 03:07 PM, Ilya Enkovich wrote: 2014-10-29 17:01 GMT+03:00 Martin Liška mli...@suse.cz: On 10/29/2014 02:45 PM, Ilya Enkovich wrote: On 29 Oct 10:34, Richard Biener wrote: On Tue, Oct 28, 2014 at 5:14 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes

Re: [PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-29 Thread Jeff Law
On 10/29/14 10:28, Martin Liška wrote: PR63574.changelog gcc/testsuite/ChangeLog: 2014-10-29 Martin Liskamli...@suse.cz * g++.dg/ipa/pr63574.C: New test. gcc/ChangeLog: 2014-10-29 Martin Liskamli...@suse.cz * ipa-icf-gimple.c (func_checker::compare_variable_decl):

[PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-28 Thread Ilya Enkovich
Hi, This patch fixes PR63664 and PR63574. Problem is in NULL types for labels not handled by ICF properly. I assume it is OK for labels to have NULL type and added check into ICF rather then fixed label generation. Bootstrapped and checked on linux-x86_64. OK for trunk? Thanks, Ilya --