[PATCH][PING^2] Fix for PR59600 (prohibit inlining if no_sanitize_address)

2014-02-03 Thread Yury Gribov
Original Message Subject: [PATCH][PING] Fix for PR59600 (prohibit inlining if no_sanitize_address) Date: Tue, 28 Jan 2014 09:13:10 +0400 From: Yury Gribov To: GCC Patches Original Message Subject: [PATCH] Fix for PR59600 Date: Tue, 21 Jan 2014 14:42:31 +040

Re: [PATCH][PING^2] Fix for PR59600 (prohibit inlining if no_sanitize_address)

2014-02-04 Thread Richard Biener
On Tue, Feb 4, 2014 at 4:39 AM, Yury Gribov wrote: > Original Message > Subject: [PATCH][PING] Fix for PR59600 (prohibit inlining if > no_sanitize_address) > Date: Tue, 28 Jan 2014 09:13:10 +0400 > From: Yury Gribov > To: GCC Patches > > Original Message > Sub

Re: [PATCH][PING^2] Fix for PR59600 (prohibit inlining if no_sanitize_address)

2014-02-04 Thread Yury Gribov
Richard wrote: I think you can't rely on pointer equivalence of the lookup_attribute result so you want instead of Thanks, makes sense. Please also name CIF_OPTION_MISMATCH as CIF_ATTRIBUTE_MISMATCH and say "function attribute mismatch" in the description. Done. What about updated patch?

Re: [PATCH][PING^2] Fix for PR59600 (prohibit inlining if no_sanitize_address)

2014-02-04 Thread Richard Biener
On Tue, Feb 4, 2014 at 3:32 PM, Yury Gribov wrote: > Richard wrote: >> >> I think you can't rely on pointer equivalence of the lookup_attribute >> result so you want instead of > > > Thanks, makes sense. > > >> Please also name CIF_OPTION_MISMATCH as CIF_ATTRIBUTE_MISMATCH >> and say "function att

Re: [PATCH][PING^2] Fix for PR59600 (prohibit inlining if no_sanitize_address)

2014-02-04 Thread Yury Gribov
Richard wrote: What about updated patch? Ok if it passes bootstrap and regtesting. It does, commited in r207497. -Y