Re: [PATCH] [Microblaze]: PIC Data Text Relative

Committed. On 05/05/2018 04:14 AM, Andrew Sadek wrote: Hello Michael, I made a re-run for the GCC test suite. I have just noticed that picdtr.c was not uploaded, also I forgot to adapt the new pic option text in it. thus we need to apply the attached patch. Otherwise, it's all fine. Results

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Hello Michael, I made a re-run for the GCC test suite. I have just noticed that picdtr.c was not uploaded, also I forgot to adapt the new pic option text in it. thus we need to apply the attached patch. Otherwise, it's all fine. Results (Normal Run): === gcc Summary === # of expected pa

Re: [PATCH] [Microblaze]: PIC Data Text Relative

--resend Michael's reply On Mon, Apr 30, 2018 at 1:19 PM, Michael Eager wrote: > > Applied -- Committed revision 259758. > > Andrew -- Please re-run GCC regression test to verify that nothing > was lost in the editing. > > > > -- > Michael Eagerea...@eagerm.com > 1960 Park Blvd., Palo Alto,

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Thanks Michael. Please find below updated Change Log. 2018-04-27 Andrew Sadek Microblaze Target: PIC data text relative * gcc/config/microblaze/microblaze.opt: add new option -mpic-is-data-text-relative. * gcc/config/microblaze/microblaze-protos.h (microblaze_constant_address_p):

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On 04/19/2018 03:43 AM, Andrew Sadek wrote: On Wed, Apr 18, 2018 at 6:57 PM, Michael Eager wrote: Hi Andrew -- Check indents in the following files: (Make sure that your tabs are set at 8 chars.) --- gcc/config/microblaze/microblaze.c --- gcc/config/microblaze/microblaze.md I have re-run ch

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On Wed, Apr 18, 2018 at 6:57 PM, Michael Eager wrote: > > Hi Andrew -- > > Check indents in the following files: > (Make sure that your tabs are set at 8 chars.) > --- gcc/config/microblaze/microblaze.c > --- gcc/config/microblaze/microblaze.md > I have re-run check_GNU_Style.sh and no are issues

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On 04/18/2018 05:44 AM, Andrew Sadek wrote: Hello Michael, I have attached the patch as well, (the same as in : https://github.com/andrewsadek/microblaze-pic-data-text-rel/blob/pic_data_text_rel/PATCH_BUNDLE/gcc.patch) On Thu, Mar 22, 2018 at 8:37 PM, Andrew Sadek wrote: Hello Michael, I h

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Hello Michael, I have attached the patch as well, (the same as in : https://github.com/andrewsadek/microblaze-pic-data-text-rel/blob/pic_data_text_rel/PATCH_BUNDLE/gcc.patch) On Thu, Mar 22, 2018 at 8:37 PM, Andrew Sadek wrote: > Hello Michael, > > I have adapted the test cases. > > Please find

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Hello Michael, I have adapted the test cases. Please find the patch below with Change log, description and test results. Description: -- This branch is regarding a new implemented feature in GCC Microblaze that allows Position Independent Code to run using Data Text Relative add

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Hi Andrew -- I just do a visual check. The script can help. On 03/20/2018 07:13 AM, Andrew Sadek wrote: Many Thanks Michael for the updates .. I was actually looking for something similar for my test case .. I m currently revising the Gnu code conventions on the patches then will send them aga

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Many Thanks Michael for the updates .. I was actually looking for something similar for my test case .. I m currently revising the Gnu code conventions on the patches then will send them again. I m actually running the 'check_GNU_Style' in contrib folder,, is this the correct way ? Is it enough ?

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Also check the { dg-skip-if } directive. https://gcc.gnu.org/onlinedocs/gccint/Directives.html On 03/19/2018 06:14 PM, Michael Eager wrote: Hi Andrew -- Please take a look at the test case description: https://gcc.gnu.org/wiki/HowToPrepareATestcase and see if you can do one of the following:  

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Hi Andrew -- Please take a look at the test case description: https://gcc.gnu.org/wiki/HowToPrepareATestcase and see if you can do one of the following: - Modify the regex expression in the scan-assembler to accept either format of generated output or - Add { dg-option } directives to tur

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Hi Andrew -- Good work. Please submit your updated patch. Check that you follow GNU coding standards. Also make sure that the new options are documented in gcc/doc/invoke.texi. On 03/18/18 03:27, Andrew Sadek wrote: Hello Michael, I have run the test using the new PIC options. Actually, I h

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Hello Michael, I have run the test using the new PIC options. Actually, I have discovered 2 unhandled cases in 'microblaze_expand_move' + missing conditions in linker relax leading some test cases execution to fail. After fixing them, I made a re-run for the whole regression, and the results analo

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On 03/13/18 00:56, Andrew Sadek wrote: Ok, so you mean with '-fPIC -mpic-data-text-relative' as I do in my test case ? If all is Ok, execution and compilation shall ideally pass for the test cases. Correct. I want to make sure of two things: -- Your patch doesn't break anything (i.e., cause

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Ok, so you mean with '-fPIC -mpic-data-text-relative' as I do in my test case ? If all is Ok, execution and compilation shall ideally pass for the test cases. But I have noticed that there are some output pattern checks done in some test cases and this may fail since the output assembly is differen

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On 03/12/18 23:10, Andrew Sadek wrote: _Command for running testsuite:_ /make -k check-gcc RUNTESTFLAGS="-v --target_board=microblaze-qemu CFLAGS_FOR_TARGET='-include /home/andrew/qemu/common.h -L/home/andrew/qemu/lib -Wl,--start-group,-lxil,-lgcc,-lc,--end-group -mlittle-endian' "/ _Quick

Re: [PATCH] [Microblaze]: PIC Data Text Relative

*Command for running testsuite:* *make -k check-gcc RUNTESTFLAGS="-v --target_board=microblaze-qemu CFLAGS_FOR_TARGET='-include /home/andrew/qemu/common.h -L/home/andrew/qemu/lib -Wl,--start-group,-lxil,-lgcc,-lc,--end-group -mlittle-endian' "* *Quick Details:* 1) common.h: Here I define 'STACK_S

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On 03/12/18 06:19, Andrew Sadek wrote: On Mon, Mar 5, 2018 at 9:21 PM, Michael Eager > wrote: On 03/02/2018 08:12 AM, Andrew Sadek wrote: Hello Michael, I tried running the whole GCC test suite on the current head (without my patch) along

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On Mon, Mar 5, 2018 at 9:21 PM, Michael Eager wrote: > On 03/02/2018 08:12 AM, Andrew Sadek wrote: > >> Hello Michael, >> >> I tried running the whole GCC test suite on the current head (without my >> patch) along with 'microblaze-qemu' but I have the following problems: >> >> 1) The test is hang

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On 03/02/2018 08:12 AM, Andrew Sadek wrote: Hello Michael, I tried running the whole GCC test suite on the current head (without my patch) along with 'microblaze-qemu' but I have the following problems: 1) The test is hanging at 'gcc.c-torture/string-large-1.c' , the gcc is making a 100% CPU

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Hello Michael, I tried running the whole GCC test suite on the current head (without my patch) along with 'microblaze-qemu' but I have the following problems: 1) The test is hanging at 'gcc.c-torture/string-large-1.c' , the gcc is making a 100% CPU usage and the machine stucks. I tried compiling

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Thanks Micheal for your response. I shall re-submit patches separately after re-running the whole GCC Test suite and re-checking code conventions. For sending to gdb-patches, it was a conflict from my side as actually I thought it is also for binutils. On Tue, Feb 27, 2018 at 2:07 AM, Michael Eage

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On 02/25/2018 11:44 PM, Andrew Guirguis wrote: Dears, Kindly find attached the patch bundle for Microblaze '-mpic-data-text-relative' feature. Description of the feature in the following link: https://github.com/andrewsadek/microblaze-pic-data-text-rel/blob/pic_data_text_rel/README.md

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Change logs below. There is a problem in attaching the bundle. I get permanent error from sourceware.org GCC ChangeLog: Microblaze Target: PIC data text relative * gcc/config/microblaze/microblaze.opt: add new option -mpic-data-text-rel. * gcc/config/microblaze/microblaze-protos.h (microblaze_con

[PATCH] [Microblaze]: PIC Data Text Relative

Dears, Kindly find the patch bundle for Microblaze '-mpic-data-text-relative' feature at the following link: https://github.com/andrewsadek/microblaze-pic-data-text-rel/tree/pic_data_text_rel/PATCH%20BUNDLE Description of the feature: https://github.com/andrewsadek/microblaze-pic-data-text-rel/