Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-17 Thread Jeff Law
On 06/12/14 08:34, Christian Bruel wrote: On 06/11/2014 02:00 PM, Christian Bruel wrote: >On 06/11/2014 06:17 AM, Joern Rennecke wrote: Joern, is this new target macro interface OK with you ? >>Yes, this interface should allow me to do switches between rounding >>and truncating >>floating-

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-12 Thread Christian Bruel
On 06/11/2014 02:00 PM, Christian Bruel wrote: > On 06/11/2014 06:17 AM, Joern Rennecke wrote: Joern, is this new target macro interface OK with you ? >> Yes, this interface should allow me to do switches between rounding >> and truncating >> floating-point modes with an add/subtract immediate

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-11 Thread Oleg Endo
On 11 Jun 2014, at 14:40, Christian Bruel wrote: > > On 06/10/2014 04:03 PM, Joern Rennecke wrote: >> On 13 May 2014 22:41, Oleg Endo wrote: >> >>> Right. I was thinking to add FPSCR.SZ mode switching to SH, in order to >>> do float vector moves. For that SZ and PR need to be switched both

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-11 Thread Christian Bruel
On 06/10/2014 04:03 PM, Joern Rennecke wrote: > On 13 May 2014 22:41, Oleg Endo wrote: > >> Right. I was thinking to add FPSCR.SZ mode switching to SH, in order to >> do float vector moves. For that SZ and PR need to be switched both at >> the same time (only SH4A has both, fpchg and fschg). S

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-11 Thread Christian Bruel
On 06/11/2014 06:17 AM, Joern Rennecke wrote: > >>> Joern, is this new target macro interface OK with you ? > Yes, this interface should allow me to do switches between rounding > and truncating > floating-point modes with an add/subtract immediate. > > However, the implentation, as posted, doesn'

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-10 Thread Joern Rennecke
On 2 June 2014 13:34, Christian Bruel wrote: > Hello, > > Any feedback for this ? I'd like to commit only when OK for Epiphany. >> Joern, is this new target macro interface OK with you ? Yes, this interface should allow me to do switches between rounding and truncating floating-point modes with

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-10 Thread Joern Rennecke
On 13 May 2014 22:41, Oleg Endo wrote: > Right. I was thinking to add FPSCR.SZ mode switching to SH, in order to > do float vector moves. For that SZ and PR need to be switched both at > the same time (only SH4A has both, fpchg and fschg). So basically I'd > add another mode entity, which woul

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-02 Thread Christian Bruel
Hello, Any feedback for this ? I'd like to commit only when OK for Epiphany. many thanks, Christian On 05/26/2014 05:32 PM, Christian Bruel wrote: >> On 04/28/2014 10:08 AM, Christian Bruel wrote: >> Hello, >> >> I'd like to ping the following patches >> >> [Hookize mode-swi

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-26 Thread Christian Bruel
> On 04/28/2014 10:08 AM, Christian Bruel wrote: > Hello, > > I'd like to ping the following patches > > [Hookize mode-switching] > http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01003.html > > [Add new hooks to support toggle and SH4A fpchg instruction] > http://

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-13 Thread Oleg Endo
On Tue, 2014-05-13 at 09:10 +0100, Joern Rennecke wrote: > On 12 May 2014 23:39, Oleg Endo wrote: > > > This is the same as changing/setting the FP modes (PR, SZ) on SH while > > preserving the other FPSCR bits, or did I miss something? > > It's more like if you have to control multiple bits at

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-13 Thread Joern Rennecke
On 12 May 2014 23:39, Oleg Endo wrote: > This is the same as changing/setting the FP modes (PR, SZ) on SH while > preserving the other FPSCR bits, or did I miss something? It's more like if you have to control multiple bits at once to get a specific mode. Say you have to turn SZ off and PR on.

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Oleg Endo
On Mon, 2014-05-12 at 13:51 +0100, Joern Rennecke wrote: > On 12 May 2014 13:16, Christian Bruel wrote: > > > Just for my curiosity, which other targets have multi-way toggling > > support ? > > The epiphany has, sort of: you read a control register, AND and/or OR > some mask(s) to the value, >

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Oleg Endo
On Mon, 2014-05-12 at 19:32 +0900, Kaz Kojima wrote: > [I'd like to add Oleg to CC list.] > > Christian Bruel wrote: > > Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers > > > > remains the target maintainers. Joern, Kaz ? > > SH specific part looks OK to me. Oleg,

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Joern Rennecke
On 12 May 2014 13:51, Joern Rennecke wrote: > On 12 May 2014 13:16, Christian Bruel wrote: > >> Just for my curiosity, which other targets have multi-way toggling >> support ? > > The epiphany has, sort of: you read a control register, AND and/or OR > some mask(s) to the value, > and write it bac

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Joern Rennecke
On 12 May 2014 13:16, Christian Bruel wrote: > Just for my curiosity, which other targets have multi-way toggling > support ? The epiphany has, sort of: you read a control register, AND and/or OR some mask(s) to the value, and write it back. If we knew the previous mode, we might elide and AND o

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
On 04/28/2014 10:08 AM, Christian Bruel wrote: Hello, I'd like to ping the following patches [Hookize mode-switching] http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01003.html [Add new hooks to support toggle and SH4A fpchg instruction] http://gcc.gnu.org/

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Joern Rennecke
On 12 May 2014 10:06, Christian Bruel wrote: > Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers > > remains the target maintainers. Joern, Kaz ? > > Many thanks. > > Christian > > On 05/12/2014 10:44 AM, Christian Bruel wrote: >> Hello, >> >> I'd still wish to ping for

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Kaz Kojima
[I'd like to add Oleg to CC list.] Christian Bruel wrote: > Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers > > remains the target maintainers. Joern, Kaz ? SH specific part looks OK to me. Oleg, could you comment on the patch? Regards, kaz

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers remains the target maintainers. Joern, Kaz ? Many thanks. Christian On 05/12/2014 10:44 AM, Christian Bruel wrote: > Hello, > > I'd still wish to ping for the following set of patches. Those changes > does not impact

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
Hello, I'd still wish to ping for the following set of patches. Those changes does not impact other targets than SH4 but, as suggested by Joern, I have hooked the macros and moved the SH4A specific support to the target parts (so a different target can eventually implement other models than dual m

Re: [ PATCH] Extend mode-switching to support toggle (1/2)

2014-05-09 Thread Jeff Law
On 04/17/14 07:58, Christian Bruel wrote: Hello, He is a new version of the patch. It hookizes the mode-setting and mode-toggling macros. Split in 2 parts. Successfully bootstrapped/regtested on ix86 and SH4/SH4a. I was able to do a limited build on Epiphany, if someone could give it a try on

[PING][PATCH] Extend mode-switching to support toggle (1/2)

2014-04-28 Thread Christian Bruel
Hello, I'd like to ping the following patches [Hookize mode-switching] http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01003.html [Add new hooks to support toggle and SH4A fpchg instruction] http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01005.html Many thanks

[ PATCH] Extend mode-switching to support toggle (2/2)

2014-04-17 Thread Christian Bruel
and the toggle-support hookized many thanks, Christian 2014-04-02 Christian Bruel * target.def (mode_switching): New hook vector. (toggle_init, toggle_destroy, toggle_set, toggle_test): New mode toggle hooks. * targhooks.h (default_toggle_test): Declare. * basic-block.h (pre_edge_

[ PATCH] Extend mode-switching to support toggle (1/2)

2014-04-17 Thread Christian Bruel
Hello, He is a new version of the patch. It hookizes the mode-setting and mode-toggling macros. Split in 2 parts. Successfully bootstrapped/regtested on ix86 and SH4/SH4a. I was able to do a limited build on Epiphany, if someone could give it a try on it that would be great. comments ? suggesti

Re: [PING PATCH] Extend mode-switching to support toggle

2014-04-15 Thread Christian Bruel
On 04/15/2014 01:13 PM, Joern Rennecke wrote: > On 15 April 2014 10:20, Christian Bruel wrote: >> Hello, >> >> I guess it's for RTL maintainers. Also interested by mode-switching.c >> last contributors (from past ChangeLog entries) comments, >> >> http://gcc.gnu.org/ml/gcc-patches/2014-04/msg0019

[PING PATCH] Extend mode-switching to support toggle

2014-04-15 Thread Christian Bruel
Hello, I guess it's for RTL maintainers. Also interested by mode-switching.c last contributors (from past ChangeLog entries) comments, http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00196.html Many thanks Christian,

[PATCH] Extend mode-switching to support toggle

2014-04-04 Thread Christian Bruel
Respin of a long standing forgotten patch (http://gcc.gnu.org/ml/gcc-patches/2006-12/msg01562.html). This patch extends the mode-switching pass to toggle on/off a control register status bit instead of setting the value. e.g on the SH4a to support the FPCHG instruction used to switch FPU precision