Re: [PATCH] Fix PR gcov-profile/46266

2016-09-27 Thread Martin Liška
On 09/27/2016 03:05 PM, Richard Biener wrote: > On Tue, Sep 27, 2016 at 2:57 PM, Nathan Sidwell wrote: >> On 09/27/16 08:46, Martin Liška wrote: >> Second version of the patch adds validation to gcov.exp, where $result is scanned for "File ''". Luckily current test-case hit that ver

Re: [PATCH] Fix PR gcov-profile/46266

2016-09-27 Thread Richard Biener
On Tue, Sep 27, 2016 at 2:57 PM, Nathan Sidwell wrote: > On 09/27/16 08:46, Martin Liška wrote: > >>> Second version of the patch adds validation to gcov.exp, where $result is >>> scanned for "File ''". >>> Luckily current test-case hit that verification: >>> >>> FAIL: gcc.misc-tests/gcov-6.c gcov

Re: [PATCH] Fix PR gcov-profile/46266

2016-09-27 Thread Nathan Sidwell
On 09/27/16 08:46, Martin Liška wrote: Second version of the patch adds validation to gcov.exp, where $result is scanned for "File ''". Luckily current test-case hit that verification: FAIL: gcc.misc-tests/gcov-6.c gcov failed: .gcov should not be created FAIL: gcc.misc-tests/gcov-7.c gcov fai

Re: [PATCH] Fix PR gcov-profile/46266

2016-09-27 Thread Martin Liška
_reserved_location (gs)) >> to be more understandable (particularly as that matches the sense of >> RESERVED_LOCATION_P. > > Agree with you, renamed to gimple_has_reserved_location. > Ready with that change? > > Martin > >> >> Richard? >> >

Re: [PATCH] Fix PR gcov-profile/46266

2016-09-27 Thread Martin Liška
On 09/27/2016 01:32 PM, Nathan Sidwell wrote: > On 09/27/16 07:26, Martin Liška wrote: >> Following patch prevents emission of gcno file (notes file) for statements >> that do not point to original source file, like: >> >> $ echo "int main(){}" > x.c >> >> In this case the location points to a buil

Re: [PATCH] Fix PR gcov-profile/46266

2016-09-27 Thread Nathan Sidwell
On 09/27/16 07:26, Martin Liška wrote: Following patch prevents emission of gcno file (notes file) for statements that do not point to original source file, like: $ echo "int main(){}" > x.c In this case the location points to a builtin. Patch can bootstrap on x86_64-linux-gnu and survives reg

[PATCH] Fix PR gcov-profile/46266

2016-09-27 Thread Martin Liška
be installed? Martin >From 0b33d288ecad252d00ef22fd72a1b1f12c0642ff Mon Sep 17 00:00:00 2001 From: marxin Date: Mon, 8 Aug 2016 17:38:07 +0200 Subject: [PATCH] Fix PR gcov-profile/46266 gcc/ChangeLog: 2016-08-12 Martin Liska PR gcov-profile/46266 * gimple.h (gimple_has_not_reserved_locatio