Re: [PATCH] Fix algo constexpr tests in Debug mode

2019-10-23 Thread Jonathan Wakely
On 28/09/19 23:12 +0200, François Dumont wrote: Here is what I just commited. I try to use the asm trick in the _GLIBCXX_DEBUG_VERIFY_COND_AT but didn't notice any enhancement. So for now I kept my solution to just have a non-constexpr call compiler error. I fix my patch to use

Re: [PATCH] Fix algo constexpr tests in Debug mode

2019-10-01 Thread Jonathan Wakely
On 30/09/19 22:21 +0200, François Dumont wrote: On 9/30/19 11:03 AM, Jonathan Wakely wrote: These changes are fine but should have been a separate, unrelated commit. Ok, sorry, I consider that just a comment change was fine. It's fine, but it is unrelated so should be a separate commit.

Re: [PATCH] Fix algo constexpr tests in Debug mode

2019-09-30 Thread François Dumont
On 9/30/19 11:03 AM, Jonathan Wakely wrote: On 28/09/19 23:12 +0200, François Dumont wrote: Here is what I just commited. Thanks. In my branch I had a lot more _GLIBCXX20_CONSTEXPR additions in the debug mode headers. Is it not needed on __check_singular, __foreign_iterator etc. ? Yes, I

Re: [PATCH] Fix algo constexpr tests in Debug mode

2019-09-30 Thread Jonathan Wakely
On 28/09/19 23:12 +0200, François Dumont wrote: Here is what I just commited. Thanks. In my branch I had a lot more _GLIBCXX20_CONSTEXPR additions in the debug mode headers. Is it not needed on __check_singular, __foreign_iterator etc. ? I try to use the asm trick in the

[PATCH] Fix algo constexpr tests in Debug mode

2019-09-28 Thread François Dumont
Here is what I just commited. I try to use the asm trick in the _GLIBCXX_DEBUG_VERIFY_COND_AT but didn't notice any enhancement. So for now I kept my solution to just have a non-constexpr call compiler error. I fix my patch to use __builtin_is_constant_evaluated rather than