Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-24 Thread Kirill Yukhin
> Can you please split the patch to three independent parts, prefetchw > handling, rdseed and adxx. I got lost in the patch the second time. Sure! > I propose we start with prefetch. You are still changing prefetch > patterns, while it should be enough to only change prefetch expander. Actually, t

Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-24 Thread Uros Bizjak
On Tue, Jul 24, 2012 at 2:09 PM, Kirill Yukhin wrote: > Uros, Jakub, thanks fr the inputs! > > I've refactored the patch appliying (hopefully) all of your inputs. > > It is attached. Can you please split the patch to three independent parts, prefetchw handling, rdseed and adxx. I got lost in the

Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-19 Thread Uros Bizjak
On Thu, Jul 19, 2012 at 11:51 AM, Jakub Jelinek wrote: > I think it is fine to change existing mm3dnow.h header, but not in the way > it has been changed in the patch. The thing is that unlike the newly added > intrinsics headers, mm3dnow.h is still publicly includable header, and just > includi

Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-19 Thread Uros Bizjak
On Thu, Jul 19, 2012 at 11:51 AM, Jakub Jelinek wrote: >> >> You have a mnemonic clash here. prefetchw is not good name for a new >> >> instruction, it clashes with existing 3dnow name. Intel will need to >> >> fix the spec, you probably won't be able to change prefetchw encoding >> >> in binutil

Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-19 Thread Jakub Jelinek
On Thu, Jul 19, 2012 at 11:23:09AM +0200, Uros Bizjak wrote: > >> You have a mnemonic clash here. prefetchw is not good name for a new > >> instruction, it clashes with existing 3dnow name. Intel will need to > >> fix the spec, you probably won't be able to change prefetchw encoding > >> in binutil

Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-19 Thread Kirill Yukhin
> - else > -return "prefetchw\t%a0"; > -} > + "prefetch\t%a0" > > You have a mnemonic clash here. prefetchw is not good name for a new > instruction, it clashes with existing 3dnow name. Intel will need to > fix the spec, you probably won't be able to change prefetchw encoding > in binutils.

Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-19 Thread Uros Bizjak
On Thu, Jul 19, 2012 at 11:10 AM, Jakub Jelinek wrote: > On Thu, Jul 19, 2012 at 11:03:25AM +0200, Uros Bizjak wrote: >> + /* Set CF to specified value. */ >> + emit_insn (gen_addqi3_cc( >> + gen_reg_rtx(QImode), >> + op1, >> + constm1_rtx)); >>

Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-19 Thread Jakub Jelinek
On Thu, Jul 19, 2012 at 11:03:25AM +0200, Uros Bizjak wrote: > + /* Set CF to specified value. */ > + emit_insn (gen_addqi3_cc( > + gen_reg_rtx(QImode), > + op1, > + constm1_rtx)); > + > > This should be in the *.md expander. Note also that the

Re: [PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-19 Thread Uros Bizjak
Hello! > This patch adds new intrinsics for new ADCX, ADOX, RDSEED and > PREFETCHW instructions, introduced here: > http://software.intel.com/en-us/avx/ +/* Copyright (C) 2012 Free Software Foundation, Inc. + Contributed by Michael Zolotukhin. Please remove "Contributed by" lines from headers.

[PATCH] Intrinsics for ADCX, ADOX, RDSEED and PREFETCHW

2012-07-18 Thread Michael Zolotukhin
Hi, This patch adds new intrinsics for new ADCX, ADOX, RDSEED and PREFETCHW instructions, introduced here: http://software.intel.com/en-us/avx/ Bootstrapped on x86-64, testing is in progress. Is it ok for trunk? Changelog entry: 2012-07-17 Michael Zolotukhin * common/config/i386/i386