Re: [PATCH] Make std::enable_shared_from_this cope with ambiguity

2016-12-12 Thread Jonathan Wakely
On 19/10/16 21:13 +0100, Jonathan Wakely wrote: This patch does three things: 1. Refactor std::enable_shared_from_this support code. Instead of several overloads of __enable_shared_from_this_helper that contain the same code but operating on slightly different types I've split it into two parts

Re: [PATCH] Make std::enable_shared_from_this cope with ambiguity

2016-10-20 Thread Jonathan Wakely
On 19/10/16 21:13 +0100, Jonathan Wakely wrote: The standard says we have to enable shared_from_this for types with an accessible and unambiguous std::enable_shared_from_this base class, and we should be able to do that even if the class also has an experimental::enable_shared_from_this base clas

Re: [PATCH] Make std::enable_shared_from_this cope with ambiguity

2016-10-19 Thread Jonathan Wakely
On 19/10/16 21:13 +0100, Jonathan Wakely wrote: This patch does three things: 1. Refactor std::enable_shared_from_this support code. Instead of several overloads of __enable_shared_from_this_helper that contain the same code but operating on slightly different types I've split it into two parts

[PATCH] Make std::enable_shared_from_this cope with ambiguity

2016-10-19 Thread Jonathan Wakely
This patch does three things: 1. Refactor std::enable_shared_from_this support code. Instead of several overloads of __enable_shared_from_this_helper that contain the same code but operating on slightly different types I've split it into two parts. Upcasting to an accessible+unambiguous enab