Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-31 Thread Richard Biener
On May 31, 2018 12:42:39 AM GMT+02:00, Jeff Law wrote: >On 05/30/2018 03:37 AM, Richard Biener wrote: >> On Tue, May 29, 2018 at 4:58 PM Martin Sebor >wrote: >> >>> On 05/28/2018 03:11 AM, Richard Biener wrote: On Fri, May 25, 2018 at 10:15 PM Martin Sebor >wrote: > Attached is

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-30 Thread Jeff Law
On 05/30/2018 03:37 AM, Richard Biener wrote: > On Tue, May 29, 2018 at 4:58 PM Martin Sebor wrote: > >> On 05/28/2018 03:11 AM, Richard Biener wrote: >>> On Fri, May 25, 2018 at 10:15 PM Martin Sebor wrote: >>> Attached is revision 3 of the patch incorporating your

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-30 Thread Richard Biener
On Tue, May 29, 2018 at 4:58 PM Martin Sebor wrote: > On 05/28/2018 03:11 AM, Richard Biener wrote: > > On Fri, May 25, 2018 at 10:15 PM Martin Sebor wrote: > > > >> Attached is revision 3 of the patch incorporating your > >> determine_value_range function with the requested changes. > > > >

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-29 Thread Martin Sebor
I do want to follow up on the optimization you referred to above. After thinking about it some more I don't see what benefit it could provide. The value of the bound expression (LEN) ends up computed at the call site and stored in a register that the library strncmp has to read. I can't think

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-29 Thread Martin Sebor
On 05/28/2018 03:11 AM, Richard Biener wrote: On Fri, May 25, 2018 at 10:15 PM Martin Sebor wrote: Attached is revision 3 of the patch incorporating your determine_value_range function with the requested changes. I'm somewhat torn about removing the "basic" interface on SSA names so can you

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-28 Thread Richard Biener
On Fri, May 25, 2018 at 10:15 PM Martin Sebor wrote: > Attached is revision 3 of the patch incorporating your > determine_value_range function with the requested changes. I'm somewhat torn about removing the "basic" interface on SSA names so can you please not change

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-25 Thread Martin Sebor
Attached is revision 3 of the patch incorporating your determine_value_range function with the requested changes. Martin PR testsuite/85888 - New test case c-c++-common/attr-nonstring-6.c from r260541 fails with excess errors gcc/ChangeLog: PR testsuite/85888 * builtins.c

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-25 Thread Martin Sebor
On 05/25/2018 11:51 AM, Richard Biener wrote: On May 25, 2018 7:31:43 PM GMT+02:00, Martin Sebor wrote: On 05/25/2018 01:02 AM, Richard Biener wrote: On Thu, May 24, 2018 at 11:22 PM Martin Sebor wrote: On 05/24/2018 11:15 AM, Richard Biener wrote: On

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-25 Thread Richard Biener
On May 25, 2018 7:31:43 PM GMT+02:00, Martin Sebor wrote: >On 05/25/2018 01:02 AM, Richard Biener wrote: >> On Thu, May 24, 2018 at 11:22 PM Martin Sebor >wrote: >> >>> On 05/24/2018 11:15 AM, Richard Biener wrote: On May 24, 2018 7:02:17 PM GMT+02:00,

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-25 Thread Martin Sebor
On 05/25/2018 01:02 AM, Richard Biener wrote: On Thu, May 24, 2018 at 11:22 PM Martin Sebor wrote: On 05/24/2018 11:15 AM, Richard Biener wrote: On May 24, 2018 7:02:17 PM GMT+02:00, Martin Sebor wrote: On 05/24/2018 03:39 AM, Richard Biener wrote: On

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-25 Thread Richard Biener
On Thu, May 24, 2018 at 11:22 PM Martin Sebor wrote: > On 05/24/2018 11:15 AM, Richard Biener wrote: > > On May 24, 2018 7:02:17 PM GMT+02:00, Martin Sebor wrote: > >> On 05/24/2018 03:39 AM, Richard Biener wrote: > >>> On Thu, May 24, 2018 at 12:50 AM Martin

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-24 Thread Martin Sebor
On 05/24/2018 11:15 AM, Richard Biener wrote: On May 24, 2018 7:02:17 PM GMT+02:00, Martin Sebor wrote: On 05/24/2018 03:39 AM, Richard Biener wrote: On Thu, May 24, 2018 at 12:50 AM Martin Sebor wrote: The attached patch enhances the get_size_range()

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-24 Thread Richard Biener
On May 24, 2018 7:02:17 PM GMT+02:00, Martin Sebor wrote: >On 05/24/2018 03:39 AM, Richard Biener wrote: >> On Thu, May 24, 2018 at 12:50 AM Martin Sebor >wrote: >> >>> The attached patch enhances the get_size_range() function to >>> extract more accurate

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-24 Thread Martin Sebor
On 05/24/2018 03:39 AM, Richard Biener wrote: On Thu, May 24, 2018 at 12:50 AM Martin Sebor wrote: The attached patch enhances the get_size_range() function to extract more accurate ranges out of MIN_EXPR and MAX_EXPR nodes with SSA_NAME operand(s). This helps

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-24 Thread Richard Biener
On Thu, May 24, 2018 at 12:50 AM Martin Sebor wrote: > The attached patch enhances the get_size_range() function to > extract more accurate ranges out of MIN_EXPR and MAX_EXPR nodes > with SSA_NAME operand(s). This helps -Wstringop-overflow avoid > false positives on some

[PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-23 Thread Martin Sebor
The attached patch enhances the get_size_range() function to extract more accurate ranges out of MIN_EXPR and MAX_EXPR nodes with SSA_NAME operand(s). This helps -Wstringop-overflow avoid false positives on some targets in cases like some of those reported in bug 85623 - strncmp() warns about