Re: [PATCH]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-14 Thread Andrea Corallo
Kyrylo Tkachov writes: > - if (!REG_P (addr.base)) > + if (addr.type == ADDRESS_SYMBOLIC || !REG_P (addr.base)) > return false; > > Hmm, given that the code below only handles the ADDRESS_REG_* forms, how > about we get defensive here and check that addr.type is not one of >

RE: [PATCH]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-14 Thread Kyrylo Tkachov
Hi Andrea, > -Original Message- > From: Andrea Corallo > Sent: 14 April 2020 11:01 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; nd ; > Christophe Lyon > Subject: [PATCH]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for > use of uniniti

[PATCH]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-14 Thread Andrea Corallo
Hi all, Testing the backport of pr94530 fix (af19e4d0e23e) to GCC 9 I realized this is not entirely correct. aarch64_classify_address sets the base field of struct aarch64_address_info for all aarch64_address_type with the exception of ADDRESS_SYMBOLIC. In this case we would access an