[PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB

2020-12-01 Thread Kito Cheng
Use TARGET_COMPUTE_MULTILIB to search the multi-lib reuse for riscv*-*-elf*, according following rules: 1. Check ABI is same. 2. Check both has atomic extension or both don't have atomic extension. - Because mix soft and hard atomic operation doesn't make sense and won't work as expect

[PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB

2021-07-21 Thread Kito Cheng
Use TARGET_COMPUTE_MULTILIB to search the multi-lib reuse for riscv*-*-elf*, according following rules: 1. Check ABI is same. 2. Check both has atomic extension or both don't have atomic extension. - Because mix soft and hard atomic operation doesn't make sense and won't work as expect

Re: [PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB

2022-09-09 Thread Andreas Schwab
How did you test that? ../../gcc/common/config/riscv/riscv-common.cc: In function 'const char* riscv_multi_lib_check(int, const char**)': ../../gcc/common/config/riscv/riscv-common.cc:1451:11: error: bare apostrophe ''' in format [-Werror=format-diag] 1451 | "Can't find suitable multilib

Re: [PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB

2022-09-09 Thread Kito Cheng via Gcc-patches
Hi Andreas: Hm, I should change my default gcc on Ubuntu, I didn't got this when build with GCC 7, and can be reproduced by GCC 11, Will summit patch once I test done. On Fri, Sep 9, 2022 at 3:21 PM Andreas Schwab wrote: > > How did you test that? > > ../../gcc/common/config/riscv/riscv-com

Re: [PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB

2021-08-31 Thread Jim Wilson
On Wed, Jul 21, 2021 at 2:28 AM Kito Cheng wrote: > Use TARGET_COMPUTE_MULTILIB to search the multi-lib reuse for > riscv*-*-elf*, > according following rules: > I find the other_cond support a bit confusing. Is this for -mcmodel perhaps? Why not just say that if so? match_score: weigth -> we

Re: [PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB

2021-08-31 Thread Jim Wilson
On Tue, Aug 31, 2021 at 5:22 PM Jim Wilson wrote: > On Wed, Jul 21, 2021 at 2:28 AM Kito Cheng wrote: > >> Use TARGET_COMPUTE_MULTILIB to search the multi-lib reuse for >> riscv*-*-elf*, >> according following rules: >> > > I find the other_cond support a bit confusing. Is this for -mcmodel > p

Re: [PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB

2021-09-15 Thread Kito Cheng via Gcc-patches
> I find the other_cond support a bit confusing. Is this for -mcmodel > perhaps? Why not just say that if so? I suppose we might have other multilib options other than -march, -mabi and -mcmodel, so I keep the flexibility here. > riscv_multi_lib_info_t::parse > Calls riscv_subset_list::parse tw