Re: [PATCH 2/3] rs6000: Add MMA built-in function definitions

2020-06-16 Thread Peter Bergner via Gcc-patches
On 6/16/20 3:30 PM, Segher Boessenkool wrote: > We have had before > > * config/rs6000/rs6000.md (define_attr "type"): New type popcnt. > > and > > * config/rs6000/rs6000.md ('type' attribute): Add > veclogical,veccmpfx,vecexts,vecmove insn types. > > (Both are fine,

Re: [PATCH 2/3] rs6000: Add MMA built-in function definitions

2020-06-16 Thread Segher Boessenkool
Hi! On Tue, Jun 16, 2020 at 02:02:36PM -0500, Peter Bergner wrote: > On 6/15/20 5:43 PM, will schmidt wrote: > >>* config/rs6000/rs6000.md ('type' attribute): Add mma type. > > > > (mma) : New 'type' attribute. > > I just copied what someone else did, but agree this is more readable. > Will

Re: [PATCH 2/3] rs6000: Add MMA built-in function definitions

2020-06-16 Thread Peter Bergner via Gcc-patches
On 6/15/20 5:43 PM, will schmidt wrote: > checked noses, all have been found below. Thanks for verifying! >> * config/rs6000/rs6000.md ('type' attribute): Add mma type. > > (mma) : New 'type' attribute. I just copied what someone else did, but agree this is more readable. Will change.

Re: [PATCH 2/3] rs6000: Add MMA built-in function definitions

2020-06-15 Thread will schmidt via Gcc-patches
On Mon, 2020-06-15 at 14:58 -0500, Peter Bergner via Gcc-patches wrote: > This patches adds the actual MMA built-ins. The MMA accumulators are > INOUT > operands for most MMA instructions, but they are also very expensive > to > move around. For this reason, we have implemented a built-in API >

[PATCH 2/3] rs6000: Add MMA built-in function definitions

2020-06-15 Thread Peter Bergner via Gcc-patches
This patches adds the actual MMA built-ins. The MMA accumulators are INOUT operands for most MMA instructions, but they are also very expensive to move around. For this reason, we have implemented a built-in API where the accumulators are passed using pass-by-reference/pointers, so the user