On 6/16/20 3:30 PM, Segher Boessenkool wrote:
> We have had before
>
> * config/rs6000/rs6000.md (define_attr "type"): New type popcnt.
>
> and
>
> * config/rs6000/rs6000.md ('type' attribute): Add
> veclogical,veccmpfx,vecexts,vecmove insn types.
>
> (Both are fine, double quotes is a teeny bit better). The thing that
> is changed is not named "mma", it is named "type".
>
> "New value "mma"." or similar, maybe. The important thing is that what
> is in () is the thing that is modified, and that you mention the exact
> name of the value added (spelled in full).
You are right, "mma" was not that thing that was modified.
Yeah, I like: (define_attr "type"): New type mma.
better too.
Peter
