Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-29 Thread Tom de Vries
Hi, this ( r257065 ) caused: PR84088 - "[nvptx] libgomp.oacc-fortran/declare-*.f90 execution fails" ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84088 ). Thanks, - Tom On 01/24/2018 10:05 AM, Paul Richard Thomas wrote: Hi Jakub, The lateness is indeed embarrassing but couldn't be helped.

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-24 Thread Paul Richard Thomas
Hi Jakub, The lateness is indeed embarrassing but couldn't be helped. > Given above my preference would be to keep version an int, and > change rank and type to signed char and attribute to signed short. > That way there will be no padding on either 32-bit or 64-bit targets, > and the structure w

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-24 Thread Jakub Jelinek
On Wed, Jan 24, 2018 at 10:30:41AM +0200, Janne Blomqvist wrote: > On Tue, Jan 23, 2018 at 10:30 PM, Jakub Jelinek wrote: > > On Tue, Jan 23, 2018 at 07:30:49PM +, Paul Richard Thomas wrote: > >> Janne, Thanks. > >> > >> Jakub, is this OK with you? > > > > It is indeed quite late for such larg

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-24 Thread Janne Blomqvist
On Tue, Jan 23, 2018 at 10:30 PM, Jakub Jelinek wrote: > On Tue, Jan 23, 2018 at 07:30:49PM +, Paul Richard Thomas wrote: >> Janne, Thanks. >> >> Jakub, is this OK with you? > > It is indeed quite late for such large ABI changes, some distributions are > about to start using the compiler by no

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-23 Thread Jakub Jelinek
On Tue, Jan 23, 2018 at 07:30:49PM +, Paul Richard Thomas wrote: > Janne, Thanks. > > Jakub, is this OK with you? It is indeed quite late for such large ABI changes, some distributions are about to start using the compiler by now. How much was it tested (on which targets)? Has the debug inf

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-23 Thread Paul Richard Thomas
Janne, Thanks. Jakub, is this OK with you? Paul On 23 January 2018 at 19:09, Janne Blomqvist wrote: > On Mon, Jan 22, 2018 at 9:12 PM, Paul Richard Thomas > wrote: >> This patch has been triggered by Thomas's recent message to the list. >> Not only did I start work late relative to stage 3 but

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-23 Thread Janne Blomqvist
On Mon, Jan 22, 2018 at 9:12 PM, Paul Richard Thomas wrote: > This patch has been triggered by Thomas's recent message to the list. > Not only did I start work late relative to stage 3 but debugging took > somewhat longer than anticipated. Therefore, to get this committed > asap, we will have to b

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-23 Thread Thomas Koenig
Hi Paul, Could somebody please review the patch? I'd say the patch is OK for trunk. I have also tested this on a big-endian system, and things worked. I will look at the resulting fallout of the GFC_DTYPE_TYPE_SIZE stuff. Thanks a lot for your work! Regards Thomas

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-23 Thread Thomas Koenig
Hi Jerry, Do you mean adding something like this: diff --git a/libgfortran/libgfortran.h b/libgfortran/libgfortran.h index 4c643b7e17b..c86e0b45e1d 100644 --- a/libgfortran/libgfortran.h +++ b/libgfortran/libgfortran.h @@ -600,6 +600,7 @@ typedef struct st_parameter_common GFC_INTEGER_4 lin

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-23 Thread Paul Richard Thomas
Could somebody please review the patch? Thanks Paul On 23 January 2018 at 06:13, Dominique d'Humières wrote: > Dear Paul, > > The test suite passed without new regression with both -m32 and -m64. > > Thanks for the work, > > Dominique -- "If you can't explain it simply, you don't understan

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-22 Thread Dominique d'Humières
Dear Paul, The test suite passed without new regression with both -m32 and -m64. Thanks for the work, Dominique

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-22 Thread Jerry DeLisle
On 01/22/2018 12:24 PM, Thomas Koenig wrote: > Am 22.01.2018 um 20:59 schrieb Janne Blomqvist: >> On Mon, Jan 22, 2018 at 9:12 PM, Paul Richard Thomas >> wrote: >>> This patch has been triggered by Thomas's recent message to the list. >>> Not only did I start work late relative to stage 3 but debu

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-22 Thread Steve Kargl
On Mon, Jan 22, 2018 at 09:59:41PM +0200, Janne Blomqvist wrote: > On Mon, Jan 22, 2018 at 9:12 PM, Paul Richard Thomas > wrote: > > This patch has been triggered by Thomas's recent message to the list. > > Not only did I start work late relative to stage 3 but debugging took > > somewhat longer t

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-22 Thread Thomas Koenig
Am 22.01.2018 um 20:59 schrieb Janne Blomqvist: On Mon, Jan 22, 2018 at 9:12 PM, Paul Richard Thomas wrote: This patch has been triggered by Thomas's recent message to the list. Not only did I start work late relative to stage 3 but debugging took somewhat longer than anticipated. Therefore, to

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-22 Thread Janne Blomqvist
On Mon, Jan 22, 2018 at 9:12 PM, Paul Richard Thomas wrote: > This patch has been triggered by Thomas's recent message to the list. > Not only did I start work late relative to stage 3 but debugging took > somewhat longer than anticipated. Therefore, to get this committed > asap, we will have to b

[Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-22 Thread Paul Richard Thomas
This patch has been triggered by Thomas's recent message to the list. Not only did I start work late relative to stage 3 but debugging took somewhat longer than anticipated. Therefore, to get this committed asap, we will have to beg the indulgence of the release managers and prompt review and/or te