Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-11 Thread Jason Merrill
OK, I've checked this in: commit 2425dc8daa33d8b5d15c803c9bf2f51f5e1915a0 Author: Jason Merrill ja...@redhat.com Date: Tue Oct 9 21:16:52 2012 -0400 * g++.dg/ext/visibility/pragma-override1.C: Fix target markup. * g++.dg/ext/visibility/pragma-override2.C: Fix target markup. diff

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-09 Thread Dominique Dhumieres
These tests are still failing on darwin. I think tha target { ! *-*-solaris2* } { ! *-*-darwin* } sould be replaced with target { ! { *-*-solaris2* *-*-darwin* } } Could someone with a darwin box handy make the appropriate change? I have never really understood the logic of the target

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-09 Thread Mike Stump
On Oct 9, 2012, at 6:48 AM, Dominique Dhumieres domi...@lps.ens.fr wrote: These tests are still failing on darwin. I think tha target { ! *-*-solaris2* } { ! *-*-darwin* } sould be replaced with target { ! { *-*-solaris2* *-*-darwin* } } Could someone with a darwin box handy make the

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-08 Thread Dominique Dhumieres
It appears that the patch should also special case the scan-assembler .internal.*Foo.methodEv tests in g++.dg/ext/visibility/pragma-override1.C and g++.dg/ext/visibility/pragma-override2.C on darwin as well... Done, thanks. Jason, These tests are still failing on darwin. I

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-08 Thread Jason Merrill
On 10/08/2012 08:28 AM, Dominique Dhumieres wrote: These tests are still failing on darwin. I think that target { ! *-*-solaris2* } { ! *-*-darwin* } sould be replaced with target { ! { *-*-solaris2* *-*-darwin* } } Could someone with a darwin box handy make the appropriate change? Thanks.

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-04 Thread Jack Howarth
On Wed, Oct 03, 2012 at 03:26:14PM -0700, Mike Stump wrote: On Oct 3, 2012, at 12:04 PM, Jason Merrill ja...@redhat.com wrote: This patch fixes a couple of Darwin issues I noticed with a cross-compiler: 1) Adds a couple of consts to avoid const-correctness errors. 2) Treats visibility

RFA: darwin PATCH to fix build, internal visibility

2012-10-03 Thread Jason Merrill
This patch fixes a couple of Darwin issues I noticed with a cross-compiler: 1) Adds a couple of consts to avoid const-correctness errors. 2) Treats visibility internal like hidden rather than like default. The documentation says that internal is hidden + processor-specific semantics, so

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-03 Thread Mike Stump
On Oct 3, 2012, at 12:04 PM, Jason Merrill ja...@redhat.com wrote: This patch fixes a couple of Darwin issues I noticed with a cross-compiler: 1) Adds a couple of consts to avoid const-correctness errors. 2) Treats visibility internal like hidden rather than like default. The documentation