RE: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-19 Thread qiaopeixin
Thanks. All the best, Peixin -Original Message- From: Richard Sandiford [mailto:richard.sandif...@arm.com] Sent: Wednesday, August 19, 2020 5:56 PM To: qiaopeixin Cc: Christophe Lyon ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH] AArch64: Add if condition in aarch64_function_value

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-19 Thread Richard Sandiford
qiaopeixin writes: > Hi Richard, > > Thanks for the example. > > I remove the whole line "& && TREE_PUBLIC (fndecl)" and passed > bootstrap and deja tests. I add your provided example under > /gcc.target/aarch64, and the patch is attached. Thanks, pushed to master. Richard

RE: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-19 Thread qiaopeixin
All the best, Peixin -Original Message- From: Richard Sandiford [mailto:richard.sandif...@arm.com] Sent: Wednesday, August 19, 2020 1:01 AM To: qiaopeixin Cc: Christophe Lyon ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479] qiaopeixin

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-18 Thread Richard Sandiford
qiaopeixin writes: > Hi Richard, > > Thanks for the review and explanation. > > The previous fix adding if condition of TARGET_FLOAT does crash glibc-2.29. > > I checked the past log of writing the function aarch64_init_cumulative_args, > and did not find the reason why Alan Lawrence added

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-18 Thread Christophe Lyon via Gcc-patches
Do you have any suggestions on this fix? > > All the best, > Peixin > > > -Original Message----- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Thursday, August 13, 2020 8:19 PM > To: Christophe Lyon > Cc: qiaopeixin ; gcc-patches@gcc.gnu.org >

RE: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-17 Thread qiaopeixin
Original Message- From: Richard Sandiford [mailto:richard.sandif...@arm.com] Sent: Thursday, August 13, 2020 8:19 PM To: Christophe Lyon Cc: qiaopeixin ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479] Christophe Lyon writes: > On Th

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-13 Thread Richard Sandiford
;> Sent: 2020年8月13日 0:25 >> To: qiaopeixin >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH] AArch64: Add if condition in aarch64_function_value >> [PR96479] >> >> qiaopeixin writes: >> > Hi, >> > >> > The test case vector-s

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-13 Thread Christophe Lyon via Gcc-patches
patches@gcc.gnu.org > Subject: Re: [PATCH] AArch64: Add if condition in aarch64_function_value > [PR96479] > > qiaopeixin writes: > > Hi, > > > > The test case vector-subscript-2.c in the gcc testsuit will report an ICE > > in the expand pass since '-mgeneral

RE: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-12 Thread qiaopeixin
Thanks for the review and commit. All the best, Peixin -Original Message- From: Richard Sandiford [mailto:richard.sandif...@arm.com] Sent: 2020年8月13日 0:25 To: qiaopeixin Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-12 Thread Richard Sandiford
qiaopeixin writes: > Hi, > > The test case vector-subscript-2.c in the gcc testsuit will report an ICE in > the expand pass since '-mgeneral-regs-only' is incompatible with the use of > V4SI mode. I propose to report the diagnostic information instead of ICE, and > the problem has been