Re: [PATCH] RISC-V: Expand VLMAX scalar move in reduction

2024-02-05 Thread Jeff Law
On 2/4/24 23:37, juzhe.zh...@rivai.ai wrote: I think it just trigger a latent bug that we didn't encounter. Hi, Robin. Would you mind give me preprocessed file to reproduce the issue ? I suspect it triggers latent bug in VSETVL PASS. So it looks like vsetvl has made a transformation that

Re: [PATCH] RISC-V: Expand VLMAX scalar move in reduction

2024-02-05 Thread Jeff Law
On 2/4/24 23:37, juzhe.zh...@rivai.ai wrote: I think it just trigger a latent bug that we didn't encounter. Hi, Robin. Would you mind give me preprocessed file to reproduce the issue ? I suspect it triggers latent bug in VSETVL PASS. I've got a few minutes this morning before meetings

Re: Re: [PATCH] RISC-V: Expand VLMAX scalar move in reduction

2024-02-04 Thread juzhe.zh...@rivai.ai
; kito.cheng; rdapp.gcc Subject: Re: [PATCH] RISC-V: Expand VLMAX scalar move in reduction On 2/4/24 20:26, Jeff Law wrote: > > > On 2/1/24 18:56, Juzhe-Zhong wrote: >> This patch fixes the following: >> >> vsetvli a5,a1,e32,m1,tu,ma >> slli

Re: [PATCH] RISC-V: Expand VLMAX scalar move in reduction

2024-02-04 Thread Jeff Law
On 2/4/24 20:26, Jeff Law wrote: On 2/1/24 18:56, Juzhe-Zhong wrote: This patch fixes the following: vsetvli a5,a1,e32,m1,tu,ma slli    a4,a5,2 sub a1,a1,a5 vle32.v v2,0(a0) add a0,a0,a4 vadd.vv v1,v2,v1 bne

Re: [PATCH] RISC-V: Expand VLMAX scalar move in reduction

2024-02-04 Thread Jeff Law
On 2/1/24 18:56, Juzhe-Zhong wrote: This patch fixes the following: vsetvli a5,a1,e32,m1,tu,ma sllia4,a5,2 sub a1,a1,a5 vle32.v v2,0(a0) add a0,a0,a4 vadd.vv v1,v2,v1 bne a1,zero,.L3 vsetivli

Re: [PATCH] RISC-V: Expand VLMAX scalar move in reduction

2024-02-02 Thread Kito Cheng
LGTM :) On Fri, Feb 2, 2024 at 9:58 AM Juzhe-Zhong wrote: > > This patch fixes the following: > > vsetvli a5,a1,e32,m1,tu,ma > sllia4,a5,2 > sub a1,a1,a5 > vle32.v v2,0(a0) > add a0,a0,a4 > vadd.vv v1,v2,v1 > bne a1,zero,.L3