Re: [PATCH] RISC-V: Fix calculation of max live vregs

2023-12-20 Thread juzhe.zh...@rivai.ai
Hi, Han. It's awesome that some one want to optimize dynamic LMUL feature of GCC. I knew this feature is not stable yet and I failed to find the time to optimize it (Still busy with fixing bugs). Could you give me more details why this patch can refine those 2 cases with picking larger LMUL (I

Re: [PATCH] RISC-V: Fix calculation of max live vregs

2023-12-20 Thread Demin Han
Hi juzhe, The live ranges are represented as [def_point, last_use_point] in code. For example: 0: _2 = _x1 + _x2 1: _3 = _y1 + _y2 2: _1 = _2 + _3 3: _4 = _1 + x1 Origin: live ranges: _1: [2, 3] _2: [0, 2] _3: [1, 2] _x1:[0, 3] max live regs calc: _1 _2 _3 _x1 0 x x 1 x

Re: [PATCH] RISC-V: Fix calculation of max live vregs

2023-12-20 Thread Jeff Law
On 12/20/23 04:17, juzhe.zh...@rivai.ai wrote: I see. LGTM. Thanks for explanation. I will ask Li Pan commit it for you. The patch from Demin didn't specify if it had been regression tested. All patches must be regression tested and an indication that the test passed and on what target mus

Re: [PATCH] RISC-V: Fix calculation of max live vregs

2023-12-20 Thread Demin Han
Hi Jeff, Thanks for reminding this. Regression test info will be added to commit log in following patches. Demin On 2023/12/20 23:28, Jeff Law wrote: > > > On 12/20/23 04:17, juzhe.zh...@rivai.ai wrote: >> I see. LGTM. Thanks for explanation. >> >> I will ask Li Pan commit it for you. > The pa

Re: Re: [PATCH] RISC-V: Fix calculation of max live vregs

2023-12-20 Thread juzhe.zh...@rivai.ai
I see. LGTM. Thanks for explanation. I will ask Li Pan commit it for you. Thanks. juzhe.zh...@rivai.ai From: Demin Han Date: 2023-12-20 19:10 To: juzhe.zh...@rivai.ai; gcc-patches CC: pan2.li Subject: Re: [PATCH] RISC-V: Fix calculation of max live vregs Hi juzhe, The live ranges are

RE: Re: [PATCH] RISC-V: Fix calculation of max live vregs

2023-12-20 Thread Li, Pan2
Committed, thanks all. Pan From: juzhe.zh...@rivai.ai Sent: Wednesday, December 20, 2023 7:18 PM To: demin.han ; gcc-patches Cc: Li, Pan2 Subject: Re: Re: [PATCH] RISC-V: Fix calculation of max live vregs I see. LGTM. Thanks for explanation. I will ask Li Pan commit it for you. Thanks

Re: Re: [PATCH] RISC-V: Fix calculation of max live vregs

2023-12-20 Thread 钟居哲
Ok. Thanks Jeff reminding me. Will be carefull next time. juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-12-20 23:28 To: juzhe.zh...@rivai.ai; demin.han; gcc-patches CC: pan2.li Subject: Re: [PATCH] RISC-V: Fix calculation of max live vregs On 12/20/23 04:17, juzhe.zh...@rivai.ai wrote